<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>185859</bug_id>
          
          <creation_ts>2018-05-22 01:11:01 -0700</creation_ts>
          <short_desc>[selectors] Support for Focus-Indicated Pseudo-class: `:focus-visible`</short_desc>
          <delta_ts>2024-09-24 16:12:14 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>225147</dependson>
    
    <dependson>225148</dependson>
    
    <dependson>221889</dependson>
    
    <dependson>221895</dependson>
    
    <dependson>222028</dependson>
    
    <dependson>222647</dependson>
    
    <dependson>223113</dependson>
    
    <dependson>224598</dependson>
    
    <dependson>224827</dependson>
    
    <dependson>225075</dependson>
    
    <dependson>233688</dependson>
    
    <dependson>234019</dependson>
    
    <dependson>234077</dependson>
    
    <dependson>236331</dependson>
    
    <dependson>236782</dependson>
    
    <dependson>239472</dependson>
          <blocked>220578</blocked>
    
    <blocked>221925</blocked>
    
    <blocked>222645</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="James Craig">jcraig</reporter>
          <assigned_to name="Manuel Rego Casasnovas">rego</assigned_to>
          <cc>709922234</cc>
    
    <cc>account</cc>
    
    <cc>alex</cc>
    
    <cc>amir123456789893</cc>
    
    <cc>arv</cc>
    
    <cc>borisdiakur</cc>
    
    <cc>caleb</cc>
    
    <cc>cyb.ai.815</cc>
    
    <cc>dpino</cc>
    
    <cc>emilio</cc>
    
    <cc>firefoxic.dev</cc>
    
    <cc>gurmukhp</cc>
    
    <cc>john_riviello</cc>
    
    <cc>kai.hollberg</cc>
    
    <cc>koddsson</cc>
    
    <cc>koivisto</cc>
    
    <cc>kyle.bavender</cc>
    
    <cc>nvasilyev</cc>
    
    <cc>petervrachas</cc>
    
    <cc>rego</cc>
    
    <cc>sean</cc>
    
    <cc>vertigoback</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1426067</commentid>
    <comment_count>0</comment_count>
    <who name="James Craig">jcraig</who>
    <bug_when>2018-05-22 01:11:01 -0700</bug_when>
    <thetext>Support for Focus-Indicated Pseudo-class: `:focus-visible`

https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo
https://github.com/WICG/focus-visible</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1426068</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-05-22 01:11:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/40444220&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1727978</commentid>
    <comment_count>2</comment_count>
    <who name="Amir mohammadi">amir123456789893</who>
    <bug_when>2021-02-10 23:58:12 -0800</bug_when>
    <thetext>I cannot believe after 5 years web cannot support this feature fully.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1727986</commentid>
    <comment_count>3</comment_count>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2021-02-11 00:39:17 -0800</bug_when>
    <thetext>I&apos;m working on this, hopefully I will upload a patch in the coming days/weeks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1752165</commentid>
    <comment_count>4</comment_count>
    <who name="Diego Pino">dpino</who>
    <bug_when>2021-04-20 00:47:47 -0700</bug_when>
    <thetext>These two tests are failing in WPE after r273812:

  imported/w3c/web-platform-tests/css/selectors/focus-visible-003.html
  imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html

Test dashboard:

https://results.webkit.org/?platform=GTK&amp;platform=WPE&amp;suite=layout-tests&amp;test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fselectors%2Ffocus-visible-003.html

https://build.webkit.org/results/WPE-Linux-64-bit-Release-Tests/r276286%20%281261%29/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-diff.txt

--- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-expected.txt
+++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/selectors/focus-visible-003-actual.txt
@@ -28,5 +28,5 @@
 PASS Focus element INPUT#el-9 via mouse should NOT match :focus-visible as it does NOT support keyboard input
 PASS Focus element INPUT#el-10 via mouse should NOT match :focus-visible as it does NOT support keyboard input
 PASS Focus element INPUT#el-12 via mouse should NOT match :focus-visible as it does NOT support keyboard input
-PASS Focus element INPUT#el-13 via mouse should NOT match :focus-visible as it does NOT support keyboard input
+FAIL Focus element INPUT#el-13 via mouse should NOT match :focus-visible as it does NOT support keyboard input assert_equals: backgroundColor for INPUT#el-13 should be lime expected &quot;rgb(0, 255, 0)&quot; but got &quot;rgb(255, 255, 255)&quot;

https://build.webkit.org/results/WPE-Linux-64-bit-Release-Tests/r276286%20%281261%29/imported/w3c/web-platform-tests/css/selectors/focus-visible-004-diff.txt

--- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/selectors/focus-visible-004-expected.txt
+++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/css/selectors/focus-visible-004-actual.txt
@@ -24,5 +24,5 @@
 PASS Focus element INPUT#el-7 via mouse should NOT match :focus-visible as it does NOT support keyboard input - not affected by &quot;appearance: none&quot;
 PASS Focus element INPUT#el-8 via mouse should NOT match :focus-visible as it does NOT support keyboard input - not affected by &quot;appearance: none&quot;
 PASS Focus element INPUT#el-10 via mouse should NOT match :focus-visible as it does NOT support keyboard input - not affected by &quot;appearance: none&quot;
-PASS Focus element INPUT#el-11 via mouse should NOT match :focus-visible as it does NOT support keyboard input - not affected by &quot;appearance: none&quot;
+FAIL Focus element INPUT#el-11 via mouse should NOT match :focus-visible as it does NOT support keyboard input - not affected by &quot;appearance: none&quot; assert_equals: backgroundColor for INPUT#el-11 should be lime expected &quot;rgb(0, 255, 0)&quot; but got &quot;rgb(255, 255, 255)&quot;

Updated expectations in r276291.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1752199</commentid>
    <comment_count>5</comment_count>
    <who name="Manuel Rego Casasnovas">rego</who>
    <bug_when>2021-04-20 02:44:09 -0700</bug_when>
    <thetext>Thanks Diego(In reply to Diego Pino from comment #4)
&gt; These two tests are failing in WPE after r273812:
&gt; 
&gt;   imported/w3c/web-platform-tests/css/selectors/focus-visible-003.html
&gt;   imported/w3c/web-platform-tests/css/selectors/focus-visible-004.html

Thanks Diego for the report, they fail because &lt;input type=&quot;color&quot;&gt; is not supported on WPE. I&apos;m adding the new expectations on bug #224808.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1760706</commentid>
    <comment_count>6</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2021-05-17 02:55:22 -0700</bug_when>
    <thetext>*** Bug 30523 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1822159</commentid>
    <comment_count>7</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2021-12-09 09:37:15 -0800</bug_when>
    <thetext>:focus-visible was enabled by default in https://trac.webkit.org/changeset/286783/webkit</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>