185857 2018-05-21 20:13:39 -0700 Remove unused and no-op WKContextSetCookieStorageDirectory 2018-05-21 21:05:22 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa achristensen beidson cdumez commit-queue sihui_liu webkit-bug-importer youennf oldest_to_newest 1426018 0 rniwa 2018-05-21 20:13:39 -0700 WKContextSetCookieStorageDirectory doesn't do anything so remove it for now. We can always add back an API which does useful thing later if any. 1426019 1 340948 rniwa 2018-05-21 20:15:17 -0700 Created attachment 340948 Cleanup 1426022 2 rniwa 2018-05-21 20:27:44 -0700 Thanks for the review! 1426026 3 340948 commit-queue 2018-05-21 21:04:22 -0700 Comment on attachment 340948 Cleanup Clearing flags on attachment: 340948 Committed r232046: <https://trac.webkit.org/changeset/232046> 1426027 4 commit-queue 2018-05-21 21:04:24 -0700 All reviewed patches have been landed. Closing bug. 1426028 5 webkit-bug-importer 2018-05-21 21:05:22 -0700 <rdar://problem/40440417> 340948 2018-05-21 20:15:17 -0700 2018-05-21 21:04:22 -0700 Cleanup bug-185857-20180521201516.patch text/plain 3188 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzIwNDQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA1LTIxICBSeW9zdWtlIE5p d2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgYW5kIG5vLW9w IFdLQ29udGV4dFNldENvb2tpZVN0b3JhZ2VEaXJlY3RvcnkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTg1NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERlbGV0ZWQgQyBBUEkgd2hpY2ggZGlkbid0IGRv IGFueXRoaW5nIHVzZWZ1bCwgYW5kIGNvbnNlcXVlbnRseSBub3QgdXNlZCBieSBhbnlvbmUuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmNwcDoKKyAgICAgICAgKFdLQ29u dGV4dFNldENvb2tpZVN0b3JhZ2VEaXJlY3RvcnkpOiBEZWxldGVkLgorICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvQy9XS0NvbnRleHRQcml2YXRlLmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBy b2Nlc3NQb29sLmg6CisKIDIwMTgtMDUtMjEgIENocmlzIE5hcmRpICA8Y25hcmRpQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZW1vdmUgZGVhZCBleGNlcHRpb24gaW4gTWVkaWFMaXN0LmFwcGVu ZE1lZGl1bQpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5oCShy ZXZpc2lvbiAyMzIwMzIpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9v bC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNjEsOCArMjYxLDYgQEAgcHVibGljOgogICAgIH07CiAg ICAgc3RhdGljIFN0YXRpc3RpY3MmIHN0YXRpc3RpY3MoKTsgICAgCiAKLSAgICB2b2lkIHNldENv b2tpZVN0b3JhZ2VEaXJlY3RvcnkoY29uc3QgU3RyaW5nJiBkaXIpIHsgbV9vdmVycmlkZUNvb2tp ZVN0b3JhZ2VEaXJlY3RvcnkgPSBkaXI7IH0KLQogICAgIHZvaWQgdXNlVGVzdGluZ05ldHdvcmtT ZXNzaW9uKCk7CiAgICAgYm9vbCBpc1VzaW5nVGVzdGluZ05ldHdvcmtTZXNzaW9uKCkgY29uc3Qg eyByZXR1cm4gbV9zaG91bGRVc2VUZXN0aW5nTmV0d29ya1Nlc3Npb247IH0KIApAQCAtNjE0LDgg KzYxMiw2IEBAIHByaXZhdGU6CiAgICAgc3RkOjp1bmlxdWVfcHRyPFBlckFjdGl2aXR5U3RhdGVD UFVVc2FnZVNhbXBsZXI+IG1fcGVyQWN0aXZpdHlTdGF0ZUNQVVVzYWdlU2FtcGxlcjsKICNlbmRp ZgogCi0gICAgU3RyaW5nIG1fb3ZlcnJpZGVDb29raWVTdG9yYWdlRGlyZWN0b3J5OwotCiAgICAg Ym9vbCBtX3Nob3VsZFVzZVRlc3RpbmdOZXR3b3JrU2Vzc2lvbiB7IGZhbHNlIH07CiAKICAgICBi b29sIG1fcHJvY2Vzc1Rlcm1pbmF0aW9uRW5hYmxlZCB7IHRydWUgfTsKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmNwcAkocmV2aXNpb24gMjMyMDMyKQor KysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNDg4LDExICs0ODgsNiBAQCB2b2lkIFdLQ29udGV4dEFsbG93U3BlY2lmaWNIVFRQ U0NlcnRpZmljCiAgICAgdG9JbXBsKGNvbnRleHRSZWYpLT5hbGxvd1NwZWNpZmljSFRUUFNDZXJ0 aWZpY2F0ZUZvckhvc3QodG9JbXBsKGNlcnRpZmljYXRlUmVmKSwgdG9JbXBsKGhvc3RSZWYpLT5z dHJpbmcoKSk7CiB9CiAKLVdLX0VYUE9SVCB2b2lkIFdLQ29udGV4dFNldENvb2tpZVN0b3JhZ2VE aXJlY3RvcnkoV0tDb250ZXh0UmVmIGNvbnRleHRSZWYsIFdLU3RyaW5nUmVmIGNvb2tpZVN0b3Jh Z2VEaXJlY3RvcnkpCi17Ci0gICAgdG9JbXBsKGNvbnRleHRSZWYpLT5zZXRDb29raWVTdG9yYWdl RGlyZWN0b3J5KHRvSW1wbChjb29raWVTdG9yYWdlRGlyZWN0b3J5KS0+c3RyaW5nKCkpOwotfQot CiB2b2lkIFdLQ29udGV4dERpc2FibGVQcm9jZXNzVGVybWluYXRpb24oV0tDb250ZXh0UmVmIGNv bnRleHRSZWYpCiB7CiAgICAgdG9JbXBsKGNvbnRleHRSZWYpLT5kaXNhYmxlUHJvY2Vzc1Rlcm1p bmF0aW9uKCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRQ cml2YXRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tD b250ZXh0UHJpdmF0ZS5oCShyZXZpc2lvbiAyMzIwMzIpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQy9XS0NvbnRleHRQcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTc1LDggKzc1 LDYgQEAgV0tfRVhQT1JUIHZvaWQgV0tDb250ZXh0U2V0SWNvbkRhdGFiYXNlUAogCiBXS19FWFBP UlQgdm9pZCBXS0NvbnRleHRBbGxvd1NwZWNpZmljSFRUUFNDZXJ0aWZpY2F0ZUZvckhvc3QoV0tD b250ZXh0UmVmIGNvbnRleHQsIFdLQ2VydGlmaWNhdGVJbmZvUmVmIGNlcnRpZmljYXRlLCBXS1N0 cmluZ1JlZiBob3N0KTsKIAotV0tfRVhQT1JUIHZvaWQgV0tDb250ZXh0U2V0Q29va2llU3RvcmFn ZURpcmVjdG9yeShXS0NvbnRleHRSZWYgY29udGV4dCwgV0tTdHJpbmdSZWYgY29va2llU3RvcmFn ZURpcmVjdG9yeSk7Ci0KIC8vIEZJWE1FOiBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgdGVzdGlu ZyBwdXJwb3NlcyBvbmx5IGFuZCBzaG91bGQgYmUgcmVtb3ZlZCBvbmNlIGEgYmV0dGVyCiAvLyBz b2x1dGlvbiBoYXMgYmVlbiBmb3VuZCBmb3IgdGVzdGluZy4KIFdLX0VYUE9SVCB2b2lkIFdLQ29u dGV4dERpc2FibGVQcm9jZXNzVGVybWluYXRpb24oV0tDb250ZXh0UmVmIGNvbnRleHQpOwo=