185838 2018-05-21 14:15:12 -0700 Web Automation: always return an empty cookie list if document.cookieURL() is empty 2018-05-21 15:10:43 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg beidson cgarcia commit-queue dbates joepeck thorton webkit-bug-importer oldest_to_newest 1425815 0 bburg 2018-05-21 14:15:12 -0700 YMMV if trying to fetch cookies from a null or empty URL, but it crashes on Mac. 1425816 1 bburg 2018-05-21 14:15:43 -0700 <rdar://problem/37737526> 1425824 2 340890 bburg 2018-05-21 14:20:03 -0700 Created attachment 340890 Patch 1425869 3 340890 dbates 2018-05-21 15:06:47 -0700 Comment on attachment 340890 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340890&action=review > Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:754 > + if (!document.cookieURL().isEmpty()) It would good to understand how document's cookie URL can be empty given that the document has an associated frame. I haven't looked at the radar. Maybe this happens for a newly opened window? 1425877 4 340890 commit-queue 2018-05-21 15:10:41 -0700 Comment on attachment 340890 Patch Clearing flags on attachment: 340890 Committed r232031: <https://trac.webkit.org/changeset/232031> 1425878 5 commit-queue 2018-05-21 15:10:43 -0700 All reviewed patches have been landed. Closing bug. 340890 2018-05-21 14:20:03 -0700 2018-05-21 15:10:41 -0700 Patch bug-185838-20180521142002.patch text/plain 2011 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDBjNjA1NmFmZDg2MDc1NmNl YjA3Yjc5ZmFhYTNlNzE0MGMxMzMxYjYuLmI0NzMxMDBiMTcxOTVhYzc1YTM5YjYyNTAxZmMxZmJh OWFhMTRlYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDUtMjEgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEF1dG9tYXRpb246IGFsd2F5cyBy ZXR1cm4gYW4gZW1wdHkgY29va2llIGxpc3QgaWYgZG9jdW1lbnQuY29va2llVVJMKCkgaXMgZW1w dHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTgz OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzc3Mzc1MjY+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0F1dG9tYXRpb24vV2Vi QXV0b21hdGlvblNlc3Npb25Qcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkF1dG9tYXRp b25TZXNzaW9uUHJveHk6OmdldENvb2tpZXNGb3JGcmFtZSk6CisgICAgICAgIFRoaXMgY3Jhc2hl cyBpbiBDRk5ldHdvcmsgY29kZSBiZWNhdXNlIGFuIGVtcHR5IGNvb2tpZSBVUkwgaXMgbm90IGEg dmFsaWQgaW5wdXQuCisgICAgICAgIEp1c3QgcmV0dXJuIGFuIGVtcHR5IGxpc3Qgc2luY2UgdGhl cmUgY291bGRuJ3QgYmUgYW55IGNvb2tpZXMgcmV0dXJuZWQuCisKIDIwMTgtMDUtMjEgIFNpaHVp IExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgZGlza0NhY2hlU2l6 ZU92ZXJyaWRlIGFjY2Vzc29yIGZ1bmN0aW9uIG9uIFdLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9t YXRpb25TZXNzaW9uUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRp b24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5jcHAKaW5kZXggYjQyMjE2NDdmNWFlY2Q3MmVh NGNjZTI3NjAzYjI4NTg3ZjgxYWEyYS4uMWY4YWM5YjU0Yzk4Y2U1MWRlYTY0ZTQ4MmUxYjcwNjY0 YTZhYTU1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0F1dG9tYXRpb24v V2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5jcHAKQEAgLTc1MSw3ICs3 NTEsOCBAQCB2b2lkIFdlYkF1dG9tYXRpb25TZXNzaW9uUHJveHk6OmdldENvb2tpZXNGb3JGcmFt ZSh1aW50NjRfdCBwYWdlSUQsIHVpbnQ2NF90IGZyYQogICAgIC8vIFRoaXMgcmV0dXJucyB0aGUg c2FtZSBsaXN0IG9mIGNvb2tpZXMgYXMgd2hlbiBldmFsdWF0aW5nIGBkb2N1bWVudC5jb29raWVz YCBpbiBKYXZhU2NyaXB0LgogICAgIGF1dG8mIGRvY3VtZW50ID0gKmZyYW1lLT5jb3JlRnJhbWUo KS0+ZG9jdW1lbnQoKTsKICAgICBWZWN0b3I8V2ViQ29yZTo6Q29va2llPiBmb3VuZENvb2tpZXM7 Ci0gICAgV2ViQ29yZTo6Z2V0UmF3Q29va2llcyhkb2N1bWVudCwgZG9jdW1lbnQuY29va2llVVJM KCksIGZvdW5kQ29va2llcyk7CisgICAgaWYgKCFkb2N1bWVudC5jb29raWVVUkwoKS5pc0VtcHR5 KCkpCisgICAgICAgIFdlYkNvcmU6OmdldFJhd0Nvb2tpZXMoZG9jdW1lbnQsIGRvY3VtZW50LmNv b2tpZVVSTCgpLCBmb3VuZENvb2tpZXMpOwogCiAgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCku cGFyZW50UHJvY2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViQXV0b21hdGlvblNl c3Npb246OkRpZEdldENvb2tpZXNGb3JGcmFtZShjYWxsYmFja0lELCBmb3VuZENvb2tpZXMsIFN0 cmluZygpKSwgMCk7CiB9Cg==