185826 2018-05-21 11:48:39 -0700 Add a diskCacheSizeOverride accessor function on WKContextConfigurationRef 2018-05-21 13:57:58 -0700 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu achristensen cdumez commit-queue sihui_liu webkit-bug-importer oldest_to_newest 1425734 0 sihui_liu 2018-05-21 11:48:39 -0700 Required for <rdar://problem/39432656>. 1425735 1 sihui_liu 2018-05-21 11:49:21 -0700 <rdar://problem/39732113> 1425742 2 340868 sihui_liu 2018-05-21 11:59:05 -0700 Created attachment 340868 Patch 1425750 3 340868 cdumez 2018-05-21 12:29:14 -0700 Comment on attachment 340868 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340868&action=review > Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:83 > +WK_EXPORT int64_t WKContextConfigurationDiskCacheSizeOverride(WKContextConfigurationRef configuration); Is there an equivalent Cocoa API / SPI already? We are not supposed to add any new C API without a Cocoa equivalent. 1425780 4 sihui_liu 2018-05-21 13:28:58 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 340868 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340868&action=review > > > Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:83 > > +WK_EXPORT int64_t WKContextConfigurationDiskCacheSizeOverride(WKContextConfigurationRef configuration); > > Is there an equivalent Cocoa API / SPI already? We are not supposed to add > any new C API without a Cocoa equivalent. There is diskCacheSizeOverride in API/Cocoa/_WKProcessPoolConfiguration.h. 1425782 5 cdumez 2018-05-21 13:30:57 -0700 (In reply to Sihui Liu from comment #4) > (In reply to Chris Dumez from comment #3) > > Comment on attachment 340868 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=340868&action=review > > > > > Source/WebKit/UIProcess/API/C/WKContextConfigurationRef.h:83 > > > +WK_EXPORT int64_t WKContextConfigurationDiskCacheSizeOverride(WKContextConfigurationRef configuration); > > > > Is there an equivalent Cocoa API / SPI already? We are not supposed to add > > any new C API without a Cocoa equivalent. > > There is diskCacheSizeOverride in API/Cocoa/_WKProcessPoolConfiguration.h. Great, thanks. 1425802 6 340868 commit-queue 2018-05-21 13:57:57 -0700 Comment on attachment 340868 Patch Clearing flags on attachment: 340868 Committed r232025: <https://trac.webkit.org/changeset/232025> 1425803 7 commit-queue 2018-05-21 13:57:58 -0700 All reviewed patches have been landed. Closing bug. 340868 2018-05-21 11:59:05 -0700 2018-05-21 13:57:57 -0700 Patch bug-185826-20180521115904.patch text/plain 2720 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM1ZGM5YWE1NzQ0MTMxMTc3 NDk1ZWI3MzA1OTdmYWUxMjAwMmI5NDMuLjQ3MWM2NTUyOGMxMzYyNDM2ODgzZjg0MTk0YTFlMzk4 MzA4MTQzYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDUtMjEgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGEgZGlza0NhY2hlU2l6ZU92 ZXJyaWRlIGFjY2Vzc29yIGZ1bmN0aW9uIG9uIFdLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTgyNgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMzk3MzIxMTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0Q29uZmln dXJhdGlvblJlZi5jcHA6CisgICAgICAgIChXS0NvbnRleHRDb25maWd1cmF0aW9uRGlza0NhY2hl U2l6ZU92ZXJyaWRlKToKKyAgICAgICAgKFdLQ29udGV4dENvbmZpZ3VyYXRpb25TZXREaXNrQ2Fj aGVTaXplT3ZlcnJpZGUpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRDb25m aWd1cmF0aW9uUmVmLmg6CisKIDIwMTgtMDUtMjEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFVwZGF0ZSBPcHRpb25zR1RL LmNtYWtlIGFuZCBORVdTIGZvciAyLjIxLjIgcmVsZWFzZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dENvbmZpZ3VyYXRpb25SZWYuY3BwIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZi5jcHAK aW5kZXggN2ZkM2FjNjM1ZjFjZGI4MTY2Yjc5YzkxZjc1M2ZkYzQ5MjE4NjI3Ni4uMWMzMDdmNjAy MWFkNTc1MzRiY2VjNDk2OWVmZWVlZDZjMTg1MWNkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZi5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZi5jcHAK QEAgLTE5NywzICsxOTcsMTQgQEAgdm9pZCBXS0NvbnRleHRDb25maWd1cmF0aW9uU2V0VHJhY2tz UmVzb3VyY2VMb2FkTWlsZXN0b25lcyhXS0NvbnRleHRDb25maWd1cmF0aW8KIHsKICAgICB0b0lt cGwoY29uZmlndXJhdGlvbiktPnNldFRyYWNrc1Jlc291cmNlTG9hZE1pbGVzdG9uZXModHJhY2sp OwogfQorCitpbnQ2NF90IFdLQ29udGV4dENvbmZpZ3VyYXRpb25EaXNrQ2FjaGVTaXplT3ZlcnJp ZGUoV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZiBjb25maWd1cmF0aW9uKQoreworICAgIHJldHVy biB0b0ltcGwoY29uZmlndXJhdGlvbiktPmRpc2tDYWNoZVNpemVPdmVycmlkZSgpOworfQorCit2 b2lkIFdLQ29udGV4dENvbmZpZ3VyYXRpb25TZXREaXNrQ2FjaGVTaXplT3ZlcnJpZGUoV0tDb250 ZXh0Q29uZmlndXJhdGlvblJlZiBjb25maWd1cmF0aW9uLCBpbnQ2NF90IHNpemUpCit7CisgICAg dG9JbXBsKGNvbmZpZ3VyYXRpb24pLT5zZXREaXNrQ2FjaGVTaXplT3ZlcnJpZGUoc2l6ZSk7Cit9 CisKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4dENv bmZpZ3VyYXRpb25SZWYuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9DL1dLQ29udGV4 dENvbmZpZ3VyYXRpb25SZWYuaAppbmRleCBjOTU3OGZjNWM3ZWY4MDRhNzk3ZTA2NTEwNTg4YTQ5 OGQ4YWU0MGQyLi42YWYzYjJhNWQ3YTFmY2UwZjgxNWNmOGY3MzI4ZDVlNWFiZThjYmY1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQy9XS0NvbnRleHRDb25maWd1cmF0 aW9uUmVmLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0MvV0tDb250ZXh0Q29u ZmlndXJhdGlvblJlZi5oCkBAIC04MCw2ICs4MCw5IEBAIFdLX0VYUE9SVCB2b2lkIFdLQ29udGV4 dENvbmZpZ3VyYXRpb25TZXRQcm9jZXNzU3dhcHNPbldpbmRvd09wZW5XaXRoT3BlbmVyKFdLQ29u CiBXS19FWFBPUlQgYm9vbCBXS0NvbnRleHRDb25maWd1cmF0aW9uVHJhY2tzUmVzb3VyY2VMb2Fk TWlsZXN0b25lcyhXS0NvbnRleHRDb25maWd1cmF0aW9uUmVmIGNvbmZpZ3VyYXRpb24pOwogV0tf RVhQT1JUIHZvaWQgV0tDb250ZXh0Q29uZmlndXJhdGlvblNldFRyYWNrc1Jlc291cmNlTG9hZE1p bGVzdG9uZXMoV0tDb250ZXh0Q29uZmlndXJhdGlvblJlZiBjb25maWd1cmF0aW9uLCBib29sIHRy YWNrKTsKIAorV0tfRVhQT1JUIGludDY0X3QgV0tDb250ZXh0Q29uZmlndXJhdGlvbkRpc2tDYWNo ZVNpemVPdmVycmlkZShXS0NvbnRleHRDb25maWd1cmF0aW9uUmVmIGNvbmZpZ3VyYXRpb24pOwor V0tfRVhQT1JUIHZvaWQgV0tDb250ZXh0Q29uZmlndXJhdGlvblNldERpc2tDYWNoZVNpemVPdmVy cmlkZShXS0NvbnRleHRDb25maWd1cmF0aW9uUmVmIGNvbmZpZ3VyYXRpb24sIGludDY0X3Qgc2l6 ZSk7CisgICAgCiAjaWZkZWYgX19jcGx1c3BsdXMKIH0KICNlbmRpZgo=