185824 2018-05-21 10:30:35 -0700 [WPE][WebDriver] add ICU include dirs 2018-05-21 11:18:18 -0700 1 1 1 Unclassified WebKit WebDriver Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 olivier.blin webkit-unassigned annulen aperez bburg cgarcia commit-queue mcatanzaro webkit-bug-importer zan oldest_to_newest 1425696 0 olivier.blin 2018-05-21 10:30:35 -0700 WebDriver does not build in the WPE port when ICU headers are in a non-default directory. 1425698 1 340861 olivier.blin 2018-05-21 10:32:06 -0700 Created attachment 340861 Patch 1425699 2 340861 olivier.blin 2018-05-21 10:34:23 -0700 Comment on attachment 340861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340861&action=review > Source/WebDriver/PlatformWPE.cmake:5 > + "${ICU_INCLUDE_DIRS}" Is this the best place to put this since ICU is common to all ports? Shouldn't this be inherited from WTF? 1425701 3 340861 annulen 2018-05-21 10:39:05 -0700 Comment on attachment 340861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340861&action=review >> Source/WebDriver/PlatformWPE.cmake:5 >> + "${ICU_INCLUDE_DIRS}" > > Is this the best place to put this since ICU is common to all ports? > Shouldn't this be inherited from WTF? It was once working like this, but is not the case since https://bugs.webkit.org/show_bug.cgi?id=181656 1425721 4 340861 commit-queue 2018-05-21 11:17:42 -0700 Comment on attachment 340861 Patch Clearing flags on attachment: 340861 Committed r232022: <https://trac.webkit.org/changeset/232022> 1425722 5 commit-queue 2018-05-21 11:17:43 -0700 All reviewed patches have been landed. Closing bug. 1425723 6 webkit-bug-importer 2018-05-21 11:18:18 -0700 <rdar://problem/40422734> 340861 2018-05-21 10:32:06 -0700 2018-05-21 11:17:42 -0700 Patch bug-185824-20180521193205.patch text/plain 1217 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVy L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCmluZGV4IDllNWUwYTAxZDIw ZWU3YTM3NDM0NzBjNjA0ZTllYWZiYmFjNTI0NjUuLjkxMjI4NDdkZGUzZmVlYmVlMzg2ZGY4OWJl ZjE3OWNhMmU3NmY3NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDUt MjEgIE9saXZpZXIgQmxpbiAgPG9saXZpZXIuYmxpbkBzb2Z0YXRob21lLmNvbT4KKworICAgICAg ICBbV1BFXVtXZWJEcml2ZXJdIGFkZCBJQ1UgaW5jbHVkZSBkaXJzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU4MjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJEcml2ZXIgZG9lcyBub3QgYnVpbGQg aW4gdGhlIFdQRSBwb3J0IHdoZW4gSUNVIGhlYWRlcnMgYXJlIGluIGEgbm9uLWRlZmF1bHQgZGly ZWN0b3J5LgorCisgICAgICAgICogUGxhdGZvcm1XUEUuY21ha2U6IEFkZCBJQ1UgaW5jbHVkZSBk aXJzCisKIDIwMTgtMDUtMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFdlYkRyaXZlcjogaW1wbGVtZW50IGFkdmFuY2UgdXNlciBpbnRlcmFj dGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvUGxhdGZvcm1XUEUuY21ha2UgYi9T b3VyY2UvV2ViRHJpdmVyL1BsYXRmb3JtV1BFLmNtYWtlCmluZGV4IGJkM2NkODExYmQ0NmI3OTBj NTRhYmY1YzBkNDk3NDU1YjI5M2I1ODcuLmJhMjE3OTg5OGE1NGI1YThkODk0ZjczMzZjNjlhZWE4 ZGZkNTY5NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvUGxhdGZvcm1XUEUuY21ha2UK KysrIGIvU291cmNlL1dlYkRyaXZlci9QbGF0Zm9ybVdQRS5jbWFrZQpAQCAtMiw2ICsyLDcgQEAg c2V0KFdlYkRyaXZlcl9Qcm9jZXNzX09VVFBVVF9OQU1FIFdQRVdlYkRyaXZlcikKIAogbGlzdChB UFBFTkQgV2ViRHJpdmVyX1NZU1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7R0xJQl9J TkNMVURFX0RJUlN9IgorICAgICIke0lDVV9JTkNMVURFX0RJUlN9IgogICAgICIke0xJQlNPVVBf SU5DTFVERV9ESVJTfSIKICkKIAo=