185822 2018-05-21 10:05:16 -0700 Propagate WebCore system include dirs in WebCoreHeaderInterface 2018-05-21 10:53:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 olivier.blin webkit-unassigned annulen aperez bandou.yacine commit-queue fujii mcatanzaro webkit-bug-importer zan oldest_to_newest 1425687 0 olivier.blin 2018-05-21 10:05:16 -0700 System include directories from WebCore are not propagated anymore to its users. For example gcrypt, sqlite and ICU system headers defined in PAL are not properly passed to WebKit build. This may have been caused partly by the fix in r230385: [CMake] WebKit should link to WebCore as a PRIVATE library if WebCore is a static library https://bugs.webkit.org/show_bug.cgi?id=184127 1425690 1 340857 olivier.blin 2018-05-21 10:07:07 -0700 Created attachment 340857 Patch 1425707 2 340857 commit-queue 2018-05-21 10:52:24 -0700 Comment on attachment 340857 Patch Clearing flags on attachment: 340857 Committed r232020: <https://trac.webkit.org/changeset/232020> 1425708 3 commit-queue 2018-05-21 10:52:25 -0700 All reviewed patches have been landed. Closing bug. 1425710 4 webkit-bug-importer 2018-05-21 10:53:25 -0700 <rdar://problem/40421553> 340857 2018-05-21 10:07:07 -0700 2018-05-21 10:52:24 -0700 Patch bug-185822-20180521190706.patch text/plain 1714 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQzNGM5MzQzNWQ5YWUw ZmE0YThiOGI4OWYxNmIxZTkwNzI0NjkwZi4uNTY5NGFkZDUyOWZjZjFlNTI5ZDRhODc3ODRmYTFl Njk4NGNlNzExMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA1LTIxICBPbGl2 aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgUHJvcGFn YXRlIFdlYkNvcmUgc3lzdGVtIGluY2x1ZGUgZGlycyBpbiBXZWJDb3JlSGVhZGVySW50ZXJmYWNl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU4MjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTeXN0ZW0g aW5jbHVkZSBkaXJlY3RvcmllcyBmcm9tIFdlYkNvcmUgYXJlIG5vdCBwcm9wYWdhdGVkIGFueW1v cmUgdG8gaXRzIHVzZXJzLgorICAgICAgICBGb3IgZXhhbXBsZSBnY3J5cHQsIHNxbGl0ZSBhbmQg SUNVIHN5c3RlbSBoZWFkZXJzIGRlZmluZWQgaW4gUEFMIGFyZSBub3QgcHJvcGVybHkgcGFzc2Vk IHRvIFdlYktpdCBidWlsZC4KKworICAgICAgICBUaGlzIG1heSBoYXZlIGJlZW4gY2F1c2VkIHBh cnRseSBieSB0aGUgZml4IGluIHIyMzAzODU6CisgICAgICAgIFtDTWFrZV0gV2ViS2l0IHNob3Vs ZCBsaW5rIHRvIFdlYkNvcmUgYXMgYSBQUklWQVRFIGxpYnJhcnkgaWYgV2ViQ29yZSBpcyBhIHN0 YXRpYyBsaWJyYXJ5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODQxMjcKKworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZpeC4KKworICAgICAg ICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDE4LTA1LTE5ICBFcmljIENhcmxzb24gIDxlcmljLmNh cmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEltcHJvdmUgTm93UGxheWluZyAidGl0bGUiCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJjZS9XZWJDb3Jl L0NNYWtlTGlzdHMudHh0CmluZGV4IDVkZWFlZWM5NzE4OGM2ODU4NGIxZWQwZjJjZjFkY2FkYjgx ZWY4ZmEuLjEwOWUyOGEwZmFlY2FlZjJhMmQ3MjMwZGI2YzY4OWM0NDI0ZjFkNGIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NN YWtlTGlzdHMudHh0CkBAIC0xOTcyLDYgKzE5NzIsNyBAQCBlbmRpZiAoKQogIyBwYXRocyBvZiBX ZWJDb3JlLgogYWRkX2xpYnJhcnkoV2ViQ29yZUhlYWRlckludGVyZmFjZSBJTlRFUkZBQ0UpCiB0 YXJnZXRfaW5jbHVkZV9kaXJlY3RvcmllcyhXZWJDb3JlSGVhZGVySW50ZXJmYWNlIElOVEVSRkFD RSAke1dlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFU30pCit0YXJnZXRfaW5jbHVkZV9kaXJlY3Rv cmllcyhXZWJDb3JlSGVhZGVySW50ZXJmYWNlIFNZU1RFTSBJTlRFUkZBQ0UgJHtXZWJDb3JlX1NZ U1RFTV9JTkNMVURFX0RJUkVDVE9SSUVTfSkKIHRhcmdldF9saW5rX2xpYnJhcmllcyhXZWJDb3Jl SGVhZGVySW50ZXJmYWNlIElOVEVSRkFDRSAke1dlYkNvcmVfTElCUkFSSUVTfSkKIAogaWYgKE1T VkMpCg==