185821 2018-05-21 09:52:37 -0700 Fix FrameLoader build without video 2018-05-21 10:52:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 olivier.blin webkit-unassigned bandou.yacine cdumez commit-queue dbates ews-watchlist japhet jer.noble mcatanzaro olivier.blin rniwa webkit-bug-importer oldest_to_newest 1425682 0 olivier.blin 2018-05-21 09:52:37 -0700 Regression(r231392): Release assert in ScriptController::canExecuteScripts via HTMLMediaElement::~HTMLMediaElement() https://bugs.webkit.org/show_bug.cgi?id=185288 ../../Source/WebCore/loader/FrameLoader.cpp:818:9: error: incomplete type 'WebCore::HTMLMediaElement' named in nested name specifier if (HTMLMediaElement::isRunningDestructor()) { ^~~~~~~~~~~~~~~~~~ ../../Source/WebCore/dom/Document.h:130:7: note: forward declaration of 'WebCore::HTMLMediaElement' 1425685 1 340855 olivier.blin 2018-05-21 09:56:00 -0700 Created attachment 340855 Patch 1425704 2 340855 commit-queue 2018-05-21 10:50:09 -0700 Comment on attachment 340855 Patch Clearing flags on attachment: 340855 Committed r232019: <https://trac.webkit.org/changeset/232019> 1425705 3 commit-queue 2018-05-21 10:50:11 -0700 All reviewed patches have been landed. Closing bug. 1425709 4 webkit-bug-importer 2018-05-21 10:52:51 -0700 <rdar://problem/40421514> 340855 2018-05-21 09:56:00 -0700 2018-05-21 10:50:09 -0700 Patch bug-185821-20180521185559.patch text/plain 1737 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQzNGM5MzQzNWQ5YWUw ZmE0YThiOGI4OWYxNmIxZTkwNzI0NjkwZi4uYzUwYTNkYWQ2OGE5NjMxMDQxM2JhYTFhM2I4OGQw YzRlMTVjNDQ5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA1LTIxICBPbGl2 aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgRml4IEZy YW1lTG9hZGVyIGJ1aWxkIHdpdGhvdXQgdmlkZW8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTgyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFJlZ3Jlc3Npb24ocjIzMTM5Mik6IFJlbGVhc2UgYXNzZXJ0 IGluIFNjcmlwdENvbnRyb2xsZXI6OmNhbkV4ZWN1dGVTY3JpcHRzIHZpYSBIVE1MTWVkaWFFbGVt ZW50Ojp+SFRNTE1lZGlhRWxlbWVudCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODUyODgKKworICAgICAgICBObyBuZXcgdGVzdHMsIGJ1aWxkIGZp eCBvbmx5LgorCisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lTG9hZGVyOjpjaGVja0NvbXBsZXRlZCk6IEZsYWcgSFRNTE1lZGlhRWxlbWVu dDo6aXNSdW5uaW5nRGVzdHJ1Y3RvcigpIHVzYWdlLgorCiAyMDE4LTA1LTE5ICBFcmljIENhcmxz b24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAgICAgICAgIEltcHJvdmUgTm93UGxheWlu ZyAidGl0bGUiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAppbmRleCAxNmJmODIz NTVmZTA2ODM2ZDQzMzBhYjFhODA2ZTU1M2I0YTBmNTgxLi44YzZlNTRiZTYwODM5ZDkxM2JmYTk5 ZDJkZjFhNDIzNzRiNmI1ZjY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJh bWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAK QEAgLTgxNCwxMiArODE0LDE0IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNoZWNrQ29tcGxldGVkKCkK ICAgICBpZiAobV9pc0NvbXBsZXRlKQogICAgICAgICByZXR1cm47CiAgICAgCisjaWYgRU5BQkxF KFZJREVPKQogICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBjb2RlIG9uY2UgaHR0cHM6Ly93ZWJr aXQub3JnL2IvMTg1Mjg0IGlzIGZpeGVkLgogICAgIGlmIChIVE1MTWVkaWFFbGVtZW50Ojppc1J1 bm5pbmdEZXN0cnVjdG9yKCkpIHsKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAg ICAgIHNjaGVkdWxlQ2hlY2tDb21wbGV0ZWQoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KKyNl bmRpZgogCiAgICAgLy8gRklYTUU6IEl0IHdvdWxkIGJlIGJldHRlciBpZiByZXNvdXJjZSBsb2Fk cyB3ZXJlIGtpY2tlZCBvZmYgYWZ0ZXIgcmVuZGVyIHRyZWUgdXBkYXRlIChvciBkaWRuJ3QgY29t cGxldGUgc3luY2hyb25vdXNseSkuCiAgICAgLy8gICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE3MjkK