185796 2018-05-18 19:33:20 -0700 [INTL] Call Typed Array elements toLocaleString with locale and options 2018-07-26 22:48:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andy andy commit-queue darin ews-watchlist jfbastien joepeck keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1425397 0 andy 2018-05-18 19:33:20 -0700 [INTL] Call Typed Array elements toLocaleString with locale and options 1425398 1 340768 andy 2018-05-18 19:38:53 -0700 Created attachment 340768 Patch 1425648 2 andy 2018-05-21 08:13:09 -0700 This behavior is currently observable in SpiderMonkey. I don't believe v8 has yet adopted it. test262/intl402 specifically tests for this behavior. I would imagine eventually TypedArray toLocaleString and Array toLocaleString will use some of the semantics of ListFormat[1], but for now this at least passes NumberFormat locale and options to each number's toLocaleString in a typed array. [1] https://github.com/tc39/proposal-intl-list-format 1432043 3 andy 2018-06-11 14:05:17 -0700 Is there anything else this patch needs before it can be considered? 1436995 4 343721 andy 2018-06-27 10:32:34 -0700 Created attachment 343721 Rebased 1445057 5 343721 commit-queue 2018-07-25 09:48:16 -0700 Comment on attachment 343721 Rebased Rejecting attachment 343721 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 343721, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=343721&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=185796&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 343721 from bug 185796. Fetching: https://bugs.webkit.org/attachment.cgi?id=343721 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Keith Miller']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 4 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/builtins/TypedArrayPrototype.js patching file JSTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file JSTests/test262/expectations.yaml Hunk #1 FAILED at 1825. 1 out of 1 hunk FAILED -- saving rejects to file JSTests/test262/expectations.yaml.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Keith Miller']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/8651222 1445068 6 345765 andy 2018-07-25 10:06:37 -0700 Created attachment 345765 Patch 1445077 7 345765 commit-queue 2018-07-25 10:54:23 -0700 Comment on attachment 345765 Patch Clearing flags on attachment: 345765 Committed r234207: <https://trac.webkit.org/changeset/234207> 1445078 8 commit-queue 2018-07-25 10:54:25 -0700 All reviewed patches have been landed. Closing bug. 1445083 9 webkit-bug-importer 2018-07-25 10:59:19 -0700 <rdar://problem/42589763> 1445287 10 345765 darin 2018-07-25 21:12:03 -0700 Comment on attachment 345765 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345765&action=review > Source/JavaScriptCore/builtins/TypedArrayPrototype.js:410 > - var string = this[0].toLocaleString(); > + var string = this[0].toLocaleString(@argument(0), @argument(1)); > for (var i = 1; i < length; i++) > - string += "," + this[i].toLocaleString(); > + string += "," + this[i].toLocaleString(@argument(0), @argument(1)); Presumably the toLocaleString function can do any arbitrary work, so it can examine its arguments any way it likes. This will turn "no arguments" into "undefined, undefined", and will turn three arguments into two; these behaviors might be OK and might not be. I’m not clear what the specification calls for here. Do we want, instead, to forward the entire array of arguments, without changing its length? 1445333 11 345765 keith_miller 2018-07-26 00:05:48 -0700 Comment on attachment 345765 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345765&action=review >> Source/JavaScriptCore/builtins/TypedArrayPrototype.js:410 >> + string += "," + this[i].toLocaleString(@argument(0), @argument(1)); > > Presumably the toLocaleString function can do any arbitrary work, so it can examine its arguments any way it likes. This will turn "no arguments" into "undefined, undefined", and will turn three arguments into two; these behaviors might be OK and might not be. I’m not clear what the specification calls for here. Do we want, instead, to forward the entire array of arguments, without changing its length? This appears to be what the specification in Intl 402 asks for: https://tc39.github.io/ecma402/#sup-array.prototype.tolocalestring. 1445412 12 andy 2018-07-26 08:04:50 -0700 I read the spec in the way the patch has it, but at least for the default Number.prototype.toLocaleString, passing along the arguments unaltered, either by using apply, or with rest args and spread args would have the same effect. For places where the Number.prototype.toLocaleString has been altered, I'd expect it to receive [ undefined, undefined ] from the text of the spec. As a quick test I ran the following in Firefox: ``` Number.prototype.toLocaleString = function () { console.log(arguments) } new Uint8Array([ 5 ]).toLocaleString() ``` which gave me: ``` Arguments { 0: undefined, 1: undefined } ``` That seems to match the implementation in this patch. 1445657 13 darin 2018-07-26 22:48:45 -0700 (In reply to Keith Miller from comment #11) > This appears to be what the specification in Intl 402 asks for: > > https://tc39.github.io/ecma402/#sup-array.prototype.tolocalestring. OK, great. I read it over and it is what’s called for. (In reply to Andy VanWagoner from comment #12) > for the default Number.prototype.toLocaleString Right, my comment was not about the default function. > Arguments { 0: undefined, 1: undefined } Good, Firefox implementation matches. 340768 2018-05-18 19:38:53 -0700 2018-06-27 10:32:33 -0700 Patch bug-185796-20180518203851.patch text/plain 3730 andy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxOTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 OGNkZDk1YjUxNjJhMmMxMjAyN2Y2OGJmZWQ4MmU1NTU3NzkyYmUxLi41ZDM3MjFhMzBkMzE0MWEy MDliMmY3OWY2OWViNzU0MzFmZThiMTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOC0wNS0xOCAgQW5keSBWYW5XYWdvbmVyICA8YW5keUB2YW53YWdvbmVy LmZhbWlseT4KKworICAgICAgICBbSU5UTF0gQ2FsbCBUeXBlZCBBcnJheSBlbGVtZW50cyB0b0xv Y2FsZVN0cmluZyB3aXRoIGxvY2FsZSBhbmQgb3B0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1Nzk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wcm92ZSBFQ01BIDQwMiBjb21wbGlhbmNlIG9m IHR5cGVkIGFycmF5IHRvTG9jYWxlU3RyaW5nLCBwYXNzaW5nIGFsb25nCisgICAgICAgIHRoZSBs b2NhbGUgYW5kIG9wdGlvbnMgdG8gZWxlbWVudCB0b0xvY2FsZVN0cmluZyBjYWxscy4KKworICAg ICAgICAqIGJ1aWx0aW5zL1R5cGVkQXJyYXlQcm90b3R5cGUuanM6CisgICAgICAgICh0b0xvY2Fs ZVN0cmluZyk6CisKIDIwMTgtMDUtMTggIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzE5ODIuCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvVHlwZWRBcnJheVByb3RvdHlw ZS5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9UeXBlZEFycmF5UHJvdG90eXBl LmpzCmluZGV4IDY2ZGQ2NDUxNTkxZTIzYzI4ZjU2ZmI2YjAwMDMzN2Y3NWUyOTA3MjUuLjk4OWFh NjA2NDE0ZTY0N2UzNGNmNDZkMjRmZmZhYmI0ODA0MjNlYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9idWlsdGlucy9UeXBlZEFycmF5UHJvdG90eXBlLmpzCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9UeXBlZEFycmF5UHJvdG90eXBlLmpzCkBAIC0zOTYs NyArMzk2LDcgQEAgZnVuY3Rpb24gZmlsdGVyKGNhbGxiYWNrIC8qLCB0aGlzQXJnICovKQogICAg IHJldHVybiByZXN1bHQ7CiB9CiAKLWZ1bmN0aW9uIHRvTG9jYWxlU3RyaW5nKCkKK2Z1bmN0aW9u IHRvTG9jYWxlU3RyaW5nKC8qIGxvY2FsZSwgb3B0aW9ucyAqLykKIHsKICAgICAidXNlIHN0cmlj dCI7CiAKQEAgLTQwNSw5ICs0MDUsOSBAQCBmdW5jdGlvbiB0b0xvY2FsZVN0cmluZygpCiAgICAg aWYgKGxlbmd0aCA9PSAwKQogICAgICAgICByZXR1cm4gIiI7CiAKLSAgICB2YXIgc3RyaW5nID0g dGhpc1swXS50b0xvY2FsZVN0cmluZygpOworICAgIHZhciBzdHJpbmcgPSB0aGlzWzBdLnRvTG9j YWxlU3RyaW5nKEBhcmd1bWVudCgwKSwgQGFyZ3VtZW50KDEpKTsKICAgICBmb3IgKHZhciBpID0g MTsgaSA8IGxlbmd0aDsgaSsrKQotICAgICAgICBzdHJpbmcgKz0gIiwiICsgdGhpc1tpXS50b0xv Y2FsZVN0cmluZygpOworICAgICAgICBzdHJpbmcgKz0gIiwiICsgdGhpc1tpXS50b0xvY2FsZVN0 cmluZyhAYXJndW1lbnQoMCksIEBhcmd1bWVudCgxKSk7CiAKICAgICByZXR1cm4gc3RyaW5nOwog fQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRl eCBiNmFkMDQ2N2QzNTI5OGY3ODlhYWU3NTVmYmFkODIxYjI1ODc3M2I2Li4yYjBjYTc2MTc4Mjkx MTg4YTBkMDY1YzlmNGY5YWZlMTMzZTMyZDc3IDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxv ZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA1LTE4ICBB bmR5IFZhbldhZ29uZXIgIDxhbmR5QHZhbndhZ29uZXIuZmFtaWx5PgorCisgICAgICAgIFtJTlRM XSBDYWxsIFR5cGVkIEFycmF5IGVsZW1lbnRzIHRvTG9jYWxlU3RyaW5nIHdpdGggbG9jYWxlIGFu ZCBvcHRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xODU3OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmUgbm93IHBhc3NpbmcgVHlwZWRBcnJheSB0b0xvY2FsZVN0cmluZyBleHBlY3RhdGlv bi4KKworICAgICAgICAqIHRlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWw6CisKIDIwMTgtMDUtMTgg IEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgb3BfaW4g c2hvdWxkIG1hcmsgaWYgaXQgc2VlcyBvdXQgb2YgYm91bmRzIGFjY2Vzc2VzCmRpZmYgLS1naXQg YS9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwgYi9KU1Rlc3RzL3Rlc3QyNjIvZXhw ZWN0YXRpb25zLnlhbWwKaW5kZXggZWUwYjM4MDE2MDBhMjU0MzQ2NDAyYTE2MjBlODg3ODA5MTYx MTI3Mi4uNmE0NjlmODQyMDZhNDYzZmQ0ZDAyZjc4MDRlMDM2ODg3YmNjMzA2ZCAxMDA2NDQKLS0t IGEvSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1sCisrKyBiL0pTVGVzdHMvdGVzdDI2 Mi9leHBlY3RhdGlvbnMueWFtbApAQCAtMTk5Nyw5ICsxOTk3LDYgQEAgdGVzdC9pbnRsNDAyL1Bs dXJhbFJ1bGVzL2RlZmF1bHQtb3B0aW9ucy1vYmplY3QtcHJvdG90eXBlLmpzOgogdGVzdC9pbnRs NDAyL1BsdXJhbFJ1bGVzL2xlbmd0aC5qczoKICAgZGVmYXVsdDogJ1Rlc3QyNjJFcnJvcjogRXhw ZWN0ZWQgb2JqW2xlbmd0aF0gdG8gaGF2ZSBjb25maWd1cmFibGU6dHJ1ZS4nCiAgIHN0cmljdCBt b2RlOiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBvYmpbbGVuZ3RoXSB0byBoYXZlIGNvbmZpZ3Vy YWJsZTp0cnVlLicKLXRlc3QvaW50bDQwMi9UeXBlZEFycmF5L3Byb3RvdHlwZS90b0xvY2FsZVN0 cmluZy9jYWxscy10b0xvY2FsZVN0cmluZy1udW1iZXItZWxlbWVudHMuanM6Ci0gIGRlZmF1bHQ6 ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjDgsKrMMOCwrssIMOCwqvDoMK5wpAu w6DCucKQw6DCucKQw6DCucKQw4LCuykgdG8gYmUgdHJ1ZSAoVGVzdGluZyB3aXRoIEZsb2F0NjRB cnJheS4pJwotICBzdHJpY3QgbW9kZTogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQgU2FtZVZhbHVl KMOCwqsww4LCuywgw4LCq8OgwrnCkC7DoMK5wpDDoMK5wpDDoMK5wpDDgsK7KSB0byBiZSB0cnVl IChUZXN0aW5nIHdpdGggRmxvYXQ2NEFycmF5LiknCiB0ZXN0L2ludGw0MDIvZmFsbGJhY2stbG9j YWxlcy1hcmUtc3VwcG9ydGVkLmpzOgogICBkZWZhdWx0OiAiVGVzdDI2MkVycm9yOiBMb2NhbGUg emgtSGFucy1DTiBpcyBzdXBwb3J0ZWQsIGJ1dCBmYWxsYmFjayB6aC1DTiBpc24ndC4gRXhwZWN0 ZWQgU2FtZVZhbHVlKMOCwqstMcOCwrssIMOCwqstMcOCwrspIHRvIGJlIGZhbHNlIChUZXN0aW5n IHdpdGggTnVtYmVyRm9ybWF0LikiCiAgIHN0cmljdCBtb2RlOiAiVGVzdDI2MkVycm9yOiBMb2Nh bGUgemgtSGFucy1DTiBpcyBzdXBwb3J0ZWQsIGJ1dCBmYWxsYmFjayB6aC1DTiBpc24ndC4gRXhw ZWN0ZWQgU2FtZVZhbHVlKMOCwqstMcOCwrssIMOCwqstMcOCwrspIHRvIGJlIGZhbHNlIChUZXN0 aW5nIHdpdGggTnVtYmVyRm9ybWF0LikiCg== 343721 2018-06-27 10:32:34 -0700 2018-07-25 10:06:35 -0700 Rebased bug-185796-20180627113234.patch text/plain 3990 andy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzMjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NDgzYzk2ODRhMTM0ZDBiMjQ1NDc1YmNiY2NiMjI2ZmRiMzBiNTAxLi44OTA5MjhmYjdlZmIxZDll NGViN2E2Nzc5ODM1ZWY2NTE0MzFlMDY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOC0wNi0yNyAgQW5keSBWYW5XYWdvbmVyICA8YW5keUB2YW53YWdvbmVy LmZhbWlseT4KKworICAgICAgICBbSU5UTF0gQ2FsbCBUeXBlZCBBcnJheSBlbGVtZW50cyB0b0xv Y2FsZVN0cmluZyB3aXRoIGxvY2FsZSBhbmQgb3B0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1Nzk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wcm92ZSBFQ01BIDQwMiBjb21wbGlhbmNlIG9m IHR5cGVkIGFycmF5IHRvTG9jYWxlU3RyaW5nLCBwYXNzaW5nIGFsb25nCisgICAgICAgIHRoZSBs b2NhbGUgYW5kIG9wdGlvbnMgdG8gZWxlbWVudCB0b0xvY2FsZVN0cmluZyBjYWxscy4KKworICAg ICAgICAqIGJ1aWx0aW5zL1R5cGVkQXJyYXlQcm90b3R5cGUuanM6CisgICAgICAgICh0b0xvY2Fs ZVN0cmluZyk6CisKIDIwMTgtMDYtMjcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgog CiAgICAgICAgIERGRydzIGNvbXBpbGVSZWFsbG9jYXRlUHJvcGVydHlTdG9yYWdlKCkgYW5kIGNv bXBpbGVBbGxvY2F0ZVByb3BlcnR5U3RvcmFnZSgpIHNsb3cgcGF0aHMgc2hvdWxkIGFsc28gY2xl YXIgdW51c2VkIHByb3BlcnRpZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YnVpbHRpbnMvVHlwZWRBcnJheVByb3RvdHlwZS5qcyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i dWlsdGlucy9UeXBlZEFycmF5UHJvdG90eXBlLmpzCmluZGV4IDY2ZGQ2NDUxNTkxZTIzYzI4ZjU2 ZmI2YjAwMDMzN2Y3NWUyOTA3MjUuLjk4OWFhNjA2NDE0ZTY0N2UzNGNmNDZkMjRmZmZhYmI0ODA0 MjNlYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9UeXBlZEFy cmF5UHJvdG90eXBlLmpzCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWlsdGlucy9UeXBl ZEFycmF5UHJvdG90eXBlLmpzCkBAIC0zOTYsNyArMzk2LDcgQEAgZnVuY3Rpb24gZmlsdGVyKGNh bGxiYWNrIC8qLCB0aGlzQXJnICovKQogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKLWZ1bmN0aW9u IHRvTG9jYWxlU3RyaW5nKCkKK2Z1bmN0aW9uIHRvTG9jYWxlU3RyaW5nKC8qIGxvY2FsZSwgb3B0 aW9ucyAqLykKIHsKICAgICAidXNlIHN0cmljdCI7CiAKQEAgLTQwNSw5ICs0MDUsOSBAQCBmdW5j dGlvbiB0b0xvY2FsZVN0cmluZygpCiAgICAgaWYgKGxlbmd0aCA9PSAwKQogICAgICAgICByZXR1 cm4gIiI7CiAKLSAgICB2YXIgc3RyaW5nID0gdGhpc1swXS50b0xvY2FsZVN0cmluZygpOworICAg IHZhciBzdHJpbmcgPSB0aGlzWzBdLnRvTG9jYWxlU3RyaW5nKEBhcmd1bWVudCgwKSwgQGFyZ3Vt ZW50KDEpKTsKICAgICBmb3IgKHZhciBpID0gMTsgaSA8IGxlbmd0aDsgaSsrKQotICAgICAgICBz dHJpbmcgKz0gIiwiICsgdGhpc1tpXS50b0xvY2FsZVN0cmluZygpOworICAgICAgICBzdHJpbmcg Kz0gIiwiICsgdGhpc1tpXS50b0xvY2FsZVN0cmluZyhAYXJndW1lbnQoMCksIEBhcmd1bWVudCgx KSk7CiAKICAgICByZXR1cm4gc3RyaW5nOwogfQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VM b2cgYi9KU1Rlc3RzL0NoYW5nZUxvZwppbmRleCBmMjEzMjg2MjBjY2Y1NzRhNDNlMDZiZGNjMWY3 NThjZjM2ODBkOGIxLi5iMWRiY2Q2ZTg1MDcyNGY0YjA1MGY5YjY0YmM2MGZhYWZjYjNjNzMyIDEw MDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDE4LTA2LTI3ICBBbmR5IFZhbldhZ29uZXIgIDxhbmR5QHZhbndhZ29u ZXIuZmFtaWx5PgorCisgICAgICAgIFtJTlRMXSBDYWxsIFR5cGVkIEFycmF5IGVsZW1lbnRzIHRv TG9jYWxlU3RyaW5nIHdpdGggbG9jYWxlIGFuZCBvcHRpb25zCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU3OTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgbm93IHBhc3NpbmcgVHlwZWRBcnJh eSB0b0xvY2FsZVN0cmluZyBleHBlY3RhdGlvbi4KKworICAgICAgICAqIHRlc3QyNjIvZXhwZWN0 YXRpb25zLnlhbWw6CisKIDIwMTgtMDYtMjcgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29t PgogCiAgICAgICAgIERGRydzIGNvbXBpbGVSZWFsbG9jYXRlUHJvcGVydHlTdG9yYWdlKCkgYW5k IGNvbXBpbGVBbGxvY2F0ZVByb3BlcnR5U3RvcmFnZSgpIHNsb3cgcGF0aHMgc2hvdWxkIGFsc28g Y2xlYXIgdW51c2VkIHByb3BlcnRpZXMuCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3Rlc3QyNjIvZXhw ZWN0YXRpb25zLnlhbWwgYi9KU1Rlc3RzL3Rlc3QyNjIvZXhwZWN0YXRpb25zLnlhbWwKaW5kZXgg YWZhNDJkZTc5MzJlZDAyZjA5NjdkMTc1MTc0ZTA3YjBkYmI3NzBmOS4uMjRlOTM1MWQ0YzMxNzJh NzlhZjU0MDZkN2ZlYTgyMzE2ZDZkZTI5NyAxMDA2NDQKLS0tIGEvSlNUZXN0cy90ZXN0MjYyL2V4 cGVjdGF0aW9ucy55YW1sCisrKyBiL0pTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbApA QCAtMTgyNSw5ICsxODI1LDYgQEAgdGVzdC9pbnRsNDAyL1BsdXJhbFJ1bGVzL2xlbmd0aC5qczoK IHRlc3QvaW50bDQwMi9QbHVyYWxSdWxlcy9wcm90b3R5cGUvcmVzb2x2ZWRPcHRpb25zL3BsdXJh bENhdGVnb3JpZXMuanM6CiAgIGRlZmF1bHQ6ICdUZXN0MjYyRXJyb3I6IFNob3VsZCBoYXZlIGRp ZmZlcmVudCBhcnJheXMgRXhwZWN0ZWQgU2FtZVZhbHVlKMOCwqt1bmRlZmluZWTDgsK7LCDDgsKr dW5kZWZpbmVkw4LCuykgdG8gYmUgZmFsc2UnCiAgIHN0cmljdCBtb2RlOiAnVGVzdDI2MkVycm9y OiBTaG91bGQgaGF2ZSBkaWZmZXJlbnQgYXJyYXlzIEV4cGVjdGVkIFNhbWVWYWx1ZSjDgsKrdW5k ZWZpbmVkw4LCuywgw4LCq3VuZGVmaW5lZMOCwrspIHRvIGJlIGZhbHNlJwotdGVzdC9pbnRsNDAy L1R5cGVkQXJyYXkvcHJvdG90eXBlL3RvTG9jYWxlU3RyaW5nL2NhbGxzLXRvTG9jYWxlU3RyaW5n LW51bWJlci1lbGVtZW50cy5qczoKLSAgZGVmYXVsdDogJ1Rlc3QyNjJFcnJvcjogRXhwZWN0ZWQg U2FtZVZhbHVlKMOCwqsww4LCuywgw4LCq8OgwrnCkC7DoMK5wpDDoMK5wpDDoMK5wpDDgsK7KSB0 byBiZSB0cnVlIChUZXN0aW5nIHdpdGggRmxvYXQ2NEFycmF5LiknCi0gIHN0cmljdCBtb2RlOiAn VGVzdDI2MkVycm9yOiBFeHBlY3RlZCBTYW1lVmFsdWUow4LCqzDDgsK7LCDDgsKrw6DCucKQLsOg wrnCkMOgwrnCkMOgwrnCkMOCwrspIHRvIGJlIHRydWUgKFRlc3Rpbmcgd2l0aCBGbG9hdDY0QXJy YXkuKScKIHRlc3QvaW50bDQwMi9mYWxsYmFjay1sb2NhbGVzLWFyZS1zdXBwb3J0ZWQuanM6CiAg IGRlZmF1bHQ6ICJUZXN0MjYyRXJyb3I6IExvY2FsZSB6aC1IYW5zLUNOIGlzIHN1cHBvcnRlZCwg YnV0IGZhbGxiYWNrIHpoLUNOIGlzbid0LiBFeHBlY3RlZCBTYW1lVmFsdWUow4LCqy0xw4LCuywg w4LCqy0xw4LCuykgdG8gYmUgZmFsc2UgKFRlc3Rpbmcgd2l0aCBOdW1iZXJGb3JtYXQuKSIKICAg c3RyaWN0IG1vZGU6ICJUZXN0MjYyRXJyb3I6IExvY2FsZSB6aC1IYW5zLUNOIGlzIHN1cHBvcnRl ZCwgYnV0IGZhbGxiYWNrIHpoLUNOIGlzbid0LiBFeHBlY3RlZCBTYW1lVmFsdWUow4LCqy0xw4LC uywgw4LCqy0xw4LCuykgdG8gYmUgZmFsc2UgKFRlc3Rpbmcgd2l0aCBOdW1iZXJGb3JtYXQuKSIK 345765 2018-07-25 10:06:37 -0700 2018-07-25 10:54:23 -0700 Patch bug-185796-20180725110636.patch text/plain 3722 andy U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz M2VlOGI1MWRiYzE4NzNlNGRiOTUzOTkwZjJiNGI0NGIxZWExOWZlLi4wYjRmMmRlZjk1NDc4YTdi ZDdiNGUyYzMyN2Q1NGQyNDZlZmI2MWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOC0wNy0yNSAgQW5keSBWYW5XYWdvbmVyICA8YW5keUB2YW53YWdvbmVy LmZhbWlseT4KKworICAgICAgICBbSU5UTF0gQ2FsbCBUeXBlZCBBcnJheSBlbGVtZW50cyB0b0xv Y2FsZVN0cmluZyB3aXRoIGxvY2FsZSBhbmQgb3B0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1Nzk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg S2VpdGggTWlsbGVyLgorCisgICAgICAgIEltcHJvdmUgRUNNQSA0MDIgY29tcGxpYW5jZSBvZiB0 eXBlZCBhcnJheSB0b0xvY2FsZVN0cmluZywgcGFzc2luZyBhbG9uZworICAgICAgICB0aGUgbG9j YWxlIGFuZCBvcHRpb25zIHRvIGVsZW1lbnQgdG9Mb2NhbGVTdHJpbmcgY2FsbHMuCisKKyAgICAg ICAgKiBidWlsdGlucy9UeXBlZEFycmF5UHJvdG90eXBlLmpzOgorICAgICAgICAodG9Mb2NhbGVT dHJpbmcpOgorCiAyMDE4LTA3LTI0ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNv bnkuY29tPgogCiAgICAgICAgIHJ1bkpJVFRocmVhZExpbWl0VGVzdHMgaXMgZmFpbGluZwpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL1R5cGVkQXJyYXlQcm90b3R5 cGUuanMgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvVHlwZWRBcnJheVByb3RvdHlw ZS5qcwppbmRleCA2NmRkNjQ1MTU5MWUyM2MyOGY1NmZiNmIwMDAzMzdmNzVlMjkwNzI1Li45ODlh YTYwNjQxNGU2NDdlMzRjZjQ2ZDI0ZmZmYWJiNDgwNDIzZWFkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvVHlwZWRBcnJheVByb3RvdHlwZS5qcworKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvVHlwZWRBcnJheVByb3RvdHlwZS5qcwpAQCAtMzk2 LDcgKzM5Niw3IEBAIGZ1bmN0aW9uIGZpbHRlcihjYWxsYmFjayAvKiwgdGhpc0FyZyAqLykKICAg ICByZXR1cm4gcmVzdWx0OwogfQogCi1mdW5jdGlvbiB0b0xvY2FsZVN0cmluZygpCitmdW5jdGlv biB0b0xvY2FsZVN0cmluZygvKiBsb2NhbGUsIG9wdGlvbnMgKi8pCiB7CiAgICAgInVzZSBzdHJp Y3QiOwogCkBAIC00MDUsOSArNDA1LDkgQEAgZnVuY3Rpb24gdG9Mb2NhbGVTdHJpbmcoKQogICAg IGlmIChsZW5ndGggPT0gMCkKICAgICAgICAgcmV0dXJuICIiOwogCi0gICAgdmFyIHN0cmluZyA9 IHRoaXNbMF0udG9Mb2NhbGVTdHJpbmcoKTsKKyAgICB2YXIgc3RyaW5nID0gdGhpc1swXS50b0xv Y2FsZVN0cmluZyhAYXJndW1lbnQoMCksIEBhcmd1bWVudCgxKSk7CiAgICAgZm9yICh2YXIgaSA9 IDE7IGkgPCBsZW5ndGg7IGkrKykKLSAgICAgICAgc3RyaW5nICs9ICIsIiArIHRoaXNbaV0udG9M b2NhbGVTdHJpbmcoKTsKKyAgICAgICAgc3RyaW5nICs9ICIsIiArIHRoaXNbaV0udG9Mb2NhbGVT dHJpbmcoQGFyZ3VtZW50KDApLCBAYXJndW1lbnQoMSkpOwogCiAgICAgcmV0dXJuIHN0cmluZzsK IH0KZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggYTliOGU1ZWRjMDljMWM0MjVlY2VjOWVjYzljM2JkOTgxYjRkN2Q3Zi4uMmEzY2JmMTMyZDhh Y2VmYmRlNGYwODVmMzNjMGMzNmMxNGM2N2UxOCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VM b2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0wNy0yNSAg QW5keSBWYW5XYWdvbmVyICA8YW5keUB2YW53YWdvbmVyLmZhbWlseT4KKworICAgICAgICBbSU5U TF0gQ2FsbCBUeXBlZCBBcnJheSBlbGVtZW50cyB0b0xvY2FsZVN0cmluZyB3aXRoIGxvY2FsZSBh bmQgb3B0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg1Nzk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VpdGggTWlsbGVyLgorCisgICAgICAg IFJlbW92ZSBub3cgcGFzc2luZyBUeXBlZEFycmF5IHRvTG9jYWxlU3RyaW5nIGV4cGVjdGF0aW9u LgorCisgICAgICAgICogdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbDoKKwogMjAxOC0wNy0yNCAg Q29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCwgcm9sbGluZyBvdXQgcjIzNDE4My4KZGlmZiAtLWdpdCBhL0pTVGVzdHMvdGVzdDI2Mi9l eHBlY3RhdGlvbnMueWFtbCBiL0pTVGVzdHMvdGVzdDI2Mi9leHBlY3RhdGlvbnMueWFtbAppbmRl eCBiNDYyYTJiMzQyNzc2ZmVmYjVhN2I1NDhkYjczOTAzNGU3ZGY0MTZjLi5lYmEzZWM5ZGQ1NTY3 MDgwZTdhZTdhNTFmYzI1NjFkY2FmNzJiNTg0IDEwMDY0NAotLS0gYS9KU1Rlc3RzL3Rlc3QyNjIv ZXhwZWN0YXRpb25zLnlhbWwKKysrIGIvSlNUZXN0cy90ZXN0MjYyL2V4cGVjdGF0aW9ucy55YW1s CkBAIC0xNzgwLDkgKzE3ODAsNiBAQCB0ZXN0L2ludGw0MDIvUGx1cmFsUnVsZXMvbGVuZ3RoLmpz OgogdGVzdC9pbnRsNDAyL1BsdXJhbFJ1bGVzL3Byb3RvdHlwZS9yZXNvbHZlZE9wdGlvbnMvcGx1 cmFsQ2F0ZWdvcmllcy5qczoKICAgZGVmYXVsdDogJ1Rlc3QyNjJFcnJvcjogU2hvdWxkIGhhdmUg ZGlmZmVyZW50IGFycmF5cyBFeHBlY3RlZCBTYW1lVmFsdWUow4LCq3VuZGVmaW5lZMOCwrssIMOC wqt1bmRlZmluZWTDgsK7KSB0byBiZSBmYWxzZScKICAgc3RyaWN0IG1vZGU6ICdUZXN0MjYyRXJy b3I6IFNob3VsZCBoYXZlIGRpZmZlcmVudCBhcnJheXMgRXhwZWN0ZWQgU2FtZVZhbHVlKMOCwqt1 bmRlZmluZWTDgsK7LCDDgsKrdW5kZWZpbmVkw4LCuykgdG8gYmUgZmFsc2UnCi10ZXN0L2ludGw0 MDIvVHlwZWRBcnJheS9wcm90b3R5cGUvdG9Mb2NhbGVTdHJpbmcvY2FsbHMtdG9Mb2NhbGVTdHJp bmctbnVtYmVyLWVsZW1lbnRzLmpzOgotICBkZWZhdWx0OiAnVGVzdDI2MkVycm9yOiBFeHBlY3Rl ZCBTYW1lVmFsdWUow4LCqzDDgsK7LCDDgsKrw6DCucKQLsOgwrnCkMOgwrnCkMOgwrnCkMOCwrsp IHRvIGJlIHRydWUgKFRlc3Rpbmcgd2l0aCBGbG9hdDY0QXJyYXkuKScKLSAgc3RyaWN0IG1vZGU6 ICdUZXN0MjYyRXJyb3I6IEV4cGVjdGVkIFNhbWVWYWx1ZSjDgsKrMMOCwrssIMOCwqvDoMK5wpAu w6DCucKQw6DCucKQw6DCucKQw4LCuykgdG8gYmUgdHJ1ZSAoVGVzdGluZyB3aXRoIEZsb2F0NjRB cnJheS4pJwogdGVzdC9sYW5ndWFnZS9hcmd1bWVudHMtb2JqZWN0L21hcHBlZC9ub25jb25maWd1 cmFibGUtbm9uZW51bWVyYWJsZS1ub253cml0YWJsZS1kZXNjcmlwdG9ycy1zZXQtYnktYXJndW1l bnRzLmpzOgogICBkZWZhdWx0OiAnVGVzdDI2MkVycm9yOiBFeHBlY3RlZCBvYmpbMF0gdG8gaGF2 ZSBlbnVtZXJhYmxlOmZhbHNlLicKIHRlc3QvbGFuZ3VhZ2UvYXJndW1lbnRzLW9iamVjdC9tYXBw ZWQvbm9uY29uZmlndXJhYmxlLW5vbmVudW1lcmFibGUtbm9ud3JpdGFibGUtZGVzY3JpcHRvcnMt c2V0LWJ5LXBhcmFtLmpzOgo=