185790 2018-05-18 15:34:48 -0700 bisect-builds --list not showing all builds 2018-06-21 14:47:17 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari 11 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lforschler lforschler aakash_jain dean_johnson lforschler webkit-bug-importer oldest_to_newest 1425324 0 lforschler 2018-05-18 15:34:48 -0700 running this command does not get me all builds: bisect-builds -p mac-highsierra --list my initial research suggests we have reached the 1MB payload limit on amazon lambda functions. This is visible when testing the API gateway function. The following is returned: "LastEvaluatedKey": { "revision": { "N": "231282" }, "identifier": { "S": "mac-highsierra-x86_64-release" } }, "ScannedCount": 5271 LastEvaluatedKey is used to signal when we have reached the limit. If there is an entry there, it means more rows exist. We need to query again, using the LastEvaluatedKey as our starting point. Apparently, we have so many builds on this OS, that we need to investigate this. 1425325 1 lforschler 2018-05-18 15:35:18 -0700 https://stackoverflow.com/questions/43410541/dynamodb-scan-query-does-not-return-all-the-data 1425326 2 webkit-bug-importer 2018-05-18 15:35:20 -0700 <rdar://problem/40380222> 1425332 3 lforschler 2018-05-18 15:51:16 -0700 diving at the raw json returned from the gateway, I'm also seeing this: u'LastEvaluatedKey': {u'identifier': {u'S': u'mac-highsierra-x86_64-release'}, u'revision': {u'N': u'231282'}}, u'ScannedCount': 5271}} 1425333 4 lforschler 2018-05-18 15:52:25 -0700 I don't see a clear way to fix this in the AWS API Gateway. It's a dumb mapping that simply does the query and returns what it finds. It doesn't have any place to add logic to 'continue' the query from the LastEvaluatedKey. I will have to research this more. 1425336 5 lforschler 2018-05-18 15:58:32 -0700 I believe to fix this we will need to do the following: Update the API Gateway to accept an optional "startRevision". Teach the bisect-builds script to parse the json, and if it finds a non-null value for LastEvaluatedKey, then we need to send another request, using the LastEvaluatedKey value as the 'start revision' for the API. Then accumulate results until we get them all. 1425350 6 lforschler 2018-05-18 16:20:52 -0700 https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_Scan.html ExclusiveStartKey The primary key of the first item that this operation will evaluate. Use the value that was returned for LastEvaluatedKey in the previous operation. The data type for ExclusiveStartKey must be String, Number or Binary. No set data types are allowed. In a parallel scan, a Scan request that includes ExclusiveStartKey must specify the same segment whose previous Scan returned the corresponding value of LastEvaluatedKey. Type: String to AttributeValue object map Key Length Constraints: Maximum length of 65535. Required: No 1435212 7 343260 lforschler 2018-06-21 13:14:33 -0700 Created attachment 343260 Teach bisect-builds to use the LastEvaluatedKey option. 1435220 8 aakash_jain 2018-06-21 13:24:33 -0700 looks good to me. 1435244 9 lforschler 2018-06-21 13:59:06 -0700 Committed revision 233057. 1435265 10 343260 dean_johnson 2018-06-21 14:47:17 -0700 Comment on attachment 343260 Teach bisect-builds to use the LastEvaluatedKey option. View in context: https://bugs.webkit.org/attachment.cgi?id=343260&action=review > Tools/Scripts/bisect-builds:96 > +def get_api_url(options, LastEvaluatedKey=None): Nit: Use snake_case instead of CamelCase on LastEvaluatedKey. Also, it isn't immediately obvious what 'LastEvaluatedKey' is supposed to mean or be used for here -- can you add a comment or rename the variable to be more descriptive? > Tools/Scripts/bisect-builds:236 > + if 'LastEvaluatedKey' in data['revisions']: Is it possible to need to run this multiple times with 'LastEvaluatedKey'? It looks like maybe this is doing something similar to pagination? If so, we should do this in a `while` loop, or re-call fetch_revision_list with a new LastEvaluatedKey while more results need to be fetched. 343260 2018-06-21 13:14:33 -0700 2018-06-21 13:41:38 -0700 Teach bisect-builds to use the LastEvaluatedKey option. 185790.patch text/plain 3396 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzA1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE4LTA2LTIxICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBiaXNlY3QtYnVpbGRzIC0tbGlzdCBub3Qgc2hvd2luZyBhbGwgYnVp bGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU3 OTAKKworICAgICAgICBUaGUgQVdTIEdhdGV3YXkgQVBJIGNhbGwgaW50byBkeW5hbW9EQiBpcyBs aW1pdGVkIHRvIHJldHVybmluZyAxTUIgb2YgcXVlcnkgZGF0YS4gT3VyIGFyY2hpdmUgc2V0IGhh cyBvdmVyZ3Jvd24gdGhpcyBsaW1pdCwKKyAgICAgICAgY2F1c2luZyB1cyB0byByZXRyaWV2ZSBh IHRydW5jYXRlZCBsaXN0IG9mIHJlc3VsdHMuIEZvcnR1bmF0ZWx5LCB3aGVuIHRoaXMgbGltaXQg aXMgcmVhY2hlZCwgZHluYW1vREIgcmV0dXJucyBhIAorICAgICAgICAiTGFzdEV2YWx1YXRlZEtl eSIsIHdoaWNoIGNhbiBiZSB1c2VkIHRvIGNvbnRpbnVlIHRoZSBxdWVyeSBpbiBhbm90aGVyIHJl cXVlc3QuIAorCisgICAgICAgIFRoaXMgcGF0Y2ggdGVhY2hlcyBiaXNlY3QtYnVpbGQgdG8gcGFz cyBhbG9uZyB0aGlzIGtleSB3aGVuIG5lZWRlZC4gVGhlIGJhY2tlbmQgYXBpIHdhcyB1cGRhdGVk IGZyb20gdjIgdG8gdjJfMSB0byBzdXBwb3J0CisgICAgICAgIHRoaXMgbmV3IHF1ZXJ5c3RyaW5n IG9wdGlvbi4gQW55IGV4aXN0aW5nIGNvZGUgdXNpbmcgdjIgd2lsbCBub3QgYmUgYWZmZWN0ZWQu CisgICAgICAgIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvYmlzZWN0LWJ1aWxkczoKKyAgICAgICAgKGdldF9hcGlfdXJsKTogYWRkZWQg b3B0aW9uYWwgTGFzdEV2YWx1YXRlZEtleSBhcmd1bWVudCwgd2hpY2ggd2lsbCBhcHBlbmQgdGhl IHF1ZXJ5IHN0cmluZyB0byB0aGUgYmFzZSBhcGkgdXJsLgorICAgICAgICAoZmV0Y2hfcmV2aXNp b25fbGlzdCk6IEFkZGVkIHRvIGFsbG93IGEgcmVjdXJzaXZlIGNhbGwgd2hpY2ggd2lsbCBxdWVy eSB1bnRpbCB3ZSByZXRyaWV2ZSBldmVyeSBpdGVtIHJlcXVlc3RlZC4KKyAgICAgICAgKG1haW4p OiB0ZWFjaCBob3cgdG8gdXNlIGZldGNoX3JldmlzaW9uX2xpc3QuCisKIDIwMTgtMDYtMjEgIEFh a2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtld3MtYnVpbGRd IHVuaXQtdGVzdHMgZmFpbCB3aGVuIHJ1biBmcm9tIGFub3RoZXIgZGlyZWN0b3J5CkluZGV4OiBU b29scy9TY3JpcHRzL2Jpc2VjdC1idWlsZHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9i aXNlY3QtYnVpbGRzCShyZXZpc2lvbiAyMzMwNTMpCisrKyBUb29scy9TY3JpcHRzL2Jpc2VjdC1i dWlsZHMJKHdvcmtpbmcgY29weSkKQEAgLTM4LDcgKzM4LDcgQEAgaW1wb3J0IHRlbXBmaWxlCiBp bXBvcnQgdXJsbGliMgogaW1wb3J0IHVybHBhcnNlCiAKLVJFU1RfQVBJX1VSTCA9ICdodHRwczov L3ExdHpxZnk0OGUuZXhlY3V0ZS1hcGkudXMtd2VzdC0yLmFtYXpvbmF3cy5jb20vdjIvJworUkVT VF9BUElfVVJMID0gJ2h0dHBzOi8vcTF0enFmeTQ4ZS5leGVjdXRlLWFwaS51cy13ZXN0LTIuYW1h em9uYXdzLmNvbS92Ml8xLycKIFJFU1RfQVBJX0VORFBPSU5UID0gJ2FyY2hpdmVzLycKIFJFU1Rf QVBJX01JTklGSUVEX0VORFBPSU5UID0gJ21pbmlmaWVkLWFyY2hpdmVzLycKIApAQCAtOTMsMTMg KzkzLDE3IEBAIGRlZiBmaW5kX2dlKGEsIHgpOgogIyAtLS0tIGVuZCBiaXNlY3QgaGVscGVycyAt LS0tCiAKIAotZGVmIGdldF9hcGlfdXJsKG9wdGlvbnMpOgorZGVmIGdldF9hcGlfdXJsKG9wdGlv bnMsIExhc3RFdmFsdWF0ZWRLZXk9Tm9uZSk6CiAgICAgaWYgb3B0aW9ucy5mdWxsOgogICAgICAg ICBiYXNlX3VybCA9IHVybHBhcnNlLnVybGpvaW4oUkVTVF9BUElfVVJMLCBSRVNUX0FQSV9FTkRQ T0lOVCkKICAgICBlbHNlOgogICAgICAgICBiYXNlX3VybCA9IHVybHBhcnNlLnVybGpvaW4oUkVT VF9BUElfVVJMLCBSRVNUX0FQSV9NSU5JRklFRF9FTkRQT0lOVCkKIAogICAgIGFwaV91cmwgPSB1 cmxwYXJzZS51cmxqb2luKGJhc2VfdXJsLCAnLScuam9pbihbb3B0aW9ucy5wbGF0Zm9ybSwgb3B0 aW9ucy5hcmNoaXRlY3R1cmUsIG9wdGlvbnMuY29uZmlndXJhdGlvbl0pKQorICAgIGlmIExhc3RF dmFsdWF0ZWRLZXk6CisgICAgICAgIHF1ZXJ5c3RyaW5nID0gdXJsbGliMi5xdW90ZShqc29uLmR1 bXBzKExhc3RFdmFsdWF0ZWRLZXkpKQorICAgICAgICBhcGlfdXJsICs9ICc/RXhjbHVzaXZlU3Rh cnRLZXk9JyArIHF1ZXJ5c3RyaW5nCisgICAgICAgIAogICAgIHJldHVybiBhcGlfdXJsCiAKIApA QCAtMjIzLDE1ICsyMjcsMjMgQEAgZGVmIHByaW50X2xpc3RfYW5kX2V4aXQocmV2aXNpb25fbGlz dCwgbwogICAgICAgICBwcmludChyZXZpc2lvbl9saXN0KQogICAgICAgICBleGl0KDApCiAKLWRl ZiBtYWluKG9wdGlvbnMpOgotICAgIHZhbGlkYXRlX29wdGlvbnMob3B0aW9ucykKLQotICAgIHVy bCA9IGdldF9hcGlfdXJsKG9wdGlvbnMpCitkZWYgZmV0Y2hfcmV2aXNpb25fbGlzdChvcHRpb25z LCBMYXN0RXZhbHVhdGVkS2V5PU5vbmUpOgorICAgIHVybCA9IGdldF9hcGlfdXJsKG9wdGlvbnMs IExhc3RFdmFsdWF0ZWRLZXkpCiAgICAgciA9IHVybGxpYjIudXJsb3Blbih1cmwpCiAgICAgZGF0 YSA9IGpzb24ubG9hZChyKQotICAgIAogICAgIHJldmlzaW9uX2xpc3QgPSBnZXRfc29ydGVkX3Jl dmlzaW9ucyhkYXRhKQogCisgICAgaWYgJ0xhc3RFdmFsdWF0ZWRLZXknIGluIGRhdGFbJ3Jldmlz aW9ucyddOgorICAgICAgICBMYXN0RXZhbHVhdGVkS2V5ID0gZGF0YVsncmV2aXNpb25zJ11bJ0xh c3RFdmFsdWF0ZWRLZXknXQorICAgICAgICByZXZpc2lvbl9saXN0ICs9IGZldGNoX3JldmlzaW9u X2xpc3Qob3B0aW9ucywgTGFzdEV2YWx1YXRlZEtleSkKKyAgICAgICAgCisgICAgcmV0dXJuIHJl dmlzaW9uX2xpc3QKKyAgICAKK2RlZiBtYWluKG9wdGlvbnMpOgorICAgIHZhbGlkYXRlX29wdGlv bnMob3B0aW9ucykKKworICAgIHJldmlzaW9uX2xpc3QgPSBmZXRjaF9yZXZpc2lvbl9saXN0KG9w dGlvbnMpCisgICAgCiAgICAgaWYgb3B0aW9ucy5saXN0OgogICAgICAgICBwcmludF9saXN0X2Fu ZF9leGl0KHJldmlzaW9uX2xpc3QsIG9wdGlvbnMpCiAK