185786 2018-05-18 14:26:43 -0700 Add missing exception check. 2018-05-18 14:46:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1425287 0 mark.lam 2018-05-18 14:26:43 -0700 <rdar://problem/35686560> 1425290 1 340737 mark.lam 2018-05-18 14:33:16 -0700 Created attachment 340737 proposed patch. 1425291 2 340737 msaboff 2018-05-18 14:35:29 -0700 Comment on attachment 340737 proposed patch. r=me 1425296 3 mark.lam 2018-05-18 14:46:54 -0700 Thanks for the review. Landed in r231983: <http://trac.webkit.org/r231983>. 340737 2018-05-18 14:33:16 -0700 2018-05-18 14:35:29 -0700 proposed patch. bug-185786.patch text/plain 2800 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzE5ODIpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA1LTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgbWlzc2luZyBleGNlcHRpb24gY2hlY2suCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU3ODYKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzM1Njg2NTYwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogc3RyZXNzL3JlZ3Jlc3MtMTg1Nzg2LmpzOiBBZGRlZC4KKwogMjAxOC0w NS0xNiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEpTQyBzaG91 bGQgaGF2ZSBJbnN0YW5jZU9mIGlubGluZSBjYWNoaW5nCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9y ZWdyZXNzLTE4NTc4Ni5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4 NTc4Ni5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4NTc4Ni5q cwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDIyIEBACitmdW5jdGlvbiBmb28oKSB7CisgICAg cmV0dXJuIG5ldyBQcm94eSh7fSwKKyAgICAgICAgbmV3IFByb3h5KHt9LCB7CisgICAgICAgICAg ICBnZXQ6IGZ1bmN0aW9uICgpIHsKKyAgICAgICAgICAgICAgICB0aHJvdyAiZXhwZWN0ZWQgZXhj ZXB0aW9uIjsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfSkKKyAgICApOyAKK30KKwordmFyIGEg PSBmb28oKTsKK3ZhciBiID0gT2JqZWN0LmNyZWF0ZShhKTsKKwordmFyIGV4Y2VwdGlvbjsKK3Ry eSB7CisgICAgZm9yICh2YXIgdiBpbiBiKSB7IH0KK30gY2F0Y2ggKGUpIHsKKyAgICBleGNlcHRp b24gPSBlOworfQorCitpZiAoZXhjZXB0aW9uICE9ICJleHBlY3RlZCBleGNlcHRpb24iKQorICAg IHRocm93ICJGQUlMIjsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMx OTgwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE4LTA1LTE4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgbWlzc2luZyBleGNlcHRpb24gY2hlY2suCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU3ODYKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzM1Njg2NTYwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcnVudGltZS9KU1Byb3BlcnR5TmFtZUVudW1lcmF0b3IuaDoKKyAgICAg ICAgKEpTQzo6cHJvcGVydHlOYW1lRW51bWVyYXRvcik6CisKIDIwMTgtMDUtMTggIFl1c3VrZSBT dXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgZml4 IGV4Y2VwdGlvbiBjaGVja2luZywgcGFydCAyCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU1Byb3BlcnR5TmFtZUVudW1lcmF0b3IuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1Byb3BlcnR5TmFtZUVudW1lcmF0b3IuaAkocmV2aXNp b24gMjMxOTgwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNQcm9wZXJ0eU5h bWVFbnVtZXJhdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyMiwxNCArMTIyLDEzIEBAIGlubGlu ZSBKU1Byb3BlcnR5TmFtZUVudW1lcmF0b3IqIHByb3BlcnQKICAgICAgICAgbnVtYmVyU3RydWN0 dXJlUHJvcGVydGllcyA9IHByb3BlcnR5TmFtZXMuc2l6ZSgpOwogCiAgICAgICAgIGJhc2UtPm1l dGhvZFRhYmxlKHZtKS0+Z2V0R2VuZXJpY1Byb3BlcnR5TmFtZXMoYmFzZSwgZXhlYywgcHJvcGVy dHlOYW1lcywgRW51bWVyYXRpb25Nb2RlKCkpOwotICAgICAgICBzY29wZS5hc3NlcnROb0V4Y2Vw dGlvbigpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIC8vIEdlbmVyaWMgcHJvcGVydHkgbmFtZXMg dmVjdG9yIGNvbnRhaW5zIGFsbCBpbmRleGVkIHByb3BlcnR5IG5hbWVzLgogICAgICAgICAvLyBT byBkaXNhYmxlIGluZGV4ZWQgcHJvcGVydHkgZW51bWVyYXRpb24gcGhhc2UgYnkgc2V0dGluZyB8 aW5kZXhlZExlbmd0aHwgdG8gMC4KICAgICAgICAgaW5kZXhlZExlbmd0aCA9IDA7CiAgICAgICAg IGJhc2UtPm1ldGhvZFRhYmxlKHZtKS0+Z2V0UHJvcGVydHlOYW1lcyhiYXNlLCBleGVjLCBwcm9w ZXJ0eU5hbWVzLCBFbnVtZXJhdGlvbk1vZGUoKSk7Ci0gICAgICAgIFJFVFVSTl9JRl9FWENFUFRJ T04oc2NvcGUsIG51bGxwdHIpOwogICAgIH0KKyAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3Bl LCBudWxscHRyKTsKIAogICAgIEFTU0VSVChwcm9wZXJ0eU5hbWVzLnNpemUoKSA8IFVJTlQzMl9N QVgpOwogCg==