185777 2018-05-18 11:55:19 -0700 Click events only fire once when editing 2018-05-21 17:19:35 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build iPhone / iPad iOS 11 RESOLVED FIXED InRadar P2 Normal --- 1 pxlcoder webkit-unassigned bdakin commit-queue megan_gardner pxlcoder thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1425221 0 pxlcoder 2018-05-18 11:55:19 -0700 Click events are only firing once on editable regions of text - this includes elements that specify contenteditable, as well as <input> elements. 1425223 1 pxlcoder 2018-05-18 11:56:05 -0700 <rdar://problem/9724138> 1425240 2 340726 pxlcoder 2018-05-18 12:24:36 -0700 Created attachment 340726 Patch 1425266 3 340726 wenson_hsieh 2018-05-18 13:17:46 -0700 Comment on attachment 340726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340726&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:714 > + if (node->document().focusedElement() == node) We probably only want to bail here if we're also editing... Otherwise, this means that if an element that's not in editable content already has focus, we will no longer flash the tap highlight over that node. For instance, if you have a <button id='button'> and call button.focus(), we should still see the tap highlight over the button if you tap on it. Perhaps we could check if m_assistedNode == node instead? 1425272 4 340726 wenson_hsieh 2018-05-18 13:36:43 -0700 Comment on attachment 340726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340726&action=review >> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:714 >> + if (node->document().focusedElement() == node) > > We probably only want to bail here if we're also editing... > > Otherwise, this means that if an element that's not in editable content already has focus, we will no longer flash the tap highlight over that node. > For instance, if you have a <button id='button'> and call button.focus(), we should still see the tap highlight over the button if you tap on it. Perhaps we could check if m_assistedNode == node instead? Actually, checking against m_assistedNode is probably still won't work in the case of editable elements that have been programmatically focused (select, input, textarea, etc.) prior to the tap... We really only want to suppress the tap highlight if we've tapped inside a node that is assisted in the UI process (i.e. the keyboard is up and the selection assistant is active). 1425274 5 pxlcoder 2018-05-18 13:39:02 -0700 We also have m_isAssistingNodeDueToUserInteraction in the WebProcess. I'm going to see if I can use that. 1425292 6 340738 pxlcoder 2018-05-18 14:37:00 -0700 Created attachment 340738 Patch 1425294 7 pxlcoder 2018-05-18 14:41:05 -0700 Wenson pointed out that we can't use m_isAssistingNodeDueToUserInteraction in order to bail out of highlighting, due to a corner case. Clients that implement _webView:focusShouldStartInputSession: can programmatically focus editable elements and show the keyboard. This would result in m_isAssistingNodeDueToUserInteraction remaining false, and a tap highlight showing if a user were to tap on the element while editing. For this reason, I have moved the tap highlight check to the UIProcess. 1425949 8 340738 thorton 2018-05-21 16:48:28 -0700 Comment on attachment 340738 Patch Megan and I looked at this together. 1425964 9 340738 commit-queue 2018-05-21 17:19:34 -0700 Comment on attachment 340738 Patch Clearing flags on attachment: 340738 Committed r232040: <https://trac.webkit.org/changeset/232040> 1425965 10 commit-queue 2018-05-21 17:19:35 -0700 All reviewed patches have been landed. Closing bug. 340726 2018-05-18 12:24:36 -0700 2018-05-18 14:36:58 -0700 Patch bug-185777-20180518122435.patch text/plain 5896 pxlcoder U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRmZjYxZWI3NDAzMGM3N2M4 NDkwNjA4ZDIzNDE3OTYyN2RlMzQxZmQuLjQzZTU2ZGNkOWZmYTY1ZDg5YWJmOWYyZTIzOTFkOWY0 ODMzMTQwNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMDUtMTggIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIENsaWNrIGV2ZW50 cyBvbmx5IGZpcmUgb25jZSB3aGVuIGVkaXRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTc3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGdlc3R1cmVSZWNvZ25pemVyU2hvdWxkQmVnaW46IHdhcyBy ZXR1cm5pbmcgZmFsc2UgZm9yIHRoZSBzaW5nbGUgdGFwIGdlc3R1cmUgd2hlbiBhIG5vZGUgd2Fz IGJlaW5nCisgICAgICAgIGVkaXRlZC4gVGhpcyBpcyBhbiBhcnRpZmFjdCBvZiBob3cgdGhlIGdl c3R1cmUgd2FzIHByZXZpb3VzbHkgaGFuZGxlZCB3aXRoIHRoZSB0ZXh0IHNlbGVjdGlvbiBhc3Np c3RhbnQuCisgICAgICAgIFRoaXMgY29uZGl0aW9uIGlzIG5vdyByZW1vdmVkLCBhbGxvd2luZyB0 aGUgc2luZ2xlIHRhcCBnZXN0dXJlIHRvIGdvIHRocm91Z2ggYW5kIGNvcnJlY3RseSBwcm9wYWdh dGUgdGhlCisgICAgICAgIGNsaWNrIGV2ZW50LgorCisgICAgICAgIEFsc28gYWRkZWQgbG9naWMg dG8gc2VuZFRhcEhpZ2hsaWdodEZvck5vZGVJZk5lY2Vzc2FyeSB0byBwcmV2ZW50IHRoZSB0YXAg aGlnaGxpZ2h0IGZyb20gc2hvd2luZyB1cCB3aGVuCisgICAgICAgIHRoZSBub2RlIGFscmVhZHkg aGFzIGZvY3VzLiBXaXRob3V0IHRoaXMsIHRoZSB0YXAgaGlnaGxpZ2h0IGNvdWxkIGJlIHNob3du IHdoaWxlIGVkaXRpbmcuICAKKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGdlc3R1cmVSZWNvZ25p emVyU2hvdWxkQmVnaW46XSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQ YWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpzZW5kVGFwSGlnaGxpZ2h0Rm9y Tm9kZUlmTmVjZXNzYXJ5KToKKwogMjAxOC0wNS0wNCAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0 ZWFkQHNvbnkuY29tPgogCiAgICAgICAgIFtXaW5dW1dlYktpdF0gRml4IGZvcndhcmRpbmcgaGVh ZGVycyBmb3IgV2luZG93cyBidWlsZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5kZXggYzZiZjBhOTcyOTZmNmIx YzEzM2NiNmU5ZmY1NTc5MzA1ZGU2ZTNkOC4uM2YzOTNlN2U5M2QwYWUzNTQ1MTQ5MDA3ZWUzODRh OGQ1ZDUwYzIyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0xNTQ3LDggKzE1NDcsNyBAQCBzdGF0aWMg aW5saW5lIGJvb2wgaXNTYW1lUGFpcihVSUdlc3R1cmVSZWNvZ25pemVyICphLCBVSUdlc3R1cmVS ZWNvZ25pemVyICpiLCBVSQogICAgIGlmIChnZXN0dXJlUmVjb2duaXplciA9PSBfaGlnaGxpZ2h0 TG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIKICAgICAgICAgfHwgZ2VzdHVyZVJlY29nbml6ZXIg PT0gX2RvdWJsZVRhcEdlc3R1cmVSZWNvZ25pemVyCiAgICAgICAgIHx8IGdlc3R1cmVSZWNvZ25p emVyID09IF9ub25CbG9ja2luZ0RvdWJsZVRhcEdlc3R1cmVSZWNvZ25pemVyCi0gICAgICAgIHx8 IGdlc3R1cmVSZWNvZ25pemVyID09IF90d29GaW5nZXJEb3VibGVUYXBHZXN0dXJlUmVjb2duaXpl cgotICAgICAgICB8fCBnZXN0dXJlUmVjb2duaXplciA9PSBfc2luZ2xlVGFwR2VzdHVyZVJlY29n bml6ZXIpIHsKKyAgICAgICAgfHwgZ2VzdHVyZVJlY29nbml6ZXIgPT0gX3R3b0ZpbmdlckRvdWJs ZVRhcEdlc3R1cmVSZWNvZ25pemVyKSB7CiAKICAgICAgICAgaWYgKGhhc0Fzc2lzdGVkTm9kZShf YXNzaXN0ZWROb2RlSW5mb3JtYXRpb24pKSB7CiAgICAgICAgICAgICAvLyBSZXF1ZXN0IGluZm9y bWF0aW9uIGFib3V0IHRoZSBwb3NpdGlvbiB3aXRoIHN5bmMgbWVzc2FnZS4KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KaW5kZXggZmY3 NzBkNjY3ODUwYWQwYzQ0Mjk0Yzc0NWFhNzNjMmNhNGZiMzdmMy4uZmYzNWQ0MWVkM2Y0Zjk4MmQ5 ZDY5MjBiNzVhZTZjZjFlYTFhNDBiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KQEAgLTcxMSw2ICs3MTEsOSBAQCB2b2lkIFdl YlBhZ2U6OnNlbmRUYXBIaWdobGlnaHRGb3JOb2RlSWZOZWNlc3NhcnkodWludDY0X3QgcmVxdWVz dElELCBOb2RlKiBub2RlKQogICAgIGlmICghbm9kZSkKICAgICAgICAgcmV0dXJuOwogCisgICAg aWYgKG5vZGUtPmRvY3VtZW50KCkuZm9jdXNlZEVsZW1lbnQoKSA9PSBub2RlKQorICAgICAgICBy ZXR1cm47CisKICAgICBpZiAobV9wYWdlLT5pc0VkaXRhYmxlKCkgJiYgbm9kZSA9PSBtX3BhZ2Ut Pm1haW5GcmFtZSgpLmRvY3VtZW50KCktPmJvZHkoKSkKICAgICAgICAgcmV0dXJuOwogCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggMGNiNjBhN2QwYmI1YTAyY2I1ZGRiNDhmMzA5ZmU1ODY1NmM4NzgwMy4uYmUzZTA3NTY0ZGRk MTBjMGI0ZGIwNDBhZjgzMGNkNjE1MTk1MTU3MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE4 LTA1LTE4ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGRlZCB0ZXN0IHRvIHZlcmlmeSBiZWhhdmlvdXIgd2hlbiB0YXBwaW5nIG11bHRpcGxlIHRpbWVz IG9uIGFuIGVkaXRhYmxlIG5vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODU3NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL2lvcy9jbGljay1ldmVudC13aGlsZS1lZGl0aW5n LW5vZGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2V2ZW50cy9pb3MvY2xp Y2stZXZlbnQtd2hpbGUtZWRpdGluZy1ub2RlLmh0bWw6IEFkZGVkLgorCiAyMDE4LTA1LTA0ICBS eWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIE1hcmsgYW5pbWF0 aW9ucy9kdXBsaWNhdGUta2V5cy5odG1sIGFzIGZsYWt5IG9uIGlPUy4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9jbGljay1ldmVudC13aGlsZS1lZGl0aW5nLW5vZGUt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL2NsaWNrLWV2ZW50LXdo aWxlLWVkaXRpbmctbm9kZS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTVlODZhYjdjOTAyOGQ4 ZDg3YzE3YjA1MGFmMjk2MjgzMzJkOWU4NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvZXZlbnRzL2lvcy9jbGljay1ldmVudC13aGlsZS1lZGl0aW5nLW5vZGUtZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEsOSBAQAorUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY2xpY2tz JykudGV4dENvbnRlbnQgaXMgIjIiCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisK K1RFU1QgQ09NUExFVEUKK1RoZSBjbGljayBldmVudCBzaG91bGQgYmUgZmlyZWQgb24gYSBub2Rl IHRoYXQgaXMgYmVpbmcgZWRpdGVkLgorCitUaGUgY2xpY2sgY291bnQgaW4gdGhlIGVkaXRhYmxl IG5vZGUgaXM6IDIKKworQ2xpY2sgbWUhCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy9pb3MvY2xpY2stZXZlbnQtd2hpbGUtZWRpdGluZy1ub2RlLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9pb3MvY2xpY2stZXZlbnQtd2hpbGUtZWRpdGluZy1ub2RlLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNGRlMDlkYzEzMDY1N2VjYTQyYjRhYmQ2MzI3MmI0MmNhOTJhZjhiMgotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9jbGljay1ldmVudC13aGls ZS1lZGl0aW5nLW5vZGUuaHRtbApAQCAtMCwwICsxLDM2IEBACis8IURPQ1RZUEUgaHRtbD4KKzxo dG1sPgorPGhlYWQ+CisgICAgPG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9IndpZHRoPWRl dmljZS13aWR0aCwgaW5pdGlhbC1zY2FsZT0xIj4KKyAgICA8c2NyaXB0IHNyYz0iLi4vLi4vLi4v cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iLi4v Li4vLi4vcmVzb3VyY2VzL3VpLWhlbHBlci5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4K KyAgICA8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+CisgICAgICAgIDxwPlRoZSBjbGljayBldmVudCBz aG91bGQgYmUgZmlyZWQgb24gYSBub2RlIHRoYXQgaXMgYmVpbmcgZWRpdGVkLjwvcD4KKyAgICAg ICAgPHA+VGhlIGNsaWNrIGNvdW50IGluIHRoZSBlZGl0YWJsZSBub2RlIGlzOiA8c3BhbiBpZD0i Y2xpY2tzIj4wPC9zcGFuPjwvcD4KKyAgICA8L2Rpdj4KKyAgICA8ZGl2IGlkPSJlZGl0YWJsZSIg Y29udGVudGVkaXRhYmxlPSJ0cnVlIiBzdHlsZT0id2lkdGg6IDEwMCU7IGhlaWdodDogNTAwcHg7 IGJvcmRlcjoxcHggc29saWQgYmxhY2s7Ij4KKyAgICAgICAgPHA+Q2xpY2sgbWUhPC9wPgorICAg IDwvZGl2PgorPC9ib2R5PgorPHNjcmlwdD4KK2NsaWNrQ291bnQgPSAwOworZWRpdGFibGUuYWRk RXZlbnRMaXN0ZW5lcigiY2xpY2siLCBmdW5jdGlvbigpeworICAgICBjbGlja0NvdW50ICs9IDE7 CisgICAgIGNsaWNrcy50ZXh0Q29udGVudCA9IGNsaWNrQ291bnQ7Cit9KTsKKworaWYgKHdpbmRv dy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAganNUZXN0 SXNBc3luYyA9IHRydWU7CisgICAgVUlIZWxwZXIuYWN0aXZhdGVBbmRXYWl0Rm9ySW5wdXRTZXNz aW9uQXQoNTAsIDMwMCkudGhlbigoKSA9PiB7CisgICAgICAgIFVJSGVscGVyLnRhcEF0KDUwLCAz MDApLnRoZW4oKCkgPT4geworICAgICAgICAgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgnY2xpY2tzJykudGV4dENvbnRlbnQiLCBgJHtjbGlja0NvdW50 fWApOworICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7CisgICAgICAgIH0pOworICAgIH0pOwor fQorPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9z dC5qcyI+PC9zY3JpcHQ+Cis8L2h0bWw+Cg== 340738 2018-05-18 14:37:00 -0700 2018-05-21 17:19:34 -0700 Patch bug-185777-20180518143659.patch text/plain 5673 pxlcoder U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRmZjYxZWI3NDAzMGM3N2M4 NDkwNjA4ZDIzNDE3OTYyN2RlMzQxZmQuLjZkODk3M2EwMWEzNjk4YWQzZTE2ZmYwYTYzYThmMzRm NWZiYzFjYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDUtMTggIEFkaXR5YSBL ZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIENsaWNrIGV2ZW50 cyBvbmx5IGZpcmUgb25jZSB3aGVuIGVkaXRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTc3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGdlc3R1cmVSZWNvZ25pemVyU2hvdWxkQmVnaW46IHdhcyBy ZXR1cm5pbmcgZmFsc2UgZm9yIHRoZSBzaW5nbGUgdGFwIGdlc3R1cmUgd2hlbiBhIG5vZGUgd2Fz IGJlaW5nCisgICAgICAgIGVkaXRlZC4gVGhpcyBpcyBhbiBhcnRpZmFjdCBvZiBob3cgdGhlIGdl c3R1cmUgd2FzIHByZXZpb3VzbHkgaGFuZGxlZCB3aXRoIHRoZSB0ZXh0IHNlbGVjdGlvbiBhc3Np c3RhbnQuCisgICAgICAgIFRoaXMgY29uZGl0aW9uIGlzIG5vdyByZW1vdmVkLCBhbGxvd2luZyB0 aGUgc2luZ2xlIHRhcCBnZXN0dXJlIHRvIGdvIHRocm91Z2ggYW5kIGNvcnJlY3RseSBwcm9wYWdh dGUgdGhlCisgICAgICAgIGNsaWNrIGV2ZW50LgorCisgICAgICAgIEFsc28gYWRkZWQgYW4gZWFy bHkgcmV0dXJuIHRvIF9kaWRHZXRUYXBIaWdobGlnaHRGb3JSZXF1ZXN0OiBpbiBvcmRlciB0byBw cmV2ZW50IHRoZSB0YXAgaGlnaGxpZ2h0IGZyb20KKyAgICAgICAgYmVpbmcgc2hvd24gd2hlbiB0 aGUgbm9kZSBpcyBhbHJlYWR5IGJlaW5nIGFzc2lzdGVkLgorCisgICAgICAgICogVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZp ZXcgX2RpZEdldFRhcEhpZ2hsaWdodEZvclJlcXVlc3Q6Y29sb3I6cXVhZHM6dG9wTGVmdFJhZGl1 czp0b3BSaWdodFJhZGl1czpib3R0b21MZWZ0UmFkaXVzOmJvdHRvbVJpZ2h0UmFkaXVzOl0pOgor ICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGdlc3R1cmVSZWNvZ25pemVyU2hvdWxkQmVnaW46XSk6 CisKIDIwMTgtMDUtMDQgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KIAog ICAgICAgICBbV2luXVtXZWJLaXRdIEZpeCBmb3J3YXJkaW5nIGhlYWRlcnMgZm9yIFdpbmRvd3Mg YnVpbGQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50 Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGM2YmYwYTk3Mjk2ZjZiMWMxMzNjYjZlOWZmNTU3OTMw NWRlNmUzZDguLmFiNzMwYWU2YmFkY2QzZjc4NDE1ZGYwYWU5ZjllMzgwOWM0ZmU4YTAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp b24ubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbQpAQCAtMTE3Niw2ICsxMTc2LDkgQEAgc3RhdGljIE5TVmFsdWUgKm5zU2l6ZUZv clRhcEhpZ2hsaWdodEJvcmRlclJhZGl1cyhXZWJDb3JlOjpJbnRTaXplIGJvcmRlclJhZGl1cywK ICAgICBpZiAoIV9pc1RhcEhpZ2hsaWdodElEVmFsaWQgfHwgX2xhdGVzdFRhcElEICE9IHJlcXVl c3RJRCkKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYgKF9wb3RlbnRpYWxUYXBJblByb2dyZXNz ICYmIGhhc0Fzc2lzdGVkTm9kZShfYXNzaXN0ZWROb2RlSW5mb3JtYXRpb24pICYmIF9wb3NpdGlv bkluZm9ybWF0aW9uLm5vZGVBdFBvc2l0aW9uSXNBc3Npc3RlZE5vZGUpCisgICAgICAgIHJldHVy bjsKKwogICAgIF9pc1RhcEhpZ2hsaWdodElEVmFsaWQgPSBOTzsKIAogICAgIF90YXBIaWdobGln aHRJbmZvcm1hdGlvbi5xdWFkcyA9IGhpZ2hsaWdodGVkUXVhZHM7CkBAIC0xNTQ3LDggKzE1NTAs NyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaXNTYW1lUGFpcihVSUdlc3R1cmVSZWNvZ25pemVyICph LCBVSUdlc3R1cmVSZWNvZ25pemVyICpiLCBVSQogICAgIGlmIChnZXN0dXJlUmVjb2duaXplciA9 PSBfaGlnaGxpZ2h0TG9uZ1ByZXNzR2VzdHVyZVJlY29nbml6ZXIKICAgICAgICAgfHwgZ2VzdHVy ZVJlY29nbml6ZXIgPT0gX2RvdWJsZVRhcEdlc3R1cmVSZWNvZ25pemVyCiAgICAgICAgIHx8IGdl c3R1cmVSZWNvZ25pemVyID09IF9ub25CbG9ja2luZ0RvdWJsZVRhcEdlc3R1cmVSZWNvZ25pemVy Ci0gICAgICAgIHx8IGdlc3R1cmVSZWNvZ25pemVyID09IF90d29GaW5nZXJEb3VibGVUYXBHZXN0 dXJlUmVjb2duaXplcgotICAgICAgICB8fCBnZXN0dXJlUmVjb2duaXplciA9PSBfc2luZ2xlVGFw R2VzdHVyZVJlY29nbml6ZXIpIHsKKyAgICAgICAgfHwgZ2VzdHVyZVJlY29nbml6ZXIgPT0gX3R3 b0ZpbmdlckRvdWJsZVRhcEdlc3R1cmVSZWNvZ25pemVyKSB7CiAKICAgICAgICAgaWYgKGhhc0Fz c2lzdGVkTm9kZShfYXNzaXN0ZWROb2RlSW5mb3JtYXRpb24pKSB7CiAgICAgICAgICAgICAvLyBS ZXF1ZXN0IGluZm9ybWF0aW9uIGFib3V0IHRoZSBwb3NpdGlvbiB3aXRoIHN5bmMgbWVzc2FnZS4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwY2I2MGE3ZDBiYjVhMDJjYjVkZGI0OGYzMDlmZTU4NjU2Yzg3ODAzLi5iZTNlMDc1 NjRkZGQxMGMwYjRkYjA0MGFmODMwY2Q2MTUxOTUxNTcxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTgtMDUtMTggIEFkaXR5YSBLZWVydGhpICA8YWtlZXJ0aGlAYXBwbGUuY29tPgorCisgICAg ICAgIEFkZGVkIHRlc3QgdG8gdmVyaWZ5IGJlaGF2aW91ciB3aGVuIHRhcHBpbmcgbXVsdGlwbGUg dGltZXMgb24gYW4gZWRpdGFibGUgbm9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4NTc3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZmFzdC9ldmVudHMvaW9zL2NsaWNrLWV2ZW50LXdoaWxlLWVk aXRpbmctbm9kZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZXZlbnRzL2lv cy9jbGljay1ldmVudC13aGlsZS1lZGl0aW5nLW5vZGUuaHRtbDogQWRkZWQuCisKIDIwMTgtMDUt MDQgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgTWFyayBh bmltYXRpb25zL2R1cGxpY2F0ZS1rZXlzLmh0bWwgYXMgZmxha3kgb24gaU9TLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL2NsaWNrLWV2ZW50LXdoaWxlLWVkaXRpbmct bm9kZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9pb3MvY2xpY2stZXZl bnQtd2hpbGUtZWRpdGluZy1ub2RlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xNWU4NmFiN2M5 MDI4ZDhkODdjMTdiMDUwYWYyOTYyODMzMmQ5ZTg1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvaW9zL2NsaWNrLWV2ZW50LXdoaWxlLWVkaXRpbmctbm9kZS1leHBl Y3RlZC50eHQKQEAgLTAsMCArMSw5IEBACitQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdj bGlja3MnKS50ZXh0Q29udGVudCBpcyAiMiIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKKworVEVTVCBDT01QTEVURQorVGhlIGNsaWNrIGV2ZW50IHNob3VsZCBiZSBmaXJlZCBvbiBh IG5vZGUgdGhhdCBpcyBiZWluZyBlZGl0ZWQuCisKK1RoZSBjbGljayBjb3VudCBpbiB0aGUgZWRp dGFibGUgbm9kZSBpczogMgorCitDbGljayBtZSEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvZXZlbnRzL2lvcy9jbGljay1ldmVudC13aGlsZS1lZGl0aW5nLW5vZGUuaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9jbGljay1ldmVudC13aGlsZS1lZGl0aW5nLW5vZGUuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi40ZGUwOWRjMTMwNjU3ZWNhNDJiNGFiZDYzMjcyYjQyY2E5MmFmOGIyCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL2NsaWNrLWV2ZW50 LXdoaWxlLWVkaXRpbmctbm9kZS5odG1sCkBAIC0wLDAgKzEsMzYgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8aGVhZD4KKyAgICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lk dGg9ZGV2aWNlLXdpZHRoLCBpbml0aWFsLXNjYWxlPTEiPgorICAgIDxzY3JpcHQgc3JjPSIuLi8u Li8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3Jj PSIuLi8uLi8uLi9yZXNvdXJjZXMvdWktaGVscGVyLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxi b2R5PgorICAgIDxkaXYgaWQ9ImRlc2NyaXB0aW9uIj4KKyAgICAgICAgPHA+VGhlIGNsaWNrIGV2 ZW50IHNob3VsZCBiZSBmaXJlZCBvbiBhIG5vZGUgdGhhdCBpcyBiZWluZyBlZGl0ZWQuPC9wPgor ICAgICAgICA8cD5UaGUgY2xpY2sgY291bnQgaW4gdGhlIGVkaXRhYmxlIG5vZGUgaXM6IDxzcGFu IGlkPSJjbGlja3MiPjA8L3NwYW4+PC9wPgorICAgIDwvZGl2PgorICAgIDxkaXYgaWQ9ImVkaXRh YmxlIiBjb250ZW50ZWRpdGFibGU9InRydWUiIHN0eWxlPSJ3aWR0aDogMTAwJTsgaGVpZ2h0OiA1 MDBweDsgYm9yZGVyOjFweCBzb2xpZCBibGFjazsiPgorICAgICAgICA8cD5DbGljayBtZSE8L3A+ CisgICAgPC9kaXY+Cis8L2JvZHk+Cis8c2NyaXB0PgorY2xpY2tDb3VudCA9IDA7CitlZGl0YWJs ZS5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIGZ1bmN0aW9uKCl7CisgICAgIGNsaWNrQ291bnQg Kz0gMTsKKyAgICAgY2xpY2tzLnRleHRDb250ZW50ID0gY2xpY2tDb3VudDsKK30pOworCitpZiAo d2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKyAgICBq c1Rlc3RJc0FzeW5jID0gdHJ1ZTsKKyAgICBVSUhlbHBlci5hY3RpdmF0ZUFuZFdhaXRGb3JJbnB1 dFNlc3Npb25BdCg1MCwgMzAwKS50aGVuKCgpID0+IHsKKyAgICAgICAgVUlIZWxwZXIudGFwQXQo NTAsIDMwMCkudGhlbigoKSA9PiB7CisgICAgICAgICAgICBzaG91bGRCZUVxdWFsVG9TdHJpbmco ImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdjbGlja3MnKS50ZXh0Q29udGVudCIsIGAke2NsaWNr Q291bnR9YCk7CisgICAgICAgICAgICBmaW5pc2hKU1Rlc3QoKTsKKyAgICAgICAgfSk7CisgICAg fSk7Cit9Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi8uLi9yZXNvdXJjZXMvanMtdGVz dC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvaHRtbD4K