185767 2018-05-18 07:45:28 -0700 [LFC] Implement height computation for non-replaced floating elements. 2018-05-18 09:33:28 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1425110 0 zalan 2018-05-18 07:45:28 -0700 ssia 1425111 1 340695 zalan 2018-05-18 07:48:57 -0700 Created attachment 340695 Patch 1425133 2 340695 commit-queue 2018-05-18 09:32:19 -0700 Comment on attachment 340695 Patch Clearing flags on attachment: 340695 Committed r231958: <https://trac.webkit.org/changeset/231958> 1425134 3 commit-queue 2018-05-18 09:32:21 -0700 All reviewed patches have been landed. Closing bug. 1425135 4 webkit-bug-importer 2018-05-18 09:33:28 -0700 <rdar://problem/40367528> 340695 2018-05-18 07:48:57 -0700 2018-05-18 09:32:19 -0700 Patch bug-185767-20180518074856.patch text/plain 5058 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxOTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE0MzZjZTY0ZjNjMjc4 NTBjYTBlNWFkNThkYjM0YzRkZDYyMzQ0Ni4uZGVkOWU0MGMwNTBiYTdhZmU1NzllNzhiNTNiNjQ3 ZWQxOGExM2FkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA1LTE4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gSW1wbGVtZW50IGhl aWdodCBjb21wdXRhdGlvbiBmb3Igbm9uLXJlcGxhY2VkIGZsb2F0aW5nIGVsZW1lbnRzLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NzY3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsYXlvdXQvRm9y bWF0dGluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpGb3JtYXR0aW5n Q29udGV4dDo6Y29tcHV0ZUZsb2F0aW5nSGVpZ2h0IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6 OkxheW91dDo6Rm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVGbG9hdGluZ05vblJlcGxhY2VkSGVp Z2h0IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6Rm9ybWF0dGluZ0NvbnRleHQ6 OmNvbnRlbnRIZWlnaHRGb3JGb3JtYXR0aW5nQ29udGV4dFJvb3QgY29uc3QpOgorICAgICAgICAq IGxheW91dC9Gb3JtYXR0aW5nQ29udGV4dC5oOgorCiAyMDE4LTA1LTE4ICBaYWxhbiBCdWp0YXMg IDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ10gSW1wbGVtZW50IGhlaWdodCBjb21w dXRhdGlvbiBmb3IgcmVwbGFjZWQgZWxlbWVudHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvRm9ybWF0dGluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zv cm1hdHRpbmdDb250ZXh0LmNwcAppbmRleCBmNzNlNWRjZDUwYmYyZjc2MjljZmJmNjM3ZmIxNWUx MTgyM2I2ZWVjLi5iMTk3ZWE1NjMxOGU0YWU0NTBiYmI0MDNjNDI2MjAwNTRhZDVjYjRiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRm9ybWF0dGluZ0NvbnRleHQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4dC5jcHAKQEAgLTEwOCw3ICsx MDgsNyBAQCB2b2lkIEZvcm1hdHRpbmdDb250ZXh0Ojpjb21wdXRlT3V0T2ZGbG93SGVpZ2h0KExh eW91dENvbnRleHQmIGxheW91dENvbnRleHQsIGNvbgogdm9pZCBGb3JtYXR0aW5nQ29udGV4dDo6 Y29tcHV0ZUZsb2F0aW5nSGVpZ2h0KExheW91dENvbnRleHQmIGxheW91dENvbnRleHQsIGNvbnN0 IEJveCYgbGF5b3V0Qm94LCBEaXNwbGF5OjpCb3gmIGRpc3BsYXlCb3gpIGNvbnN0CiB7CiAgICAg aWYgKCFsYXlvdXRCb3gucmVwbGFjZWQoKSkgewotICAgICAgICBBU1NFUlRfTk9UX0lNUExFTUVO VEVEX1lFVCgpOworICAgICAgICBjb21wdXRlRmxvYXRpbmdOb25SZXBsYWNlZEhlaWdodChsYXlv dXRDb250ZXh0LCBsYXlvdXRCb3gsIGRpc3BsYXlCb3gpOwogICAgICAgICByZXR1cm47CiAgICAg fQogICAgIGNvbXB1dGVSZXBsYWNlZEhlaWdodChsYXlvdXRDb250ZXh0LCBsYXlvdXRCb3gsIGRp c3BsYXlCb3gpOwpAQCAtMjE3LDYgKzIxNywxOCBAQCB2b2lkIEZvcm1hdHRpbmdDb250ZXh0Ojpj b21wdXRlT3V0T2ZGbG93Tm9uUmVwbGFjZWRIZWlnaHQoTGF5b3V0Q29udGV4dCYgbGF5b3V0Qwog ICAgIGRpc3BsYXlCb3guc2V0SGVpZ2h0KGNvbXB1dGVkSGVpZ2h0VmFsdWUpOwogfQogCit2b2lk IEZvcm1hdHRpbmdDb250ZXh0Ojpjb21wdXRlRmxvYXRpbmdOb25SZXBsYWNlZEhlaWdodChMYXlv dXRDb250ZXh0JiBsYXlvdXRDb250ZXh0LCBjb25zdCBCb3gmIGxheW91dEJveCwgRGlzcGxheTo6 Qm94JiBkaXNwbGF5Qm94KSBjb25zdAoreworICAgIEFTU0VSVChsYXlvdXRCb3guaXNGbG9hdGlu Z1Bvc2l0aW9uZWQoKSAmJiAhbGF5b3V0Qm94LnJlcGxhY2VkKCkpOworICAgIC8vIDEwLjYuNiBD b21wbGljYXRlZCBjYXNlcworICAgIC8vCisgICAgLy8gRmxvYXRpbmcsIG5vbi1yZXBsYWNlZCBl bGVtZW50cy4KKyAgICAvLworICAgIC8vIElmICdoZWlnaHQnIGlzICdhdXRvJywgdGhlIGhlaWdo dCBkZXBlbmRzIG9uIHRoZSBlbGVtZW50J3MgZGVzY2VuZGFudHMgcGVyIDEwLjYuNy4KKyAgICBh dXRvIGhlaWdodCA9IGxheW91dEJveC5zdHlsZSgpLmxvZ2ljYWxIZWlnaHQoKTsKKyAgICBkaXNw bGF5Qm94LnNldEhlaWdodChoZWlnaHQuaXNBdXRvKCkgPyBjb250ZW50SGVpZ2h0Rm9yRm9ybWF0 dGluZ0NvbnRleHRSb290KGxheW91dENvbnRleHQsIGxheW91dEJveCkgOiBMYXlvdXRVbml0KGhl aWdodC52YWx1ZSgpKSk7Cit9CisKIHZvaWQgRm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVSZXBs YWNlZEhlaWdodChMYXlvdXRDb250ZXh0JiwgY29uc3QgQm94JiBsYXlvdXRCb3gsIERpc3BsYXk6 OkJveCYgZGlzcGxheUJveCkgY29uc3QKIHsKICAgICBBU1NFUlQoKGxheW91dEJveC5pc091dE9m Rmxvd1Bvc2l0aW9uZWQoKSB8fCBsYXlvdXRCb3guaXNGbG9hdGluZ1Bvc2l0aW9uZWQoKSB8fCBs YXlvdXRCb3guaXNJbkZsb3coKSkgJiYgbGF5b3V0Qm94LnJlcGxhY2VkKCkpOwpAQCAtMzE3LDEy ICszMjksNyBAQCB2b2lkIEZvcm1hdHRpbmdDb250ZXh0Ojpjb21wdXRlUmVwbGFjZWRXaWR0aChM YXlvdXRDb250ZXh0JiwgY29uc3QgQm94JiBsYXlvdXRCbwogCiBMYXlvdXRVbml0IEZvcm1hdHRp bmdDb250ZXh0Ojpjb250ZW50SGVpZ2h0Rm9yRm9ybWF0dGluZ0NvbnRleHRSb290KExheW91dENv bnRleHQmIGxheW91dENvbnRleHQsIGNvbnN0IEJveCYgbGF5b3V0Qm94KSBjb25zdAogewotICAg IEFTU0VSVChsYXlvdXRCb3guc3R5bGUoKS5sb2dpY2FsSGVpZ2h0KCkuaXNBdXRvKCkpOwotCi0g ICAgaWYgKCFpczxDb250YWluZXI+KGxheW91dEJveCkgfHwgIWRvd25jYXN0PENvbnRhaW5lcj4o bGF5b3V0Qm94KS5oYXNJbkZsb3dPckZsb2F0aW5nQ2hpbGQoKSkKLSAgICAgICAgcmV0dXJuIDA7 Ci0KLSAgICBhdXRvJiBmb3JtYXR0aW5nUm9vdENvbnRhaW5lciA9IGRvd25jYXN0PENvbnRhaW5l cj4obGF5b3V0Qm94KTsKKyAgICBBU1NFUlQobGF5b3V0Qm94LnN0eWxlKCkubG9naWNhbEhlaWdo dCgpLmlzQXV0bygpICYmIGxheW91dEJveC5lc3RhYmxpc2hlc0Zvcm1hdHRpbmdDb250ZXh0KCkp OwogICAgIC8vIDEwLjYuNyAnQXV0bycgaGVpZ2h0cyBmb3IgYmxvY2sgZm9ybWF0dGluZyBjb250 ZXh0IHJvb3RzCiAKICAgICAvLyBJZiBpdCBvbmx5IGhhcyBpbmxpbmUtbGV2ZWwgY2hpbGRyZW4s IHRoZSBoZWlnaHQgaXMgdGhlIGRpc3RhbmNlIGJldHdlZW4gdGhlIHRvcCBvZiB0aGUgdG9wbW9z dCBsaW5lIGJveCBhbmQgdGhlIGJvdHRvbSBvZiB0aGUgYm90dG9tbW9zdCBsaW5lIGJveC4KQEAg LTMzMiw2ICszMzksMTAgQEAgTGF5b3V0VW5pdCBGb3JtYXR0aW5nQ29udGV4dDo6Y29udGVudEhl aWdodEZvckZvcm1hdHRpbmdDb250ZXh0Um9vdChMYXlvdXRDb250ZXgKICAgICAvLyBJbiBhZGRp dGlvbiwgaWYgdGhlIGVsZW1lbnQgaGFzIGFueSBmbG9hdGluZyBkZXNjZW5kYW50cyB3aG9zZSBi b3R0b20gbWFyZ2luIGVkZ2UgaXMgYmVsb3cgdGhlIGVsZW1lbnQncyBib3R0b20gY29udGVudCBl ZGdlLAogICAgIC8vIHRoZW4gdGhlIGhlaWdodCBpcyBpbmNyZWFzZWQgdG8gaW5jbHVkZSB0aG9z ZSBlZGdlcy4gT25seSBmbG9hdHMgdGhhdCBwYXJ0aWNpcGF0ZSBpbiB0aGlzIGJsb2NrIGZvcm1h dHRpbmcgY29udGV4dCBhcmUgdGFrZW4KICAgICAvLyBpbnRvIGFjY291bnQsIGUuZy4sIGZsb2F0 cyBpbnNpZGUgYWJzb2x1dGVseSBwb3NpdGlvbmVkIGRlc2NlbmRhbnRzIG9yIG90aGVyIGZsb2F0 cyBhcmUgbm90LgorICAgIGlmICghaXM8Q29udGFpbmVyPihsYXlvdXRCb3gpIHx8ICFkb3duY2Fz dDxDb250YWluZXI+KGxheW91dEJveCkuaGFzSW5GbG93T3JGbG9hdGluZ0NoaWxkKCkpCisgICAg ICAgIHJldHVybiAwOworCisgICAgYXV0byYgZm9ybWF0dGluZ1Jvb3RDb250YWluZXIgPSBkb3du Y2FzdDxDb250YWluZXI+KGxheW91dEJveCk7CiAgICAgaWYgKGZvcm1hdHRpbmdSb290Q29udGFp bmVyLmVzdGFibGlzaGVzSW5saW5lRm9ybWF0dGluZ0NvbnRleHQoKSkKICAgICAgICAgcmV0dXJu IDA7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4 dC5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zvcm1hdHRpbmdDb250ZXh0LmgKaW5kZXggYzlh N2NiZjlmOTRhN2M4MzE0MjgyMjdiMzIyMWZhZjQ0NmFhMGYzMS4uZWUwZWQ1NTRiNmI4NGYxMzhm YzkwNGM0N2ZkNjY5NTllYjcxMzdjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L0Zvcm1hdHRpbmdDb250ZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zvcm1hdHRp bmdDb250ZXh0LmgKQEAgLTk2LDYgKzk2LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIGNvbXB1dGVP dXRPZkZsb3dSZXBsYWNlZEhlaWdodChMYXlvdXRDb250ZXh0JiwgY29uc3QgQm94JiwgRGlzcGxh eTo6Qm94JikgY29uc3Q7CiAgICAgdm9pZCBjb21wdXRlT3V0T2ZGbG93UmVwbGFjZWRXaWR0aChM YXlvdXRDb250ZXh0JiwgY29uc3QgQm94JiwgRGlzcGxheTo6Qm94JikgY29uc3Q7CiAKKyAgICB2 b2lkIGNvbXB1dGVGbG9hdGluZ05vblJlcGxhY2VkSGVpZ2h0KExheW91dENvbnRleHQmLCBjb25z dCBCb3gmLCBEaXNwbGF5OjpCb3gmKSBjb25zdDsKICAgICB2b2lkIGNvbXB1dGVGbG9hdGluZ05v blJlcGxhY2VkV2lkdGgoTGF5b3V0Q29udGV4dCYsIGNvbnN0IEJveCYsIERpc3BsYXk6OkJveCYp IGNvbnN0OwogCiAgICAgTGF5b3V0VW5pdCBjb250ZW50SGVpZ2h0Rm9yRm9ybWF0dGluZ0NvbnRl eHRSb290KExheW91dENvbnRleHQmLCBjb25zdCBCb3gmKSBjb25zdDsK