18576 2008-04-18 03:37:50 -0700 [GTK] windowsKeyCodeForKeyEvent doesn't handle GDK_ISO_Enter and GDK_KP_Enter 2008-04-18 20:32:08 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 marco.barisione webkit-unassigned alp oldest_to_newest 78081 0 marco.barisione 2008-04-18 03:37:50 -0700 windowsKeyCodeForKeyEvent (in WebCore/platform/gtk/KeyEventGtk.cpp) handles GDK_Return but not GDK_ISO_Enter and GDK_KP_Enter. I will write a patch ASAP. 78086 1 20663 marco.barisione 2008-04-18 04:20:51 -0700 Created attachment 20663 Handle GDK_ISO_Enter and GDK_KP_Enter in windowsKeyCodeForKeyEvent 78213 2 alp 2008-04-18 20:32:08 -0700 Landed in r32245. patch had a little trouble with this one so I had to hand-apply. 20663 2008-04-18 04:20:51 -0700 2008-04-18 20:24:26 -0700 Handle GDK_ISO_Enter and GDK_KP_Enter in windowsKeyCodeForKeyEvent gtk-win-enter.patch text/plain 1003 marco.barisione LS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcAorKysgV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwCkBAIC0xODgsNiArMTg4LDggQEAgc3RhdGljIGludCB3 aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50KHVuc2lnbmVkIGludCBrZXljb2RlKQogICAgICAgICAg ICAgcmV0dXJuIFZLX1RBQjsgLy8gKDA5KSBUQUIga2V5CiAgICAgICAgIGNhc2UgR0RLX0NsZWFy OgogICAgICAgICAgICAgcmV0dXJuIFZLX0NMRUFSOyAvLyAoMEMpIENMRUFSIGtleQorICAgICAg ICBjYXNlIEdES19JU09fRW50ZXI6CisgICAgICAgIGNhc2UgR0RLX0tQX0VudGVyOgogICAgICAg ICBjYXNlIEdES19SZXR1cm46CiAgICAgICAgICAgICByZXR1cm4gVktfUkVUVVJOOyAvLygwRCkg UmV0dXJuIGtleQogICAgICAgICBjYXNlIEdES19TaGlmdF9MOgotLS0gV2ViQ29yZS9DaGFuZ2VM b2cKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDQtMTggIE1h cmNvIEJhcmlzaW9uZSAgPG1hcmNvQGJhcmlzaW9uZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4NTc2CisgICAgICAgIFtHVEtdIHdpbmRvd3NLZXlDb2RlRm9yS2V5RXZl bnQgZG9lc24ndCBoYW5kbGUgR0RLX0lTT19FbnRlciBhbmQKKyAgICAgICAgR0RLX0tQX0VudGVy CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvS2V5RXZlbnRHdGsuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6d2luZG93c0tleUNvZGVGb3JLZXlFdmVudCk6IGhhbmRsZSBHREtfSVNPX0VudGVyIGFu ZAorICAgICAgICBHREtfS1BfRW50ZXIgaW4gd2luZG93c0tleUNvZGVGb3JLZXlFdmVudC4KKwog MjAwOC0wNC0xOCAgU2ltb24gSGF1c21hbm4gIDxoYXVzbWFubkB3ZWJraXQub3JnPgogCiAgICAg ICAgIEJ1aWxkIGZpeCBmb3IgUXQgYW5kIGdjYyA0LjMuCg==