185753 2018-05-17 16:13:40 -0700 defaultConstructorSourceCode needs to makeSource every time it's called 2018-05-17 16:21:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam mark.lam webkit-bug-importer oldest_to_newest 1424981 0 saam 2018-05-17 16:13:40 -0700 Rubber stamped already by Mark Lam. The bug here is multiple VMs can be running concurrently to one another in the same process. They may each ref/deref something that isn't ThreadSafeRefCounted 1424984 1 340664 saam 2018-05-17 16:17:59 -0700 Created attachment 340664 patch for landing 1424986 2 saam 2018-05-17 16:20:45 -0700 landed in: https://trac.webkit.org/changeset/231930/webkit 1424987 3 webkit-bug-importer 2018-05-17 16:21:18 -0700 <rdar://problem/40349098> 340664 2018-05-17 16:17:59 -0700 2018-05-17 16:17:59 -0700 patch for landing a-backup.diff text/plain 2325 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMxOTI5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE4LTA1LTE3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IGRlZmF1bHRDb25zdHJ1Y3RvclNvdXJjZUNvZGUgbmVlZHMgdG8gbWFrZVNvdXJjZSBldmVyeSB0 aW1lIGl0cyBjYWxsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4NTc1MworCisgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IE1hcmsgTGFtLgorCisg ICAgICAgIFRoZSBidWcgaGVyZSBpcyBtdWx0aXBsZSBWTXMgY2FuIGJlIHJ1bm5pbmcgY29uY3Vy cmVudGx5IHRvIG9uZSBhbm90aGVyCisgICAgICAgIGluIHRoZSBzYW1lIHByb2Nlc3MuIFRoZXkg bWF5IGVhY2ggcmVmL2RlcmVmIHNvbWV0aGluZyB0aGF0IGlzbid0IFRocmVhZFNhZmVSZWZDb3Vu dGVkCisgICAgICAgIGlmIHdlIGNvcHkgYSBzdGF0aWMgU291cmNlQ29kZS4gaW5zdGVhZCwgd2Ug Y3JlYXRlIGEgbmV3IG9uZSBlYWNoIHRpbWUKKyAgICAgICAgdGhpcyBmdW5jdGlvbiBpcyBjYWxs ZWQuCisKKyAgICAgICAgKiBidWlsdGlucy9CdWlsdGluRXhlY3V0YWJsZXMuY3BwOgorICAgICAg ICAoSlNDOjpCdWlsdGluRXhlY3V0YWJsZXM6OmRlZmF1bHRDb25zdHJ1Y3RvclNvdXJjZUNvZGUp OgorCiAyMDE4LTA1LTE3ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgog CiAgICAgICAgIFtKU0NdIFVzZSBBc3NlbWJseUhlbHBlcnMnIHR5cGUgY2hlY2tpbmcgZnVuY3Rp b25zIGFzIG11Y2ggYXMgcG9zc2libGUKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9idWls dGlucy9CdWlsdGluRXhlY3V0YWJsZXMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9idWlsdGlucy9CdWlsdGluRXhlY3V0YWJsZXMuY3BwCShyZXZpc2lvbiAyMzE5Mjkp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvQnVpbHRpbkV4ZWN1dGFibGVzLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNDksMjEgKzQ5LDExIEBAIFNvdXJjZUNvZGUgQnVpbHRpbkV4 ZWN1dGFibGVzOjpkZWZhdWx0Q28KICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBDb25zdHJ1Y3Rv cktpbmQ6OkJhc2U6IHsKICAgICAgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPGNvbnN0IFN0cmlu Zz4gYmFzZUNvbnN0cnVjdG9yQ29kZShNQUtFX1NUQVRJQ19TVFJJTkdfSU1QTCgiKGZ1bmN0aW9u ICgpIHsgfSkiKSk7Ci0gICAgICAgIHN0YXRpYyBMYXp5TmV2ZXJEZXN0cm95ZWQ8U291cmNlQ29k ZT4gcmVzdWx0OwotICAgICAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgb25jZUZsYWc7Ci0gICAg ICAgIHN0ZDo6Y2FsbF9vbmNlKG9uY2VGbGFnLCBbJl0gewotICAgICAgICAgICAgcmVzdWx0LmNv bnN0cnVjdChtYWtlU291cmNlKGJhc2VDb25zdHJ1Y3RvckNvZGUsIHsgfSkpOwotICAgICAgICB9 KTsKLSAgICAgICAgcmV0dXJuIHJlc3VsdDsKKyAgICAgICAgcmV0dXJuIG1ha2VTb3VyY2UoYmFz ZUNvbnN0cnVjdG9yQ29kZSwgeyB9KTsKICAgICB9CiAgICAgY2FzZSBDb25zdHJ1Y3RvcktpbmQ6 OkV4dGVuZHM6IHsKICAgICAgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPGNvbnN0IFN0cmluZz4g ZGVyaXZlZENvbnN0cnVjdG9yQ29kZShNQUtFX1NUQVRJQ19TVFJJTkdfSU1QTCgiKGZ1bmN0aW9u ICguLi5hcmdzKSB7IHN1cGVyKC4uLmFyZ3MpOyB9KSIpKTsKLSAgICAgICAgc3RhdGljIExhenlO ZXZlckRlc3Ryb3llZDxTb3VyY2VDb2RlPiByZXN1bHQ7Ci0gICAgICAgIHN0YXRpYyBzdGQ6Om9u Y2VfZmxhZyBvbmNlRmxhZzsKLSAgICAgICAgc3RkOjpjYWxsX29uY2Uob25jZUZsYWcsIFsmXSB7 Ci0gICAgICAgICAgICByZXN1bHQuY29uc3RydWN0KG1ha2VTb3VyY2UoZGVyaXZlZENvbnN0cnVj dG9yQ29kZSwgeyB9KSk7Ci0gICAgICAgIH0pOwotICAgICAgICByZXR1cm4gcmVzdWx0OworICAg ICAgICByZXR1cm4gbWFrZVNvdXJjZShkZXJpdmVkQ29uc3RydWN0b3JDb2RlLCB7IH0pOwogICAg IH0KICAgICB9CiAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsK