185747 2018-05-17 14:50:52 -0700 Remove unnecessary exit fullscreen call on application resume 2018-05-23 09:27:27 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jeremyj-wk jeremyj-wk commit-queue eric.carlson fred.wang jer.noble webkit-bug-importer oldest_to_newest 1424933 0 jeremyj-wk 2018-05-17 14:50:52 -0700 Remove unnecessary exit fullscreen call on application resume 1424934 1 jeremyj-wk 2018-05-17 14:51:26 -0700 rdar://problem/40345725 1424940 2 340653 jeremyj-wk 2018-05-17 14:54:46 -0700 Created attachment 340653 Patch 1424942 3 340653 jer.noble 2018-05-17 15:01:14 -0700 Comment on attachment 340653 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340653&action=review > Source/WebCore/ChangeLog:11 > + Auto-PiP doesn't automatically returns to fullscreen on app resume, Nit: "doesn't returns" 1424944 4 340655 jeremyj-wk 2018-05-17 15:03:21 -0700 Created attachment 340655 Patch For Landing 1424979 5 340655 commit-queue 2018-05-17 16:03:55 -0700 Comment on attachment 340655 Patch For Landing Clearing flags on attachment: 340655 Committed r231929: <https://trac.webkit.org/changeset/231929> 340653 2018-05-17 14:54:46 -0700 2018-05-17 15:01:14 -0700 Patch bug-185747-20180517145446.patch text/plain 2533 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRhZDIwNzBhNGVhMzQ4 ZGM0MjAyNmYxOGI3NzdkODc1OTU3NTNkNi4uYmZlZjcxNzY3NjFjYzUxZGIxMGY2MGMwOTczNDM5 YTdjOTUwMDhkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA1LTE3ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3Nh cnkgZXhpdCBmdWxsc2NyZWVuIGNhbGwgb24gYXBwbGljYXRpb24gcmVzdW1lCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU3NDcKKyAgICAgICAgcmRh cjovL3Byb2JsZW0vNDAzNDU3MjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSBubyBiZWhhdmlvciBjaGFuZ2UuCisK KyAgICAgICAgQXV0by1QaVAgZG9lc24ndCBhdXRvbWF0aWNhbGx5IHJldHVybnMgdG8gZnVsbHNj cmVlbiBvbiBhcHAgcmVzdW1lLAorICAgICAgICBzbyB3ZSBkb24ndCBuZWVkIHRvIGtlZXAgdGhp cyB2ZXN0aWdpYWwgY29kZSBmb3IgaGFuZGxpbmcgYSBjb3JuZXIgY2FzZSBvZiB0aGF0IGZlYXR1 cmUuCisgICAgICAgIEFsc28sIHRoaXMgY2FuIGNhdXNlIGFuIHVubmVjZXNzYXJ5IGV4aXQgZnVs bHNjcmVlbiB0aGF0IGNvdWxkIGNhdXNlIGRlYnVnIGFzc2VydHMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW06CisgICAgICAgIChWaWRl b0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6YXBwbGljYXRpb25EaWRCZWNvbWVBY3RpdmUpOgor CiAyMDE4LTA0LTMwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4K IAogICAgICAgICBbR1RLXSBXZWJraXQgc2hvdWxkIHNwb29mIGFzIFNhZmFyaSBvbiBhIE1hYyB3 aGVuIG9uIENoYXNlLmNvbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9z L1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vaW9zL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCmluZGV4IGY0MTNmMTVkZmY0 NWYwNTg5NDUyMmEwYzczNzkxZjcwYTNmM2FiNmUuLmNjMDJiMGEwODVlNDQ4MTdkMTcyYjZjOGFk ZGNmZDE2MDFhMGNjOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9W aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KQEAgLTEyODIsMTUgKzEy ODIsNiBAQCBib29sIFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpzaG91bGRFeGl0RnVs bHNjcmVlbldpdGhSZWFzb24oVmlkZW9GdWxsc2NyZQogdm9pZCBWaWRlb0Z1bGxzY3JlZW5JbnRl cmZhY2VBVktpdDo6YXBwbGljYXRpb25EaWRCZWNvbWVBY3RpdmUoKQogewogICAgIExPRyhGdWxs c2NyZWVuLCAiVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmFwcGxpY2F0aW9uRGlkQmVj b21lQWN0aXZlKCVwKSIsIHRoaXMpOwotCi0gICAgLy8gSWYgd2UgYXJlIGJvdGggaW4gUGlQIGFu ZCBpbiBGdWxsc2NyZWVuIChpLmUuLCB2aWEgYXV0by1QaVApLCBhbmQgd2UgZGlkIG5vdCBzdG9w IGZ1bGxzY3JlZW4gdXBvbiByZXR1cm5pbmcsIGl0IG11c3QgYmUKLSAgICAvLyBiZWNhdXNlIHRo ZSBvcmlnaW5hdGluZyB2aWV3IGlzIG5vdCB2aXNpYmxlLCBzbyBoaWRlIHRoZSBmdWxsc2NyZWVu IHdpbmRvdy4KLSAgICBpZiAobV9jdXJyZW50TW9kZS5oYXNGdWxsc2NyZWVuKCkgJiYgbV9jdXJy ZW50TW9kZS5oYXNQaWN0dXJlSW5QaWN0dXJlKCkpIHsKLSAgICAgICAgW1ttX3BsYXllclZpZXdD b250cm9sbGVyIHZpZXddIGxheW91dElmTmVlZGVkXTsKLSAgICAgICAgW21fcGxheWVyVmlld0Nv bnRyb2xsZXIgZXhpdEZ1bGxTY3JlZW5BbmltYXRlZDpOTyBjb21wbGV0aW9uSGFuZGxlcjpbcHJv dGVjdGVkVGhpcyA9IG1ha2VSZWZQdHIodGhpcyksIHRoaXNdIChCT09MIHN1Y2Nlc3MsIE5TRXJy b3IgKmVycm9yKSB7Ci0gICAgICAgICAgICBleGl0RnVsbHNjcmVlbkhhbmRsZXIoc3VjY2Vzcywg ZXJyb3IpOwotICAgICAgICB9XTsKLSAgICB9CiB9CiAKIHZvaWQgVmlkZW9GdWxsc2NyZWVuSW50 ZXJmYWNlQVZLaXQ6OnNldHVwRnVsbHNjcmVlbihVSVZpZXcmIHZpZGVvVmlldywgY29uc3QgSW50 UmVjdCYgaW5pdGlhbFJlY3QsIFVJVmlldyogcGFyZW50VmlldywgSFRNTE1lZGlhRWxlbWVudEVu dW1zOjpWaWRlb0Z1bGxzY3JlZW5Nb2RlIG1vZGUsIGJvb2wgYWxsb3dzUGljdHVyZUluUGljdHVy ZVBsYXliYWNrLCBib29sIHN0YW5kYnkpCg== 340655 2018-05-17 15:03:21 -0700 2018-05-17 16:03:55 -0700 Patch For Landing bug-185747-20180517150320.patch text/plain 2527 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTRhZDIwNzBhNGVhMzQ4 ZGM0MjAyNmYxOGI3NzdkODc1OTU3NTNkNi4uYWNhM2JmZmY0ZGQ4NGRmZjIxZmUyODdlNTQzYTM2 NDljMjNmMjljOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA1LTE3ICBKZXJl bXkgSm9uZXMgIDxqZXJlbXlqQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3Nh cnkgZXhpdCBmdWxsc2NyZWVuIGNhbGwgb24gYXBwbGljYXRpb24gcmVzdW1lCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU3NDcKKyAgICAgICAgcmRh cjovL3Byb2JsZW0vNDAzNDU3MjUKKworICAgICAgICBSZXZpZXdlZCBieSBKZXIgTm9ibGUuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2Ugbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAg ICAgIEF1dG8tUGlQIGRvZXNuJ3QgYXV0b21hdGljYWxseSByZXR1cm4gdG8gZnVsbHNjcmVlbiBv biBhcHAgcmVzdW1lLAorICAgICAgICBzbyB3ZSBkb24ndCBuZWVkIHRvIGtlZXAgdGhpcyB2ZXN0 aWdpYWwgY29kZSBmb3IgaGFuZGxpbmcgYSBjb3JuZXIgY2FzZSBvZiB0aGF0IGZlYXR1cmUuCisg ICAgICAgIEFsc28sIHRoaXMgY2FuIGNhdXNlIGFuIHVubmVjZXNzYXJ5IGV4aXQgZnVsbHNjcmVl biB0aGF0IGNvdWxkIGNhdXNlIGRlYnVnIGFzc2VydHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9p b3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW06CisgICAgICAgIChWaWRlb0Z1bGxz Y3JlZW5JbnRlcmZhY2VBVktpdDo6YXBwbGljYXRpb25EaWRCZWNvbWVBY3RpdmUpOgorCiAyMDE4 LTA0LTMwICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXSBXZWJraXQgc2hvdWxkIHNwb29mIGFzIFNhZmFyaSBvbiBhIE1hYyB3aGVuIG9u IENoYXNlLmNvbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1ZpZGVv RnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9z L1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tCmluZGV4IGY0MTNmMTVkZmY0NWYwNTg5 NDUyMmEwYzczNzkxZjcwYTNmM2FiNmUuLmNjMDJiMGEwODVlNDQ4MTdkMTcyYjZjOGFkZGNmZDE2 MDFhMGNjOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9WaWRlb0Z1 bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9p b3MvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KQEAgLTEyODIsMTUgKzEyODIsNiBA QCBib29sIFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpzaG91bGRFeGl0RnVsbHNjcmVl bldpdGhSZWFzb24oVmlkZW9GdWxsc2NyZQogdm9pZCBWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VB VktpdDo6YXBwbGljYXRpb25EaWRCZWNvbWVBY3RpdmUoKQogewogICAgIExPRyhGdWxsc2NyZWVu LCAiVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OmFwcGxpY2F0aW9uRGlkQmVjb21lQWN0 aXZlKCVwKSIsIHRoaXMpOwotCi0gICAgLy8gSWYgd2UgYXJlIGJvdGggaW4gUGlQIGFuZCBpbiBG dWxsc2NyZWVuIChpLmUuLCB2aWEgYXV0by1QaVApLCBhbmQgd2UgZGlkIG5vdCBzdG9wIGZ1bGxz Y3JlZW4gdXBvbiByZXR1cm5pbmcsIGl0IG11c3QgYmUKLSAgICAvLyBiZWNhdXNlIHRoZSBvcmln aW5hdGluZyB2aWV3IGlzIG5vdCB2aXNpYmxlLCBzbyBoaWRlIHRoZSBmdWxsc2NyZWVuIHdpbmRv dy4KLSAgICBpZiAobV9jdXJyZW50TW9kZS5oYXNGdWxsc2NyZWVuKCkgJiYgbV9jdXJyZW50TW9k ZS5oYXNQaWN0dXJlSW5QaWN0dXJlKCkpIHsKLSAgICAgICAgW1ttX3BsYXllclZpZXdDb250cm9s bGVyIHZpZXddIGxheW91dElmTmVlZGVkXTsKLSAgICAgICAgW21fcGxheWVyVmlld0NvbnRyb2xs ZXIgZXhpdEZ1bGxTY3JlZW5BbmltYXRlZDpOTyBjb21wbGV0aW9uSGFuZGxlcjpbcHJvdGVjdGVk VGhpcyA9IG1ha2VSZWZQdHIodGhpcyksIHRoaXNdIChCT09MIHN1Y2Nlc3MsIE5TRXJyb3IgKmVy cm9yKSB7Ci0gICAgICAgICAgICBleGl0RnVsbHNjcmVlbkhhbmRsZXIoc3VjY2VzcywgZXJyb3Ip OwotICAgICAgICB9XTsKLSAgICB9CiB9CiAKIHZvaWQgVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNl QVZLaXQ6OnNldHVwRnVsbHNjcmVlbihVSVZpZXcmIHZpZGVvVmlldywgY29uc3QgSW50UmVjdCYg aW5pdGlhbFJlY3QsIFVJVmlldyogcGFyZW50VmlldywgSFRNTE1lZGlhRWxlbWVudEVudW1zOjpW aWRlb0Z1bGxzY3JlZW5Nb2RlIG1vZGUsIGJvb2wgYWxsb3dzUGljdHVyZUluUGljdHVyZVBsYXli YWNrLCBib29sIHN0YW5kYnkpCg==