185740 2018-05-17 12:40:34 -0700 [MSE][GStreamer] Force segment.start = 0 after matroskademux 2018-05-21 04:52:40 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya aboya bugs-noreply calvaris commit-queue eocanha oldest_to_newest 1424865 0 aboya 2018-05-17 12:40:34 -0700 This patch ensures that when WebM MSE media segments are appended in an out of order fashion their frames are not discarded by opusparse or any other potential elements downstream in the AppendPipeline that perform segment clipping. This patch fixes the following YTTV 2018 tests: 38. OpusAudioWithOverlap 39. OpusAudioWithSmallGap 40. OpusAudioWithLargeGap 70. VP9VideoWithOverlap 71. VP9VideoWithSmallGap This patch is necessary, but not sufficient for fixing the following YTTV 2018 tests: 36. AppendOpusAudioOutOfOrder 67. AppendVP9VideoOutOfOrder 1424870 1 340628 aboya 2018-05-17 12:51:33 -0700 Created attachment 340628 Patch 1425616 2 calvaris 2018-05-21 04:11:32 -0700 It looks good. Let's have Quique having last word. 1425620 3 340628 commit-queue 2018-05-21 04:52:39 -0700 Comment on attachment 340628 Patch Clearing flags on attachment: 340628 Committed r232014: <https://trac.webkit.org/changeset/232014> 1425621 4 commit-queue 2018-05-21 04:52:40 -0700 All reviewed patches have been landed. Closing bug. 340628 2018-05-17 12:51:33 -0700 2018-05-21 04:52:39 -0700 Patch bug-185740-20180517215131.patch text/plain 4763 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjU0OGFhODc3ZGZiZTcx OTViMDllOTAzNTFkOTZhMzc3YjQxYjQ2MC4uOWE2YmZkNWJkNjIyYjk4NWM5MTQ2MzgwNmZmNDQ5 YzBkNDVkMGQ3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDE4LTA1LTE3ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIEZvcmNlIHNlZ21lbnQuc3RhcnQgPSAwIGFmdGVyIG1hdHJvc2thZGVtdXgKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTc0MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggZW5z dXJlcyB0aGF0IHdoZW4gV2ViTSBNU0UgbWVkaWEgc2VnbWVudHMgYXJlIGFwcGVuZGVkIGluCisg ICAgICAgIGFuIG91dCBvZiBvcmRlciBmYXNoaW9uIHRoZWlyIGZyYW1lcyBhcmUgbm90IGRpc2Nh cmRlZCBieSBvcHVzcGFyc2Ugb3IKKyAgICAgICAgYW55IG90aGVyIHBvdGVudGlhbCBlbGVtZW50 cyBkb3duc3RyZWFtIGluIHRoZSBBcHBlbmRQaXBlbGluZSB0aGF0CisgICAgICAgIHBlcmZvcm0g c2VnbWVudCBjbGlwcGluZy4KKworICAgICAgICBUaGlzIHBhdGNoIGZpeGVzIHRoZSBmb2xsb3dp bmcgWVRUViAyMDE4IHRlc3RzOgorCisgICAgICAgIDM4LiBPcHVzQXVkaW9XaXRoT3ZlcmxhcAor ICAgICAgICAzOS4gT3B1c0F1ZGlvV2l0aFNtYWxsR2FwCisgICAgICAgIDQwLiBPcHVzQXVkaW9X aXRoTGFyZ2VHYXAKKyAgICAgICAgNzAuIFZQOVZpZGVvV2l0aE92ZXJsYXAKKyAgICAgICAgNzEu IFZQOVZpZGVvV2l0aFNtYWxsR2FwCisKKyAgICAgICAgVGhpcyBwYXRjaCBpcyBuZWNlc3Nhcnks IGJ1dCBub3Qgc3VmZmljaWVudCBmb3IgZml4aW5nIHRoZSBmb2xsb3dpbmcKKyAgICAgICAgWVRU ViAyMDE4IHRlc3RzOgorCisgICAgICAgIDM2LiBBcHBlbmRPcHVzQXVkaW9PdXRPZk9yZGVyCisg ICAgICAgIDY3LiBBcHBlbmRWUDlWaWRlb091dE9mT3JkZXIKKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6QXBwZW5kUGlwZWxpbmU6OmNvbm5lY3REZW11eGVyU3JjUGFkVG9BcHBzaW5rKToKKyAg ICAgICAgKFdlYkNvcmU6Om1hdHJvc2thZGVtdXhGb3JjZVNlZ21lbnRTdGFydFRvRXF1YWxaZXJv KToKKwogMjAxOC0wNS0xNyAgQWxpY2lhIEJveWEgR2FyY8OtYSAgPGFib3lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW01TRV1bR1N0cmVhbWVyXSBTdHJlYW06OmRlY29kZWJpblNpbmtQYWQgaXMg cmVhZCBidXQgbmV2ZXIgYXNzaWduZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAK aW5kZXggOWU1ODZmNGMxMzgwYTE4ZDhkMDJhY2FhYmFjN2IwOGI2NDRjZDk1NS4uZTIxM2QyZGU0 MWNkMjFkOTIxOTdmZDQzZDUxOTgzZGJjMTZiY2UzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQ aXBlbGluZS5jcHAKQEAgLTg1LDYgKzg1LDggQEAgc3RhdGljIEdzdFBhZFByb2JlUmV0dXJuIGFw cGVuZFBpcGVsaW5lRGVtdXhlckJsYWNrSG9sZVBhZFByb2JlKEdzdFBhZCosIEdzdFBhZFAKIHN0 YXRpYyBHc3RGbG93UmV0dXJuIGFwcGVuZFBpcGVsaW5lQXBwc2lua05ld1NhbXBsZShHc3RFbGVt ZW50KiwgQXBwZW5kUGlwZWxpbmUqKTsKIHN0YXRpYyB2b2lkIGFwcGVuZFBpcGVsaW5lQXBwc2lu a0VPUyhHc3RFbGVtZW50KiwgQXBwZW5kUGlwZWxpbmUqKTsKIAorc3RhdGljIEdzdFBhZFByb2Jl UmV0dXJuIG1hdHJvc2thZGVtdXhGb3JjZVNlZ21lbnRTdGFydFRvRXF1YWxaZXJvKEdzdFBhZCos IEdzdFBhZFByb2JlSW5mbyosIHZvaWQqKTsKKwogc3RhdGljIHZvaWQgYXBwZW5kUGlwZWxpbmVO ZWVkQ29udGV4dE1lc3NhZ2VDYWxsYmFjayhHc3RCdXMqLCBHc3RNZXNzYWdlKiBtZXNzYWdlLCBB cHBlbmRQaXBlbGluZSogYXBwZW5kUGlwZWxpbmUpCiB7CiAgICAgR1NUX1RSQUNFKCJyZWNlaXZl ZCBjYWxsYmFjayIpOwpAQCAtOTc4LDYgKzk4MCwxMCBAQCB2b2lkIEFwcGVuZFBpcGVsaW5lOjpj b25uZWN0RGVtdXhlclNyY1BhZFRvQXBwc2luayhHc3RQYWQqIGRlbXV4ZXJTcmNQYWQpCiAgICAg QVNTRVJUKFdURjo6aXNNYWluVGhyZWFkKCkpOwogICAgIEdTVF9ERUJVRygiQ29ubmVjdGluZyB0 byBhcHBzaW5rIik7CiAKKyAgICBjb25zdCBTdHJpbmcmIHR5cGUgPSBtX3NvdXJjZUJ1ZmZlclBy aXZhdGUtPnR5cGUoKS5jb250YWluZXJUeXBlKCk7CisgICAgaWYgKHR5cGUuZW5kc1dpdGgoIndl Ym0iKSkKKyAgICAgICAgZ3N0X3BhZF9hZGRfcHJvYmUoZGVtdXhlclNyY1BhZCwgR1NUX1BBRF9Q Uk9CRV9UWVBFX0VWRU5UX0RPV05TVFJFQU0sIG1hdHJvc2thZGVtdXhGb3JjZVNlZ21lbnRTdGFy dFRvRXF1YWxaZXJvLCBudWxscHRyLCBudWxscHRyKTsKKwogICAgIExvY2tIb2xkZXIgbG9ja2Vy KG1fcGFkQWRkUmVtb3ZlTG9jayk7CiAgICAgR1JlZlB0cjxHc3RQYWQ+IHNpbmtTaW5rUGFkID0g YWRvcHRHUmVmKGdzdF9lbGVtZW50X2dldF9zdGF0aWNfcGFkKG1fYXBwc2luay5nZXQoKSwgInNp bmsiKSk7CiAKQEAgLTExNDgsNyArMTE1NCwzNSBAQCBzdGF0aWMgdm9pZCBhcHBlbmRQaXBlbGlu ZUFwcHNpbmtFT1MoR3N0RWxlbWVudCosIEFwcGVuZFBpcGVsaW5lKiBhcHBlbmRQaXBlbGluZQog ICAgIEdTVF9ERUJVRygiJXMgbWFpbiB0aHJlYWQiLCAoV1RGOjppc01haW5UaHJlYWQoKSkgPyAi SXMiIDogIk5vdCIpOwogfQogCi0KK3N0YXRpYyBHc3RQYWRQcm9iZVJldHVybiBtYXRyb3NrYWRl bXV4Rm9yY2VTZWdtZW50U3RhcnRUb0VxdWFsWmVybyhHc3RQYWQqLCBHc3RQYWRQcm9iZUluZm8q IGluZm8sIHZvaWQqKQoreworICAgIC8vIG1hdHJvc2thZGVtdXggc2V0cyBHc3RTZWdtZW50LnN0 YXJ0IHRvIHRoZSBQVFMgb2YgdGhlIGZpcnN0IGZyYW1lLgorICAgIC8vCisgICAgLy8gVGhpcyB3 YXkgaW4gdGhlIHVubGlrZWx5IGNhc2UgYSB1c2VyIG1hZGUgYSAubWt2IG9yIC53ZWJtIGZpbGUg d2hlcmUgYSBjZXJ0YWluIHBvcnRpb24gb2YgdGhlIG1vdmllIGlzIHNraXBwZWQKKyAgICAvLyAo ZS5nLiBieSBjb25jYXRlbmF0aW5nIGEgTVNFIGluaXRpYWxpemF0aW9uIHNlZ21lbnQgd2l0aCBh bnkgTVNFIG1lZGlhIHNlZ21lbnQgb3RoZXIgdGhhbiB0aGUgZmlyc3QpIGFuZCBvcGVuZWQKKyAg ICAvLyBpdCB3aXRoIGEgcmVndWxhciBwbGF5ZXIsIHBsYXliYWNrIHdvdWxkIHN0YXJ0IGltbWVk aWF0ZWx5LiBHc3RTZWdtZW50LmR1cmF0aW9uIGlzIG5vdCBtb2RpZmllZCBpbiBhbnkgY2FzZS4K KyAgICAvLworICAgIC8vIExlYXZpbmcgdGhlIHVzZWZ1bG5lc3Mgb2YgdGhhdCBmZWF0dXJlIGFz aWRlLCB0aGUgZmFjdCB0aGF0IGl0IHVzZXMgR3N0U2VnbWVudC5zdGFydCBpcyBwcm9ibGVtYXRp YyBmb3IgTVNFLgorICAgIC8vIEluIE1TRSBpcyBub3QgdW51c3VhbCB0byBwcm9jZXNzIHVub3Jk ZXJlZCBNU0UgbWVkaWEgc2VnbWVudHMuIEluIHRoaXMgY2FzZSwgYSBmcmFtZSBtYXkgaGF2ZQor ICAgIC8vIFBUUyA8PDwgR3N0U2VnbWVudC5zdGFydCBhbmQgYmUgZGlzY2FyZGVkIGJ5IGRvd25z dHJlYW0uIFRoaXMgaGFwcGVucyBmb3IgaW5zdGFuY2UgaW4gZWxlbWVudHMgZGVyaXZlZCBmcm9t CisgICAgLy8gYXVkaW9iYXNlZmlsdGVyLCBzdWNoIGFzIG9wdXNwYXJzZS4KKyAgICAvLworICAg IC8vIFRoaXMgcHJvYmUgcmVtZWRpZXMgdGhlIHByb2JsZW0gYnkgc2V0dGluZyBHc3RTZWdtZW50 LnN0YXJ0IHRvIDAgaW4gYWxsIGNhc2VzLCBub3Qgb25seSB3aGVuIHRoZSBQVFMgb2YgdGhlIGZp cnN0CisgICAgLy8gZnJhbWUgaXMgemVyby4KKworICAgIEFTU0VSVChpbmZvLT50eXBlICYgR1NU X1BBRF9QUk9CRV9UWVBFX0VWRU5UX0RPV05TVFJFQU0pOworICAgIEdzdEV2ZW50KiBldmVudCA9 IHN0YXRpY19jYXN0PEdzdEV2ZW50Kj4oaW5mby0+ZGF0YSk7CisgICAgaWYgKGV2ZW50LT50eXBl ID09IEdTVF9FVkVOVF9TRUdNRU5UKSB7CisgICAgICAgIEdzdFNlZ21lbnQgc2VnbWVudDsKKyAg ICAgICAgZ3N0X2V2ZW50X2NvcHlfc2VnbWVudChldmVudCwgJnNlZ21lbnQpOworCisgICAgICAg IHNlZ21lbnQuc3RhcnQgPSAwOworCisgICAgICAgIEdSZWZQdHI8R3N0RXZlbnQ+IG5ld0V2ZW50 ID0gYWRvcHRHUmVmKGdzdF9ldmVudF9uZXdfc2VnbWVudCgmc2VnbWVudCkpOworICAgICAgICBn c3RfZXZlbnRfcmVwbGFjZShyZWludGVycHJldF9jYXN0PEdzdEV2ZW50Kio+KCZpbmZvLT5kYXRh KSwgbmV3RXZlbnQuZ2V0KCkpOworICAgIH0KKyAgICByZXR1cm4gR1NUX1BBRF9QUk9CRV9PSzsK K30KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZS4KIAo=