185727 2018-05-17 07:38:13 -0700 Remove cssom-remove-shorthand-property.html test 2018-05-17 22:14:11 -0700 1 1 1 Unclassified WebKit CSS WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 177684 1 rbuis webkit-unassigned ap commit-queue fred.wang webkit-bug-importer oldest_to_newest 1424715 0 rbuis 2018-05-17 07:38:13 -0700 The exact same test is contained in WPT: cssom/cssom-setProperty-shorthand.html 1424718 1 340582 rbuis 2018-05-17 07:40:10 -0700 Created attachment 340582 Patch 1424732 2 340582 commit-queue 2018-05-17 08:27:44 -0700 Comment on attachment 340582 Patch Clearing flags on attachment: 340582 Committed r231898: <https://trac.webkit.org/changeset/231898> 1424733 3 commit-queue 2018-05-17 08:27:45 -0700 All reviewed patches have been landed. Closing bug. 1424734 4 webkit-bug-importer 2018-05-17 08:28:24 -0700 <rdar://problem/40331782> 1424873 5 ap 2018-05-17 13:01:05 -0700 It's not great to remove tests, because that loses all the history. In this case, how would one know that there was discussion in https://bugs.webkit.org/show_bug.cgi?id=68551 ? I guess at least there's a link from WPT source. But it's so much harder to find. 1425058 6 fred.wang 2018-05-17 22:14:11 -0700 (In reply to Alexey Proskuryakov from comment #5) > It's not great to remove tests, because that loses all the history. In this > case, how would one know that there was discussion in > https://bugs.webkit.org/show_bug.cgi?id=68551 ? > > I guess at least there's a link from WPT source. But it's so much harder to > find. Yes, sorry about that. This came in the context of bug 177684, probably it would have make more sense for us to not apply the rule of splitting work into smaller patches here, so that we preserve the history link between the new file and old file (at least that's not worse than when people rename/move directories or files in WebKit). I'm adding a Bugzilla dependency to improve that a bit for future searches. Anyway, I believe it makes sense to migrate to a WPT test and remove duplicate tests for this kind of bug reports, which could have been noticed earlier if the people who fixed the behavior in other browsers or clarified a spec had written new WPT tests and if one had sync CSSOM tests between WPT and WebKit. For Web Platform development, it seems more helpful to me to link to interoperability tests, to the current specs or to other browsers' behaviors than to discussions that happened several years ago (not saying these discussions were not important of course). 340582 2018-05-17 07:40:10 -0700 2018-05-17 08:27:44 -0700 Patch bug-185727-20180517164009.patch text/plain 4784 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxODg5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTRjMGFmYzA2ZmQ0NmMzODgzMGZl NjJkNjQzYWQ1YWRiNWIyY2NkYy4uMTI5MjMyZDhlM2U5OWU4YTVlZDhhYzQ0YmQ3NTYwNjg5MjI5 NjI0NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA1LTE3ICBSb2IgQnVpcyAgPHJidWlz QGlnYWxpYS5jb20+CisKKyAgICAgICAgUmVtb3ZlIGNzc29tLXJlbW92ZS1zaG9ydGhhbmQtcHJv cGVydHkuaHRtbCB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODU3MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBFeGFjdCBzYW1lIHRlc3QgaXMgY29udGFpbmVkIGluIFdQVDoKKyAgICAgICAgY3Nz b20vY3Nzb20tc2V0UHJvcGVydHktc2hvcnRoYW5kLmh0bWwKKworICAgICAgICAqIGZhc3QvY3Nz L2Nzc29tLXJlbW92ZS1zaG9ydGhhbmQtcHJvcGVydHktZXhwZWN0ZWQudHh0OiBSZW1vdmVkLgor ICAgICAgICAqIGZhc3QvY3NzL2Nzc29tLXJlbW92ZS1zaG9ydGhhbmQtcHJvcGVydHkuaHRtbDog UmVtb3ZlZC4KKwogMjAxOC0wNS0xNiAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgTGF5b3V0VGVzdCBzdG9yYWdlL2luZGV4ZWRkYi9kb250LXdlZGdlLXByaXZh dGUuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv Y3NzL2Nzc29tLXJlbW92ZS1zaG9ydGhhbmQtcHJvcGVydHktZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvZmFzdC9jc3MvY3Nzb20tcmVtb3ZlLXNob3J0aGFuZC1wcm9wZXJ0eS1leHBlY3RlZC50 eHQKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IGM4Yzg3NTA2ZjU5YTRlOGRjNTNhY2Q3 NzgzZDc1ZjVjNWZlYjQ5ZDguLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvY3Nzb20tcmVtb3ZlLXNob3J0aGFuZC1wcm9w ZXJ0eS1leHBlY3RlZC50eHQKKysrIC9kZXYvbnVsbApAQCAtMSw0NyArMCwwIEBACi1UZXN0cyB0 aGF0IHNob3J0aGFuZCBwcm9wZXJ0aWVzIGNhbiBiZSByZW1vdmVkIHZpYSBDU1NPTS4KLQotT24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93 ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgotCi0KLVBBU1MgY2FuU2V0UHJvcGVydHkoJ2ZvbnQnKSBp cyB0cnVlCi1QQVNTIGNhblJlbW92ZVByb3BlcnR5KCdmb250JykgaXMgdHJ1ZQotUEFTUyBjYW5T ZXRQcm9wZXJ0eSgnYm9yZGVyLXRvcCcpIGlzIHRydWUKLVBBU1MgY2FuUmVtb3ZlUHJvcGVydHko J2JvcmRlci10b3AnKSBpcyB0cnVlCi1QQVNTIGNhblNldFByb3BlcnR5KCdib3JkZXItcmlnaHQn KSBpcyB0cnVlCi1QQVNTIGNhblJlbW92ZVByb3BlcnR5KCdib3JkZXItcmlnaHQnKSBpcyB0cnVl Ci1QQVNTIGNhblNldFByb3BlcnR5KCdib3JkZXItYm90dG9tJykgaXMgdHJ1ZQotUEFTUyBjYW5S ZW1vdmVQcm9wZXJ0eSgnYm9yZGVyLWJvdHRvbScpIGlzIHRydWUKLVBBU1MgY2FuU2V0UHJvcGVy dHkoJ2JvcmRlci1sZWZ0JykgaXMgdHJ1ZQotUEFTUyBjYW5SZW1vdmVQcm9wZXJ0eSgnYm9yZGVy LWxlZnQnKSBpcyB0cnVlCi1QQVNTIGNhblNldFByb3BlcnR5KCdib3JkZXInKSBpcyB0cnVlCi1Q QVNTIGNhblJlbW92ZVByb3BlcnR5KCdib3JkZXInKSBpcyB0cnVlCi1QQVNTIGNhblNldFByb3Bl cnR5KCdib3JkZXItY29sb3InKSBpcyB0cnVlCi1QQVNTIGNhblJlbW92ZVByb3BlcnR5KCdib3Jk ZXItY29sb3InKSBpcyB0cnVlCi1QQVNTIGNhblNldFByb3BlcnR5KCdib3JkZXItc3R5bGUnKSBp cyB0cnVlCi1QQVNTIGNhblJlbW92ZVByb3BlcnR5KCdib3JkZXItc3R5bGUnKSBpcyB0cnVlCi1Q QVNTIGNhblNldFByb3BlcnR5KCdib3JkZXItd2lkdGgnKSBpcyB0cnVlCi1QQVNTIGNhblJlbW92 ZVByb3BlcnR5KCdib3JkZXItd2lkdGgnKSBpcyB0cnVlCi1QQVNTIGNhblNldFByb3BlcnR5KCdi YWNrZ3JvdW5kLXBvc2l0aW9uJykgaXMgdHJ1ZQotUEFTUyBjYW5SZW1vdmVQcm9wZXJ0eSgnYmFj a2dyb3VuZC1wb3NpdGlvbicpIGlzIHRydWUKLVBBU1MgY2FuU2V0UHJvcGVydHkoJ2JhY2tncm91 bmQtcmVwZWF0JykgaXMgdHJ1ZQotUEFTUyBjYW5SZW1vdmVQcm9wZXJ0eSgnYmFja2dyb3VuZC1y ZXBlYXQnKSBpcyB0cnVlCi1QQVNTIGNhblNldFByb3BlcnR5KCdib3JkZXItc3BhY2luZycpIGlz IHRydWUKLVBBU1MgY2FuUmVtb3ZlUHJvcGVydHkoJ2JvcmRlci1zcGFjaW5nJykgaXMgdHJ1ZQot UEFTUyBjYW5TZXRQcm9wZXJ0eSgnbGlzdC1zdHlsZScpIGlzIHRydWUKLVBBU1MgY2FuUmVtb3Zl UHJvcGVydHkoJ2xpc3Qtc3R5bGUnKSBpcyB0cnVlCi1QQVNTIGNhblNldFByb3BlcnR5KCdtYXJn aW4nKSBpcyB0cnVlCi1QQVNTIGNhblJlbW92ZVByb3BlcnR5KCdtYXJnaW4nKSBpcyB0cnVlCi1Q QVNTIGNhblNldFByb3BlcnR5KCdvdXRsaW5lJykgaXMgdHJ1ZQotUEFTUyBjYW5SZW1vdmVQcm9w ZXJ0eSgnb3V0bGluZScpIGlzIHRydWUKLVBBU1MgY2FuU2V0UHJvcGVydHkoJ3BhZGRpbmcnKSBp cyB0cnVlCi1QQVNTIGNhblJlbW92ZVByb3BlcnR5KCdwYWRkaW5nJykgaXMgdHJ1ZQotUEFTUyBj YW5TZXRQcm9wZXJ0eSgnYmFja2dyb3VuZCcpIGlzIHRydWUKLVBBU1MgY2FuUmVtb3ZlUHJvcGVy dHkoJ2JhY2tncm91bmQnKSBpcyB0cnVlCi1QQVNTIGNhblNldFByb3BlcnR5KCdvdmVyZmxvdycp IGlzIHRydWUKLVBBU1MgY2FuUmVtb3ZlUHJvcGVydHkoJ292ZXJmbG93JykgaXMgdHJ1ZQotUEFT UyBjYW5TZXRQcm9wZXJ0eSgnYm9yZGVyLXJhZGl1cycpIGlzIHRydWUKLVBBU1MgY2FuUmVtb3Zl UHJvcGVydHkoJ2JvcmRlci1yYWRpdXMnKSBpcyB0cnVlCi1QQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCi0KLVRFU1QgQ09NUExFVEUKLQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9jc3MvY3Nzb20tcmVtb3ZlLXNob3J0aGFuZC1wcm9wZXJ0eS5odG1sIGIvTGF5b3V0VGVzdHMv ZmFzdC9jc3MvY3Nzb20tcmVtb3ZlLXNob3J0aGFuZC1wcm9wZXJ0eS5odG1sCmRlbGV0ZWQgZmls ZSBtb2RlIDEwMDY0NAppbmRleCA3NTlhNDI3MWYzOGZmNjMwM2M3MmZjODg0MmQwMTZjMGRiZWUz MTRmLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91 dFRlc3RzL2Zhc3QvY3NzL2Nzc29tLXJlbW92ZS1zaG9ydGhhbmQtcHJvcGVydHkuaHRtbAorKysg L2Rldi9udWxsCkBAIC0xLDU2ICswLDAgQEAKLTwhRE9DVFlQRSBodG1sPgotPGh0bWw+Ci08aGVh ZD4KLTxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KLTxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMv anMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgotPC9oZWFkPgotPGJvZHk+Ci08c2NyaXB0PgotCi1z aG9ydGhhbmRQcm9wZXJ0aWVzID0gWwotICAgICJmb250IiwKLSAgICAiYm9yZGVyLXRvcCIsCi0g ICAgImJvcmRlci1yaWdodCIsCi0gICAgImJvcmRlci1ib3R0b20iLAotICAgICJib3JkZXItbGVm dCIsCi0gICAgImJvcmRlciIsCi0gICAgImJvcmRlci1jb2xvciIsCi0gICAgImJvcmRlci1zdHls ZSIsCi0gICAgImJvcmRlci13aWR0aCIsCi0gICAgImJhY2tncm91bmQtcG9zaXRpb24iLAotICAg ICJiYWNrZ3JvdW5kLXJlcGVhdCIsCi0gICAgImJvcmRlci1zcGFjaW5nIiwKLSAgICAibGlzdC1z dHlsZSIsCi0gICAgIm1hcmdpbiIsCi0gICAgIm91dGxpbmUiLAotICAgICJwYWRkaW5nIiwKLSAg ICAiYmFja2dyb3VuZCIsCi0gICAgIm92ZXJmbG93IiwKLSAgICAiYm9yZGVyLXJhZGl1cyIKLV07 Ci0KLWVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdzcGFuJyk7Ci0KLWZ1bmN0aW9u IGNhblNldFByb3BlcnR5KHByb3BlcnR5TmFtZSkgewotICAgIGVsZW1lbnQuc3R5bGUuc2V0UHJv cGVydHkocHJvcGVydHlOYW1lLCAnaW5pdGlhbCcpOwotICAgIHJldHVybiBlbGVtZW50LnN0eWxl LmdldFByb3BlcnR5VmFsdWUocHJvcGVydHlOYW1lKSA9PSAnaW5pdGlhbCc7Ci19Ci0KLWZ1bmN0 aW9uIGNhblJlbW92ZVByb3BlcnR5KHByb3BlcnR5TmFtZSkgewotICAgIGVsZW1lbnQuc3R5bGUu cmVtb3ZlUHJvcGVydHkocHJvcGVydHlOYW1lKTsKLSAgICByZXR1cm4gZWxlbWVudC5zdHlsZS5n ZXRQcm9wZXJ0eVZhbHVlKHByb3BlcnR5TmFtZSkgIT0gJ2luaXRpYWwnOwotfQotCi1kZXNjcmlw dGlvbigiVGVzdHMgdGhhdCBzaG9ydGhhbmQgcHJvcGVydGllcyBjYW4gYmUgcmVtb3ZlZCB2aWEg Q1NTT00uIik7Ci0KLWZvciAoaSA9IDA7IGkgPCBzaG9ydGhhbmRQcm9wZXJ0aWVzLmxlbmd0aDsg KytpKSB7Ci0gICAgdmFyIHByb3BlcnR5TmFtZSA9IHNob3J0aGFuZFByb3BlcnRpZXNbaV07Ci0K LSAgICBzaG91bGRCZSgiY2FuU2V0UHJvcGVydHkoJyIgKyBwcm9wZXJ0eU5hbWUgKyAiJykiLCAi dHJ1ZSIpOwotICAgIHNob3VsZEJlKCJjYW5SZW1vdmVQcm9wZXJ0eSgnIiArIHByb3BlcnR5TmFt ZSArICInKSIsICJ0cnVlIik7Ci19Ci0KLTwvc2NyaXB0PgotPHNjcmlwdCBzcmM9Ii4uLy4uL3Jl c291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgotPC9ib2R5PgotPC9odG1sPgo=