185723 2018-05-17 06:21:47 -0700 [MSE][GStreamer] Fix the deadlock caused by bug 185242 (r231351) 2018-05-22 02:32:54 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 185725 1 bandou.yacine webkit-unassigned aboya bugs-noreply calvaris commit-queue olivier.blin oldest_to_newest 1424693 0 bandou.yacine 2018-05-17 06:21:47 -0700 After a detailed investigation, I found that, the patch r231351 doesn't fix the crash that expected to fix, it just replaces it by a deadlock. This Patch will remove a part of r231351 which cause a deadlock. See https://bugs.webkit.org/show_bug.cgi?id=185242#c11 and https://bugs.webkit.org/show_bug.cgi?id=185242#c12 Thanks to Alicia for her explanations in bugs 185242 and 185592. 1424803 1 340601 bandou.yacine 2018-05-17 10:55:42 -0700 Created attachment 340601 Patch 1426080 2 340601 commit-queue 2018-05-22 02:32:52 -0700 Comment on attachment 340601 Patch Clearing flags on attachment: 340601 Committed r232058: <https://trac.webkit.org/changeset/232058> 1426081 3 commit-queue 2018-05-22 02:32:54 -0700 All reviewed patches have been landed. Closing bug. 340601 2018-05-17 10:55:42 -0700 2018-05-22 02:32:52 -0700 Patch bug-185723-20180517195544.patch text/plain 2256 bandou.yacine U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODZjNWU5NjliOGIxMGFm MTgyN2MzODQ0MzY4MWJjZWUzNDZmMzc0NS4uYWZhNWY1NGQyMzFjMWJjMjgzZjYxMDM3ZTNiZGYx OWRjYTdhYThiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA1LTE3ICBZYWNp bmUgQmFuZG91ICA8eWFjaW5lLmJhbmRvdV9leHRAc29mdGF0aG9tZS5jb20+CisKKyAgICAgICAg W01TRV1bR1N0cmVhbWVyXSBGaXggdGhlIGRlYWRsb2NrIGNhdXNlZCBieSBidWcgMTg1MjQyIChy MjMxMzUxKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTg1NzIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWZ0ZXIgYSBkZXRhaWxlZCBpbnZlc3RpZ2F0aW9uLCB3ZSBmb3VuZCB0aGF0LCB0aGUgcGF0Y2gg cjIzMTM1MSBkb2Vzbid0IGZpeCB0aGUgY3Jhc2ggdGhhdCBleHBlY3RlZCB0byBmaXgsCisgICAg ICAgIGl0IGp1c3QgcmVwbGFjZXMgaXQgYnkgYSBkZWFkbG9jay4gTm93IHRoZSBjcmFzaCBpcyBm aXhlZCBpbiB0aGUgYnVnIDE4NTcyNS4KKworICAgICAgICBUaGlzIFBhdGNoIHdpbGwgcmVtb3Zl IGEgcGFydCBvZiByMjMxMzUxIHRoYXQgY2F1c2VzIHRoZSBkZWFkbG9jay4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvV2ViS2l0TWVkaWFTb3VyY2VHU3RyZWFt ZXIuY3BwOgorICAgICAgICAod2ViS2l0TWVkaWFTcmNGcmVlU3RyZWFtKToKKwogMjAxOC0wNS0x NyAgWWFjaW5lIEJhbmRvdSAgPHlhY2luZS5iYW5kb3VfZXh0QHNvZnRhdGhvbWUuY29tPgogCiAg ICAgICAgIFtNU0VdW0dTdHJlYW1lcl0gRG9uJ3Qgc2V0IHRoZSBSZWFkeVN0YXRlIHRvIEhhdmVO b3RoaW5nIHdoZW4gYW4gZXJyb3Igb2NjdXJzIGluIHRoZSBwbGF5YmFjayBwaXBlbGluZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9X ZWJLaXRNZWRpYVNvdXJjZUdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvbXNlL1dlYktpdE1lZGlhU291cmNlR1N0cmVhbWVyLmNwcAppbmRl eCBiYjE0ZjJiY2U4Y2RlZGY2YmU4NjcyNmQyMzIwOWFjZTBiOTljZjA1Li40OGQwOWVkMjA2YmRl OWMzNWUzMDkwZWQyYjExMjAwMmJmMzMwOWEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL1dlYktpdE1lZGlhU291cmNlR1N0cmVhbWVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNl L1dlYktpdE1lZGlhU291cmNlR1N0cmVhbWVyLmNwcApAQCAtNTEzLDE1ICs1MTMsNiBAQCB2b2lk IHdlYktpdE1lZGlhU3JjRnJlZVN0cmVhbShXZWJLaXRNZWRpYVNyYyogc291cmNlLCBTdHJlYW0q IHN0cmVhbSkKICAgICAgICAgLy8gRG9uJ3QgdHJpZ2dlciBjYWxsYmFja3MgZnJvbSB0aGlzIGFw cHNyYyB0byBhdm9pZCB1c2luZyB0aGUgc3RyZWFtIGFueW1vcmUuCiAgICAgICAgIGdzdF9hcHBf c3JjX3NldF9jYWxsYmFja3MoR1NUX0FQUF9TUkMoc3RyZWFtLT5hcHBzcmMpLCAmZGlzYWJsZWRB cHBzcmNDYWxsYmFja3MsIG51bGxwdHIsIG51bGxwdHIpOwogICAgICAgICBnc3RfYXBwX3NyY19l bmRfb2Zfc3RyZWFtKEdTVF9BUFBfU1JDKHN0cmVhbS0+YXBwc3JjKSk7Ci0gICAgICAgIGdzdF9l bGVtZW50X3NldF9zdGF0ZShzdHJlYW0tPmFwcHNyYywgR1NUX1NUQVRFX05VTEwpOwotICAgICAg ICBnc3RfYmluX3JlbW92ZShHU1RfQklOKHNvdXJjZSksIHN0cmVhbS0+YXBwc3JjKTsKLSAgICAg ICAgc3RyZWFtLT5hcHBzcmMgPSBudWxscHRyOwotICAgIH0KLQotICAgIGlmIChzdHJlYW0tPnBh cnNlcikgewotICAgICAgICBnc3RfZWxlbWVudF9zZXRfc3RhdGUoc3RyZWFtLT5wYXJzZXIsIEdT VF9TVEFURV9OVUxMKTsKLSAgICAgICAgZ3N0X2Jpbl9yZW1vdmUoR1NUX0JJTihzb3VyY2UpLCBz dHJlYW0tPnBhcnNlcik7Ci0gICAgICAgIHN0cmVhbS0+cGFyc2VyID0gbnVsbHB0cjsKICAgICB9 CiAKICAgICBHU1RfT0JKRUNUX0xPQ0soc291cmNlKTsK