185722 2018-05-17 04:01:31 -0700 Safari optimized flow should be releasing viewer to prevent memory growth with subsequent launches/closes 2018-05-17 04:30:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino ddkilzer webkit-bug-importer oldest_to_newest 1424669 0 dino 2018-05-17 04:01:31 -0700 Safari optimized flow should be releasing viewer to prevent memory growth with subsequent launches/closes 1424670 1 dino 2018-05-17 04:01:52 -0700 <rdar://problem/40247351> 1424671 2 340570 dino 2018-05-17 04:04:13 -0700 Created attachment 340570 Patch 1424674 3 340570 ddkilzer 2018-05-17 04:21:13 -0700 Comment on attachment 340570 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340570&action=review r=me > Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:90 > + WebKit::WeakObjCPtr<_WKPreviewControllerDataSource> weakSelf { self }; FWIW, as of Bug 184789 / r230824, you can start using __weak directly. Not sure how well that plays with C++ lambdas, though. > Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:93 > + auto strongSelf = weakSelf.get(); > + if (strongSelf) Nit: Could use: if ((auto strongSelf = weakSelf.get())) 1424675 4 dino 2018-05-17 04:26:11 -0700 (In reply to David Kilzer (:ddkilzer) from comment #3) > Comment on attachment 340570 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340570&action=review > > r=me > > > Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:90 > > + WebKit::WeakObjCPtr<_WKPreviewControllerDataSource> weakSelf { self }; > > FWIW, as of Bug 184789 / r230824, you can start using __weak directly. Not > sure how well that plays with C++ lambdas, though. This can just be a regular block, so __weak would be fine. However, I didn't see any other uses of __weak, so I just copied what is already used. > > > Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:93 > > + auto strongSelf = weakSelf.get(); > > + if (strongSelf) > > Nit: Could use: > > if ((auto strongSelf = weakSelf.get())) Thanks! 1424676 5 dino 2018-05-17 04:30:30 -0700 Committed r231893: <https://trac.webkit.org/changeset/231893> 340570 2018-05-17 04:04:13 -0700 2018-05-17 04:21:13 -0700 Patch bug-185722-20180517210411.patch text/plain 2622 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZiYjRkN2JiYmY3NzRkYjM1 NTIyODg4MTVkNjhlY2MyZTYwOGZkZWUuLjMxYzBjZDM5ZjA2NTM5N2Q0OWY4MjE4ZGM2MTBhNGQw YzlkNmQxNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTgtMDUtMTcgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFNhZmFyaSBvcHRpbWl6ZWQgZmxvdyBz aG91bGQgYmUgcmVsZWFzaW5nIHZpZXdlciB0byBwcmV2ZW50IG1lbW9yeSBncm93dGggd2l0aCBz dWJzZXF1ZW50IGxhdW5jaGVzL2Nsb3NlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NzIyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MDI0NzM1 MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIG1h ZGUgYSByb29raWUgbWlzdGFrZSBpbiB0aGUgb3JpZ2luYWwgcGF0Y2g6IEkgd2FzIGhvbGRpbmcg YSBzdHJvbmcKKyAgICAgICAgcmVmZXJlbmNlIHRvICJzZWxmIiBpbiBhIGJsb2NrLCB3aGljaCB3 YXMgY2F1c2luZyBhIHJldGFpbiBjeWNsZS4KKyAgICAgICAgUmVwbGFjZSB0aGF0IHdpdGggYSBX ZWFrT2JqQ1B0ci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9TeXN0ZW1QcmV2aWV3Q29u dHJvbGxlckNvY29hLm1tOgorICAgICAgICAoLVtfV0tQcmV2aWV3Q29udHJvbGxlckRhdGFTb3Vy Y2UgcHJldmlld0NvbnRyb2xsZXI6cHJldmlld0l0ZW1BdEluZGV4Ol0pOgorCiAyMDE4LTA1LTE2 ICBCYWJhayBTaGFmaWVpICA8YnNoYWZpZWlAYXBwbGUuY29tPgogCiAgICAgICAgIENoZXJyeS1w aWNrIHIyMzE4MjUuIHJkYXI6Ly9wcm9ibGVtLzQwMjc4MTgxCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TeXN0ZW1QcmV2aWV3Q29udHJvbGxlckNvY29hLm1tIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvU3lzdGVtUHJldmlld0NvbnRyb2xsZXJDb2Nv YS5tbQppbmRleCBjYzAxNGQ0ZGQzMTQ5OThjODA2NDg4NzgxOWMzMzZkNzYyNjA3NTRhLi44ODcz YzMwMmU1MTYzYWRjNDRmYTZiZTMwMDc2ZDE2YTRlNWY2OGU3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TeXN0ZW1QcmV2aWV3Q29udHJvbGxlckNvY29hLm1tCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1N5c3RlbVByZXZpZXdDb250cm9sbGVy Q29jb2EubW0KQEAgLTI5LDggKzI5LDggQEAKICNpZiBVU0UoU1lTVEVNX1BSRVZJRVcpCiAKICNp bXBvcnQgIkFQSVVJQ2xpZW50LmgiCisjaW1wb3J0ICJXZWFrT2JqQ1B0ci5oIgogI2ltcG9ydCAi V2ViUGFnZVByb3h5LmgiCi0KICNpbXBvcnQgPE1vYmlsZUNvcmVTZXJ2aWNlcy9Nb2JpbGVDb3Jl U2VydmljZXMuaD4KICNpbXBvcnQgPFF1aWNrTG9vay9RdWlja0xvb2suaD4KICNpbXBvcnQgPFVJ S2l0L1VJVmlld0NvbnRyb2xsZXIuaD4KQEAgLTg3LDkgKzg3LDExIEBAIFNPRlRfTElOS19DTEFT UyhRdWlja0xvb2ssIFFMSXRlbSk7CiAgICAgX2l0ZW0gPSBhZG9wdE5TKFthbGxvY1FMSXRlbUlu c3RhbmNlKCkgaW5pdFdpdGhQcmV2aWV3SXRlbVByb3ZpZGVyOl9pdGVtUHJvdmlkZXIuZ2V0KCkg Y29udGVudFR5cGU6Y29udGVudFR5cGUgcHJldmlld1RpdGxlOkAiUHJldmlldyIgZmlsZVNpemU6 QCgwKV0pOwogICAgIFtfaXRlbSBzZXRVc2VMb2FkaW5nVGltZW91dDpOT107CiAKLSAgICBbX2l0 ZW1Qcm92aWRlciByZWdpc3Rlckl0ZW1Gb3JUeXBlSWRlbnRpZmllcjpjb250ZW50VHlwZSBsb2Fk SGFuZGxlcjpeKE5TSXRlbVByb3ZpZGVyQ29tcGxldGlvbkhhbmRsZXIgY29tcGxldGlvbkhhbmRs ZXIsIENsYXNzIGV4cGVjdGVkVmFsdWVDbGFzcywgTlNEaWN0aW9uYXJ5ICogb3B0aW9ucykgewot ICAgICAgICAvLyBUaGlzIHdpbGwgZ2V0IGNhbGxlZCBvbmNlIHRoZSBkb3dubG9hZCBjb21wbGV0 ZXMuCi0gICAgICAgIHNlbGYuY29tcGxldGlvbkhhbmRsZXIgPSBjb21wbGV0aW9uSGFuZGxlcjsK KyAgICBXZWJLaXQ6OldlYWtPYmpDUHRyPF9XS1ByZXZpZXdDb250cm9sbGVyRGF0YVNvdXJjZT4g d2Vha1NlbGYgeyBzZWxmIH07CisgICAgW19pdGVtUHJvdmlkZXIgcmVnaXN0ZXJJdGVtRm9yVHlw ZUlkZW50aWZpZXI6Y29udGVudFR5cGUgbG9hZEhhbmRsZXI6W3dlYWtTZWxmID0gV1RGTW92ZSh3 ZWFrU2VsZildIChOU0l0ZW1Qcm92aWRlckNvbXBsZXRpb25IYW5kbGVyIGNvbXBsZXRpb25IYW5k bGVyLCBDbGFzcyBleHBlY3RlZFZhbHVlQ2xhc3MsIE5TRGljdGlvbmFyeSAqIG9wdGlvbnMpIHsK KyAgICAgICAgYXV0byBzdHJvbmdTZWxmID0gd2Vha1NlbGYuZ2V0KCk7CisgICAgICAgIGlmIChz dHJvbmdTZWxmKQorICAgICAgICAgICAgW3N0cm9uZ1NlbGYgc2V0Q29tcGxldGlvbkhhbmRsZXI6 Y29tcGxldGlvbkhhbmRsZXJdOwogICAgIH1dOwogICAgIHJldHVybiBfaXRlbS5nZXQoKTsKIH0K