185687 2018-05-16 10:29:11 -0700 REGRESSION(r230269): ASSERTION FAILED: sendRightCount == 1 at ProcessLauncherMac.mm(218) 2018-05-24 15:51:33 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez bfulgham andersca ap beidson cdumez commit-queue ddkilzer mitz oldest_to_newest 1424378 0 cdumez 2018-05-16 10:29:11 -0700 I frequently hit the following assertion when closing tabs: ASSERTION FAILED: sendRightCount == 1 /Volumes/Data/cdumez/WebKit/OpenSource/Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm(218) : auto WebKit::ProcessLauncher::launchProcess()::(anonymous class)::operator()(xpc_object_t) const 1 0x10f218e49 WTFCrash 2 0x114d327ab WebKit::ProcessLauncher::launchProcess()::$_0::operator()(NSObject<OS_xpc_object>*) const 3 0x114d326b1 invocation function for block in WebKit::ProcessLauncher::launchProcess()::$_0::operator void (NSObject<OS_xpc_object>*) block_pointer() const 4 0x7fff6241ae60 _xpc_connection_call_event_handler 5 0x7fff6241940b _xpc_connection_mach_event 6 0x7fff6219b1ff _dispatch_client_callout4 7 0x7fff6219d790 _dispatch_mach_cancel_invoke 8 0x7fff6219a12d _dispatch_mach_invoke 9 0x7fff621a0e21 _dispatch_main_queue_callback_4CF 10 0x7fff350aa395 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ 11 0x7fff35074f3c __CFRunLoopRun 12 0x7fff350743f5 CFRunLoopRunSpecific 13 0x7fff3431b79b RunCurrentEventLoopInMode 14 0x7fff3431b4d5 ReceiveNextEventCommon 15 0x7fff3431b252 _BlockUntilNextEventMatchingListInModeWithFilter 16 0x7fff32603a9e _DPSNextEvent 17 0x7fff32d49b76 -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] 18 0x10cb99590 -[BrowserApplication nextEventMatchingMask:untilDate:inMode:dequeue:] 19 0x7fff325f91a5 -[NSApplication run] 20 0x7fff325c8c70 NSApplicationMain 21 0x10d4955aa SafariMain 22 0x10c9ddf82 main 23 0x7fff621d18d1 start 24 0x1 This assertion was added recently by Brent. 1426981 1 bfulgham 2018-05-24 10:46:18 -0700 This assertion was meant to help identify cases where we had poor bookkeeping and attempted to remove send rights that we did not have. Limiting the assertion to a single send-right is probably too conservative, since the port could have been granted other send-rights during other operations. I do think it would be worrisome to attempt to remove a send right when we don't have one (that would indicate an out-of-balance condition, and possible corruption of the port space). Let's change the assertion to check that we have AT LEAST ONE send right before we remove it. 1426986 2 bfulgham 2018-05-24 10:52:01 -0700 <rdar://problem/39386361> 1426990 3 341209 bfulgham 2018-05-24 11:02:54 -0700 Created attachment 341209 Patch 1427018 4 341209 commit-queue 2018-05-24 12:32:18 -0700 Comment on attachment 341209 Patch Clearing flags on attachment: 341209 Committed r232160: <https://trac.webkit.org/changeset/232160> 1427019 5 commit-queue 2018-05-24 12:32:20 -0700 All reviewed patches have been landed. Closing bug. 1427077 6 341209 andersca 2018-05-24 14:58:24 -0700 Comment on attachment 341209 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=341209&action=review > Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm:218 > - ASSERT(sendRightCount == 1); > + ASSERT(sendRightCount >= 1); This essentially checks that sendRightsCount is not 0. Is it possible to have a port with zero send rights? 1427083 7 bfulgham 2018-05-24 15:51:33 -0700 (In reply to Anders Carlsson from comment #6) > Comment on attachment 341209 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=341209&action=review > > > Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm:218 > > - ASSERT(sendRightCount == 1); > > + ASSERT(sendRightCount >= 1); > > This essentially checks that sendRightsCount is not 0. Is it possible to > have a port with zero send rights? Yes - though I'm not sure under what circumstances that happens. Apparently you can pass send rights around, but I don't believe WebKit attempts to do that. 341209 2018-05-24 11:02:54 -0700 2018-05-24 12:32:18 -0700 Patch bug-185687-20180524110254.patch text/plain 2503 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjMyMTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI4ZWRjMTIxZmIxNWE4ZjBl YjJkNTVhNjliY2RiZDVkMGNjMzYwZTMuLmY1NTg1YWI2MWE4ZmRjMWRiMjBjYTRmZGQ0OTYxZDky YzM3ODg3YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTgtMDUtMjQgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjMwMjY5 KTogQVNTRVJUSU9OIEZBSUxFRDogc2VuZFJpZ2h0Q291bnQgPT0gMSBhdCBQcm9jZXNzTGF1bmNo ZXJNYWMubW0oMjE4KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg1Njg3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTM4NjM2MT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiByMjMwMjY5IEkgYWRk ZWQgYW4gYXNzZXJ0aW9uIHRvIGhlbHAgaWRlbnRpZnkgY2FzZXMgd2hlcmUgd2Ugd2VyZSBkb2lu ZyBiYWQKKyAgICAgICAgYm9va2tlZXBpbmcgaW4gb3VyIHBvcnQgc2VuZCByaWdodHMuIEkgYXNz dW1lZCB0aGF0IGJlY2F1c2Ugd2Ugd2VyZSBhZGRpbmcKKyAgICAgICAgb25lIHNlbmQgcmlnaHQs IHRoYXQgd2hlbiB3ZSB3ZW50IHRvIGNsb3NlIGRvd24gdGhlIGNvbm5lY3Rpb24gdGhhdCB3ZSBz aG91bGQKKyAgICAgICAgaGF2ZSBvbmx5IG9uZSBzZW5kIHJpZ2h0LgorICAgICAgICAKKyAgICAg ICAgSSBoYXZlIHNpbmNlIGRpc2NvdmVyZWQgdGhhdCB0aGlzIGFzc3VtcHRpb24gaXMgaW52YWxp ZCwgYW5kIHRoYXQgSSBzaG91bGQKKyAgICAgICAgb25seSBiZSBjaGVja2luZyB0aGF0IHdlIGhh dmUgQVQgTEVBU1QgT05FIHNlbmQgcmlnaHQgYXQgdGhlIHRpbWUgd2UgYXR0ZW1wdAorICAgICAg ICB0byByZW1vdmUgaXQuCisKKyAgICAgICAgVGhpcyBwYXRjaCBjaGFuZ2VzIHRoZSBhc3NlcnRp b24gdG8gY29uZmlybSB0aGF0IHdlIGhhdmUgYXQgbGVhc3Qgb25lIHNlbmQKKyAgICAgICAgcmln aHQgYmVmb3JlIHdlIHJlbW92ZSB0aGUgc2VuZCByaWdodC4KKworICAgICAgICAqIFVJUHJvY2Vz cy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpQ cm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MpOgorCiAyMDE4LTA1LTIzICBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBOZXR3b3JrTG9hZENoZWNrZXIgc2hv dWxkIGNoZWNrIGNhY2hlZCByZWRpcmVjdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW0gYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5jaGVyTWFjLm1tCmluZGV4IDI0 Yzc5ZWNkYWZhZDM1ODU1ZGU4OGQxMThhNTQ5YzVhNzQ0ODU3OTguLjhkYWZiMTNiNTExYzFjZDZj NzI5N2EwOTQ0M2MzYWVhNjMwYzlkMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW0KKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NMYXVuY2hlck1hYy5tbQpAQCAtMjE1LDcg KzIxNSw3IEBAIHZvaWQgUHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKCkKICNpZm5kZWYg X05ERUJVRwogICAgICAgICBtYWNoX3BvcnRfdXJlZnNfdCBzZW5kUmlnaHRDb3VudCA9IDA7CiAg ICAgICAgIG1hY2hfcG9ydF9nZXRfcmVmcyhtYWNoX3Rhc2tfc2VsZigpLCBsaXN0ZW5pbmdQb3J0 LCBNQUNIX1BPUlRfUklHSFRfU0VORCwgJnNlbmRSaWdodENvdW50KTsKLSAgICAgICAgQVNTRVJU KHNlbmRSaWdodENvdW50ID09IDEpOworICAgICAgICBBU1NFUlQoc2VuZFJpZ2h0Q291bnQgPj0g MSk7CiAjZW5kaWYKIAogICAgICAgICAvLyBXZSBmYWlsZWQgdG8gbGF1bmNoLiBSZWxlYXNlIHRo ZSBzZW5kIHJpZ2h0LgpAQCAtMjUyLDcgKzI1Miw3IEBAIHZvaWQgUHJvY2Vzc0xhdW5jaGVyOjps YXVuY2hQcm9jZXNzKCkKICNpZm5kZWYgX05ERUJVRwogICAgICAgICAgICAgbWFjaF9wb3J0X3Vy ZWZzX3Qgc2VuZFJpZ2h0Q291bnQgPSAwOwogICAgICAgICAgICAgbWFjaF9wb3J0X2dldF9yZWZz KG1hY2hfdGFza19zZWxmKCksIGxpc3RlbmluZ1BvcnQsIE1BQ0hfUE9SVF9SSUdIVF9TRU5ELCAm c2VuZFJpZ2h0Q291bnQpOwotICAgICAgICAgICAgQVNTRVJUKHNlbmRSaWdodENvdW50ID09IDEp OworICAgICAgICAgICAgQVNTRVJUKHNlbmRSaWdodENvdW50ID49IDEpOwogI2VuZGlmCiAKICAg ICAgICAgICAgIGRlYWxsb2NhdGVTZW5kUmlnaHRTYWZlbHkobGlzdGVuaW5nUG9ydCk7Cg==