185671 2018-05-15 18:28:40 -0700 StorageManager::deleteLocalStorageOriginsModifiedSince: database files get deleted before database connections close 2018-05-15 21:44:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu commit-queue ggaren sihui_liu webkit-bug-importer oldest_to_newest 1424211 0 sihui_liu 2018-05-15 18:28:40 -0700 We should always close the database before unlinking database file. 1424213 1 340461 sihui_liu 2018-05-15 18:41:46 -0700 Created attachment 340461 Patch 1424232 2 340461 ggaren 2018-05-15 21:15:42 -0700 Comment on attachment 340461 Patch r=me 1424233 3 340461 commit-queue 2018-05-15 21:43:20 -0700 Comment on attachment 340461 Patch Clearing flags on attachment: 340461 Committed r231837: <https://trac.webkit.org/changeset/231837> 1424234 4 commit-queue 2018-05-15 21:43:21 -0700 All reviewed patches have been landed. Closing bug. 1424235 5 webkit-bug-importer 2018-05-15 21:44:19 -0700 <rdar://problem/40283939> 340461 2018-05-15 18:41:46 -0700 2018-05-15 21:43:20 -0700 Patch bug-185671-20180515184145.patch text/plain 6052 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxODI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNmMGU3YzYxNGIxMDc2NGNk NmIwYzA4MmU1NTIxYzg5MjcxODM3YzkuLmNjZjA5ZDg3YzRkMjdmZGRjYWFjMmUzZTAxZTJjMmRl ZjUzOGM5ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDUtMTUgIFNpaHVpIExp dSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcmFnZU1hbmFnZXI6OmRlbGV0 ZUxvY2FsU3RvcmFnZU9yaWdpbnNNb2RpZmllZFNpbmNlOiBkYXRhYmFzZSBmaWxlcyBnZXQgZGVs ZXRlZCBiZWZvcmUgZGF0YWJhc2UgY29ubmVjdGlvbnMgY2xvc2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTY3MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBkZWxldGUgZGF0YWJhc2Ug ZmlsZXMgYmVmb3JlIGNsb3NpbmcgZGF0YWJhc2VzLgorCisgICAgICAgICogVUlQcm9jZXNzL1dl YlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpMb2Nh bFN0b3JhZ2VEYXRhYmFzZTo6dXBkYXRlRGF0YWJhc2VXaXRoQ2hhbmdlZEl0ZW1zKToKKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXIuY3Bw OgorICAgICAgICAoV2ViS2l0OjpMb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXI6OmRhdGFiYXNl c01vZGlmaWVkU2luY2UpOgorICAgICAgICAoV2ViS2l0OjpMb2NhbFN0b3JhZ2VEYXRhYmFzZVRy YWNrZXI6OmRlbGV0ZURhdGFiYXNlc01vZGlmaWVkU2luY2UpOiBEZWxldGVkLgorICAgICAgICAq IFVJUHJvY2Vzcy9XZWJTdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlVHJhY2tlci5oOgorICAg ICAgICAqIFVJUHJvY2Vzcy9XZWJTdG9yYWdlL1N0b3JhZ2VNYW5hZ2VyLmNwcDoKKyAgICAgICAg KFdlYktpdDo6U3RvcmFnZU1hbmFnZXI6OmRlbGV0ZUxvY2FsU3RvcmFnZU9yaWdpbnNNb2RpZmll ZFNpbmNlKToKKwogMjAxOC0wNS0xNSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAK ICAgICAgICAgTGF1bmNoIFN5c3RlbSBQcmV2aWV3IGFzIHRoZSBkb3dubG9hZCBzdGFydHMsIHJh dGhlciB0aGFuIHdhaXRpbmcgZm9yIGEgcmVzcG9uc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyLmNwcCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2VU cmFja2VyLmNwcAppbmRleCA4MjExMDJiN2JlMWY4Mjg4OWY0OGI0ZDBlYjNmYmNkZTk5NGFhZGRm Li5jYTU2ZDA1N2RlYzQwNjI1YzA3MjU4ZTY4MzBlMzBiYjVmNjBiYzQyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJTdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlVHJh Y2tlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViU3RvcmFnZS9Mb2NhbFN0 b3JhZ2VEYXRhYmFzZVRyYWNrZXIuY3BwCkBAIC0xNDIsMzMgKzE0MiwzMSBAQCBzdGF0aWMgc3Rk OjpvcHRpb25hbDx0aW1lX3Q+IGZpbGVNb2RpZmljYXRpb25UaW1lKGNvbnN0IFN0cmluZyYgZmls ZVBhdGgpCiAgICAgcmV0dXJuIHRpbWU7CiB9CiAKLVZlY3RvcjxTZWN1cml0eU9yaWdpbkRhdGE+ IExvY2FsU3RvcmFnZURhdGFiYXNlVHJhY2tlcjo6ZGVsZXRlRGF0YWJhc2VzTW9kaWZpZWRTaW5j ZShXYWxsVGltZSB0aW1lKQorVmVjdG9yPFNlY3VyaXR5T3JpZ2luRGF0YT4gTG9jYWxTdG9yYWdl RGF0YWJhc2VUcmFja2VyOjpkYXRhYmFzZXNNb2RpZmllZFNpbmNlKFdhbGxUaW1lIHRpbWUpCiB7 CiAgICAgQVNTRVJUKCFSdW5Mb29wOjppc01haW4oKSk7CiAgICAgaW1wb3J0T3JpZ2luSWRlbnRp ZmllcnMoKTsKLSAgICBWZWN0b3I8U3RyaW5nPiBvcmlnaW5JZGVudGlmaWVyc1RvRGVsZXRlOwot CisgICAgVmVjdG9yPFN0cmluZz4gb3JpZ2luSWRlbnRpZmllcnNNb2RpZmllZDsKKyAgICAKICAg ICBmb3IgKGNvbnN0IFN0cmluZyYgb3JpZ2luIDogbV9vcmlnaW5zKSB7CiAgICAgICAgIFN0cmlu ZyBmaWxlUGF0aCA9IHBhdGhGb3JEYXRhYmFzZVdpdGhPcmlnaW5JZGVudGlmaWVyKG9yaWdpbik7 Ci0KKyAgICAgICAgCiAgICAgICAgIGF1dG8gbW9kaWZpY2F0aW9uVGltZSA9IEZpbGVTeXN0ZW06 OmdldEZpbGVNb2RpZmljYXRpb25UaW1lKGZpbGVQYXRoKTsKICAgICAgICAgaWYgKCFtb2RpZmlj YXRpb25UaW1lIHx8IG1vZGlmaWNhdGlvblRpbWUudmFsdWUoKSA+PSB0aW1lKQotICAgICAgICAg ICAgb3JpZ2luSWRlbnRpZmllcnNUb0RlbGV0ZS5hcHBlbmQob3JpZ2luKTsKKyAgICAgICAgICAg IG9yaWdpbklkZW50aWZpZXJzTW9kaWZpZWQuYXBwZW5kKG9yaWdpbik7CiAgICAgfQotCi0gICAg VmVjdG9yPFNlY3VyaXR5T3JpZ2luRGF0YT4gZGVsZXRlZERhdGFiYXNlT3JpZ2luczsKLSAgICBk ZWxldGVkRGF0YWJhc2VPcmlnaW5zLnJlc2VydmVJbml0aWFsQ2FwYWNpdHkob3JpZ2luSWRlbnRp ZmllcnNUb0RlbGV0ZS5zaXplKCkpOwotCi0gICAgZm9yIChjb25zdCBhdXRvJiBvcmlnaW5JZGVu dGlmaWVyIDogb3JpZ2luSWRlbnRpZmllcnNUb0RlbGV0ZSkgewotICAgICAgICByZW1vdmVEYXRh YmFzZVdpdGhPcmlnaW5JZGVudGlmaWVyKG9yaWdpbklkZW50aWZpZXIpOwotCisgICAgCisgICAg VmVjdG9yPFNlY3VyaXR5T3JpZ2luRGF0YT4gZGF0YWJhc2VPcmlnaW5zTW9kaWZpZWQ7CisgICAg ZGF0YWJhc2VPcmlnaW5zTW9kaWZpZWQucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShvcmlnaW5JZGVu dGlmaWVyc01vZGlmaWVkLnNpemUoKSk7CisgICAgCisgICAgZm9yIChjb25zdCBhdXRvJiBvcmln aW5JZGVudGlmaWVyIDogb3JpZ2luSWRlbnRpZmllcnNNb2RpZmllZCkgewogICAgICAgICBpZiAo YXV0byBvcmlnaW4gPSBTZWN1cml0eU9yaWdpbkRhdGE6OmZyb21EYXRhYmFzZUlkZW50aWZpZXIo b3JpZ2luSWRlbnRpZmllcikpCi0gICAgICAgICAgICBkZWxldGVkRGF0YWJhc2VPcmlnaW5zLnVu Y2hlY2tlZEFwcGVuZCgqb3JpZ2luKTsKKyAgICAgICAgICAgIGRhdGFiYXNlT3JpZ2luc01vZGlm aWVkLnVuY2hlY2tlZEFwcGVuZCgqb3JpZ2luKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAg QVNTRVJUX05PVF9SRUFDSEVEKCk7CiAgICAgfQotCi0gICAgcmV0dXJuIGRlbGV0ZWREYXRhYmFz ZU9yaWdpbnM7CisgICAgCisgICAgcmV0dXJuIGRhdGFiYXNlT3JpZ2luc01vZGlmaWVkOwogfQog CiBWZWN0b3I8U2VjdXJpdHlPcmlnaW5EYXRhPiBMb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXI6 Om9yaWdpbnMoKSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi U3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXIuaCBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYlN0b3JhZ2UvTG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyLmgKaW5kZXggNTY3 OWE4M2Q3OTM2OTYxYTkyMzI0MDI1MmUxM2M1NjE3YmM1YzI0NC4uNjNkZTk2ZjY5YzJlYjQwNTRl MTJhNjE0MDlkMzU3MmJhOGFhZDU2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvV2ViU3RvcmFnZS9Mb2NhbFN0b3JhZ2VEYXRhYmFzZVRyYWNrZXIuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJTdG9yYWdlL0xvY2FsU3RvcmFnZURhdGFiYXNlVHJhY2tlci5o CkBAIC01NSw4ICs1NSw4IEBAIHB1YmxpYzoKICAgICB2b2lkIGRlbGV0ZURhdGFiYXNlV2l0aE9y aWdpbihjb25zdCBXZWJDb3JlOjpTZWN1cml0eU9yaWdpbkRhdGEmKTsKICAgICB2b2lkIGRlbGV0 ZUFsbERhdGFiYXNlcygpOwogCi0gICAgLy8gUmV0dXJucyBhIHZlY3RvciBvZiB0aGUgb3JpZ2lu cyB3aG9zZSBkYXRhYmFzZXMgaGF2ZSBiZWVuIGRlbGV0ZWQuCi0gICAgVmVjdG9yPFdlYkNvcmU6 OlNlY3VyaXR5T3JpZ2luRGF0YT4gZGVsZXRlRGF0YWJhc2VzTW9kaWZpZWRTaW5jZShXYWxsVGlt ZSk7CisgICAgLy8gUmV0dXJucyBhIHZlY3RvciBvZiB0aGUgb3JpZ2lucyB3aG9zZSBkYXRhYmFz ZXMgc2hvdWxkIGJlIGRlbGV0ZWQuCisgICAgVmVjdG9yPFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2lu RGF0YT4gZGF0YWJhc2VzTW9kaWZpZWRTaW5jZShXYWxsVGltZSk7CiAKICAgICBWZWN0b3I8V2Vi Q29yZTo6U2VjdXJpdHlPcmlnaW5EYXRhPiBvcmlnaW5zKCkgY29uc3Q7CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlN0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuY3BwIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5jcHAKaW5k ZXggN2Y3MDJlMThlYjNhNjdkYmU0NzZlNjkzYTBmNDIwZDEzYjRjZjc2OS4uOTU4MzE3NWUzOTRm MzM5NTM1YmM2NDIyMjAzNzRhNzYzMWYwZTcxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2ViU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViU3RvcmFnZS9TdG9yYWdlTWFuYWdlci5jcHAKQEAgLTYxOCwxNiArNjE4 LDE4IEBAIHZvaWQgU3RvcmFnZU1hbmFnZXI6OmRlbGV0ZUxvY2FsU3RvcmFnZUVudHJpZXNGb3JP cmlnaW4oY29uc3QgU2VjdXJpdHlPcmlnaW5EYXRhCiB2b2lkIFN0b3JhZ2VNYW5hZ2VyOjpkZWxl dGVMb2NhbFN0b3JhZ2VPcmlnaW5zTW9kaWZpZWRTaW5jZShXYWxsVGltZSB0aW1lLCBGdW5jdGlv bjx2b2lkKCk+JiYgY29tcGxldGlvbkhhbmRsZXIpCiB7CiAgICAgbV9xdWV1ZS0+ZGlzcGF0Y2go W3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKSwgdGltZSwgY29tcGxldGlvbkhh bmRsZXIgPSBXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKV0oKSBtdXRhYmxlIHsKLSAgICAgICAg YXV0byBkZWxldGVkT3JpZ2lucyA9IG1fbG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyLT5kZWxl dGVEYXRhYmFzZXNNb2RpZmllZFNpbmNlKHRpbWUpOworICAgICAgICBhdXRvIG9yaWdpbnNUb0Rl bGV0ZSA9IG1fbG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFja2VyLT5kYXRhYmFzZXNNb2RpZmllZFNp bmNlKHRpbWUpOworICAgICAgICAKKyAgICAgICAgZm9yIChhdXRvJiB0cmFuc2llbnRMb2NhbFN0 b3JhZ2VOYW1lc3BhY2UgOiBtX3RyYW5zaWVudExvY2FsU3RvcmFnZU5hbWVzcGFjZXMudmFsdWVz KCkpCisgICAgICAgICAgICB0cmFuc2llbnRMb2NhbFN0b3JhZ2VOYW1lc3BhY2UtPmNsZWFyQWxs U3RvcmFnZUFyZWFzKCk7CiAKLSAgICAgICAgZm9yIChjb25zdCBhdXRvJiBvcmlnaW4gOiBkZWxl dGVkT3JpZ2lucykgeworICAgICAgICBmb3IgKGNvbnN0IGF1dG8mIG9yaWdpbiA6IG9yaWdpbnNU b0RlbGV0ZSkgewogICAgICAgICAgICAgZm9yIChhdXRvJiBsb2NhbFN0b3JhZ2VOYW1lc3BhY2Ug OiBtX2xvY2FsU3RvcmFnZU5hbWVzcGFjZXMudmFsdWVzKCkpCiAgICAgICAgICAgICAgICAgbG9j YWxTdG9yYWdlTmFtZXNwYWNlLT5jbGVhclN0b3JhZ2VBcmVhc01hdGNoaW5nT3JpZ2luKG9yaWdp bik7CisgICAgICAgICAgICAKKyAgICAgICAgICAgIG1fbG9jYWxTdG9yYWdlRGF0YWJhc2VUcmFj a2VyLT5kZWxldGVEYXRhYmFzZVdpdGhPcmlnaW4ob3JpZ2luKTsKICAgICAgICAgfQogCi0gICAg ICAgIGZvciAoYXV0byYgdHJhbnNpZW50TG9jYWxTdG9yYWdlTmFtZXNwYWNlIDogbV90cmFuc2ll bnRMb2NhbFN0b3JhZ2VOYW1lc3BhY2VzLnZhbHVlcygpKQotICAgICAgICAgICAgdHJhbnNpZW50 TG9jYWxTdG9yYWdlTmFtZXNwYWNlLT5jbGVhckFsbFN0b3JhZ2VBcmVhcygpOwotCiAgICAgICAg IFJ1bkxvb3A6Om1haW4oKS5kaXNwYXRjaChXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CiAg ICAgfSk7CiB9Cg==