185648 2018-05-15 03:21:19 -0700 Update animation when presenting QuickLook 2018-05-15 03:37:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino graouts webkit-bug-importer oldest_to_newest 1423979 0 dino 2018-05-15 03:21:19 -0700 Update animation when presenting QuickLook 1423981 1 dino 2018-05-15 03:21:54 -0700 <rdar://problem/39652624> 1423984 2 340402 dino 2018-05-15 03:25:19 -0700 Created attachment 340402 Patch 1423985 3 340402 graouts 2018-05-15 03:29:24 -0700 Comment on attachment 340402 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340402&action=review > Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:142 > + frame = CGRectMake(CGRectGetMidX(frame) - 5, CGRectGetMidY(frame) - 5, 10, 10); You should make 10 a named constant and replace 5 with half that value. 1423986 4 340402 dino 2018-05-15 03:30:07 -0700 Comment on attachment 340402 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340402&action=review >> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:142 >> + frame = CGRectMake(CGRectGetMidX(frame) - 5, CGRectGetMidY(frame) - 5, 10, 10); > > You should make 10 a named constant and replace 5 with half that value. I think I'll make the rect 50% of the width and height instead. 1423989 5 dino 2018-05-15 03:37:38 -0700 Committed r231797: <https://trac.webkit.org/changeset/231797> 340402 2018-05-15 03:25:19 -0700 2018-05-15 03:29:24 -0700 Patch bug-185648-20180515202517.patch text/plain 2780 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDNiZjA1YjJjZDM3OWU0ZTlk NWM0NWY2NGM5MjU2MDk3OGY5YjNmYjUuLmRjZTIyNmZmZDA2MjU0MGEyOTcyZmQ2NGFiNmQ3MjI0 NmEyNWNlYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgtMDUtMTUgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBhbmltYXRpb24gd2hlbiBw cmVzZW50aW5nIFF1aWNrTG9vaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg1NjQ4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTY1MjYyND4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQg dGhlIFF1aWNrTG9vayBkZWxlZ2F0ZSBvbiBfV0tQcmV2aWV3Q29udHJvbGxlckRlbGVnYXRlIHRo YXQKKyAgICAgICAgcHJvZHVjZXMgYSB6b29tLWxpa2UgYW5pbWF0aW9uIHdoZW4gdGhlIFFMUHJl dmlld0NvbnRyb2xsZXIgYXBwZWFycy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9TeXN0 ZW1QcmV2aWV3Q29udHJvbGxlckNvY29hLm1tOgorICAgICAgICAoLVtfV0tQcmV2aWV3Q29udHJv bGxlckRlbGVnYXRlIHByZXZpZXdDb250cm9sbGVyOmZyYW1lRm9yUHJldmlld0l0ZW06aW5Tb3Vy Y2VWaWV3Ol0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9TeXN0ZW1QcmV2aWV3Q29udHJvbGxlci5o OiBBZGQgYSByZWZlcmVuY2UgYmFjayB0byB0aGUgcGFnZSwgc28gdGhhdAorICAgICAgICB0aGUg ZGVsZWdhdGUgaW1wbGVtZW50YXRpb24gY2FuIGFjY2VzcyB0aGUgcHJlc2VudGluZ1ZpZXdDb250 cm9sbGVyLgorICAgICAgICAoV2ViS2l0OjpTeXN0ZW1QcmV2aWV3Q29udHJvbGxlcjo6cGFnZSk6 CisKIDIwMTgtMDUtMTQgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAg IERvd25sb2FkIGFuZCBwcmVzZW50IFN5c3RlbSBQcmV2aWV3CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TeXN0ZW1QcmV2aWV3Q29udHJvbGxlckNvY29hLm1tIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvU3lzdGVtUHJldmlld0NvbnRyb2xsZXJDb2Nv YS5tbQppbmRleCA0YmFhZWJhNTRhNjYwMTVmMjJjMDJjZWI0MjY1NWZmOGVmYzgyODUwLi4zYTdj ZjY3NTM4NDFjODAwMTZhOGE3ZjdmZTgwY2JkMmQ0ZjVjNjM3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9TeXN0ZW1QcmV2aWV3Q29udHJvbGxlckNvY29hLm1tCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1N5c3RlbVByZXZpZXdDb250cm9sbGVy Q29jb2EubW0KQEAgLTEyNiw2ICsxMjYsMjMgQEAgU09GVF9MSU5LX0NMQVNTKFF1aWNrTG9vaywg UUxJdGVtKTsKICAgICBpZiAoX3ByZXZpZXdDb250cm9sbGVyKQogICAgICAgICBfcHJldmlld0Nv bnRyb2xsZXItPmNhbmNlbCgpOwogfQorCistIChDR1JlY3QpcHJldmlld0NvbnRyb2xsZXI6KFFM UHJldmlld0NvbnRyb2xsZXIgKiljb250cm9sbGVyIGZyYW1lRm9yUHJldmlld0l0ZW06KGlkIDxR TFByZXZpZXdJdGVtPilpdGVtIGluU291cmNlVmlldzooVUlWaWV3ICogKil2aWV3Cit7CisgICAg aWYgKCFfcHJldmlld0NvbnRyb2xsZXIpCisgICAgICAgIHJldHVybiBDR1JlY3RaZXJvOworCisg ICAgVUlWaWV3Q29udHJvbGxlciAqcHJlc2VudGluZ1ZpZXdDb250cm9sbGVyID0gX3ByZXZpZXdD b250cm9sbGVyLT5wYWdlKCkudWlDbGllbnQoKS5wcmVzZW50aW5nVmlld0NvbnRyb2xsZXIoKTsK KworICAgIGlmICghcHJlc2VudGluZ1ZpZXdDb250cm9sbGVyKQorICAgICAgICByZXR1cm4gQ0dS ZWN0WmVybzsKKworICAgIENHUmVjdCBmcmFtZSA9IHByZXNlbnRpbmdWaWV3Q29udHJvbGxlci52 aWV3LmZyYW1lOworICAgIC8vIENyZWF0ZSBhIHNtYWxsIHJlY3RhbmdsZSBjZW50ZXJlZCBpbiB0 aGUgZnJhbWUuCisgICAgZnJhbWUgPSBDR1JlY3RNYWtlKENHUmVjdEdldE1pZFgoZnJhbWUpIC0g NSwgQ0dSZWN0R2V0TWlkWShmcmFtZSkgLSA1LCAxMCwgMTApOworICAgIHJldHVybiBmcmFtZTsK K30KKwogQGVuZAogCiBuYW1lc3BhY2UgV2ViS2l0IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1N5c3RlbVByZXZpZXdDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9TeXN0ZW1QcmV2aWV3Q29udHJvbGxlci5oCmluZGV4IGY5ZDRjOWE4ODMxNDAzMDVh YTgyNTlmNDNmNDJlMTkyOGU0OTIyMWIuLjgwNGIyMjhiY2MyMTQxNTgzNDA4YWQ2OTE4NjUwZTk5 OTQwMjQxYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1N5c3RlbVByZXZp ZXdDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvU3lzdGVtUHJldmll d0NvbnRyb2xsZXIuaApAQCAtNTEsNiArNTEsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBmaW5pc2go V2ViQ29yZTo6VVJMKTsKICAgICB2b2lkIGNhbmNlbCgpOwogCisgICAgV2ViUGFnZVByb3h5JiBw YWdlKCkgeyByZXR1cm4gbV93ZWJQYWdlUHJveHk7IH0KKwogcHJpdmF0ZToKICAgICBXZWJQYWdl UHJveHkmIG1fd2ViUGFnZVByb3h5OwogI2lmIFVTRShRVUlDS19MT09LKQo=