185633 2018-05-14 16:16:05 -0700 [LFC] FormattingContext:computeOutOfFlowNonReplacedHeight/Width should use the computed margins/paddings/borders 2018-05-15 03:21:39 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1423846 0 zalan 2018-05-14 16:16:05 -0700 By the time we start computing height and width, DisplayBox should already have the computed values. 1423850 1 340374 zalan 2018-05-14 16:18:33 -0700 Created attachment 340374 Patch 1423890 2 340374 commit-queue 2018-05-14 18:31:26 -0700 Comment on attachment 340374 Patch Clearing flags on attachment: 340374 Committed r231780: <https://trac.webkit.org/changeset/231780> 1423891 3 commit-queue 2018-05-14 18:31:27 -0700 All reviewed patches have been landed. Closing bug. 1423980 4 webkit-bug-importer 2018-05-15 03:21:39 -0700 <rdar://problem/40251739> 340374 2018-05-14 16:18:33 -0700 2018-05-14 18:31:26 -0700 Patch bug-185633-20180514161831.patch text/plain 6978 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNzU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGVjYmQ4MGQwMTk5ZDhk NmNiZWYxZGQ0MGM1MzU3NDZhMTNlMDVkNi4uODRjZWI4YjkxMDMyOGUyYWM1ZWViOTk0ODk2NzVl MzA2Njk4MzI5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE4LTA1LTE0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gRm9ybWF0dGluZ0Nv bnRleHQ6Y29tcHV0ZU91dE9mRmxvd05vblJlcGxhY2VkSGVpZ2h0L1dpZHRoIHNob3VsZCB1c2Ug dGhlIGNvbXB1dGVkIG1hcmdpbnMvcGFkZGluZ3MvYm9yZGVycworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NjMzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnkgdGhlIHRpbWUgd2Ugc3RhcnQgY29tcHV0 aW5nIGhlaWdodCBhbmQgd2lkdGgsIERpc3BsYXlCb3ggc2hvdWxkIGFscmVhZHkgaGF2ZSB0aGUg Y29tcHV0ZWQgdmFsdWVzIGZvciBtYXJnaW4vcGFkZGluZy9ib3JkZXIuCisKKyAgICAgICAgKiBs YXlvdXQvRm9ybWF0dGluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpG b3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZU91dE9mRmxvd05vblJlcGxhY2VkSGVpZ2h0IGNvbnN0 KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6Rm9ybWF0dGluZ0NvbnRleHQ6OmNvbXB1dGVP dXRPZkZsb3dOb25SZXBsYWNlZFdpZHRoIGNvbnN0KToKKyAgICAgICAgKiBsYXlvdXQvZGlzcGxh eXRyZWUvRGlzcGxheUJveC5oOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheTo6Qm94OjpwYWRk aW5nVG9wIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6OkJveDo6cGFkZGluZ0xl ZnQgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheTo6Qm94OjpwYWRkaW5nQm90dG9t IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6OkJveDo6cGFkZGluZ1JpZ2h0IGNv bnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6OkJveDo6Ym9yZGVyVG9wIGNvbnN0KToK KyAgICAgICAgKFdlYkNvcmU6OkRpc3BsYXk6OkJveDo6Ym9yZGVyTGVmdCBjb25zdCk6CisgICAg ICAgIChXZWJDb3JlOjpEaXNwbGF5OjpCb3g6OmJvcmRlckJvdHRvbSBjb25zdCk6CisgICAgICAg IChXZWJDb3JlOjpEaXNwbGF5OjpCb3g6OmJvcmRlclJpZ2h0IGNvbnN0KToKKwogMjAxOC0wNS0x NCAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdIEltcGxl bWVudCBoZWlnaHQgY29tcHV0YXRpb24gZm9yIG5vbi1yZXBsYWNlZCBvdXQgb2YgZmxvdyBlbGVt ZW50cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4 dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRm9ybWF0dGluZ0NvbnRleHQuY3BwCmluZGV4 IDhkYTcwZGVlOGUwOGE2N2ZmZTI4MWZjZjA4ZjQzOGRhY2IzOTE1NGEuLmZlMTA2OWExOGM3YjNi YTc3Y2Q5NzNmOThjMDEwM2ZmYjg2ZTM4MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9Gb3JtYXR0aW5nQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zv cm1hdHRpbmdDb250ZXh0LmNwcApAQCAtMTg1LDE3ICsxODUsMTYgQEAgdm9pZCBGb3JtYXR0aW5n Q29udGV4dDo6Y29tcHV0ZU91dE9mRmxvd05vblJlcGxhY2VkSGVpZ2h0KExheW91dENvbnRleHQm IGxheW91dEMKICAgICAgICAgY29tcHV0ZWRIZWlnaHRWYWx1ZSA9IGNvbnRlbnRIZWlnaHRGb3JG b3JtYXR0aW5nQ29udGV4dFJvb3QobGF5b3V0Q29udGV4dCwgbGF5b3V0Qm94KTsKICAgICB9IGVs c2UgaWYgKCF0b3AuaXNBdXRvKCkgJiYgaGVpZ2h0LmlzQXV0bygpICYmICFib3R0b20uaXNBdXRv KCkpIHsKICAgICAgICAgLy8gIzUKLSAgICAgICAgYXV0byBtYXJnaW5Ub3AgPSBzdHlsZS5tYXJn aW5Ub3AoKS5pc0F1dG8oKSA/IExheW91dFVuaXQoKSA6IHZhbHVlRm9yTGVuZ3RoKHN0eWxlLm1h cmdpblRvcCgpLCBjb250YWluaW5nQmxvY2tIZWlnaHQpOwotICAgICAgICBhdXRvIG1hcmdpbkJv dHRvbSA9IHN0eWxlLm1hcmdpbkJvdHRvbSgpLmlzQXV0bygpID8gTGF5b3V0VW5pdCgpIDogdmFs dWVGb3JMZW5ndGgoc3R5bGUubWFyZ2luQm90dG9tKCksIGNvbnRhaW5pbmdCbG9ja0hlaWdodCk7 CisgICAgICAgIGF1dG8gbWFyZ2luVG9wID0gZGlzcGxheUJveC5tYXJnaW5Ub3AoKTsKKyAgICAg ICAgYXV0byBtYXJnaW5Cb3R0b20gPSBkaXNwbGF5Qm94Lm1hcmdpbkJvdHRvbSgpOwogICAgIAot ICAgICAgICBhdXRvIGNvbnRhaW5pbmdCbG9ja1dpZHRoID0gbGF5b3V0Q29udGV4dC5kaXNwbGF5 Qm94Rm9yTGF5b3V0Qm94KCpsYXlvdXRCb3guY29udGFpbmluZ0Jsb2NrKCkpLT53aWR0aCgpOwot ICAgICAgICBhdXRvIHBhZGRpbmdUb3AgPSB2YWx1ZUZvckxlbmd0aChzdHlsZS5wYWRkaW5nVG9w KCksIGNvbnRhaW5pbmdCbG9ja1dpZHRoKTsKLSAgICAgICAgYXV0byBwYWRkaW5nQm90dG9tID0g dmFsdWVGb3JMZW5ndGgoc3R5bGUucGFkZGluZ0JvdHRvbSgpLCBjb250YWluaW5nQmxvY2tXaWR0 aCk7CisgICAgICAgIGF1dG8gcGFkZGluZ1RvcCA9IGRpc3BsYXlCb3gucGFkZGluZ1RvcCgpOwor ICAgICAgICBhdXRvIHBhZGRpbmdCb3R0b20gPSBkaXNwbGF5Qm94LnBhZGRpbmdCb3R0b20oKTsK IAotICAgICAgICBhdXRvIGJvcmRlclRvcFdpZHRoID0gc3R5bGUuYm9yZGVyQmVmb3JlV2lkdGgo KTsKLSAgICAgICAgYXV0byBib3JkZXJCb3R0b21XaWR0aCA9IHN0eWxlLmJvcmRlckFmdGVyV2lk dGgoKTsKKyAgICAgICAgYXV0byBib3JkZXJUb3AgPSBkaXNwbGF5Qm94LmJvcmRlclRvcCgpOwor ICAgICAgICBhdXRvIGJvcmRlckJvdHRvbSA9IGRpc3BsYXlCb3guYm9yZGVyQm90dG9tKCk7CiAK LSAgICAgICAgY29tcHV0ZWRIZWlnaHRWYWx1ZSA9IGNvbnRhaW5pbmdCbG9ja0hlaWdodCAtICh0 b3AudmFsdWUoKSArIG1hcmdpblRvcCArIGJvcmRlclRvcFdpZHRoICsgcGFkZGluZ1RvcCArIHBh ZGRpbmdCb3R0b20gKyBib3JkZXJCb3R0b21XaWR0aCArIG1hcmdpbkJvdHRvbSArIGJvdHRvbS52 YWx1ZSgpKTsKKyAgICAgICAgY29tcHV0ZWRIZWlnaHRWYWx1ZSA9IGNvbnRhaW5pbmdCbG9ja0hl aWdodCAtICh0b3AudmFsdWUoKSArIG1hcmdpblRvcCArIGJvcmRlclRvcCArIHBhZGRpbmdUb3Ag KyBwYWRkaW5nQm90dG9tICsgYm9yZGVyQm90dG9tICsgbWFyZ2luQm90dG9tICsgYm90dG9tLnZh bHVlKCkpOwogICAgIH0gZWxzZSBpZiAoIWhlaWdodC5pc0F1dG8oKSkKICAgICAgICAgY29tcHV0 ZWRIZWlnaHRWYWx1ZSA9IHZhbHVlRm9yTGVuZ3RoKGhlaWdodCwgY29udGFpbmluZ0Jsb2NrSGVp Z2h0KTsKICAgICBlbHNlCkBAIC0yNjQsMTYgKzI2MywxNiBAQCB2b2lkIEZvcm1hdHRpbmdDb250 ZXh0Ojpjb21wdXRlT3V0T2ZGbG93Tm9uUmVwbGFjZWRXaWR0aChMYXlvdXRDb250ZXh0JiBsYXlv dXRDbwogICAgICAgICBjb21wdXRlZFdpZHRoVmFsdWUgPSBzaHJpbmtUb0ZpdFdpZHRoKGxheW91 dENvbnRleHQsIGxheW91dEJveCk7CiAgICAgfSBlbHNlIGlmICghbGVmdC5pc0F1dG8oKSAmJiB3 aWR0aC5pc0F1dG8oKSAmJiAhcmlnaHQuaXNBdXRvKCkpIHsKICAgICAgICAgLy8gIzUKLSAgICAg ICAgYXV0byBtYXJnaW5MZWZ0ID0gc3R5bGUubWFyZ2luTGVmdCgpLmlzQXV0bygpID8gTGF5b3V0 VW5pdCgpIDogdmFsdWVGb3JMZW5ndGgoc3R5bGUubWFyZ2luTGVmdCgpLCBjb250YWluaW5nQmxv Y2tXaWR0aCk7Ci0gICAgICAgIGF1dG8gbWFyZ2luUmlnaHQgPSBzdHlsZS5tYXJnaW5SaWdodCgp LmlzQXV0bygpID8gTGF5b3V0VW5pdCgpIDogdmFsdWVGb3JMZW5ndGgoc3R5bGUubWFyZ2luUmln aHQoKSwgY29udGFpbmluZ0Jsb2NrV2lkdGgpOworICAgICAgICBhdXRvIG1hcmdpbkxlZnQgPSBk aXNwbGF5Qm94Lm1hcmdpbkxlZnQoKTsKKyAgICAgICAgYXV0byBtYXJnaW5SaWdodCA9IGRpc3Bs YXlCb3gubWFyZ2luUmlnaHQoKTsKICAgICAKLSAgICAgICAgYXV0byBwYWRkaW5nTGVmdCA9IHZh bHVlRm9yTGVuZ3RoKHN0eWxlLnBhZGRpbmdUb3AoKSwgY29udGFpbmluZ0Jsb2NrV2lkdGgpOwot ICAgICAgICBhdXRvIHBhZGRpbmdSaWdodCA9IHZhbHVlRm9yTGVuZ3RoKHN0eWxlLnBhZGRpbmdC b3R0b20oKSwgY29udGFpbmluZ0Jsb2NrV2lkdGgpOworICAgICAgICBhdXRvIHBhZGRpbmdMZWZ0 ID0gZGlzcGxheUJveC5wYWRkaW5nTGVmdCgpOworICAgICAgICBhdXRvIHBhZGRpbmdSaWdodCA9 IGRpc3BsYXlCb3gucGFkZGluZ1JpZ2h0KCk7CiAKLSAgICAgICAgYXV0byBib3JkZXJMZWZ0V2lk dGggPSBzdHlsZS5ib3JkZXJTdGFydFdpZHRoKCk7Ci0gICAgICAgIGF1dG8gYm9yZGVyUmlnaHRX aWR0aCA9IHN0eWxlLmJvcmRlckVuZFdpZHRoKCk7CisgICAgICAgIGF1dG8gYm9yZGVyTGVmdCA9 IGRpc3BsYXlCb3guYm9yZGVyTGVmdCgpOworICAgICAgICBhdXRvIGJvcmRlclJpZ2h0ID0gZGlz cGxheUJveC5ib3JkZXJSaWdodCgpOwogCi0gICAgICAgIGNvbXB1dGVkV2lkdGhWYWx1ZSA9IGNv bnRhaW5pbmdCbG9ja1dpZHRoIC0gKGxlZnQudmFsdWUoKSArIG1hcmdpbkxlZnQgKyBib3JkZXJM ZWZ0V2lkdGggKyBwYWRkaW5nTGVmdCArIHBhZGRpbmdSaWdodCArIGJvcmRlclJpZ2h0V2lkdGgg KyBtYXJnaW5SaWdodCArIHJpZ2h0LnZhbHVlKCkpOworICAgICAgICBjb21wdXRlZFdpZHRoVmFs dWUgPSBjb250YWluaW5nQmxvY2tXaWR0aCAtIChsZWZ0LnZhbHVlKCkgKyBtYXJnaW5MZWZ0ICsg Ym9yZGVyTGVmdCArIHBhZGRpbmdMZWZ0ICsgcGFkZGluZ1JpZ2h0ICsgYm9yZGVyUmlnaHQgKyBt YXJnaW5SaWdodCArIHJpZ2h0LnZhbHVlKCkpOwogICAgIH0gZWxzZSBpZiAoIXdpZHRoLmlzQXV0 bygpKQogICAgICAgICBjb21wdXRlZFdpZHRoVmFsdWUgPSB2YWx1ZUZvckxlbmd0aCh3aWR0aCwg Y29udGFpbmluZ0Jsb2NrV2lkdGgpOwogICAgIGVsc2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2xheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5Qm94LmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvZGlzcGxheXRyZWUvRGlzcGxheUJveC5oCmluZGV4IDQ5YTFkMTA1NDFmZTczZDIyMDBkMzAy ZmQyYTA4ZDJlNGYyYTUzMjYuLjM2OGZkYWYwZWI4NWI0ZDJhY2FmNjg0ZjI0MTI4ZWQyMDY4YjVl OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5 Qm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlCb3gu aApAQCAtNzAsNiArNzAsMTYgQEAgcHVibGljOgogICAgIExheW91dFVuaXQgbWFyZ2luQm90dG9t KCkgY29uc3Q7CiAgICAgTGF5b3V0VW5pdCBtYXJnaW5SaWdodCgpIGNvbnN0OwogCisgICAgTGF5 b3V0VW5pdCBib3JkZXJUb3AoKSBjb25zdDsKKyAgICBMYXlvdXRVbml0IGJvcmRlckxlZnQoKSBj b25zdDsKKyAgICBMYXlvdXRVbml0IGJvcmRlckJvdHRvbSgpIGNvbnN0OworICAgIExheW91dFVu aXQgYm9yZGVyUmlnaHQoKSBjb25zdDsKKworICAgIExheW91dFVuaXQgcGFkZGluZ1RvcCgpIGNv bnN0OworICAgIExheW91dFVuaXQgcGFkZGluZ0xlZnQoKSBjb25zdDsKKyAgICBMYXlvdXRVbml0 IHBhZGRpbmdCb3R0b20oKSBjb25zdDsKKyAgICBMYXlvdXRVbml0IHBhZGRpbmdSaWdodCgpIGNv bnN0OworCiAgICAgTGF5b3V0UmVjdCBtYXJnaW5Cb3goKSBjb25zdDsKICAgICBMYXlvdXRSZWN0 IGJvcmRlckJveCgpIGNvbnN0OwogICAgIExheW91dFJlY3QgcGFkZGluZ0JveCgpIGNvbnN0OwpA QCAtMzQ3LDYgKzM1Nyw1NCBAQCBpbmxpbmUgTGF5b3V0VW5pdCBCb3g6Om1hcmdpblJpZ2h0KCkg Y29uc3QKICAgICByZXR1cm4gbV9tYXJnaW5SaWdodDsKIH0KIAoraW5saW5lIExheW91dFVuaXQg Qm94OjpwYWRkaW5nVG9wKCkgY29uc3QKK3sKKyAgICBBU1NFUlQobV9oYXNWYWxpZFBhZGRpbmcp OworICAgIHJldHVybiBtX3BhZGRpbmdUb3A7Cit9CisKK2lubGluZSBMYXlvdXRVbml0IEJveDo6 cGFkZGluZ0xlZnQoKSBjb25zdAoreworICAgIEFTU0VSVChtX2hhc1ZhbGlkUGFkZGluZyk7Cisg ICAgcmV0dXJuIG1fcGFkZGluZ0xlZnQ7Cit9CisKK2lubGluZSBMYXlvdXRVbml0IEJveDo6cGFk ZGluZ0JvdHRvbSgpIGNvbnN0Cit7CisgICAgQVNTRVJUKG1faGFzVmFsaWRQYWRkaW5nKTsKKyAg ICByZXR1cm4gbV9wYWRkaW5nQm90dG9tOworfQorCitpbmxpbmUgTGF5b3V0VW5pdCBCb3g6OnBh ZGRpbmdSaWdodCgpIGNvbnN0Cit7CisgICAgQVNTRVJUKG1faGFzVmFsaWRQYWRkaW5nKTsKKyAg ICByZXR1cm4gbV9wYWRkaW5nUmlnaHQ7Cit9CisKK2lubGluZSBMYXlvdXRVbml0IEJveDo6Ym9y ZGVyVG9wKCkgY29uc3QKK3sKKyAgICBBU1NFUlQobV9oYXNWYWxpZEJvcmRlcik7CisgICAgcmV0 dXJuIG1fYm9yZGVyVG9wOworfQorCitpbmxpbmUgTGF5b3V0VW5pdCBCb3g6OmJvcmRlckxlZnQo KSBjb25zdAoreworICAgIEFTU0VSVChtX2hhc1ZhbGlkQm9yZGVyKTsKKyAgICByZXR1cm4gbV9i b3JkZXJMZWZ0OworfQorCitpbmxpbmUgTGF5b3V0VW5pdCBCb3g6OmJvcmRlckJvdHRvbSgpIGNv bnN0Cit7CisgICAgQVNTRVJUKG1faGFzVmFsaWRCb3JkZXIpOworICAgIHJldHVybiBtX2JvcmRl ckJvdHRvbTsKK30KKworaW5saW5lIExheW91dFVuaXQgQm94Ojpib3JkZXJSaWdodCgpIGNvbnN0 Cit7CisgICAgQVNTRVJUKG1faGFzVmFsaWRCb3JkZXIpOworICAgIHJldHVybiBtX2JvcmRlclJp Z2h0OworfQorCiB9CiB9CiAjZW5kaWYK