185595 2018-05-13 16:39:30 -0700 Simplified Mach exception handling 2018-05-14 09:46:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren ap benjamin cdumez cmarcelo dbates ews-watchlist keith_miller mark.lam webkit-bug-importer oldest_to_newest 1423471 0 ggaren 2018-05-13 16:39:30 -0700 Simplified Mach exception handling 1423473 1 340279 ggaren 2018-05-13 16:55:17 -0700 Created attachment 340279 Patch 1423482 2 340279 ap 2018-05-13 19:07:53 -0700 Comment on attachment 340279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340279&action=review > Source/WTF/wtf/threads/Signals.cpp:86 > + UNUSED_PARAM(source); // Silence the leaks tool. How does this work? 1423508 3 340279 keith_miller 2018-05-14 00:05:29 -0700 Comment on attachment 340279 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340279&action=review r=me with some comments. > Source/WTF/wtf/threads/Signals.cpp:-89 > - // We should never cancel our handler since it's a permanent thing so we don't add a cancel handler. Why'd you remove this comment? I think it had useful information... >> Source/WTF/wtf/threads/Signals.cpp:86 >> + UNUSED_PARAM(source); // Silence the leaks tool. > > How does this work? The block will keep a reference to source if you use it inside the block. If we don't keep a pointer to it leaks thinks we leaked it even though the somewhere inside the mach code someone (I assume) is keeping it around. 1423647 4 ggaren 2018-05-14 09:30:50 -0700 > > - // We should never cancel our handler since it's a permanent thing so we don't add a cancel handler. > > Why'd you remove this comment? I think it had useful information... Sounded a bit tautological to me. I'll bring it back with an explanation. > >> Source/WTF/wtf/threads/Signals.cpp:86 > >> + UNUSED_PARAM(source); // Silence the leaks tool. > > > > How does this work? I'll expand this comment too. 1423651 5 ggaren 2018-05-14 09:45:11 -0700 Committed r231760: <https://trac.webkit.org/changeset/231760> 1423652 6 webkit-bug-importer 2018-05-14 09:46:23 -0700 <rdar://problem/40220637> 340279 2018-05-13 16:55:17 -0700 2018-05-14 00:05:40 -0700 Patch bug-185595-20180513165517.patch text/plain 4370 ggaren SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzE3NDUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA1LTEzICBHZW9mZnJleSBHYXJlbiAgPGdn YXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZmllZCBNYWNoIGV4Y2VwdGlvbiBoYW5k bGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1 NTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3 dGYvdGhyZWFkcy9TaWduYWxzLmNwcDoKKyAgICAgICAgKFdURjo6c3RhcnRNYWNoRXhjZXB0aW9u SGFuZGxlclRocmVhZCk6IFVzZSBtYWNoX21zZ19zZXJ2ZXJfb25jZSBpbnN0ZWFkCisgICAgICAg IG9mIGR1cGxpY2F0aW5nIGl0cyBmdW5jdGlvbmFsaXR5LiBTZXBhcmF0ZSBlcnJvciBoYW5kbGlu ZyBsb2dpYyBmcm9tCisgICAgICAgIHByb2dyYW0gbG9naWMgdG8gaGVscCBwcm9ncmFtIGxvZ2lj IHN0YW5kIG91dC4gVXNlCisgICAgICAgIERJU1BBVENIX1RBUkdFVF9RVUVVRV8qIGluc3RlYWQg b2YgZXhwbGljaXRseSBmZXRjaGluZyBhIHF1ZXVlLgorCisgICAgICAgIEFsc28sIHdlIGRvbid0 IG5lZWQgdGhlIGhpZ2ggcHJpb3JpdHkgcXVldWUuIFRoZSBrZXJuZWwgZG9uYXRlcyBhCisgICAg ICAgIHByaW9yaXR5IHZvdWNoZXIgZnJvbSB0aGUgZXhjZXB0aW9uIHRocmVhZCB0byB0aGUgcmVj ZWl2ZXIgdGhyZWFkLCBhbmQKKyAgICAgICAgbWFjaF9tc2dfc2VydmVyX29uY2UgdGFrZXMgY2Fy ZSB0byBmb3J3YXJkIHRoYXQgdm91Y2hlci4KKwogMjAxOC0wNS0xMyAgRmlsaXAgUGl6bG8gIDxm cGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIERpc2FibGUgcG9pbnRlciBwb2lzb25pbmcKSW5k ZXg6IFNvdXJjZS9XVEYvd3RmL3RocmVhZHMvU2lnbmFscy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmNwcAkocmV2aXNpb24gMjMxNzQzKQorKysgU291 cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzMsNDEg KzczLDIxIEBAIHN0YXRpYyB2b2lkIHN0YXJ0TWFjaEV4Y2VwdGlvbkhhbmRsZXJUaHIKIHsKICAg ICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcgb25jZTsKICAgICBzdGQ6OmNhbGxfb25jZShvbmNlLCBb XSB7Ci0gICAgICAgIGlmIChtYWNoX3BvcnRfYWxsb2NhdGUobWFjaF90YXNrX3NlbGYoKSwgTUFD SF9QT1JUX1JJR0hUX1JFQ0VJVkUsICZleGNlcHRpb25Qb3J0KSAhPSBLRVJOX1NVQ0NFU1MpCi0g ICAgICAgICAgICBDUkFTSCgpOworICAgICAgICBrZXJuX3JldHVybl90IGtyID0gbWFjaF9wb3J0 X2FsbG9jYXRlKG1hY2hfdGFza19zZWxmKCksIE1BQ0hfUE9SVF9SSUdIVF9SRUNFSVZFLCAmZXhj ZXB0aW9uUG9ydCk7CisgICAgICAgIFJFTEVBU0VfQVNTRVJUKGtyID09IEtFUk5fU1VDQ0VTUyk7 CisgICAgICAgIGtyID0gbWFjaF9wb3J0X2luc2VydF9yaWdodChtYWNoX3Rhc2tfc2VsZigpLCBl eGNlcHRpb25Qb3J0LCBleGNlcHRpb25Qb3J0LCBNQUNIX01TR19UWVBFX01BS0VfU0VORCk7Cisg ICAgICAgIFJFTEVBU0VfQVNTRVJUKGtyID09IEtFUk5fU1VDQ0VTUyk7CisKKyAgICAgICAgZGlz cGF0Y2hfc291cmNlX3Qgc291cmNlID0gZGlzcGF0Y2hfc291cmNlX2NyZWF0ZSgKKyAgICAgICAg ICAgIERJU1BBVENIX1NPVVJDRV9UWVBFX01BQ0hfUkVDViwgZXhjZXB0aW9uUG9ydCwgMCwgRElT UEFUQ0hfVEFSR0VUX1FVRVVFX0RFRkFVTFQpOworICAgICAgICBSRUxFQVNFX0FTU0VSVChzb3Vy Y2UpOwogCi0gICAgICAgIGlmIChtYWNoX3BvcnRfaW5zZXJ0X3JpZ2h0KG1hY2hfdGFza19zZWxm KCksIGV4Y2VwdGlvblBvcnQsIGV4Y2VwdGlvblBvcnQsIE1BQ0hfTVNHX1RZUEVfTUFLRV9TRU5E KSAhPSBLRVJOX1NVQ0NFU1MpCi0gICAgICAgICAgICBDUkFTSCgpOwotCi0gICAgICAgIC8vIEl0 J3Mgbm90IGNsZWFyIHRoYXQgdGhpcyBuZWVkcyB0byBiZSB0aGUgaGlnaCBwcmlvcml0eSBxdWV1 ZSBidXQgaXQgc2hvdWxkIGJlIHJhcmUgYW5kIGl0IG1pZ2h0IGJlCi0gICAgICAgIC8vIGhhbmRs aW5nIGV4Y2VwdGlvbnMgZnJvbSBoaWdoIHByaW9yaXR5IHRocmVhZHMuIEFueXdheSwgb3VyIGhh bmRsZXJzIHNob3VsZCBiZSB2ZXJ5IGZhc3QgYW55d2F5IHNvIGl0J3MKLSAgICAgICAgLy8gcHJv YmFibHkgbm90IHRoZSBlbmQgb2YgdGhlIHdvcmxkIGlmIHdlIGhhbmRsZSBhIGxvdyBwcmlvcml0 eSBleGNlcHRpb24gb24gYSBoaWdoIHByaW9yaXR5IHF1ZXVlLgotICAgICAgICBkaXNwYXRjaF9x dWV1ZV90IHF1ZXVlID0gZGlzcGF0Y2hfZ2V0X2dsb2JhbF9xdWV1ZShESVNQQVRDSF9RVUVVRV9Q UklPUklUWV9ISUdILCAwKTsKLSAgICAgICAgZGlzcGF0Y2hfc291cmNlX3Qgc291cmNlID0gZGlz cGF0Y2hfc291cmNlX2NyZWF0ZShESVNQQVRDSF9TT1VSQ0VfVFlQRV9NQUNIX1JFQ1YsIGV4Y2Vw dGlvblBvcnQsIDAsIHF1ZXVlKTsKLSAgICAgICAgUkVMRUFTRV9BU1NFUlRfV0lUSF9NRVNTQUdF KHNvdXJjZSwgIldlIG5lZWQgdG8gZW5zdXJlIG91ciBzb3VyY2Ugd2FzIGNyZWF0ZWQuIik7Ci0K LSAgICAgICAgLy8gV2Ugc2hvdWxkIG5ldmVyIGNhbmNlbCBvdXIgaGFuZGxlciBzaW5jZSBpdCdz IGEgcGVybWFuZW50IHRoaW5nIHNvIHdlIGRvbid0IGFkZCBhIGNhbmNlbCBoYW5kbGVyLgogICAg ICAgICBkaXNwYXRjaF9zb3VyY2Vfc2V0X2V2ZW50X2hhbmRsZXIoc291cmNlLCBeewotICAgICAg ICAgICAgLy8gdGhlIGxlYWtzIHRvb2wgd2lsbCBnZXQgbWFkIGF0IHVzIGlmIHdlIGRvbid0IHBy ZXRlbmQgdG8gd2F0Y2ggdGhlIHNvdXJjZS4KLSAgICAgICAgICAgIFVOVVNFRF9QQVJBTShzb3Vy Y2UpOwotICAgICAgICAgICAgdW5pb24gTWVzc2FnZSB7Ci0gICAgICAgICAgICAgICAgbWFjaF9t c2dfaGVhZGVyX3QgaGVhZGVyOwotICAgICAgICAgICAgICAgIGNoYXIgZGF0YVttYXhNZXNzYWdl U2l6ZV07Ci0gICAgICAgICAgICB9OwotICAgICAgICAgICAgTWVzc2FnZSBtZXNzYWdlSGVhZGVy SW47Ci0gICAgICAgICAgICBNZXNzYWdlIG1lc3NhZ2VIZWFkZXJPdXQ7Ci0KLSAgICAgICAgICAg IGtlcm5fcmV0dXJuX3QgbWVzc2FnZVJlc3VsdCA9IG1hY2hfbXNnKCZtZXNzYWdlSGVhZGVySW4u aGVhZGVyLCBNQUNIX1JDVl9NU0csIDAsIG1heE1lc3NhZ2VTaXplLCBleGNlcHRpb25Qb3J0LCBN QUNIX01TR19USU1FT1VUX05PTkUsIE1BQ0hfUE9SVF9OVUxMKTsKLSAgICAgICAgICAgIGlmICht ZXNzYWdlUmVzdWx0ID09IEtFUk5fU1VDQ0VTUykgewotICAgICAgICAgICAgICAgIGlmICghbWFj aF9leGNfc2VydmVyKCZtZXNzYWdlSGVhZGVySW4uaGVhZGVyLCAmbWVzc2FnZUhlYWRlck91dC5o ZWFkZXIpKQotICAgICAgICAgICAgICAgICAgICBDUkFTSCgpOwotCi0gICAgICAgICAgICAgICAg bWVzc2FnZVJlc3VsdCA9IG1hY2hfbXNnKCZtZXNzYWdlSGVhZGVyT3V0LmhlYWRlciwgTUFDSF9T RU5EX01TRywgbWVzc2FnZUhlYWRlck91dC5oZWFkZXIubXNnaF9zaXplLCAwLCBtZXNzYWdlSGVh ZGVyT3V0LmhlYWRlci5tc2doX2xvY2FsX3BvcnQsIDAsIE1BQ0hfUE9SVF9OVUxMKTsKLSAgICAg ICAgICAgICAgICBSRUxFQVNFX0FTU0VSVChtZXNzYWdlUmVzdWx0ID09IEtFUk5fU1VDQ0VTUyk7 Ci0gICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgIGRhdGFMb2dMbigiRmFpbGVk IHRvIHJlY2VpdmUgbWFjaCBtZXNzYWdlIGR1ZSB0byAiLCBtYWNoX2Vycm9yX3N0cmluZyhtZXNz YWdlUmVzdWx0KSk7Ci0gICAgICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQo KTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIFVOVVNFRF9QQVJBTShzb3VyY2UpOyAvLyBT aWxlbmNlIHRoZSBsZWFrcyB0b29sLgorCisgICAgICAgICAgICBrZXJuX3JldHVybl90IGtyID0g bWFjaF9tc2dfc2VydmVyX29uY2UoCisgICAgICAgICAgICAgICAgbWFjaF9leGNfc2VydmVyLCBt YXhNZXNzYWdlU2l6ZSwgZXhjZXB0aW9uUG9ydCwgTUFDSF9NU0dfVElNRU9VVF9OT05FKTsKKyAg ICAgICAgICAgIFJFTEVBU0VfQVNTRVJUKGtyID09IEtFUk5fU1VDQ0VTUyk7CiAgICAgICAgIH0p OwogCiAgICAgICAgIGRpc3BhdGNoX3Jlc3VtZShzb3VyY2UpOwo=