185586 2018-05-13 11:02:21 -0700 Disable pointer poisoning 2018-05-14 16:16:35 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo fpizlo benjamin cdumez cmarcelo dbates ews-watchlist ryanhaddad webkit-bug-importer ysuzuki oldest_to_newest 1423425 0 fpizlo 2018-05-13 11:02:21 -0700 It seems to possibly be a small speed-up. I want to see if the bots agree. 1423426 1 340268 fpizlo 2018-05-13 11:03:24 -0700 Created attachment 340268 the patch 1423427 2 340268 ysuzuki 2018-05-13 11:06:04 -0700 Comment on attachment 340268 the patch r=me. BTW, do you plan to remove this functionality? I have a patch for Windows 64bit poisoning right now (https://bugs.webkit.org/show_bug.cgi?id=185421). If it will be removed soon, I'll make that patch WONTFIX. 1423434 3 fpizlo 2018-05-13 11:56:35 -0700 (In reply to Yusuke Suzuki from comment #2) > Comment on attachment 340268 [details] > the patch > > r=me. BTW, do you plan to remove this functionality? I have a patch for > Windows 64bit poisoning right now > (https://bugs.webkit.org/show_bug.cgi?id=185421). If it will be removed > soon, I'll make that patch WONTFIX. I think that if it's a confirmed speed-up then we will remove it. 1423435 4 fpizlo 2018-05-13 11:57:21 -0700 Landed in https://trac.webkit.org/changeset/231743/webkit 1423436 5 webkit-bug-importer 2018-05-13 11:58:18 -0700 <rdar://problem/40202974> 1423823 6 ryanhaddad 2018-05-14 15:39:13 -0700 I suppose this may be expected, but this caused some API tests to timeout: Timeout TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.Assignment TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.Basic TestWTF.WTF_PoisonedUniquePtr.Assignment TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.Swap TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.ReturnValue TestWTF.WTF_Poisoned.Assignment TestWTF.WTF_PoisonedUniquePtr.Swap TestWTF.WTF_Poisoned.ReturnValue TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.ReturnValue TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.Basic TestWTF.WTF_PoisonedUniquePtr.Basic TestWTF.WTF_Poisoned.Swap TestWTF.WTF_Poisoned.Basic TestWTF.WTF_PoisonedUniquePtr.ReturnValue TestWTF.WTF_PoisonedUniquePtrForNonTriviallyDestructibleArrays.Assignment TestWTF.WTF_PoisonedUniquePtrForTriviallyDestructibleArrays.Swap https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK2%20%28Tests%29/builds/4487 1423847 7 ryanhaddad 2018-05-14 16:16:35 -0700 Disabled API tests in https://trac.webkit.org/r231774 340268 2018-05-13 11:03:24 -0700 2018-05-13 11:06:04 -0700 the patch blah.patch text/plain 1334 fpizlo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMzE3NDEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA1LTEzICBGaWxpcCBQaXpsbyAgPGZwaXps b0BhcHBsZS5jb20+CisKKyAgICAgICAgRGlzYWJsZSBwb2ludGVyIHBvaXNvbmluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NTg2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBUaGlzIHNl ZW1zIGxpa2UgYSAwLjMlIHNwZWVkLXVwIG9uIG1pY3JvYmVuY2htYXJrcy4gSXQgc2VlbXMgbGlr ZSBpdCBtYXkgYmUgYSBzbWFsbCBzcGVlZC11cCBvbgorICAgICAgICBvdGhlciB0ZXN0cywgdG9v LgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTgtMDUtMTEgIENocmlzIER1bWV6 ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChhc3luYyBwb2xpY3kg ZGVsZWdhdGUpOiBSZXZva2luZyBhbiBvYmplY3QgVVJMIGltbWVkaWF0ZWx5IGFmdGVyIHRyaWdn ZXJpbmcgZG93bmxvYWQgYnJlYWtzIGZpbGUgZG93bmxvYWQKSW5kZXg6IFNvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkocmV2 aXNpb24gMjMxNjg2KQorKysgU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5 KQpAQCAtOTkxLDEyICs5OTEsNyBAQAogI2RlZmluZSBFTkFCTEVfU0lHTkFMX0JBU0VEX1ZNX1RS QVBTIDEKICNlbmRpZgogCi0jZGVmaW5lIEVOQUJMRV9QT0lTT04gMQotLyogTm90IGN1cnJlbnRs eSBzdXBwb3J0ZWQgZm9yIDMyLWJpdCBvciBPUyhXSU5ET1dTKSBidWlsZHMgKGJlY2F1c2Ugb2Yg bWlzc2luZyBsbGludCBzdXBwb3J0KS4gTWFrZSBzdXJlIGl0J3MgZGlzYWJsZWQuICovCi0jaWYg VVNFKEpTVkFMVUUzMl82NCkgfHwgT1MoV0lORE9XUykKLSN1bmRlZiBFTkFCTEVfUE9JU09OCiAj ZGVmaW5lIEVOQUJMRV9QT0lTT04gMAotI2VuZGlmCiAKICNpZiAhZGVmaW5lZChVU0VfUE9JTlRF Ul9QUk9GSUxJTkcpIHx8IFVTRShKU1ZBTFVFMzJfNjQpIHx8ICFFTkFCTEUoSklUKQogI3VuZGVm IFVTRV9QT0lOVEVSX1BST0ZJTElORwo=