185561 2018-05-11 13:21:50 -0700 WebHTMLView is not setting aside subviews when drawing 2018-05-11 14:00:01 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1423234 0 timothy 2018-05-11 13:21:50 -0700 The method we override in AppKit has changed its signature. - (void)_recursive:(BOOL)recurse displayRectIgnoringOpacity:(NSRect)displayRect inContext:(NSGraphicsContext *)context shouldChangeFontReferenceColor:(BOOL)shouldChangeFontReferenceColor; is now: - (void)_recursive:(BOOL)recursive displayRectIgnoringOpacity:(NSRect)displayRect inContext:(NSGraphicsContext *)graphicsContext shouldChangeFontReferenceColor:(BOOL)shouldChangeFontReferenceColor stopAtLayerBackedViews:(BOOL)stopAtLayerBackedViews; Also the follow is removed: - (void)_recursive:(BOOL)recurseX displayRectIgnoringOpacity:(NSRect)displayRect inGraphicsContext:(NSGraphicsContext *)graphicsContext shouldChangeFontReferenceColor:(BOOL)shouldChangeFontReferenceColor; 1423235 1 webkit-bug-importer 2018-05-11 13:22:53 -0700 <rdar://problem/40172894> 1423236 2 webkit-bug-importer 2018-05-11 13:23:03 -0700 <rdar://problem/40172901> 1423239 3 340217 timothy 2018-05-11 13:32:00 -0700 Created attachment 340217 Patch 1423251 4 340217 commit-queue 2018-05-11 13:59:59 -0700 Comment on attachment 340217 Patch Clearing flags on attachment: 340217 Committed r231718: <https://trac.webkit.org/changeset/231718> 1423252 5 commit-queue 2018-05-11 14:00:01 -0700 All reviewed patches have been landed. Closing bug. 340217 2018-05-11 13:32:00 -0700 2018-05-11 13:59:59 -0700 Patch bug-185561-20180511133159.patch text/plain 5129 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggNDQ4M2E1MWQ3OTA4NTlkMDJjYTgzNGY3YzIzOWJkNTgxNGFkY2ZkMy4uMWNjNGI4ZmIzYzll MTE3NmJhYWVhZWI4NzMxOWJlN2QyNmE4ZGYyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA1LTExICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5 QGFwcGxlLmNvbT4KKworICAgICAgICBXZWJIVE1MVmlldyBpcyBub3Qgc2V0dGluZyBhc2lkZSBz dWJ2aWV3cyB3aGVuIGRyYXdpbmcuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NTU2MQorICAgICAgICByZGFyOi8vcHJvYmxlbS80MDE3Mjg5NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0aGUg bmV3IG1ldGhvZCBzaWduYXR1cmUgZm9yIF9yZWN1cnNpdmU6ZGlzcGxheVJlY3RJZ25vcmluZ09w YWNpdHk6c2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5jZUNvbG9yOi4KKworICAgICAgICAqIFdlYlZp ZXcvV2ViSFRNTFZpZXcubW06CisgICAgICAgICgtW1dlYkhUTUxWaWV3IF9yZWN1cnNpdmU6ZGlz cGxheVJlY3RJZ25vcmluZ09wYWNpdHk6aW5Db250ZXh0OnNob3VsZENoYW5nZUZvbnRSZWZlcmVu Y2VDb2xvcjpzdG9wQXRMYXllckJhY2tlZFZpZXdzOl0pOiBBZGRlZC4KKwogMjAxOC0wNS0wNyAg RGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgU3Vic3RpdHV0ZSBD cm9zc09yaWdpblByZWZsaWdodFJlc3VsdENhY2hlOjpjbGVhcigpIGZvciBDcm9zc09yaWdpblBy ZWZsaWdodFJlc3VsdENhY2hlOjplbXB0eSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMv V2ViVmlldy9XZWJIVE1MVmlldy5tbQppbmRleCA0MWI3YmM3YTVjZTU3NzdkNjFlZGE2YzA5M2E1 MDJmZTBjZGMwZjllLi41OTc1MzIyYmEzYzQyNTliNzQ3MmU1ZmRkYmYxZGRjZTVkMmVlOTVjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1t CisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KQEAg LTcxNSw3ICs3MTUsOSBAQCBAaW50ZXJmYWNlIE5TVmlldyAoKQogLSAodm9pZClfcmVjdXJzaXZl RGlzcGxheVJlY3RJZk5lZWRlZElnbm9yaW5nT3BhY2l0eTooTlNSZWN0KXJlY3QgaXNWaXNpYmxl UmVjdDooQk9PTClpc1Zpc2libGVSZWN0IHJlY3RJc1Zpc2libGVSZWN0Rm9yVmlldzooTlNWaWV3 ICopdmlzaWJsZVZpZXcgdG9wVmlldzooQk9PTCl0b3BWaWV3OwogLSAodm9pZClfcmVjdXJzaXZl RGlzcGxheUFsbERpcnR5V2l0aExvY2tGb2N1czooQk9PTCluZWVkc0xvY2tGb2N1cyB2aXNSZWN0 OihOU1JlY3QpdmlzUmVjdDsKICNpZiBQTEFURk9STShNQUMpCi0jaWYgX19NQUNfT1NfWF9WRVJT SU9OX01JTl9SRVFVSVJFRCA+PSAxMDEzMDAKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JF UVVJUkVEID49IDEwMTQwMAorLSAodm9pZClfcmVjdXJzaXZlOihCT09MKXJlY3Vyc2l2ZSBkaXNw bGF5UmVjdElnbm9yaW5nT3BhY2l0eTooTlNSZWN0KWRpc3BsYXlSZWN0IGluQ29udGV4dDooTlNH cmFwaGljc0NvbnRleHQgKilncmFwaGljc0NvbnRleHQgc2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5j ZUNvbG9yOihCT09MKXNob3VsZENoYW5nZUZvbnRSZWZlcmVuY2VDb2xvciBzdG9wQXRMYXllckJh Y2tlZFZpZXdzOihCT09MKXN0b3BBdExheWVyQmFja2VkVmlld3M7CisjZWxpZiBfX01BQ19PU19Y X1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTMwMAogLSAodm9pZClfcmVjdXJzaXZlOihCT09M KXJlY3Vyc2UgZGlzcGxheVJlY3RJZ25vcmluZ09wYWNpdHk6KE5TUmVjdClkaXNwbGF5UmVjdCBp bkNvbnRleHQ6KE5TR3JhcGhpY3NDb250ZXh0ICopY29udGV4dCBzaG91bGRDaGFuZ2VGb250UmVm ZXJlbmNlQ29sb3I6KEJPT0wpc2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5jZUNvbG9yOwogLSAodm9p ZClfcmVjdXJzaXZlOihCT09MKXJlY3Vyc2VYIGRpc3BsYXlSZWN0SWdub3JpbmdPcGFjaXR5OihO U1JlY3QpZGlzcGxheVJlY3QgaW5HcmFwaGljc0NvbnRleHQ6KE5TR3JhcGhpY3NDb250ZXh0ICop Z3JhcGhpY3NDb250ZXh0IHNob3VsZENoYW5nZUZvbnRSZWZlcmVuY2VDb2xvcjooQk9PTClzaG91 bGRDaGFuZ2VGb250UmVmZXJlbmNlQ29sb3I7CiAjZWxzZQpAQCAtMTY2NiwxNCArMTY2OCwxOCBA QCAtICh2b2lkKV9yZWN1cnNpdmVEaXNwbGF5QWxsRGlydHlXaXRoTG9ja0ZvY3VzOihCT09MKW5l ZWRzTG9ja0ZvY3VzIHZpc1JlY3Q6KE5TUgogfQogCiAvLyBEb24ndCBsZXQgQXBwS2l0IGV2ZW4g ZHJhdyBzdWJ2aWV3cy4gV2UgdGFrZSBjYXJlIG9mIHRoYXQuCi0jaWYgX19NQUNfT1NfWF9WRVJT SU9OX01JTl9SRVFVSVJFRCA+PSAxMDEzMDAKKyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JF UVVJUkVEID49IDEwMTQwMAorLSAodm9pZClfcmVjdXJzaXZlOihCT09MKXJlY3Vyc2l2ZSBkaXNw bGF5UmVjdElnbm9yaW5nT3BhY2l0eTooTlNSZWN0KWRpc3BsYXlSZWN0IGluQ29udGV4dDooTlNH cmFwaGljc0NvbnRleHQgKilncmFwaGljc0NvbnRleHQgc2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5j ZUNvbG9yOihCT09MKXNob3VsZENoYW5nZUZvbnRSZWZlcmVuY2VDb2xvciBzdG9wQXRMYXllckJh Y2tlZFZpZXdzOihCT09MKXN0b3BBdExheWVyQmFja2VkVmlld3MKKyNlbGlmIF9fTUFDX09TX1hf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMzAwCiAtICh2b2lkKV9yZWN1cnNpdmU6KEJPT0wp cmVjdXJzZSBkaXNwbGF5UmVjdElnbm9yaW5nT3BhY2l0eTooTlNSZWN0KWRpc3BsYXlSZWN0IGlu Q29udGV4dDooTlNHcmFwaGljc0NvbnRleHQgKiljb250ZXh0IHNob3VsZENoYW5nZUZvbnRSZWZl cmVuY2VDb2xvcjooQk9PTClzaG91bGRDaGFuZ2VGb250UmVmZXJlbmNlQ29sb3IKICNlbHNlCiAt ICh2b2lkKV9yZWN1cnNpdmU6KEJPT0wpcmVjdXJzZSBkaXNwbGF5UmVjdElnbm9yaW5nT3BhY2l0 eTooTlNSZWN0KWRpc3BsYXlSZWN0IGluQ29udGV4dDooTlNHcmFwaGljc0NvbnRleHQgKiljb250 ZXh0IHRvcFZpZXc6KEJPT0wpdG9wVmlldwogI2VuZGlmCiB7CiAgICAgW3NlbGYgX3NldEFzaWRl U3Vidmlld3NdOwotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMzAw CisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDAKKyAgICBbc3Vw ZXIgX3JlY3Vyc2l2ZTpyZWN1cnNpdmUgZGlzcGxheVJlY3RJZ25vcmluZ09wYWNpdHk6ZGlzcGxh eVJlY3QgaW5Db250ZXh0OmdyYXBoaWNzQ29udGV4dCBzaG91bGRDaGFuZ2VGb250UmVmZXJlbmNl Q29sb3I6c2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5jZUNvbG9yIHN0b3BBdExheWVyQmFja2VkVmll d3M6c3RvcEF0TGF5ZXJCYWNrZWRWaWV3c107CisjZWxpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlO X1JFUVVJUkVEID49IDEwMTMwMAogICAgIFtzdXBlciBfcmVjdXJzaXZlOnJlY3Vyc2UgZGlzcGxh eVJlY3RJZ25vcmluZ09wYWNpdHk6ZGlzcGxheVJlY3QgaW5Db250ZXh0OmNvbnRleHQgc2hvdWxk Q2hhbmdlRm9udFJlZmVyZW5jZUNvbG9yOnNob3VsZENoYW5nZUZvbnRSZWZlcmVuY2VDb2xvcl07 CiAjZWxzZQogICAgIFtzdXBlciBfcmVjdXJzaXZlOnJlY3Vyc2UgZGlzcGxheVJlY3RJZ25vcmlu Z09wYWNpdHk6ZGlzcGxheVJlY3QgaW5Db250ZXh0OmNvbnRleHQgdG9wVmlldzp0b3BWaWV3XTsK QEAgLTE2ODEsNiArMTY4Nyw3IEBAIC0gKHZvaWQpX3JlY3Vyc2l2ZTooQk9PTClyZWN1cnNlIGRp c3BsYXlSZWN0SWdub3JpbmdPcGFjaXR5OihOU1JlY3QpZGlzcGxheVJlY3QKICAgICBbc2VsZiBf cmVzdG9yZVN1YnZpZXdzXTsKIH0KIAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPCAxMDE0MDAKIC8vIERvbid0IGxldCBBcHBLaXQgZXZlbiBkcmF3IHN1YnZpZXdzLiBXZSB0 YWtlIGNhcmUgb2YgdGhhdC4KICNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49 IDEwMTMwMAogLSAodm9pZClfcmVjdXJzaXZlOihCT09MKXJlY3Vyc2VYIGRpc3BsYXlSZWN0SWdu b3JpbmdPcGFjaXR5OihOU1JlY3QpZGlzcGxheVJlY3QgaW5HcmFwaGljc0NvbnRleHQ6KE5TR3Jh cGhpY3NDb250ZXh0ICopZ3JhcGhpY3NDb250ZXh0IHNob3VsZENoYW5nZUZvbnRSZWZlcmVuY2VD b2xvcjooQk9PTClzaG91bGRDaGFuZ2VGb250UmVmZXJlbmNlQ29sb3IKQEAgLTE2OTQsNyArMTcw MSw3IEBAIC0gKHZvaWQpX3JlY3Vyc2l2ZTooQk9PTClyZWN1cnNlWCBkaXNwbGF5UmVjdElnbm9y aW5nT3BhY2l0eTooTlNSZWN0KWRpc3BsYXlSZWN0CiAgICAgICAgIFtzZWxmIF9zZXRBc2lkZVN1 YnZpZXdzXTsKICAgICAgICAgZGlkU2V0QXNpZGVTdWJ2aWV3cyA9IFlFUzsKICAgICB9Ci0gICAg CisKICNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTMwMAogICAgIFtz dXBlciBfcmVjdXJzaXZlOnJlY3Vyc2VYIGRpc3BsYXlSZWN0SWdub3JpbmdPcGFjaXR5OmRpc3Bs YXlSZWN0IGluR3JhcGhpY3NDb250ZXh0OmdyYXBoaWNzQ29udGV4dCBzaG91bGRDaGFuZ2VGb250 UmVmZXJlbmNlQ29sb3I6c2hvdWxkQ2hhbmdlRm9udFJlZmVyZW5jZUNvbG9yXTsKICNlbHNlCkBA IC0xNzA0LDYgKzE3MTEsNyBAQCAtICh2b2lkKV9yZWN1cnNpdmU6KEJPT0wpcmVjdXJzZVggZGlz cGxheVJlY3RJZ25vcmluZ09wYWNpdHk6KE5TUmVjdClkaXNwbGF5UmVjdAogICAgIGlmIChkaWRT ZXRBc2lkZVN1YnZpZXdzKQogICAgICAgICBbc2VsZiBfcmVzdG9yZVN1YnZpZXdzXTsKIH0KKyNl bmRpZgogCiBzdGF0aWMgQk9PTCBpc1F1aWNrTG9va0V2ZW50KE5TRXZlbnQgKmV2ZW50KQogewo=