185560 2018-05-11 13:11:33 -0700 Add CF_NOESCAPE decorators for tvOS and watchOS 2018-05-11 15:03:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson mitz webkit-bug-importer oldest_to_newest 1423226 0 jer.noble 2018-05-11 13:11:33 -0700 Add CF_NOESCAPE decorators for tvOS and watchOS 1423229 1 340214 jer.noble 2018-05-11 13:12:36 -0700 Created attachment 340214 Patch 1423230 2 jer.noble 2018-05-11 13:13:49 -0700 <rdar://problem/39806412> 1423237 3 340214 mitz 2018-05-11 13:23:15 -0700 Comment on attachment 340214 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340214&action=review > Source/WebCore/PAL/pal/cf/CoreMediaSoftLink.h:40 > +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED <= 120000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED <= 101400) || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED <= 50000) || (PLATFORM(TVOS) && __TV_OS_VERSION_MAX_ALLOWED <= 120000) We normally use >= or < to compare against versions. We don’t expect something to be needed for 101400 but not for 101401. Perhaps you meant < 101500 ? Similarly for the other platforms. 1423250 4 340221 jer.noble 2018-05-11 13:59:33 -0700 Created attachment 340221 Patch 1423277 5 340221 commit-queue 2018-05-11 15:03:12 -0700 Comment on attachment 340221 Patch Clearing flags on attachment: 340221 Committed r231721: <https://trac.webkit.org/changeset/231721> 1423278 6 commit-queue 2018-05-11 15:03:14 -0700 All reviewed patches have been landed. Closing bug. 340214 2018-05-11 13:12:36 -0700 2018-05-11 13:59:32 -0700 Patch bug-185560-20180511131235.patch text/plain 1566 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCAzZGMxN2Ji YTU0NmIwMTNhMmQ0M2Y4NzM2YTAxYjQzMWFmMTVjMTk0Li42N2Q5OWU3MzJhOGU1YmMwMTY2NjVl ZGJhZmNiMzExMWFjNjA2ZWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxOC0wNS0xMSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgQ0ZfTk9FU0NBUEUgZGVjb3JhdG9ycyBmb3IgdHZPUyBhbmQgd2F0Y2hPUworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NTYwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWwvY2YvQ29yZU1lZGlh U29mdExpbmsuaDoKKwogMjAxOC0wNS0wOCAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNv bT4KIAogICAgICAgICBBZG9wdCBuZXcgYXN5bmMgX3NhdmVjb29raWVzIFNQSSBmb3Iga2VlcGlu ZyBuZXR3b3JraW5nIHByb2Nlc3MgYWN0aXZlIGR1cmluZyBmbHVzaGluZyBjb29raWVzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL2NmL0NvcmVNZWRpYVNvZnRMaW5rLmggYi9T b3VyY2UvV2ViQ29yZS9QQUwvcGFsL2NmL0NvcmVNZWRpYVNvZnRMaW5rLmgKaW5kZXggMjU2Y2Yy ZTVjZjQzMDE1NGNjMWFkYjgwY2FlNjY0MTJiOTcwOTA0Zi4uNzljM2NhYTk0N2EyNjZiODMyYTYw ZDM3YTMyOTA1ZWVlZWFhNjI1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9j Zi9Db3JlTWVkaWFTb2Z0TGluay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvY2YvQ29y ZU1lZGlhU29mdExpbmsuaApAQCAtMzcsNyArMzcsNyBAQAogI2RlZmluZSBTT0ZUTElOS19BVktJ VF9GUkFNRVdPUksoKSBTT0ZUX0xJTktfRlJBTUVXT1JLX09QVElPTkFMKEFWS2l0KQogI2VuZGlm CiAKLSNpZiAoUExBVEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJF RCA8PSAxMjAwMDApIHx8IChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPD0gMTAxNDAwKQorI2lmIChQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZF UlNJT05fTUFYX0FMTE9XRUQgPD0gMTIwMDAwKSB8fCAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19P U19YX1ZFUlNJT05fTUFYX0FMTE9XRUQgPD0gMTAxNDAwKSB8fCAoUExBVEZPUk0oV0FUQ0hPUykg JiYgX19XQVRDSF9PU19WRVJTSU9OX01BWF9BTExPV0VEIDw9IDUwMDAwKSB8fCAoUExBVEZPUk0o VFZPUykgJiYgX19UVl9PU19WRVJTSU9OX01BWF9BTExPV0VEIDw9IDEyMDAwMCkKICNkZWZpbmUg Q01TQU1QTEVCVUZGRVJDQUxMX05PRVNDQVBFCiAjZWxzZQogI2RlZmluZSBDTVNBTVBMRUJVRkZF UkNBTExfTk9FU0NBUEUgQ0ZfTk9FU0NBUEUK 340221 2018-05-11 13:59:33 -0700 2018-05-11 15:03:12 -0700 Patch bug-185560-20180511135932.patch text/plain 1562 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCAzZGMxN2Ji YTU0NmIwMTNhMmQ0M2Y4NzM2YTAxYjQzMWFmMTVjMTk0Li42N2Q5OWU3MzJhOGU1YmMwMTY2NjVl ZGJhZmNiMzExMWFjNjA2ZWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxOC0wNS0xMSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgQ0ZfTk9FU0NBUEUgZGVjb3JhdG9ycyBmb3IgdHZPUyBhbmQgd2F0Y2hPUworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NTYwCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWwvY2YvQ29yZU1lZGlh U29mdExpbmsuaDoKKwogMjAxOC0wNS0wOCAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNv bT4KIAogICAgICAgICBBZG9wdCBuZXcgYXN5bmMgX3NhdmVjb29raWVzIFNQSSBmb3Iga2VlcGlu ZyBuZXR3b3JraW5nIHByb2Nlc3MgYWN0aXZlIGR1cmluZyBmbHVzaGluZyBjb29raWVzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL2NmL0NvcmVNZWRpYVNvZnRMaW5rLmggYi9T b3VyY2UvV2ViQ29yZS9QQUwvcGFsL2NmL0NvcmVNZWRpYVNvZnRMaW5rLmgKaW5kZXggMjU2Y2Yy ZTVjZjQzMDE1NGNjMWFkYjgwY2FlNjY0MTJiOTcwOTA0Zi4uNWEzZTViYWQ4ZGExMzQ3M2ZhZWVl YzllZGEyMWM5MTQ2MWIyODQwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9j Zi9Db3JlTWVkaWFTb2Z0TGluay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvY2YvQ29y ZU1lZGlhU29mdExpbmsuaApAQCAtMzcsNyArMzcsNyBAQAogI2RlZmluZSBTT0ZUTElOS19BVktJ VF9GUkFNRVdPUksoKSBTT0ZUX0xJTktfRlJBTUVXT1JLX09QVElPTkFMKEFWS2l0KQogI2VuZGlm CiAKLSNpZiAoUExBVEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJF RCA8PSAxMjAwMDApIHx8IChQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPD0gMTAxNDAwKQorI2lmIChQTEFURk9STShJT1MpICYmIF9fSVBIT05FX09TX1ZF UlNJT05fTUFYX0FMTE9XRUQgPCAxMzAwMDApIHx8IChQTEFURk9STShNQUMpICYmIF9fTUFDX09T X1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA8IDEwMTUwMCkgfHwgKFBMQVRGT1JNKFdBVENIT1MpICYm IF9fV0FUQ0hfT1NfVkVSU0lPTl9NQVhfQUxMT1dFRCA8IDYwMDAwKSB8fCAoUExBVEZPUk0oVFZP UykgJiYgX19UVl9PU19WRVJTSU9OX01BWF9BTExPV0VEIDwgMTMwMDAwKQogI2RlZmluZSBDTVNB TVBMRUJVRkZFUkNBTExfTk9FU0NBUEUKICNlbHNlCiAjZGVmaW5lIENNU0FNUExFQlVGRkVSQ0FM TF9OT0VTQ0FQRSBDRl9OT0VTQ0FQRQo=