185553 2018-05-11 10:49:41 -0700 LinkLoader fails to remove CachedResourceClient in some cases 2018-05-12 04:24:11 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned beidson cdumez commit-queue dbates ews-watchlist ggaren japhet yoav youennf oldest_to_newest 1423180 0 koivisto 2018-05-11 10:49:41 -0700 This may corrupt CachedResource client map. 1423181 1 koivisto 2018-05-11 10:49:59 -0700 <rdar://problem/36879656> 1423187 2 340204 koivisto 2018-05-11 11:03:14 -0700 Created attachment 340204 patch 1423188 3 koivisto 2018-05-11 11:05:40 -0700 The whole LinkPreloadResourceClient thing could use refactoring to be more robust and less confusing. This is the minimal fix. 1423197 4 340204 ggaren 2018-05-11 11:27:47 -0700 Comment on attachment 340204 patch r=me 1423213 5 340204 commit-queue 2018-05-11 12:05:42 -0700 Comment on attachment 340204 patch Clearing flags on attachment: 340204 Committed r231713: <https://trac.webkit.org/changeset/231713> 1423214 6 commit-queue 2018-05-11 12:05:44 -0700 All reviewed patches have been landed. Closing bug. 340204 2018-05-11 11:03:14 -0700 2018-05-11 12:05:42 -0700 patch link-preload-client-remove.patch text/plain 3560 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzMTcwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA1LTExICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBMaW5rTG9hZGVyIGZhaWxzIHRv IHJlbW92ZSBDYWNoZWRSZXNvdXJjZUNsaWVudCBpbiBzb21lIGNhc2VzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU1NTMKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzM2ODc5NjU2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMvcHJlbG9hZC9saW5rLXByZWxvYWQtY2xpZW50 LXJlbW92ZS5odG1sCisKKyAgICAgICAgKiBsb2FkZXIvTGlua0xvYWRlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpMaW5rTG9hZGVyOjpsb2FkTGluayk6CisKKyAgICAgICAgSWYgdGhlcmUgaXMg YSBsaW5rIHByZWxvYWQgYWxyZWFkeSBpbiBwcm9ncmVzcywgd2UgZmFpbCB0byBjbGVhciB0aGUg Y2xpZW50IGZvciB0aGUgb25nb2luZyBsb2FkLgorICAgICAgICBUaGlzIG1heSBsZWF2ZSB0aGUg Q2FjaGVkUmVzb3VyY2UgY2xpZW50IG1hcCBpbiBhIGJhZCBzdGF0ZS4KKwogMjAxOC0wNS0xMSAg QnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBzdXJlIGhp c3RvcnkgbmF2aWdhdGlvbnMgcmV1c2UgdGhlIGV4aXN0aW5nIHByb2Nlc3Mgd2hlbiBuZWNlc3Nh cnkuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvTGlua0xvYWRlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0xpbmtMb2FkZXIuY3BwCShyZXZpc2lvbiAyMzE1 NTMpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvTGlua0xvYWRlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTMwMSwxMCArMzAxLDEwIEBAIGJvb2wgTGlua0xvYWRlcjo6bG9hZExpbmsoY29uc3Qg TGlua1JlbEEKIAogICAgIGlmIChtX2NsaWVudC5zaG91bGRMb2FkTGluaygpKSB7CiAgICAgICAg IGF1dG8gcmVzb3VyY2VDbGllbnQgPSBwcmVsb2FkSWZOZWVkZWQocmVsQXR0cmlidXRlLCBocmVm LCBkb2N1bWVudCwgYXMsIG1lZGlhLCBtaW1lVHlwZSwgY3Jvc3NPcmlnaW4sIHRoaXMpOworICAg ICAgICBpZiAobV9wcmVsb2FkUmVzb3VyY2VDbGllbnQpCisgICAgICAgICAgICBtX3ByZWxvYWRS ZXNvdXJjZUNsaWVudC0+Y2xlYXIoKTsKICAgICAgICAgaWYgKHJlc291cmNlQ2xpZW50KQogICAg ICAgICAgICAgbV9wcmVsb2FkUmVzb3VyY2VDbGllbnQgPSBXVEZNb3ZlKHJlc291cmNlQ2xpZW50 KTsKLSAgICAgICAgZWxzZSBpZiAobV9wcmVsb2FkUmVzb3VyY2VDbGllbnQpCi0gICAgICAgICAg ICBtX3ByZWxvYWRSZXNvdXJjZUNsaWVudC0+Y2xlYXIoKTsKICAgICB9CiAKICAgICBwcmVmZXRj aElmTmVlZGVkKHJlbEF0dHJpYnV0ZSwgaHJlZiwgZG9jdW1lbnQpOwpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gMjMxNTUzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTgtMDUtMTEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29t PgorCisgICAgICAgIExpbmtMb2FkZXIgZmFpbHMgdG8gcmVtb3ZlIENhY2hlZFJlc291cmNlQ2xp ZW50IGluIHNvbWUgY2FzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NTU1MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzY4Nzk2NTY+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3Rz L3ByZWxvYWQvbGluay1wcmVsb2FkLWNsaWVudC1yZW1vdmUtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBodHRwL3Rlc3RzL3ByZWxvYWQvbGluay1wcmVsb2FkLWNsaWVudC1yZW1vdmUu aHRtbDogQWRkZWQuCisKIDIwMTgtMDUtMDkgIERvbWluaWsgSW5mdWVociAgPGRpbmZ1ZWhyQGln YWxpYS5jb20+CiAKICAgICAgICAgW0FSTV0gRGlzYWJsZSB0ZXN0IG9uIExpbnV4IGR1ZSB0byBs YWNrIG9mIGV4ZWN1dGFibGUgbWVtb3J5CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3By ZWxvYWQvbGluay1wcmVsb2FkLWNsaWVudC1yZW1vdmUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvcHJlbG9hZC9saW5rLXByZWxvYWQtY2xpZW50LXJl bW92ZS1leHBlY3RlZC50eHQJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0 cy9wcmVsb2FkL2xpbmstcHJlbG9hZC1jbGllbnQtcmVtb3ZlLWV4cGVjdGVkLnR4dAkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxIEBACitUZXN0IHRoYXQgcmVzdGFydGluZyBsaW5rIHByZWxvYWQg ZG9lc24ndCBhc3NlcnQgb3IgY3Jhc2guCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3By ZWxvYWQvbGluay1wcmVsb2FkLWNsaWVudC1yZW1vdmUuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL3ByZWxvYWQvbGluay1wcmVsb2FkLWNsaWVudC1yZW1vdmUuaHRt bAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3ByZWxvYWQvbGluay1w cmVsb2FkLWNsaWVudC1yZW1vdmUuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE3IEBA Cis8IURPQ1RZUEUgaHRtbD4KKzxzY3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAg ICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKQorICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgp OworICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24oKSB7CisgICAg ICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgIH0pOworfQorPC9zY3JpcHQ+Cis8bGlu ayBpZD1saW5rIHJlbD1wcmVsb2FkIGhyZWY9Ii4uL3Jlc291cmNlcy9kdW1teS5qcyIgYXM9ZmV0 Y2g+Cis8Ym9keT4KK1Rlc3QgdGhhdCByZXN0YXJ0aW5nIGxpbmsgcHJlbG9hZCBkb2Vzbid0IGFz c2VydCBvciBjcmFzaC4KKzwvYm9keT4KKzxzY3JpcHQ+CitsaW5rLnNldEF0dHJpYnV0ZSgicmVs IiwgInByZWxvYWQiKTsKKzwvc2NyaXB0Pgo=