185551 2018-05-11 10:21:35 -0700 [iOS] Text decoration of dragged content does not paint with opacity 2018-05-11 16:01:50 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build iPhone / iPad iOS 11 RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 dbates dbates bfulgham simon.fraser webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1423164 0 dbates 2018-05-11 10:21:35 -0700 On iOS, when dragging content that has a text decoration we change the opacity of the original text during the drag. However, if the dragged text had a text decoration the opacity of the decoration remains unchanged. 1423169 1 webkit-bug-importer 2018-05-11 10:32:48 -0700 <rdar://problem/40166867> 1423245 2 340219 dbates 2018-05-11 13:44:48 -0700 Created attachment 340219 Patch 1423246 3 dbates 2018-05-11 13:48:11 -0700 I did not include a test with this change because we do not have existing infrastructure for testing that the appearance of the dragged content marker and it seems non-trivial to add such infrastructure. I am open to ideas. 1423248 4 340219 wenson_hsieh 2018-05-11 13:52:02 -0700 Comment on attachment 340219 Patch Thanks for the patch! 1423293 5 340219 dbates 2018-05-11 16:01:48 -0700 Comment on attachment 340219 Patch Clearing flags on attachment: 340219 Committed r231725: <https://trac.webkit.org/changeset/231725> 1423294 6 dbates 2018-05-11 16:01:50 -0700 All reviewed patches have been landed. Closing bug. 340219 2018-05-11 13:44:48 -0700 2018-05-11 16:01:48 -0700 Patch bug-185551-20180511134448.patch text/plain 2641 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmIzZTVhNDJjN2I5ZGVi MWYxZjAwNzBkNjU1NGIxMjZmZjQ5NDYwMy4uMmRjOWQ2MDI2MGMyMjdiYjQ2OTJlNjUzYTI0OWM5 NzRjNWQwNTNkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA1LTExICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBUZXh0IGRlY29y YXRpb24gb2YgZHJhZ2dlZCBjb250ZW50IGRvZXMgbm90IHBhaW50IHdpdGggb3BhY2l0eQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NTUxCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS80MDE2Njg2Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZXNwZWN0IGFscGhhIHdoZW4gcGFpbnRpbmcgdGhlIHRl eHQgZGVjb3JhdGlvbiBmb3IgZHJhZ2dlZCBjb250ZW50LgorCisgICAgICAgICogcmVuZGVyaW5n L0lubGluZVRleHRCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5saW5lVGV4dEJveDo6TWFy a2VkVGV4dFN0eWxlOjphcmVEZWNvcmF0aW9uTWFya2VkVGV4dFN0eWxlc0VxdWFsKTogQ29uc2lk ZXIgYWxwaGEgd2hlbgorICAgICAgICBjb21wYXJpbmcgZGVjb3JhdGlvbiBzdHlsZXMgZm9yIGVx dWFsaXR5IHNvIHRoYXQgd2UgZG8gbm90IGNvYWxlc2NlIHN0eWxlcyB3aXRoIGRpZmZlcmluZyBh bHBoYS4KKyAgICAgICAgKFdlYkNvcmU6OklubGluZVRleHRCb3g6OnBhaW50TWFya2VkVGV4dERl Y29yYXRpb24pOiBSZXNwZWN0IGFscGhhIHdoZW4gcGFpbnRpbmcgZHJhZ2dlZCBjb250ZW50Lgor CiAyMDE4LTA1LTExICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAg ICBNYWtlIHN1cmUgaGlzdG9yeSBuYXZpZ2F0aW9ucyByZXVzZSB0aGUgZXhpc3RpbmcgcHJvY2Vz cyB3aGVuIG5lY2Vzc2FyeS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9J bmxpbmVUZXh0Qm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVUZXh0Qm94 LmNwcAppbmRleCA1YTg1OWJiZDMwNzc5ZGRmMzdiOGI4Njc2NzVmZGU1N2NhYTg4MTZiLi41OGZm Nzk4NTNiZGRkMjA3Yzc2MjhmZTdkYjc3ZmFjMjk5ZDFkMzU5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCkBAIC00MDMsNyArNDAzLDcgQEAgc3RydWN0IElu bGluZVRleHRCb3g6Ok1hcmtlZFRleHRTdHlsZSB7CiAgICAgfQogICAgIHN0YXRpYyBib29sIGFy ZURlY29yYXRpb25NYXJrZWRUZXh0U3R5bGVzRXF1YWwoY29uc3QgTWFya2VkVGV4dFN0eWxlJiBh LCBjb25zdCBNYXJrZWRUZXh0U3R5bGUmIGIpCiAgICAgewotICAgICAgICByZXR1cm4gYS50ZXh0 RGVjb3JhdGlvblN0eWxlcyA9PSBiLnRleHREZWNvcmF0aW9uU3R5bGVzICYmIGEudGV4dFNoYWRv dyA9PSBiLnRleHRTaGFkb3c7CisgICAgICAgIHJldHVybiBhLnRleHREZWNvcmF0aW9uU3R5bGVz ID09IGIudGV4dERlY29yYXRpb25TdHlsZXMgJiYgYS50ZXh0U2hhZG93ID09IGIudGV4dFNoYWRv dyAmJiBhLmFscGhhID09IGIuYWxwaGE7CiAgICAgfQogCiAgICAgQ29sb3IgYmFja2dyb3VuZENv bG9yOwpAQCAtMTA3NSw5ICsxMDc1LDEzIEBAIHZvaWQgSW5saW5lVGV4dEJveDo6cGFpbnRNYXJr ZWRUZXh0RGVjb3JhdGlvbihQYWludEluZm8mIHBhaW50SW5mbywgY29uc3QgRmxvYXRSCiAKICAg ICB7CiAgICAgICAgIEdyYXBoaWNzQ29udGV4dFN0YXRlU2F2ZXIgc3RhdGVTYXZlciB7IGNvbnRl eHQsIGZhbHNlIH07Ci0gICAgICAgIGlmICghY2xpcE91dFJlY3QuaXNFbXB0eSgpKSB7CisgICAg ICAgIGJvb2wgaXNEcmFnZ2VkQ29udGVudCA9IG1hcmtlZFRleHQudHlwZSA9PSBNYXJrZWRUZXh0 OjpEcmFnZ2VkQ29udGVudDsKKyAgICAgICAgaWYgKGlzRHJhZ2dlZENvbnRlbnQgfHwgIWNsaXBP dXRSZWN0LmlzRW1wdHkoKSkgewogICAgICAgICAgICAgc3RhdGVTYXZlci5zYXZlKCk7Ci0gICAg ICAgICAgICBjb250ZXh0LmNsaXBPdXQoY2xpcE91dFJlY3QpOworICAgICAgICAgICAgaWYgKGlz RHJhZ2dlZENvbnRlbnQpCisgICAgICAgICAgICAgICAgY29udGV4dC5zZXRBbHBoYShtYXJrZWRU ZXh0LnN0eWxlLmFscGhhKTsKKyAgICAgICAgICAgIGlmICghY2xpcE91dFJlY3QuaXNFbXB0eSgp KQorICAgICAgICAgICAgICAgIGNvbnRleHQuY2xpcE91dChjbGlwT3V0UmVjdCk7CiAgICAgICAg IH0KICAgICAgICAgZGVjb3JhdGlvblBhaW50ZXIucGFpbnRUZXh0RGVjb3JhdGlvbih0ZXh0UnVu LnN1YlJ1bihzdGFydE9mZnNldCwgZW5kT2Zmc2V0IC0gc3RhcnRPZmZzZXQpLCB0ZXh0T3JpZ2lu RnJvbUJveFJlY3Qoc25hcHBlZFNlbGVjdGlvblJlY3QpLCBzbmFwcGVkU2VsZWN0aW9uUmVjdC5s b2NhdGlvbigpKTsKICAgICB9Cg==