185540 2018-05-10 22:25:12 -0700 CommitLogViewer._preceedingCommit should not always be null 2024-02-25 10:41:50 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dewei_zhu webkit-unassigned ahmad.saleem792 dewei_zhu rniwa oldest_to_newest 1423045 0 dewei_zhu 2018-05-10 22:25:12 -0700 CommitLogViewer._preceedingCommit should not always be null 1423046 1 340171 dewei_zhu 2018-05-10 22:27:26 -0700 Created attachment 340171 Patch 1423070 2 rniwa 2018-05-11 00:01:50 -0700 Do we have a test for this? 2016719 3 ahmad.saleem792 2024-02-25 10:41:50 -0800 Landed - https://github.com/WebKit/WebKit/commit/4ff938da6c1143e3cb8ab197b8b9fa78d6ca2a53 340171 2018-05-10 22:27:26 -0700 2018-05-11 00:01:42 -0700 Patch bug-185540-20180510222726.patch text/plain 2919 dewei_zhu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNjg5CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCAzNmUxOGY2MmU3NWJhNTA1YTMxY2I1ZDBlZGMxZTFiMDM2MjIyNDI4Li45NjJjNDY3MTc0 ODhkNDJjODkyOWVmNmI3ZmZkNDc2NzIzNjU1ZDk4IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxOC0wNS0xMCAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1 QGFwcGxlLmNvbT4KKworICAgICAgICBDb21taXRMb2dWaWV3ZXIuX3ByZWNlZWRpbmdDb21taXQg c2hvdWxkIG5vdCBhbHdheXMgYmUgbnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NTQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgRml4IHRoZSBidWcgaW50cm9kdWNlZCBpbiByMjI3NzQ2IHRoYXQg Q29tbWl0TG9nVmlld2VyLl9wcmVjZWVkaW5nQ29tbWl0IGlzIGFsd2F5cyBudWxsLgorCisgICAg ICAgICogYnJvd3Nlci10ZXN0cy9pbmRleC5odG1sOiBGaXggZXhwZWN0ZWQgbWVhc3VyZW1lbnQt c2V0IHVybC4KKyAgICAgICAgKiBwdWJsaWMvdjMvY29tcG9uZW50cy9jb21taXQtbG9nLXZpZXdl ci5qczogCisgICAgICAgIChDb21taXRMb2dWaWV3ZXIucHJvdG90eXBlLl9mZXRjaENvbW1pdExv Z3MpOiBDb21taXRMb2dWaWV3ZXIuX3ByZWNlZWRpbmdDb21taXQgc2hvdWxkIGJlIHNldAorICAg ICAgICAgd2hlbiBmZXRjaGluZyBmb3IgcHJlY2VlZGluZyByZXZpc2lvbiBzdWNjZWVkcy4KKwog MjAxOC0wNS0wMyAgRGV3ZWkgWmh1ICA8ZGV3ZWlfemh1QGFwcGxlLmNvbT4KIAogICAgICAgICBS YW5nZSBiaXNlY3RvciBzaG91bGQgY2hlY2sgdGhlIGNvbW1pdHMgZm9yIHJlcG9zaXRvcmllcyB3 aXRob3V0IGNoYW5nZSBpbiBzcGVjaWZpZWQgcmFuZ2UuCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9w ZXJmLndlYmtpdC5vcmcvYnJvd3Nlci10ZXN0cy9pbmRleC5odG1sIGIvV2Vic2l0ZXMvcGVyZi53 ZWJraXQub3JnL2Jyb3dzZXItdGVzdHMvaW5kZXguaHRtbAppbmRleCA1MTdhZTg1MWVkNmQ3OGU3 NTIzZTY1YjZlMzllNGQ2YzVkMjEwYTU2Li5kZGVkMTc5MDUwMzQyMjU0MWVhOTAzNDMyNDRhMzNi YWE4OTA2NDUwIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvYnJvd3Nlci10 ZXN0cy9pbmRleC5odG1sCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9icm93c2VyLXRl c3RzL2luZGV4Lmh0bWwKQEAgLTM2Myw3ICszNjMsNyBAQCBjb25zdCBDaGFydFRlc3QgPSB7CiAK ICAgICByZXNwb25kV2l0aFNhbXBsZUNsdXN0ZXIocmVxdWVzdCwgb3B0aW9ucykKICAgICB7Ci0g ICAgICAgIGV4cGVjdChyZXF1ZXN0LnVybCkudG8uYmUoJy4uL2RhdGEvbWVhc3VyZW1lbnQtc2V0 LTEtMS5qc29uJyk7CisgICAgICAgIGV4cGVjdChyZXF1ZXN0LnVybCkudG8uYmUoJy9kYXRhL21l YXN1cmVtZW50LXNldC0xLTEuanNvbicpOwogICAgICAgICBleHBlY3QocmVxdWVzdC5tZXRob2Qp LnRvLmJlKCdHRVQnKTsKICAgICAgICAgcmVxdWVzdC5yZXNvbHZlKHRoaXMubWFrZVNhbXBsZUNs dXN0ZXIob3B0aW9ucykpOwogICAgIH0sCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtp dC5vcmcvcHVibGljL3YzL2NvbXBvbmVudHMvY29tbWl0LWxvZy12aWV3ZXIuanMgYi9XZWJzaXRl cy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL2NvbXBvbmVudHMvY29tbWl0LWxvZy12aWV3ZXIu anMKaW5kZXggMDA1YjU1MmZhNTZiNmRhY2QzZDkwZmIzNjNiZjllYTMyNjJiMGI3Yi4uN2E4ZTNi OTNlODJjOWRiNGYyNDFmN2ZkMDEwMmUyZThkMGYyMmNmOCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMv cGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9jb21wb25lbnRzL2NvbW1pdC1sb2ctdmlld2VyLmpz CisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvY29tcG9uZW50cy9jb21t aXQtbG9nLXZpZXdlci5qcwpAQCAtMzYsNyArMzYsNiBAQCBjbGFzcyBDb21taXRMb2dWaWV3ZXIg ZXh0ZW5kcyBDb21wb25lbnRCYXNlIHsKICAgICAgICAgfQogCiAgICAgICAgIGxldCBwcm9taXNl OwotICAgICAgICBsZXQgcHJlY2VkaW5nQ29tbWl0UHJvbWlzZTsKICAgICAgICAgY29uc3QgZmV0 Y2hTaW5nbGVDb21taXQgPSAhcHJlY2VkaW5nUmV2aXNpb24gfHwgcHJlY2VkaW5nUmV2aXNpb24g PT0gbGFzdFJldmlzaW9uOwogICAgICAgICBpZiAoZmV0Y2hTaW5nbGVDb21taXQpIHsKICAgICAg ICAgICAgIHByb21pc2UgPSBDb21taXRMb2cuZmV0Y2hGb3JTaW5nbGVSZXZpc2lvbihyZXBvc2l0 b3J5LCBsYXN0UmV2aXNpb24pLnRoZW4oKGNvbW1pdHMpID0+IHsKQEAgLTU1LDcgKzU0LDcgQEAg Y2xhc3MgQ29tbWl0TG9nVmlld2VyIGV4dGVuZHMgQ29tcG9uZW50QmFzZSB7CiAgICAgICAgICAg ICAgICAgQ29tbWl0TG9nLmZldGNoRm9yU2luZ2xlUmV2aXNpb24ocmVwb3NpdG9yeSwgcHJlY2Vk aW5nUmV2aXNpb24pLnRoZW4oKHByZWNlZGluZ0NvbW1pdCkgPT4gewogICAgICAgICAgICAgICAg ICAgICBpZiAodGhpcy5fZmV0Y2hpbmdQcm9taXNlICE9IHByb21pc2UpCiAgICAgICAgICAgICAg ICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICAgICAgICAgIHRoaXMuX3ByZWNlZGluZ0Nv bW1pdCA9IG51bGw7CisgICAgICAgICAgICAgICAgICAgIHRoaXMuX3ByZWNlZGluZ0NvbW1pdCA9 IHByZWNlZGluZ0NvbW1pdFswXTsKICAgICAgICAgICAgICAgICB9KQogICAgICAgICAgICAgXSk7 CiAgICAgICAgIH0K