<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>185533</bug_id>
          
          <creation_ts>2018-05-10 16:09:56 -0700</creation_ts>
          <short_desc>build-webkit can erroneously warn about Xcode being too old</short_desc>
          <delta_ts>2018-05-10 17:11:01 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryosuke Niwa">rniwa</reporter>
          <assigned_to name="Ryosuke Niwa">rniwa</assigned_to>
          <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dbates</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>ggaren</cc>
    
    <cc>lforschler</cc>
    
    <cc>mitz</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1422925</commentid>
    <comment_count>0</comment_count>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-05-10 16:09:56 -0700</bug_when>
    <thetext>Fix that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422926</commentid>
    <comment_count>1</comment_count>
      <attachid>340143</attachid>
    <who name="Ryosuke Niwa">rniwa</who>
    <bug_when>2018-05-10 16:12:47 -0700</bug_when>
    <thetext>Created attachment 340143
Fixes the bug</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422931</commentid>
    <comment_count>2</comment_count>
      <attachid>340143</attachid>
    <who name="">mitz</who>
    <bug_when>2018-05-10 16:17:18 -0700</bug_when>
    <thetext>Comment on attachment 340143
Fixes the bug

Seems OK, but I doubt that the mechanism that the Xcode version check that uses this is correct.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422956</commentid>
    <comment_count>3</comment_count>
      <attachid>340143</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-05-10 17:06:38 -0700</bug_when>
    <thetext>Comment on attachment 340143
Fixes the bug

Clearing flags on attachment: 340143

Committed r231677: &lt;https://trac.webkit.org/changeset/231677&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422957</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-05-10 17:06:40 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422960</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-05-10 17:11:01 -0700</bug_when>
    <thetext>&lt;rdar://problem/40147925&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>340143</attachid>
            <date>2018-05-10 16:12:47 -0700</date>
            <delta_ts>2018-05-10 17:06:38 -0700</delta_ts>
            <desc>Fixes the bug</desc>
            <filename>bug-185533-20180510161246.patch</filename>
            <type>text/plain</type>
            <size>1206</size>
            <attacher name="Ryosuke Niwa">rniwa</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIzMTY3MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE1IEBACisyMDE4LTA1LTEwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor
CisgICAgICAgIGJ1aWxkLXdlYmtpdCBjYW4gZXJyb25lb3VzbHkgd2FybiBhYm91dCBYY29kZSBi
ZWluZyB0b28gb2xkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xODU1MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICBEb24ndCBhc3N1bWUgdGhlIHZlcnNpb24gbnVtYmVyIGlzIGFsd2F5cyBhIHNpbmdsZSBk
aWdpdC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVy
bWluZVhjb2RlVmVyc2lvbik6CisKIDIwMTgtMDUtMTAgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNh
dGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEZpeCBzb21lIC1Xc3RyaW5nLW9wLXRydW5j
YXRpb24gd2FybmluZ3MKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDIzMTY1NCkKKysr
IFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkod29ya2luZyBjb3B5KQpAQCAtMjMwLDcgKzIz
MCw3IEBAIHN1YiBkZXRlcm1pbmVYY29kZVZlcnNpb24KIHsKICAgICByZXR1cm4gaWYgZGVmaW5l
ZCAkeGNvZGVWZXJzaW9uOwogICAgIG15ICR4Y29kZWJ1aWxkVmVyc2lvbk91dHB1dCA9IGB4Y29k
ZWJ1aWxkIC12ZXJzaW9uYDsKLSAgICAkeGNvZGVWZXJzaW9uID0gKCR4Y29kZWJ1aWxkVmVyc2lv
bk91dHB1dCA9fiAvWGNvZGUgKFswLTldKFwuWzAtOV0rKSopLykgPyAkMSA6ICIzLjAiOworICAg
ICR4Y29kZVZlcnNpb24gPSAoJHhjb2RlYnVpbGRWZXJzaW9uT3V0cHV0ID1+IC9YY29kZSAoWzAt
OV0rKFwuWzAtOV0rKSopLykgPyAkMSA6ICIzLjAiOwogfQogCiBzdWIgcmVhZFhjb2RlVXNlckRl
ZmF1bHQoJCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>