185528 2018-05-10 14:01:15 -0700 [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements. 2018-05-10 16:15:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ross.kirsling ross.kirsling commit-queue don.olmstead ews-watchlist lforschler pvollan webkit-bug-importer oldest_to_newest 1422859 0 ross.kirsling 2018-05-10 14:01:15 -0700 [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements. 1422860 1 340126 ross.kirsling 2018-05-10 14:01:38 -0700 Created attachment 340126 Patch 1422861 2 ews-watchlist 2018-05-10 14:03:04 -0700 Attachment 340126 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:85: [TestFactory.__init__] Undefined variable 'InstallWinCairoDependencies' [pylint/E0602] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1422862 3 ross.kirsling 2018-05-10 14:04:38 -0700 `build-webkit` does this automatically: https://github.com/WebKit/webkit/blob/master/Tools/Scripts/build-webkit#L242-L243 But the test bot, of course, runs `--no-build`, so we need to actually ask for the dependencies. 1422863 4 ross.kirsling 2018-05-10 14:06:57 -0700 Style error should be a mistake...? 1422927 5 340126 commit-queue 2018-05-10 16:14:58 -0700 Comment on attachment 340126 Patch Clearing flags on attachment: 340126 Committed r231673: <https://trac.webkit.org/changeset/231673> 1422928 6 commit-queue 2018-05-10 16:14:59 -0700 All reviewed patches have been landed. Closing bug. 1422929 7 webkit-bug-importer 2018-05-10 16:15:37 -0700 <rdar://problem/40146077> 340126 2018-05-10 14:01:38 -0700 2018-05-10 16:14:58 -0700 Patch bug-185528-20180510140139.patch text/plain 2558 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNjUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNWU5NmMzMWQ4NDFkZDRkOWFlMDRmYmYxNjk3MGRlNWQy YWI4YTk0OS4uZWE2ZjQ1NWNlYmQ3ZWFlY2VlYzcyODI5MzgzNzlkM2I4ZmNjYWU4OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE4LTA1LTEwICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4K KworICAgICAgICBbV2luQ2Fpcm9dW0J1aWxkYm90XSBUZXN0IGJvdHMgbmVlZCB0byBhY3F1aXJl IFdpbkNhaXJvUmVxdWlyZW1lbnRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg1NTI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9mYWN0b3JpZXMucHk6CisgICAgICAgIChUZXN0RmFjdG9yeS5fX2luaXRfXyk6CisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvc3RlcHMucHk6Cisg ICAgICAgIChJbnN0YWxsV2luQ2Fpcm9EZXBlbmRlbmNpZXMpOgorCiAyMDE4LTA1LTEwICBTdGVw aGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4KIAogICAgICAgICBTdXBwb3J0IC0t dmVyYm9zZSBpbiBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL2ZhY3Rvcmllcy5weSBiL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL2ZhY3Rvcmllcy5w eQppbmRleCA2OTBlMzkyZTAwOGEwODUzNzAyNzgyZjgzYTQ2ZmJjZGMwOGMyNzc3Li5mOGI3MzNl MzE2NjcyZjk4YzIxM2E2ZDg2NGJjYjY3ZTU0ZjBjNWE5IDEwMDY0NAotLS0gYS9Ub29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9mYWN0b3JpZXMucHkKKysrIGIv VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvZmFjdG9yaWVz LnB5CkBAIC04MCw2ICs4MCwxMCBAQCBjbGFzcyBUZXN0RmFjdG9yeShGYWN0b3J5KToKICAgICBk ZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb24sIGFyY2hpdGVjdHVyZXMs IGFkZGl0aW9uYWxBcmd1bWVudHM9Tm9uZSwgU1ZOTWlycm9yPU5vbmUsICoqa3dhcmdzKToKICAg ICAgICAgRmFjdG9yeS5fX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJhdGlvbiwgYXJj aGl0ZWN0dXJlcywgRmFsc2UsIGFkZGl0aW9uYWxBcmd1bWVudHMsIFNWTk1pcnJvciwgKiprd2Fy Z3MpCiAgICAgICAgIHNlbGYuZ2V0UHJvZHVjdCgpCisKKyAgICAgICAgaWYgcGxhdGZvcm0gPT0g J3dpbmNhaXJvJzoKKyAgICAgICAgICAgIHNlbGYuYWRkU3RlcChJbnN0YWxsV2luQ2Fpcm9EZXBl bmRlbmNpZXMoKSkKKwogICAgICAgICBpZiBzZWxmLkpTQ1Rlc3RDbGFzczoKICAgICAgICAgICAg IHNlbGYuYWRkU3RlcChzZWxmLkpTQ1Rlc3RDbGFzcygpKQogICAgICAgICBpZiBzZWxmLkxheW91 dFRlc3RDbGFzczoKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL3N0ZXBzLnB5IGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvc3RlcHMucHkKaW5kZXggYmZlN2VkMTc4MTM0NzAxMjRmMjM1OWQy ZjI3OWMzNjU2ODJhYzZmMS4uMzYxNjEwODc2NzI0YzNkZjQwNjg1ZGIwMjYzZWZiMjJkOWU5NDVh NyAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1j b25maWcvc3RlcHMucHkKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvc3RlcHMucHkKQEAgLTE2MCw2ICsxNjAsMTQgQEAgY2xhc3MgRGVsZXRlU3Rh bGVCdWlsZEZpbGVzKHNoZWxsLkNvbXBpbGUpOgogICAgICAgICByZXR1cm4gc2hlbGwuQ29tcGls ZS5zdGFydChzZWxmKQogCiAKK2NsYXNzIEluc3RhbGxXaW5DYWlyb0RlcGVuZGVuY2llcyhzaGVs bC5TaGVsbENvbW1hbmQpOgorICAgIG5hbWUgPSAnd2luY2Fpcm8tcmVxdWlyZW1lbnRzJworICAg IGRlc2NyaXB0aW9uID0gWyd1cGRhdGluZyB3aW5jYWlybyBkZXBlbmRlbmNpZXMnXQorICAgIGRl c2NyaXB0aW9uRG9uZSA9IFsndXBkYXRlZCB3aW5jYWlybyBkZXBlbmRlbmNpZXMnXQorICAgIGNv bW1hbmQgPSBbJ3B5dGhvbicsICcuL1Rvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC13aW5jYWly by1saWJzLnB5J10KKyAgICBoYWx0T25GYWlsdXJlID0gVHJ1ZQorCisKIGNsYXNzIEluc3RhbGxH dGtEZXBlbmRlbmNpZXMoc2hlbGwuU2hlbGxDb21tYW5kKToKICAgICBuYW1lID0gImpoYnVpbGQi CiAgICAgZGVzY3JpcHRpb24gPSBbInVwZGF0aW5nIGd0ayBkZXBlbmRlbmNpZXMiXQo=