185527 2018-05-10 13:29:20 -0700 Exception in bot watcher's dashboard if a hidden platform in no longer configured for display 2018-11-29 15:52:40 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap aakash_jain commit-queue ews-watchlist lforschler ryanhaddad timothy webkit-bug-importer oldest_to_newest 1422837 0 ap 2018-05-10 13:29:20 -0700 We store hidden platforms in local storage, so we cannot expect that these platforms are valid with regards to currently running code. 1422838 1 340122 ap 2018-05-10 13:30:25 -0700 Created attachment 340122 proposed fix 1422840 2 ews-watchlist 2018-05-10 13:33:27 -0700 Attachment 340122 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:134: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1422848 3 340123 ap 2018-05-10 13:42:25 -0700 Created attachment 340123 proposed fix Oops, tab. 1483253 4 340123 commit-queue 2018-11-29 15:51:33 -0800 Comment on attachment 340123 proposed fix Clearing flags on attachment: 340123 Committed r238704: <https://trac.webkit.org/changeset/238704> 1483254 5 commit-queue 2018-11-29 15:51:34 -0800 All reviewed patches have been landed. Closing bug. 1483255 6 webkit-bug-importer 2018-11-29 15:52:40 -0800 <rdar://problem/46357482> 340122 2018-05-10 13:30:25 -0700 2018-05-10 13:42:25 -0700 proposed fix HiddenPlatform.txt text/plain 1510 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMTY1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE4LTA1LTEwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEV4Y2VwdGlvbiBpbiBib3Qgd2F0Y2hlcidzIGRhc2hib2FyZCBpZiBhIGhp ZGRlbiBwbGF0Zm9ybSBpbiBubyBsb25nZXIgY29uZmlndXJlZCBmb3IgZGlzcGxheQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NTI3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0 cy9NYWluLmpzOgorICAgICAgICAodXBkYXRlSGlkZGVuUGxhdGZvcm1zKToKKwogMjAxOC0wNS0x MCAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CiAKICAgICAgICAgU3Vw cG9ydCAtLXZlcmJvc2UgaW4gcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCkluZGV4OiBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU2NyaXB0cy9NYWluLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRz L01haW4uanMJKHJldmlzaW9uIDIzMTQzOCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL01haW4u anMJKHdvcmtpbmcgY29weSkKQEAgLTEzMCw2ICsxMzAsOCBAQCBmdW5jdGlvbiB1cGRhdGVIaWRk ZW5QbGF0Zm9ybXMoKQogCiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBoaWRkZW5QbGF0Zm9ybUZh bWlsaWVzLmxlbmd0aDsgKytpKSB7CiAgICAgICAgIHZhciBwbGF0Zm9ybUZhbWlseSA9IGhpZGRl blBsYXRmb3JtRmFtaWxpZXNbaV07CisgICAgICAgIGlmICghKHBsYXRmb3JtRmFtaWx5IGluIHBs YXRmb3Jtc0J5RmFtaWx5KSkKKyAgICAgICAgCWNvbnRpbnVlOwogICAgICAgICBmb3IgKHZhciBq ID0gMDsgaiA8IHBsYXRmb3Jtc0J5RmFtaWx5W3BsYXRmb3JtRmFtaWx5XS5sZW5ndGg7ICsraikg ewogICAgICAgICAgICAgdmFyIG5hbWUgPSBwbGF0Zm9ybXNCeUZhbWlseVtwbGF0Zm9ybUZhbWls eV1bal07CiAgICAgICAgICAgICB2YXIgcGxhdGZvcm1Sb3cgPSBkb2N1bWVudC5xdWVyeVNlbGVj dG9yKCJ0ci5wbGF0Zm9ybS4iICsgbmFtZSk7Cg== 340123 2018-05-10 13:42:25 -0700 2018-11-29 15:51:33 -0800 proposed fix HiddenPlatform.txt text/plain 1513 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMTY1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE4LTA1LTEwICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIEV4Y2VwdGlvbiBpbiBib3Qgd2F0Y2hlcidzIGRhc2hib2FyZCBpZiBhIGhp ZGRlbiBwbGF0Zm9ybSBpbiBubyBsb25nZXIgY29uZmlndXJlZCBmb3IgZGlzcGxheQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NTI3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0 cy9NYWluLmpzOgorICAgICAgICAodXBkYXRlSGlkZGVuUGxhdGZvcm1zKToKKwogMjAxOC0wNS0x MCAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CiAKICAgICAgICAgU3Vw cG9ydCAtLXZlcmJvc2UgaW4gcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCkluZGV4OiBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNo Ym9hcmQvU2NyaXB0cy9NYWluLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRz L01haW4uanMJKHJldmlzaW9uIDIzMTQzOCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1 aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL01haW4u anMJKHdvcmtpbmcgY29weSkKQEAgLTEzMCw2ICsxMzAsOCBAQCBmdW5jdGlvbiB1cGRhdGVIaWRk ZW5QbGF0Zm9ybXMoKQogCiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBoaWRkZW5QbGF0Zm9ybUZh bWlsaWVzLmxlbmd0aDsgKytpKSB7CiAgICAgICAgIHZhciBwbGF0Zm9ybUZhbWlseSA9IGhpZGRl blBsYXRmb3JtRmFtaWxpZXNbaV07CisgICAgICAgIGlmICghKHBsYXRmb3JtRmFtaWx5IGluIHBs YXRmb3Jtc0J5RmFtaWx5KSkKKyAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICBmb3IgKHZh ciBqID0gMDsgaiA8IHBsYXRmb3Jtc0J5RmFtaWx5W3BsYXRmb3JtRmFtaWx5XS5sZW5ndGg7ICsr aikgewogICAgICAgICAgICAgdmFyIG5hbWUgPSBwbGF0Zm9ybXNCeUZhbWlseVtwbGF0Zm9ybUZh bWlseV1bal07CiAgICAgICAgICAgICB2YXIgcGxhdGZvcm1Sb3cgPSBkb2N1bWVudC5xdWVyeVNl bGVjdG9yKCJ0ci5wbGF0Zm9ybS4iICsgbmFtZSk7Cg==