<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>185511</bug_id>
          
          <creation_ts>2018-05-10 05:45:34 -0700</creation_ts>
          <short_desc>[GTK] Implement ImageBuffer::toBGRAData</short_desc>
          <delta_ts>2018-05-10 07:51:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Thibault Saunier">tsaunier</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>tsaunier</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1422697</commentid>
    <comment_count>0</comment_count>
    <who name="Thibault Saunier">tsaunier</who>
    <bug_when>2018-05-10 05:45:34 -0700</bug_when>
    <thetext>.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422698</commentid>
    <comment_count>1</comment_count>
      <attachid>340086</attachid>
    <who name="Thibault Saunier">tsaunier</who>
    <bug_when>2018-05-10 05:49:58 -0700</bug_when>
    <thetext>Created attachment 340086
[GTK] Implement ImageBuffer::toBGRAData

This was never implemented but will is required for the MediaStream API
tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422699</commentid>
    <comment_count>2</comment_count>
      <attachid>340087</attachid>
    <who name="Thibault Saunier">tsaunier</who>
    <bug_when>2018-05-10 05:51:39 -0700</bug_when>
    <thetext>Created attachment 340087
Minor typo fix since previous version.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422704</commentid>
    <comment_count>3</comment_count>
      <attachid>340087</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2018-05-10 06:44:52 -0700</bug_when>
    <thetext>Comment on attachment 340087
Minor typo fix since previous version.

View in context: https://bugs.webkit.org/attachment.cgi?id=340087&amp;action=review

&gt; Source/WebCore/ChangeLog:8
&gt; +        [GTK] Implement ImageBuffer::toBGRAData

The commit title doesn&apos;t belong here, you already have it properly up at the top.

&gt; Source/WebCore/platform/graphics/ImageBuffer.cpp:105
&gt; +#if USE(CG) &amp;&amp; !PLATFORM(GTK)

Move the CG implementation to ImageBufferCG.cpp, then this condition can become #if !USE(CG) &amp;&amp; !PLATFORM(GTK).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422707</commentid>
    <comment_count>4</comment_count>
      <attachid>340088</attachid>
    <who name="Thibault Saunier">tsaunier</who>
    <bug_when>2018-05-10 07:06:35 -0700</bug_when>
    <thetext>Created attachment 340088
(In reply to Michael Catanzaro from comment #3)

&gt; Comment on attachment 340087 [details]
&gt; Minor typo fix since previous version.
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=340087&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/ChangeLog:8
&gt; &gt; +        [GTK] Implement ImageBuffer::toBGRAData
&gt; 
&gt; The commit title doesn&apos;t belong here, you already have it properly up at the
&gt; top.

Not sure how that happened, I just used prepareChangeLog, anyway Fixed.

&gt; &gt; Source/WebCore/platform/graphics/ImageBuffer.cpp:105
&gt; &gt; +#if USE(CG) &amp;&amp; !PLATFORM(GTK)
&gt; 
&gt; Move the CG implementation to ImageBufferCG.cpp, then this condition can
&gt; become #if !USE(CG) &amp;&amp; !PLATFORM(GTK).

Done.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422716</commentid>
    <comment_count>5</comment_count>
      <attachid>340088</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-05-10 07:50:47 -0700</bug_when>
    <thetext>Comment on attachment 340088
(In reply to Michael Catanzaro from comment #3)

Clearing flags on attachment: 340088

Committed r231638: &lt;https://trac.webkit.org/changeset/231638&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422717</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2018-05-10 07:50:49 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1422718</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2018-05-10 07:51:41 -0700</bug_when>
    <thetext>&lt;rdar://problem/40127886&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>340086</attachid>
            <date>2018-05-10 05:49:58 -0700</date>
            <delta_ts>2018-05-10 05:51:39 -0700</delta_ts>
            <desc>[GTK] Implement ImageBuffer::toBGRAData</desc>
            <filename>GTK-Implement-ImageBuffertoBGRAData.patch</filename>
            <type>text/plain</type>
            <size>3259</size>
            <attacher name="Thibault Saunier">tsaunier</attacher>
            
              <data encoding="base64">RnJvbSA2NDJkY2RlZmY5YTQyODBkNjZiOWM2M2FlMjUwZTVjYjMxOGEyMGEwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUaGliYXVsdCBTYXVuaWVyIDx0c2F1bmllckBpZ2FsaWEuY29t
PgpEYXRlOiBXZWQsIDI1IEFwciAyMDE4IDExOjU5OjU5IC0wMzAwClN1YmplY3Q6IFtQQVRDSCB4
c2VydmVyXSBbR1RLXSBJbXBsZW1lbnQgSW1hZ2VCdWZmZXI6OnRvQkdSQURhdGEKClRoaXMgd2Fz
IG5ldmVyIGltcGxlbWVudGVkIGJ1dCB3aWxsIGlzIHJlcXVpcmVkIGZvciB0aGUgTWVkaWFTdHJl
YW0gQVBJCnRlc3RzLgoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4
NTUxMQotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg
ICB8IDE2ICsrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L0ltYWdlQnVmZmVyLmNwcCB8ICAyICsrCiAuLi4vcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdl
QnVmZmVyR3RrLmNwcCAgICAgfCAxMiArKysrKysrKysrKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjkg
aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMDM0YTBlNzUxMS4u
MGJjODllMjMxMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T
b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxOC0wNS0xMCAgVGhp
YmF1bHQgU2F1bmllciAgPHRzYXVuaWVyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gSW1w
bGVtZW50IEltYWdlQnVmZmVyOjp0b0JHUkFEYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU1MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBJbXBsZW1lbnQgSW1hZ2VCdWZmZXI6OnRvQkdS
QURhdGEKKworICAgICAgICBUaGlzIHdhcyBuZXZlciBpbXBsZW1lbnRlZCBidXQgd2lsbCBpcyBy
ZXF1aXJlZCBmb3IgdGhlIE1lZGlhU3RyZWFtIEFQSQorICAgICAgICB0ZXN0cy4KKworICAgICAg
ICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9y
bS9ncmFwaGljcy9ndGsvSW1hZ2VCdWZmZXJHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1h
Z2VCdWZmZXI6OnRvQkdSQURhdGEgY29uc3QpOgorCiAyMDE4LTA1LTEwICBUaGliYXVsdCBTYXVu
aWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBGaXggc3R5
bGUgaXNzdWUgaW4gTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZQpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuY3BwIGIvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuY3BwCmluZGV4IDQxNDViMmI4
ZjFlLi4xMWM5MWJjZGM2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh
cGhpY3MvSW1hZ2VCdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo
aWNzL0ltYWdlQnVmZmVyLmNwcApAQCAtMTAyLDYgKzEwMiw3IEBAIEZsb2F0UmVjdCBJbWFnZUJ1
ZmZlcjo6Y2xhbXBlZFJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KQogICAgIHJldHVybiBGbG9h
dFJlY3QocmVjdC5sb2NhdGlvbigpLCBjbGFtcGVkU2l6ZShyZWN0LnNpemUoKSkpOwogfQogCisj
aWYgVVNFKENHKSAmJiAhUExBVEZPUk0oR1RLKQogVmVjdG9yPHVpbnQ4X3Q+IEltYWdlQnVmZmVy
Ojp0b0JHUkFEYXRhKCkgY29uc3QKIHsKICNpZiBVU0UoQ0cpCkBAIC0xMTMsNiArMTE0LDcgQEAg
VmVjdG9yPHVpbnQ4X3Q+IEltYWdlQnVmZmVyOjp0b0JHUkFEYXRhKCkgY29uc3QKICAgICByZXR1
cm4geyB9OwogI2VuZGlmCiB9CisjZW5kaWYKIAogI2lmICEoVVNFKENHKSB8fCBVU0UoRElSRUNU
MkQpKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsv
SW1hZ2VCdWZmZXJHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3Rr
L0ltYWdlQnVmZmVyR3RrLmNwcAppbmRleCBiMjNlNjQ3NjllOS4uZWQzYTExZjkxM2IgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUJ1ZmZlckd0
ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlQnVm
ZmVyR3RrLmNwcApAQCAtMjAsOCArMjAsOCBAQAogI2luY2x1ZGUgIkltYWdlQnVmZmVyLmgiCiAK
ICNpbmNsdWRlICJDYWlyb1V0aWxpdGllcy5oIgotI2luY2x1ZGUgIkdka0NhaXJvVXRpbGl0aWVz
LmgiCiAjaW5jbHVkZSAiR1JlZlB0ckd0ay5oIgorI2luY2x1ZGUgIkdka0NhaXJvVXRpbGl0aWVz
LmgiCiAjaW5jbHVkZSAiTUlNRVR5cGVSZWdpc3RyeS5oIgogI2luY2x1ZGUgPGNhaXJvLmg+CiAj
aW5jbHVkZSA8Z3RrL2d0ay5oPgpAQCAtODcsNiArODcsMTYgQEAgU3RyaW5nIEltYWdlQnVmZmVy
Ojp0b0RhdGFVUkwoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSwgc3RkOjpvcHRpb25hbDxkb3VibGU+
IHF1YWwKICAgICByZXR1cm4gImRhdGE6IiArIG1pbWVUeXBlICsgIjtiYXNlNjQsIiArIGJhc2U2
NERhdGE7CiB9CiAKK1ZlY3Rvcjx1aW50OF90PiBJbWFnZUJ1ZmZlcjo6dG9CR1JBRGF0YSgpIGNv
bnN0Cit7CisgICAgYXV0byBwaXhidWYgPSBhZG9wdEdSZWYoY2Fpcm9TdXJmYWNlVG9HZGtQaXhi
dWYobV9kYXRhLm1fc3VyZmFjZS5nZXQoKSkpOworICAgIGF1dG8gcGl4ZWxzID0gZ2RrX3BpeGJ1
Zl9nZXRfcGl4ZWxzKHBpeGJ1Zi5nZXQoKSk7CisKKyAgICBWZWN0b3I8dWludDhfdD4gaW1hZ2VE
YXRhOworICAgIGltYWdlRGF0YS5hcHBlbmQocGl4ZWxzLCBnZGtfcGl4YnVmX2dldF9ieXRlX2xl
bmd0aChwaXhidWYuZ2V0KCkpKTsKKyAgICByZXR1cm4gaW1hZ2VEYXRhOworfQorCiBWZWN0b3I8
dWludDhfdD4gSW1hZ2VCdWZmZXI6OnRvRGF0YShjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBzdGQ6
Om9wdGlvbmFsPGRvdWJsZT4gcXVhbGl0eSkgY29uc3QKIHsKICAgICBBU1NFUlQoTUlNRVR5cGVS
ZWdpc3RyeTo6aXNTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlRm9yRW5jb2RpbmcobWltZVR5cGUpKTsK
LS0gCjIuMTcuMA==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>340087</attachid>
            <date>2018-05-10 05:51:39 -0700</date>
            <delta_ts>2018-05-10 07:07:11 -0700</delta_ts>
            <desc>Minor typo fix since previous version.</desc>
            <filename>GTK-Implement-ImageBuffertoBGRAData.patch</filename>
            <type>text/plain</type>
            <size>3259</size>
            <attacher name="Thibault Saunier">tsaunier</attacher>
            
              <data encoding="base64">RnJvbSBjMTQzNGVhZDU3MDFkZWZmMzkyODhkZTI4M2ExYjE1OTZjNmVjNzFmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUaGliYXVsdCBTYXVuaWVyIDx0c2F1bmllckBpZ2FsaWEuY29t
PgpEYXRlOiBXZWQsIDI1IEFwciAyMDE4IDExOjU5OjU5IC0wMzAwClN1YmplY3Q6IFtQQVRDSCB4
c2VydmVyXSBbR1RLXSBJbXBsZW1lbnQgSW1hZ2VCdWZmZXI6OnRvQkdSQURhdGEKClRoaXMgd2Fz
IG5ldmVyIGltcGxlbWVudGVkIGJ1dCB3aWxsIGJlIHJlcXVpcmVkIGZvciB0aGUgTWVkaWFTdHJl
YW0gQVBJCnRlc3RzLgoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4
NTUxMQotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg
ICB8IDE2ICsrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L0ltYWdlQnVmZmVyLmNwcCB8ICAyICsrCiAuLi4vcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdl
QnVmZmVyR3RrLmNwcCAgICAgfCAxMiArKysrKysrKysrKy0KIDMgZmlsZXMgY2hhbmdlZCwgMjkg
aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl
L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMDM0YTBlNzUxMS4u
ZmU1MTIxNTA4NGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T
b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxOC0wNS0xMCAgVGhp
YmF1bHQgU2F1bmllciAgPHRzYXVuaWVyQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gSW1w
bGVtZW50IEltYWdlQnVmZmVyOjp0b0JHUkFEYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU1MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBJbXBsZW1lbnQgSW1hZ2VCdWZmZXI6OnRvQkdS
QURhdGEKKworICAgICAgICBUaGlzIHdhcyBuZXZlciBpbXBsZW1lbnRlZCBidXQgd2lsbCBiZSBy
ZXF1aXJlZCBmb3IgdGhlIE1lZGlhU3RyZWFtIEFQSQorICAgICAgICB0ZXN0cy4KKworICAgICAg
ICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9y
bS9ncmFwaGljcy9ndGsvSW1hZ2VCdWZmZXJHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1h
Z2VCdWZmZXI6OnRvQkdSQURhdGEgY29uc3QpOgorCiAyMDE4LTA1LTEwICBUaGliYXVsdCBTYXVu
aWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBGaXggc3R5
bGUgaXNzdWUgaW4gTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZQpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuY3BwIGIvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuY3BwCmluZGV4IDQxNDViMmI4
ZjFlLi4xMWM5MWJjZGM2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh
cGhpY3MvSW1hZ2VCdWZmZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo
aWNzL0ltYWdlQnVmZmVyLmNwcApAQCAtMTAyLDYgKzEwMiw3IEBAIEZsb2F0UmVjdCBJbWFnZUJ1
ZmZlcjo6Y2xhbXBlZFJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KQogICAgIHJldHVybiBGbG9h
dFJlY3QocmVjdC5sb2NhdGlvbigpLCBjbGFtcGVkU2l6ZShyZWN0LnNpemUoKSkpOwogfQogCisj
aWYgVVNFKENHKSAmJiAhUExBVEZPUk0oR1RLKQogVmVjdG9yPHVpbnQ4X3Q+IEltYWdlQnVmZmVy
Ojp0b0JHUkFEYXRhKCkgY29uc3QKIHsKICNpZiBVU0UoQ0cpCkBAIC0xMTMsNiArMTE0LDcgQEAg
VmVjdG9yPHVpbnQ4X3Q+IEltYWdlQnVmZmVyOjp0b0JHUkFEYXRhKCkgY29uc3QKICAgICByZXR1
cm4geyB9OwogI2VuZGlmCiB9CisjZW5kaWYKIAogI2lmICEoVVNFKENHKSB8fCBVU0UoRElSRUNU
MkQpKQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsv
SW1hZ2VCdWZmZXJHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3Rr
L0ltYWdlQnVmZmVyR3RrLmNwcAppbmRleCBiMjNlNjQ3NjllOS4uZWQzYTExZjkxM2IgMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUJ1ZmZlckd0
ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlQnVm
ZmVyR3RrLmNwcApAQCAtMjAsOCArMjAsOCBAQAogI2luY2x1ZGUgIkltYWdlQnVmZmVyLmgiCiAK
ICNpbmNsdWRlICJDYWlyb1V0aWxpdGllcy5oIgotI2luY2x1ZGUgIkdka0NhaXJvVXRpbGl0aWVz
LmgiCiAjaW5jbHVkZSAiR1JlZlB0ckd0ay5oIgorI2luY2x1ZGUgIkdka0NhaXJvVXRpbGl0aWVz
LmgiCiAjaW5jbHVkZSAiTUlNRVR5cGVSZWdpc3RyeS5oIgogI2luY2x1ZGUgPGNhaXJvLmg+CiAj
aW5jbHVkZSA8Z3RrL2d0ay5oPgpAQCAtODcsNiArODcsMTYgQEAgU3RyaW5nIEltYWdlQnVmZmVy
Ojp0b0RhdGFVUkwoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSwgc3RkOjpvcHRpb25hbDxkb3VibGU+
IHF1YWwKICAgICByZXR1cm4gImRhdGE6IiArIG1pbWVUeXBlICsgIjtiYXNlNjQsIiArIGJhc2U2
NERhdGE7CiB9CiAKK1ZlY3Rvcjx1aW50OF90PiBJbWFnZUJ1ZmZlcjo6dG9CR1JBRGF0YSgpIGNv
bnN0Cit7CisgICAgYXV0byBwaXhidWYgPSBhZG9wdEdSZWYoY2Fpcm9TdXJmYWNlVG9HZGtQaXhi
dWYobV9kYXRhLm1fc3VyZmFjZS5nZXQoKSkpOworICAgIGF1dG8gcGl4ZWxzID0gZ2RrX3BpeGJ1
Zl9nZXRfcGl4ZWxzKHBpeGJ1Zi5nZXQoKSk7CisKKyAgICBWZWN0b3I8dWludDhfdD4gaW1hZ2VE
YXRhOworICAgIGltYWdlRGF0YS5hcHBlbmQocGl4ZWxzLCBnZGtfcGl4YnVmX2dldF9ieXRlX2xl
bmd0aChwaXhidWYuZ2V0KCkpKTsKKyAgICByZXR1cm4gaW1hZ2VEYXRhOworfQorCiBWZWN0b3I8
dWludDhfdD4gSW1hZ2VCdWZmZXI6OnRvRGF0YShjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBzdGQ6
Om9wdGlvbmFsPGRvdWJsZT4gcXVhbGl0eSkgY29uc3QKIHsKICAgICBBU1NFUlQoTUlNRVR5cGVS
ZWdpc3RyeTo6aXNTdXBwb3J0ZWRJbWFnZU1JTUVUeXBlRm9yRW5jb2RpbmcobWltZVR5cGUpKTsK
LS0gCjIuMTcuMA==
</data>
<flag name="review"
          id="358323"
          type_id="1"
          status="+"
          setter="mcatanzaro"
    />
    <flag name="commit-queue"
          id="358324"
          type_id="3"
          status="-"
          setter="mcatanzaro"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>340088</attachid>
            <date>2018-05-10 07:06:35 -0700</date>
            <delta_ts>2018-05-10 07:50:47 -0700</delta_ts>
            <desc>(In reply to Michael Catanzaro from comment #3)</desc>
            <filename>GTK-Implement-ImageBuffertoBGRAData.patch</filename>
            <type>text/plain</type>
            <size>4248</size>
            <attacher name="Thibault Saunier">tsaunier</attacher>
            
              <data encoding="base64">RnJvbSAwOTJmZGJkNWUzOTY1OWVjMWNiN2M1ZGQ1N2U5ZGQ2ZGVjNDE2ZWEzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBUaGliYXVsdCBTYXVuaWVyIDx0c2F1bmllckBpZ2FsaWEuY29t
PgpEYXRlOiBXZWQsIDI1IEFwciAyMDE4IDExOjU5OjU5IC0wMzAwClN1YmplY3Q6IFtQQVRDSCB4
c2VydmVyXSBbR1RLXSBJbXBsZW1lbnQgSW1hZ2VCdWZmZXI6OnRvQkdSQURhdGEKClRoaXMgd2Fz
IG5ldmVyIGltcGxlbWVudGVkIGJ1dCB3aWxsIGJlIHJlcXVpcmVkIGZvciB0aGUgTWVkaWFTdHJl
YW0gQVBJCnRlc3RzLgoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4
NTUxMQotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg
IHwgMTcgKysrKysrKysrKysrKysrKysKIC4uLi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0lt
YWdlQnVmZmVyLmNwcCAgIHwgIDggKystLS0tLS0KIC4uLi9wbGF0Zm9ybS9ncmFwaGljcy9jZy9J
bWFnZUJ1ZmZlckNHLmNwcCAgICAgIHwgIDcgKysrKysrKwogLi4uL3BsYXRmb3JtL2dyYXBoaWNz
L2d0ay9JbWFnZUJ1ZmZlckd0ay5jcHAgICAgfCAxMiArKysrKysrKysrKy0KIDQgZmlsZXMgY2hh
bmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTRh
MTA4ZDRlOWEuLmU0ZjA5MDNkYzBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM
b2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTgt
MDUtMTAgIFRoaWJhdWx0IFNhdW5pZXIgIDx0c2F1bmllckBpZ2FsaWEuY29tPgorCisgICAgICAg
IFtHVEtdIEltcGxlbWVudCBJbWFnZUJ1ZmZlcjo6dG9CR1JBRGF0YQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NTExCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB3YXMgbmV2ZXIgaW1wbGVtZW50
ZWQgYnV0IHdpbGwgYmUgcmVxdWlyZWQgZm9yIHRoZSBNZWRpYVN0cmVhbSBBUEkKKyAgICAgICAg
dGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5jcHA6Cisg
ICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6dG9CR1JBRGF0YSBjb25zdCk6CisgICAgICAg
ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHA6CisgICAgICAgIChXZWJD
b3JlOjpJbWFnZUJ1ZmZlcjo6dG9CR1JBRGF0YSBjb25zdCk6CisgICAgICAgICogcGxhdGZvcm0v
Z3JhcGhpY3MvZ3RrL0ltYWdlQnVmZmVyR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdl
QnVmZmVyOjp0b0JHUkFEYXRhIGNvbnN0KToKKwogMjAxOC0wNS0xMCAgVGhpYmF1bHQgU2F1bmll
ciAgPHRzYXVuaWVyQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gRml4IHN0eWxl
IGlzc3VlIGluIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcCBiL1NvdXJjZS9X
ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmNwcAppbmRleCA0MTQ1YjJiOGYx
ZS4uOGU4NTk2NTBmMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo
aWNzL0ltYWdlQnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy9JbWFnZUJ1ZmZlci5jcHAKQEAgLTEwMiwxNyArMTAyLDEzIEBAIEZsb2F0UmVjdCBJbWFnZUJ1
ZmZlcjo6Y2xhbXBlZFJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KQogICAgIHJldHVybiBGbG9h
dFJlY3QocmVjdC5sb2NhdGlvbigpLCBjbGFtcGVkU2l6ZShyZWN0LnNpemUoKSkpOwogfQogCisj
aWYgIVVTRShDRykgJiYgIVBMQVRGT1JNKEdUSykKIFZlY3Rvcjx1aW50OF90PiBJbWFnZUJ1ZmZl
cjo6dG9CR1JBRGF0YSgpIGNvbnN0CiB7Ci0jaWYgVVNFKENHKQotICAgIGlmIChjb250ZXh0KCku
aXNBY2NlbGVyYXRlZENvbnRleHQoKSkKLSAgICAgICAgZmx1c2hDb250ZXh0KCk7Ci0gICAgcmV0
dXJuIG1fZGF0YS50b0JHUkFEYXRhKGNvbnRleHQoKS5pc0FjY2VsZXJhdGVkQ29udGV4dCgpLCBt
X3NpemUud2lkdGgoKSwgbV9zaXplLmhlaWdodCgpKTsKLSNlbHNlCiAgICAgLy8gRklYTUU6IElt
cGxlbWVudCB0aGlzIGZvciBvdGhlciBiYWNrZW5kcy4KICAgICByZXR1cm4geyB9OwotI2VuZGlm
CiB9CisjZW5kaWYKIAogI2lmICEoVVNFKENHKSB8fCBVU0UoRElSRUNUMkQpKQogCmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNw
cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0cuY3Bw
CmluZGV4IGY0ODVhMzQxNGU1Li5hNmIxMjJjODUyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHAKKysrIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHAKQEAgLTYzMCw2ICs2
MzAsMTMgQEAgVmVjdG9yPHVpbnQ4X3Q+IGRhdGEoY29uc3QgSW1hZ2VEYXRhJiBzb3VyY2UsIGNv
bnN0IFN0cmluZyYgbWltZVR5cGUsIHN0ZDo6b3B0aW8KICAgICByZXR1cm4geyB9OwogfQogCitW
ZWN0b3I8dWludDhfdD4gSW1hZ2VCdWZmZXI6OnRvQkdSQURhdGEoKSBjb25zdAoreworICAgIGlm
IChjb250ZXh0KCkuaXNBY2NlbGVyYXRlZENvbnRleHQoKSkKKyAgICAgICAgZmx1c2hDb250ZXh0
KCk7CisgICAgcmV0dXJuIG1fZGF0YS50b0JHUkFEYXRhKGNvbnRleHQoKS5pc0FjY2VsZXJhdGVk
Q29udGV4dCgpLCBtX3NpemUud2lkdGgoKSwgbV9zaXplLmhlaWdodCgpKTsKK30KKwogfSAvLyBu
YW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUJ1ZmZlckd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VCdWZmZXJHdGsuY3BwCmluZGV4IGIyM2U2NDc2OWU5
Li5lZDNhMTFmOTEzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp
Y3MvZ3RrL0ltYWdlQnVmZmVyR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n
cmFwaGljcy9ndGsvSW1hZ2VCdWZmZXJHdGsuY3BwCkBAIC0yMCw4ICsyMCw4IEBACiAjaW5jbHVk
ZSAiSW1hZ2VCdWZmZXIuaCIKIAogI2luY2x1ZGUgIkNhaXJvVXRpbGl0aWVzLmgiCi0jaW5jbHVk
ZSAiR2RrQ2Fpcm9VdGlsaXRpZXMuaCIKICNpbmNsdWRlICJHUmVmUHRyR3RrLmgiCisjaW5jbHVk
ZSAiR2RrQ2Fpcm9VdGlsaXRpZXMuaCIKICNpbmNsdWRlICJNSU1FVHlwZVJlZ2lzdHJ5LmgiCiAj
aW5jbHVkZSA8Y2Fpcm8uaD4KICNpbmNsdWRlIDxndGsvZ3RrLmg+CkBAIC04Nyw2ICs4NywxNiBA
QCBTdHJpbmcgSW1hZ2VCdWZmZXI6OnRvRGF0YVVSTChjb25zdCBTdHJpbmcmIG1pbWVUeXBlLCBz
dGQ6Om9wdGlvbmFsPGRvdWJsZT4gcXVhbAogICAgIHJldHVybiAiZGF0YToiICsgbWltZVR5cGUg
KyAiO2Jhc2U2NCwiICsgYmFzZTY0RGF0YTsKIH0KIAorVmVjdG9yPHVpbnQ4X3Q+IEltYWdlQnVm
ZmVyOjp0b0JHUkFEYXRhKCkgY29uc3QKK3sKKyAgICBhdXRvIHBpeGJ1ZiA9IGFkb3B0R1JlZihj
YWlyb1N1cmZhY2VUb0dka1BpeGJ1ZihtX2RhdGEubV9zdXJmYWNlLmdldCgpKSk7CisgICAgYXV0
byBwaXhlbHMgPSBnZGtfcGl4YnVmX2dldF9waXhlbHMocGl4YnVmLmdldCgpKTsKKworICAgIFZl
Y3Rvcjx1aW50OF90PiBpbWFnZURhdGE7CisgICAgaW1hZ2VEYXRhLmFwcGVuZChwaXhlbHMsIGdk
a19waXhidWZfZ2V0X2J5dGVfbGVuZ3RoKHBpeGJ1Zi5nZXQoKSkpOworICAgIHJldHVybiBpbWFn
ZURhdGE7Cit9CisKIFZlY3Rvcjx1aW50OF90PiBJbWFnZUJ1ZmZlcjo6dG9EYXRhKGNvbnN0IFN0
cmluZyYgbWltZVR5cGUsIHN0ZDo6b3B0aW9uYWw8ZG91YmxlPiBxdWFsaXR5KSBjb25zdAogewog
ICAgIEFTU0VSVChNSU1FVHlwZVJlZ2lzdHJ5Ojppc1N1cHBvcnRlZEltYWdlTUlNRVR5cGVGb3JF
bmNvZGluZyhtaW1lVHlwZSkpOwotLSAKMi4xNy4w
</data>

          </attachment>
      

    </bug>

</bugzilla>