185509 2018-05-10 05:09:20 -0700 [JSC] Make return types of construction functions tight 2018-05-10 21:39:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki achristensen darin ews-watchlist keith_miller mark.lam msaboff saam sam webkit-bug-importer oldest_to_newest 1422693 0 ysuzuki 2018-05-10 05:09:20 -0700 [JSC] Make return types of construction functions tight 1422694 1 340084 ysuzuki 2018-05-10 05:10:07 -0700 Created attachment 340084 Patch 1423030 2 ysuzuki 2018-05-10 21:39:01 -0700 Committed r231688: <https://trac.webkit.org/changeset/231688> 1423031 3 webkit-bug-importer 2018-05-10 21:39:20 -0700 <rdar://problem/40153217> 340084 2018-05-10 05:10:07 -0700 2018-05-10 21:36:51 -0700 Patch bug-185509-20180510211006.patch text/plain 5336 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz NzdkYTY5MTQwODllMGJmN2MwYTJiZGViMjgzZWJkY2FiNmQzMTgwLi5kODkwYTljZTc4NDU4NjE5 MjdkOWE5YzZhOTI0ZTJhYmY1ZTQ3NDU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0wNS0xMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBNYWtlIHJldHVybiB0eXBlcyBvZiBjb25zdHJ1Y3Rpb24g ZnVuY3Rpb25zIHRpZ2h0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODU1MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBcnJheSBhbmQgT2JqZWN0IGNvbnN0cnVjdGlvbiBmdW5jdGlvbnMgc2hvdWxkIHJl dHVybiBzdHJpY3QgdHlwZXMgaW5zdGVhZCBvZiByZXR1cm5pbmcgSlNPYmplY3QqL0pTVmFsdWUu CisKKyAgICAgICAgKiBydW50aW1lL0FycmF5Q29uc3RydWN0b3IuY3BwOgorICAgICAgICAoSlND Ojpjb25zdHJ1Y3RBcnJheVdpdGhTaXplUXVpcmspOgorICAgICAgICAqIHJ1bnRpbWUvQXJyYXlD b25zdHJ1Y3Rvci5oOgorICAgICAgICAqIHJ1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuaDoKKyAg ICAgICAgKEpTQzo6Y29uc3RydWN0RW1wdHlPYmplY3QpOgorCiAyMDE4LTA1LTA5ICBDYWlvIExp bWEgIDx0aWNhaW9saW1hQGdtYWlsLmNvbT4KIAogICAgICAgICBbRVNOZXh0XVtCaWdJbnRdIElt cGxlbWVudCBzdXBwb3J0IGZvciAiPT0iIG9wZXJhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlDb25zdHJ1Y3Rvci5jcHAgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9BcnJheUNvbnN0cnVjdG9yLmNwcAppbmRleCBhYjQxMzFkNzVkNzE3 NzFjODhkMGM2MTE2NTliN2E2NzFhOTY2OTc3Li5hYzZmM2U5NzllMTBiODQzOTlmZGIyNGFmNmRm YTNmNjhhNDg1NjNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9B cnJheUNvbnN0cnVjdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9B cnJheUNvbnN0cnVjdG9yLmNwcApAQCAtNjksNyArNjksNyBAQCB2b2lkIEFycmF5Q29uc3RydWN0 b3I6OmZpbmlzaENyZWF0aW9uKFZNJiB2bSwgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwg QXJyYQogCiAvLyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0gRnVuY3Rpb25zIC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCi1KU1ZhbHVlIGNvbnN0cnVjdEFycmF5V2l0aFNpemVR dWlyayhFeGVjU3RhdGUqIGV4ZWMsIEFycmF5QWxsb2NhdGlvblByb2ZpbGUqIHByb2ZpbGUsIEpT R2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIEpTVmFsdWUgbGVuZ3RoLCBKU1ZhbHVlIG5ld1Rh cmdldCkKK0pTQXJyYXkqIGNvbnN0cnVjdEFycmF5V2l0aFNpemVRdWlyayhFeGVjU3RhdGUqIGV4 ZWMsIEFycmF5QWxsb2NhdGlvblByb2ZpbGUqIHByb2ZpbGUsIEpTR2xvYmFsT2JqZWN0KiBnbG9i YWxPYmplY3QsIEpTVmFsdWUgbGVuZ3RoLCBKU1ZhbHVlIG5ld1RhcmdldCkKIHsKICAgICBWTSYg dm0gPSBleGVjLT52bSgpOwogICAgIGF1dG8gc2NvcGUgPSBERUNMQVJFX1RIUk9XX1NDT1BFKHZt KTsKQEAgLTc5LDEzICs3OSwxNSBAQCBKU1ZhbHVlIGNvbnN0cnVjdEFycmF5V2l0aFNpemVRdWly ayhFeGVjU3RhdGUqIGV4ZWMsIEFycmF5QWxsb2NhdGlvblByb2ZpbGUqIHBybwogICAgIH0KICAg ICAKICAgICB1aW50MzJfdCBuID0gbGVuZ3RoLnRvVUludDMyKGV4ZWMpOwotICAgIGlmIChuICE9 IGxlbmd0aC50b051bWJlcihleGVjKSkKLSAgICAgICAgcmV0dXJuIHRocm93RXhjZXB0aW9uKGV4 ZWMsIHNjb3BlLCBjcmVhdGVSYW5nZUVycm9yKGV4ZWMsIEFTQ0lJTGl0ZXJhbCgiQXJyYXkgc2l6 ZSBpcyBub3QgYSBzbWFsbCBlbm91Z2ggcG9zaXRpdmUgaW50ZWdlci4iKSkpOworICAgIGlmIChu ICE9IGxlbmd0aC50b051bWJlcihleGVjKSkgeworICAgICAgICB0aHJvd0V4Y2VwdGlvbihleGVj LCBzY29wZSwgY3JlYXRlUmFuZ2VFcnJvcihleGVjLCBBU0NJSUxpdGVyYWwoIkFycmF5IHNpemUg aXMgbm90IGEgc21hbGwgZW5vdWdoIHBvc2l0aXZlIGludGVnZXIuIikpKTsKKyAgICAgICAgcmV0 dXJuIG51bGxwdHI7CisgICAgfQogICAgIHNjb3BlLnJlbGVhc2UoKTsKICAgICByZXR1cm4gY29u c3RydWN0RW1wdHlBcnJheShleGVjLCBwcm9maWxlLCBnbG9iYWxPYmplY3QsIG4sIG5ld1Rhcmdl dCk7CiB9CiAKLXN0YXRpYyBpbmxpbmUgSlNWYWx1ZSBjb25zdHJ1Y3RBcnJheVdpdGhTaXplUXVp cmsoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBBcmdMaXN0JiBhcmdzLCBKU1ZhbHVlIG5ld1Rhcmdl dCkKK3N0YXRpYyBpbmxpbmUgSlNBcnJheSogY29uc3RydWN0QXJyYXlXaXRoU2l6ZVF1aXJrKEV4 ZWNTdGF0ZSogZXhlYywgY29uc3QgQXJnTGlzdCYgYXJncywgSlNWYWx1ZSBuZXdUYXJnZXQpCiB7 CiAgICAgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCA9IGpzQ2FzdDxJbnRlcm5hbEZ1bmN0 aW9uKj4oZXhlYy0+anNDYWxsZWUoKSktPmdsb2JhbE9iamVjdCgpOwogCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheUNvbnN0cnVjdG9yLmggYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheUNvbnN0cnVjdG9yLmgKaW5kZXggYWFhZjhhMjhh MzY2ZmZjNWY5M2ZlNzk5YjBiMzU4ZTY4OTIzMzAwZi4uODNhN2YyYzMwMDQyNTlhYTBjNjBkODJh NmRlZjgxOWEzNTUzNzI0NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvQXJyYXlDb25zdHJ1Y3Rvci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0FycmF5Q29uc3RydWN0b3IuaApAQCAtNTYsNyArNTYsNyBAQCBjbGFzcyBBcnJheUNvbnN0cnVj dG9yIGZpbmFsIDogcHVibGljIEludGVybmFsRnVuY3Rpb24gewogICAgIEFycmF5Q29uc3RydWN0 b3IoVk0mLCBTdHJ1Y3R1cmUqKTsKIH07CiAKLUpTVmFsdWUgY29uc3RydWN0QXJyYXlXaXRoU2l6 ZVF1aXJrKEV4ZWNTdGF0ZSosIEFycmF5QWxsb2NhdGlvblByb2ZpbGUqLCBKU0dsb2JhbE9iamVj dCosIEpTVmFsdWUgbGVuZ3RoLCBKU1ZhbHVlIHByb3RvdHlwZSA9IEpTVmFsdWUoKSk7CitKU0Fy cmF5KiBjb25zdHJ1Y3RBcnJheVdpdGhTaXplUXVpcmsoRXhlY1N0YXRlKiwgQXJyYXlBbGxvY2F0 aW9uUHJvZmlsZSosIEpTR2xvYmFsT2JqZWN0KiwgSlNWYWx1ZSBsZW5ndGgsIEpTVmFsdWUgcHJv dG90eXBlID0gSlNWYWx1ZSgpKTsKIAogRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBhcnJh eUNvbnN0cnVjdG9yUHJpdmF0ZUZ1bmNJc0FycmF5Q29uc3RydWN0b3IoRXhlY1N0YXRlKik7CiBF bmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGFycmF5Q29uc3RydWN0b3JQcml2YXRlRnVuY0lz QXJyYXlTbG93KEV4ZWNTdGF0ZSopOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL09iamVjdENvbnN0cnVjdG9yLmgKaW5kZXggNDBiZTM1MWYxOTgwMzkxMjgxNzcxMWU2ZDk5 MWFmZmNhZjAyZTRjYS4uMGNkN2U5MzcxMGI4YjZiY2ZiYWQwMjkwNGJkMmRmZWIwNmE5OWY1MCAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT2JqZWN0Q29uc3RydWN0 b3IuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PYmplY3RDb25zdHJ1Y3Rv ci5oCkBAIC02MCwxMiArNjAsMTIgQEAgY2xhc3MgT2JqZWN0Q29uc3RydWN0b3IgZmluYWwgOiBw dWJsaWMgSW50ZXJuYWxGdW5jdGlvbiB7CiAgICAgT2JqZWN0Q29uc3RydWN0b3IoVk0mLCBTdHJ1 Y3R1cmUqKTsKIH07CiAKLWlubGluZSBKU09iamVjdCogY29uc3RydWN0RW1wdHlPYmplY3QoRXhl Y1N0YXRlKiBleGVjLCBTdHJ1Y3R1cmUqIHN0cnVjdHVyZSkKK2lubGluZSBKU0ZpbmFsT2JqZWN0 KiBjb25zdHJ1Y3RFbXB0eU9iamVjdChFeGVjU3RhdGUqIGV4ZWMsIFN0cnVjdHVyZSogc3RydWN0 dXJlKQogewogICAgIHJldHVybiBKU0ZpbmFsT2JqZWN0OjpjcmVhdGUoZXhlYywgc3RydWN0dXJl KTsKIH0KIAotaW5saW5lIEpTT2JqZWN0KiBjb25zdHJ1Y3RFbXB0eU9iamVjdChFeGVjU3RhdGUq IGV4ZWMsIEpTT2JqZWN0KiBwcm90b3R5cGUsIHVuc2lnbmVkIGlubGluZUNhcGFjaXR5KQoraW5s aW5lIEpTRmluYWxPYmplY3QqIGNvbnN0cnVjdEVtcHR5T2JqZWN0KEV4ZWNTdGF0ZSogZXhlYywg SlNPYmplY3QqIHByb3RvdHlwZSwgdW5zaWduZWQgaW5saW5lQ2FwYWNpdHkpCiB7CiAgICAgSlNH bG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCA9IGV4ZWMtPmxleGljYWxHbG9iYWxPYmplY3QoKTsK ICAgICBTdHJ1Y3R1cmVDYWNoZSYgc3RydWN0dXJlQ2FjaGUgPSBnbG9iYWxPYmplY3QtPnZtKCku c3RydWN0dXJlQ2FjaGU7CkBAIC03MywxMiArNzMsMTIgQEAgaW5saW5lIEpTT2JqZWN0KiBjb25z dHJ1Y3RFbXB0eU9iamVjdChFeGVjU3RhdGUqIGV4ZWMsIEpTT2JqZWN0KiBwcm90b3R5cGUsIHVu c2kKICAgICByZXR1cm4gY29uc3RydWN0RW1wdHlPYmplY3QoZXhlYywgc3RydWN0dXJlKTsKIH0K IAotaW5saW5lIEpTT2JqZWN0KiBjb25zdHJ1Y3RFbXB0eU9iamVjdChFeGVjU3RhdGUqIGV4ZWMs IEpTT2JqZWN0KiBwcm90b3R5cGUpCitpbmxpbmUgSlNGaW5hbE9iamVjdCogY29uc3RydWN0RW1w dHlPYmplY3QoRXhlY1N0YXRlKiBleGVjLCBKU09iamVjdCogcHJvdG90eXBlKQogewogICAgIHJl dHVybiBjb25zdHJ1Y3RFbXB0eU9iamVjdChleGVjLCBwcm90b3R5cGUsIEpTRmluYWxPYmplY3Q6 OmRlZmF1bHRJbmxpbmVDYXBhY2l0eSgpKTsKIH0KIAotaW5saW5lIEpTT2JqZWN0KiBjb25zdHJ1 Y3RFbXB0eU9iamVjdChFeGVjU3RhdGUqIGV4ZWMpCitpbmxpbmUgSlNGaW5hbE9iamVjdCogY29u c3RydWN0RW1wdHlPYmplY3QoRXhlY1N0YXRlKiBleGVjKQogewogICAgIHJldHVybiBjb25zdHJ1 Y3RFbXB0eU9iamVjdChleGVjLCBleGVjLT5sZXhpY2FsR2xvYmFsT2JqZWN0KCktPm9iamVjdFN0 cnVjdHVyZUZvck9iamVjdENvbnN0cnVjdG9yKCkpOwogfQo=