18550 2008-04-17 12:34:02 -0700 cross-frame-access-call.html doesn't really test window.open(), since popups are blocked 2008-06-08 12:09:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eroman webkit-unassigned oldest_to_newest 77965 0 eroman 2008-04-17 12:34:02 -0700 http/tests/security/cross-frame-access-call.html contains a test for cross domain violation on "window.open.call()", by checking for a return value of undefined. However since popups are disabled, window.open will return undefined regardless. 77986 1 20636 eroman 2008-04-17 13:32:50 -0700 Created attachment 20636 add layoutTestController.setCanOpenWindows(true) 78097 2 20636 aroben 2008-04-18 07:01:22 -0700 Comment on attachment 20636 add layoutTestController.setCanOpenWindows(true) Thanks for the patch! You should leave the "requestee" field blank in most cases when putting a patch up for review. You'll need to create a ChangeLog entry. See <http://webkit.org/coding/contributing.html> for information on how to prepare and submit a patch. Have you verified that the test still passes? r- so that a ChangeLog can be added. 78143 3 20673 eroman 2008-04-18 12:31:45 -0700 Created attachment 20673 add layoutTestController.setCanOpenWindows(true) Sorry about that aroben! Fixed, new patch uploaded. I ran the layout test, and it passes. I did have to change a line number in the expected output though, since this patch added two lines. 79082 4 20673 aroben 2008-04-27 22:27:21 -0700 Comment on attachment 20673 add layoutTestController.setCanOpenWindows(true) +2008-04-18 Eric Roman <minatoar@gmail.com> + + Reviewed by NOBODY (OOPS!). + + * http/tests/security/cross-frame-access-call-expected.txt: Increase a console line number (since added two lines) + * http/tests/security/cross-frame-access-call.html: Enable popups for this layout test. The test checks that window.open is returns undefined (same-domain enforcement), however unless popups are enabled it returns undefined regardless. + It's customary to list the bug title and URL of the bug you're fixing in your ChangeLog entry (though I think unfortunately this is not mentioned on our website anywhere). Whomever lands this patch can add that for you. r=me. Thanks! 82631 5 darin 2008-06-08 12:09:52 -0700 Committed revision 34447. 20636 2008-04-17 13:32:50 -0700 2008-04-18 12:31:45 -0700 add layoutTestController.setCanOpenWindows(true) allow-popups.txt text/plain 663 eroman SW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJhbWUtYWNjZXNz LWNhbGwuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5 L2Nyb3NzLWZyYW1lLWFjY2Vzcy1jYWxsLmh0bWwJKHJldmlzaW9uIDMyMDEwKQorKysgTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nlc3MtY2FsbC5odG1sCSh3 b3JraW5nIGNvcHkpCkBAIC0xMSw4ICsxMSwxMCBAQCB3aW5kb3cudGFyZ2V0V2luZG93ID0gZnJh bWVzWzBdOwogCiB3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKQogewotICAgIGlmICh3aW5kb3cu bGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxl cikgeworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRDYW5PcGVuV2luZG93cyh0cnVl KTsKICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgIH0KIAog ICAgIGxvZygiXG4tLS0tLSB0ZXN0cyBmb3IgY2FsbGluZyBtZXRob2RzIG9mIGFub3RoZXIgZnJh bWUgdXNpbmcgRnVuY3Rpb24uY2FsbCAtLS0tLVxuIik7CiAK 20673 2008-04-18 12:31:45 -0700 2008-04-27 22:27:21 -0700 add layoutTestController.setCanOpenWindows(true) allow-popups2.txt text/plain 2273 eroman SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDMyMjIwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDgtMDQtMTggIEVyaWMgUm9tYW4gIDxtaW5h dG9hckBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBodHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFjY2Vzcy1jYWxsLWV4 cGVjdGVkLnR4dDogSW5jcmVhc2UgYSBjb25zb2xlIGxpbmUgbnVtYmVyIChzaW5jZSBhZGRlZCB0 d28gbGluZXMpCisgICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nl c3MtY2FsbC5odG1sOiBFbmFibGUgcG9wdXBzIGZvciB0aGlzIGxheW91dCB0ZXN0LiBUaGUgdGVz dCBjaGVja3MgdGhhdCB3aW5kb3cub3BlbiBpcyByZXR1cm5zIHVuZGVmaW5lZCAoc2FtZS1kb21h aW4gZW5mb3JjZW1lbnQpLCBob3dldmVyIHVubGVzcyBwb3B1cHMgYXJlIGVuYWJsZWQgaXQgcmV0 dXJucyB1bmRlZmluZWQgcmVnYXJkbGVzcy4KKwogMjAwOC0wNC0xOCAgRGFuIEJlcm5zdGVpbiAg PG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIC0gYWRkIGNzczIuMS90MTUwNi1jNTI1LWZvbnQt d3QtMDAtYi5odG1sIHRvIHRoZSBXaW5kb3dzIHNraXBwZWQgbGlzdApJbmRleDogTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nlc3MtY2FsbC1leHBlY3RlZC50 eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1m cmFtZS1hY2Nlc3MtY2FsbC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDMyMDEwKQorKysgTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9zcy1mcmFtZS1hY2Nlc3MtY2FsbC1leHBlY3Rl ZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTUwLDcgKzUwLDcgQEAgQ09OU09MRSBNRVNTQUdFOiBs aW5lIDE6IFVuc2FmZSBKYXZhU2NyaQogCiBDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTogVW5zYWZl IEphdmFTY3JpcHQgYXR0ZW1wdCB0byBhY2Nlc3MgZnJhbWUgd2l0aCBVUkwgaHR0cDovL2xvY2Fs aG9zdDo4MDAwL3NlY3VyaXR5L3Jlc291cmNlcy9jcm9zcy1mcmFtZS1pZnJhbWUtZm9yLWdldC10 ZXN0Lmh0bWwgZnJvbSBmcmFtZSB3aXRoIFVSTCBodHRwOi8vMTI3LjAuMC4xOjgwMDAvc2VjdXJp dHkvY3Jvc3MtZnJhbWUtYWNjZXNzLWNhbGwuaHRtbC4gRG9tYWlucywgcHJvdG9jb2xzIGFuZCBw b3J0cyBtdXN0IG1hdGNoLgogCi1DT05TT0xFIE1FU1NBR0U6IGxpbmUgNTU6IFVuZGVmaW5lZCB2 YWx1ZQorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDU3OiBVbmRlZmluZWQgdmFsdWUKIAogCiAtLS0t LSB0ZXN0cyBmb3IgY2FsbGluZyBtZXRob2RzIG9mIGFub3RoZXIgZnJhbWUgdXNpbmcgRnVuY3Rp b24uY2FsbCAtLS0tLQpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1cml0eS9jcm9z cy1mcmFtZS1hY2Nlc3MtY2FsbC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAv dGVzdHMvc2VjdXJpdHkvY3Jvc3MtZnJhbWUtYWNjZXNzLWNhbGwuaHRtbAkocmV2aXNpb24gMzIw MTApCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L2Nyb3NzLWZyYW1lLWFjY2Vz cy1jYWxsLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTExLDggKzExLDEwIEBAIHdpbmRvdy50YXJn ZXRXaW5kb3cgPSBmcmFtZXNbMF07CiAKIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpCiB7Ci0g ICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNldENhbk9w ZW5XaW5kb3dzKHRydWUpOwogICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7CisgICAgfQogCiAgICAgbG9nKCJcbi0tLS0tIHRlc3RzIGZvciBjYWxsaW5nIG1ldGhvZHMg b2YgYW5vdGhlciBmcmFtZSB1c2luZyBGdW5jdGlvbi5jYWxsIC0tLS0tXG4iKTsKIAo=