185498 2018-05-09 16:48:12 -0700 AX: accessibleNameForNode should simplify whitespace when using innerText 2018-05-09 18:50:01 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 jdiggs jdiggs aboxhall apinheiro cfleizach commit-queue dmazzoni ews-watchlist jcraig samuel_white webkit-bug-importer oldest_to_newest 1422563 0 jdiggs 2018-05-09 16:48:12 -0700 Given this test case: <input id="test" type="text" aria-labelledby="hidden" /> <div style="display:none;"> <div id="hidden"> <table> <tr> <td>cell 1</td> <td><div>cell 2</div></td> <td>cell 3</td> </tr> </table> </div> </div> The accessible name calculated for the element with id of "test" should be "cell 1 cell 2 cell 3" without new line characters or additional spaces. We're adding both because accessibleNameForNode falls back on innerText when there is no AccessibilityObject, and there is no AccessibilityObject because the element from which the name is to be calculated is not rendered. 1422564 1 340051 jdiggs 2018-05-09 16:50:05 -0700 Created attachment 340051 Patch 1422580 2 webkit-bug-importer 2018-05-09 17:36:33 -0700 <rdar://problem/40113814> 1422599 3 340051 commit-queue 2018-05-09 18:50:00 -0700 Comment on attachment 340051 Patch Clearing flags on attachment: 340051 Committed r231627: <https://trac.webkit.org/changeset/231627> 1422600 4 commit-queue 2018-05-09 18:50:01 -0700 All reviewed patches have been landed. Closing bug. 340051 2018-05-09 16:50:05 -0700 2018-05-09 18:50:00 -0700 Patch bug-185498-20180509195004.patch text/plain 4863 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk3OGY5NjhhMDlhNmU5 NWYxMmJmYzgxMWM0NzExZjdkNTk1MWQ1Ny4uMzExYmM5NjIyM2Y3OWY4MDNmN2M5ZjgzNDkyMTE4 NjgzMTFjNGViMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA1LTA5ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogYWNjZXNzaWJs ZU5hbWVGb3JOb2RlIHNob3VsZCBzaW1wbGlmeSB3aGl0ZXNwYWNlIHdoZW4gdXNpbmcgaW5uZXJU ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU0 OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0 OiBhY2Nlc3NpYmlsaXR5L3RleHQtYWx0ZXJuYXRpdmUtY2FsY3VsYXRpb24tZnJvbS11bnJlbmRl cmVkLXRhYmxlLmh0bWwKKworICAgICAgICBDYWxsIHNpbXBsaWZ5V2hpdGVTcGFjZSgpIGJlZm9y ZSByZXR1cm5pbmcgdGhlIGlubmVyVGV4dCB2YWx1ZS4KKworICAgICAgICAqIGFjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YWNjZXNz aWJsZU5hbWVGb3JOb2RlKToKKwogMjAxOC0wNS0wNyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBw bGUuY29tPgogCiAgICAgICAgIFtMRkNdIEFkZCBGb3JtYXR0aW5nQ29udGV4dDo6bGF5b3V0T3V0 T2ZGbG93RGVzY2VuZGFudHMgaW1wbGVtZW50YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAKaW5kZXggZGI4 NTc1ZTEwMzNkZjdlOGFjZWQ5MjM5N2Q4YmMwNTRkNjY2YjVhYy4uOWE1OGZiZjNjOGMxYjc4MDc5 OWIzY2I1OTgzMjA1N2EwYmQzZjI0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAKQEAgLTE5NTAsNyArMTk1 MCw3IEBAIHN0YXRpYyBTdHJpbmcgYWNjZXNzaWJsZU5hbWVGb3JOb2RlKE5vZGUqIG5vZGUsIE5v ZGUqIGxhYmVsbGVkYnlOb2RlKQogICAgICAgICBpZiAoYXhPYmplY3QtPmFjY2Vzc2libGVOYW1l RGVyaXZlc0Zyb21Db250ZW50KCkpCiAgICAgICAgICAgICB0ZXh0ID0gYXhPYmplY3QtPnRleHRV bmRlckVsZW1lbnQoQWNjZXNzaWJpbGl0eVRleHRVbmRlckVsZW1lbnRNb2RlKEFjY2Vzc2liaWxp dHlUZXh0VW5kZXJFbGVtZW50TW9kZTo6VGV4dFVuZGVyRWxlbWVudE1vZGVJbmNsdWRlTmFtZUZy b21Db250ZW50c0NoaWxkcmVuLCB0cnVlLCBsYWJlbGxlZGJ5Tm9kZSkpOwogICAgIH0gZWxzZQot ICAgICAgICB0ZXh0ID0gZWxlbWVudC5pbm5lclRleHQoKTsKKyAgICAgICAgdGV4dCA9IGVsZW1l bnQuaW5uZXJUZXh0KCkuc2ltcGxpZnlXaGl0ZVNwYWNlKCk7CiAKICAgICBpZiAoIXRleHQuaXNF bXB0eSgpKQogICAgICAgICByZXR1cm4gdGV4dDsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmNWQ0MDJiMTFkOTg1ZTEwZTcz MjRmNDRmNTIzMDE5YWM2YjNlNzY3Li5mYWRmZmU4MzI4MmQ0MzBhYzY1OGRhZTE2YThmYmZhNjZk Mzc0NjU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDUtMDkgIEpvYW5tYXJpZSBEaWdn cyAgPGpkaWdnc0BpZ2FsaWEuY29tPgorCisgICAgICAgIEFYOiBhY2Nlc3NpYmxlTmFtZUZvck5v ZGUgc2hvdWxkIHNpbXBsaWZ5IHdoaXRlc3BhY2Ugd2hlbiB1c2luZyBpbm5lclRleHQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTQ5OAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0 eS90ZXh0LWFsdGVybmF0aXZlLWNhbGN1bGF0aW9uLWZyb20tdW5yZW5kZXJlZC10YWJsZS1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvdGV4dC1hbHRlcm5hdGl2 ZS1jYWxjdWxhdGlvbi1mcm9tLXVucmVuZGVyZWQtdGFibGUuaHRtbDogQWRkZWQuCisKIDIwMTgt MDUtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCBhZGQgZnJhbWUgbmFtZSBpbiBmb3JtLWlmcmFtZS10YXJnZXQtYmVmb3JlLWxvYWQtY3Jh c2guaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS90ZXh0LWFsdGVy bmF0aXZlLWNhbGN1bGF0aW9uLWZyb20tdW5yZW5kZXJlZC10YWJsZS1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3RleHQtYWx0ZXJuYXRpdmUtY2FsY3VsYXRpb24tZnJv bS11bnJlbmRlcmVkLXRhYmxlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zMDViYWJhZDZkYmM4 Mjc0MDEzN2JjMmJhZjgzOWU5ZWFmYzAyYTYxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvYWNjZXNzaWJpbGl0eS90ZXh0LWFsdGVybmF0aXZlLWNhbGN1bGF0aW9uLWZyb20tdW5yZW5k ZXJlZC10YWJsZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAorVGhpcyB0ZXN0cyB0ZXh0 IGFsdGVybmF0aXZlIGNhbGN1bGF0aW9uIGZyb20gYW4gdW5yZW5kZXJlZCB0YWJsZS4KKworT24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93 ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1Rlc3QgMSAtIFczQyBOYW1lOiBjZWxsIDEgY2Vs bCAyIGNlbGwgMworVGVzdCAyIC0gVzNDIERlc2NyaXB0aW9uOiBjZWxsIDEgY2VsbCAyIGNlbGwg MworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvdGV4dC1hbHRlcm5hdGl2ZS1jYWxj dWxhdGlvbi1mcm9tLXVucmVuZGVyZWQtdGFibGUuaHRtbCBiL0xheW91dFRlc3RzL2FjY2Vzc2li aWxpdHkvdGV4dC1hbHRlcm5hdGl2ZS1jYWxjdWxhdGlvbi1mcm9tLXVucmVuZGVyZWQtdGFibGUu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi45MWZkZjk5YmVlODhlYmRkNGRiNzE3ZmYzMGY4YzA4ZGZlMGNmMTNk Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS90ZXh0LWFsdGVy bmF0aXZlLWNhbGN1bGF0aW9uLWZyb20tdW5yZW5kZXJlZC10YWJsZS5odG1sCkBAIC0wLDAgKzEs NDEgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9y ZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291 cmNlcy9hY2Nlc3NpYmlsaXR5LWhlbHBlci5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4K KzxkaXYgaWQ9ImNvbnRlbnQiPgorICA8aW5wdXQgaWQ9InRlc3QxIiB0eXBlPSJ0ZXh0IiBhcmlh LWxhYmVsbGVkYnk9ImhpZGRlbiIgLz4KKyAgPGlucHV0IGlkPSJ0ZXN0MiIgdHlwZT0idGV4dCIg YXJpYS1kZXNjcmliZWRieT0iaGlkZGVuIiAvPgorICA8ZGl2IHN0eWxlPSJkaXNwbGF5Om5vbmU7 Ij4KKyAgICA8ZGl2IGlkPSJoaWRkZW4iPgorICAgICAgPHRhYmxlPgorICAgICAgICA8dHI+CisJ ICA8dGQ+Y2VsbCAxPC90ZD4KKyAgICAgICAgICA8dGQ+PGRpdj5jZWxsIDI8L2Rpdj48L3RkPgor CSAgPHRkPmNlbGwgMzwvdGQ+CisgICAgICAgIDwvdHI+CisgICAgICA8L3RhYmxlPgorICAgIDwv ZGl2PgorICA8L2Rpdj4KKzwvZGl2PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlk PSJjb25zb2xlIj48L2Rpdj4KKworPHNjcmlwdD4KKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0 cyB0ZXh0IGFsdGVybmF0aXZlIGNhbGN1bGF0aW9uIGZyb20gYW4gdW5yZW5kZXJlZCB0YWJsZS4i KTsKKyAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisgICAgICAgIHZh ciB0ZXN0MSA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgi dGVzdDEiKTsKKyAgICAgICAgZGVidWcoIlRlc3QgMSAtIFczQyBOYW1lOiAiICsgcGxhdGZvcm1W YWx1ZUZvclczQ05hbWUodGVzdDEpKTsKKworICAgICAgICB2YXIgdGVzdDIgPSBhY2Nlc3NpYmls aXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoInRlc3QyIik7CisgICAgICAgIGRl YnVnKCJUZXN0IDIgLSBXM0MgRGVzY3JpcHRpb246ICIgKyBwbGF0Zm9ybVZhbHVlRm9yVzNDRGVz Y3JpcHRpb24odGVzdDIpKTsKKyAgICAKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImNvbnRlbnQiKS5zdHlsZS52aXNpYmlsaXR5ID0gImhpZGRlbiI7CisgICAgfQorPC9zY3JpcHQ+ CisKKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4K KzwvYm9keT4KKzwvaHRtbD4K