185496 2018-05-09 16:39:55 -0700 Fix some -Wstring-op-truncation warnings 2018-05-13 07:32:59 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro achristensen commit-queue darin lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1422561 0 mcatanzaro 2018-05-09 16:39:55 -0700 testAtomicStringNumber may not be null-terminated. Caught by -Wstringop-truncation: ../../Tools/TestWebKitAPI/Tests/WTF/AtomicString.cpp:67:17: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 100 equals destination size [-Wstringop-truncation] 1422565 1 mcatanzaro 2018-05-09 16:52:09 -0700 Also, related: [415/2047] Building CXX object Tools/TestWebKitAPI/CMakeFiles/TestWTF.dir/Tests/WTF/WTFString.cpp.o ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp: In function ‘const char* TestWebKitAPI::testStringNumber(double)’: ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:169:17: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 100 equals destination size [-Wstringop-truncation] std::strncpy(testBuffer, String::numberToStringECMAScript(number).utf8().data(), 100); ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:169:17: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 100 equals destination size [-Wstringop-truncation] ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp: In function ‘const char* TestWebKitAPI::testStringNumberFixedWidth(double)’: ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:120:17: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 100 equals destination size [-Wstringop-truncation] std::strncpy(testBuffer, String::numberToStringFixedWidth(number, 6).utf8().data(), 100); ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:120:17: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 100 equals destination size [-Wstringop-truncation] ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp: In function ‘const char* TestWebKitAPI::testStringNumberFixedPrecision(double)’: ../../Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:71:17: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound 100 equals destination size [-Wstringop-truncation] std::strncpy(testBuffer, String::number(number).utf8().data(), 100); ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1422618 2 340064 mcatanzaro 2018-05-09 20:02:16 -0700 Created attachment 340064 Patch 1422886 3 340064 commit-queue 2018-05-10 14:46:57 -0700 Comment on attachment 340064 Patch Clearing flags on attachment: 340064 Committed r231661: <https://trac.webkit.org/changeset/231661> 1422887 4 commit-queue 2018-05-10 14:46:58 -0700 All reviewed patches have been landed. Closing bug. 1422888 5 webkit-bug-importer 2018-05-10 14:47:41 -0700 <rdar://problem/40142604> 1423382 6 darin 2018-05-12 21:41:56 -0700 Thanks for fixing this. For the record, changing the 100 to 99 was necessary, but adding the "= { }" was not since these are globals and initialized to zero in any case. 1423409 7 mcatanzaro 2018-05-13 07:32:59 -0700 (In reply to Darin Adler from comment #6) > Thanks for fixing this. For the record, changing the 100 to 99 was > necessary, but adding the "= { }" was not since these are globals and > initialized to zero in any case. Good point, you're right! I overlooked the static keyword. 340064 2018-05-09 20:02:16 -0700 2018-05-10 14:46:57 -0700 Patch bug-185496-20180509220215.patch text/plain 4600 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggODU0OGRmNWU5 YjQwZmRkZWQ1ODI5NTIwOWU2MTY5NDJkNWRlNTUwYS4uMzc1MjRmM2UwMWE2ZGFjNGYzNmNlNDgx Mzg4YzMxODRjZDkyNDA0MiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4 LTA1LTA5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAg ICAgICBGaXggc29tZSAtV3N0cmluZy1vcC10cnVuY2F0aW9uIHdhcm5pbmdzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU0OTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNhYmxlIHRoaXMgd2Fybmlu ZyB3aGVuIGJ1aWxkaW5nIGd0ZXN0LgorCisgICAgICAgICogZ3Rlc3QvQ01ha2VMaXN0cy50eHQ6 CisKIDIwMTgtMDUtMDkgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29t PgogCiAgICAgICAgIFtXUEVdIEJ1aWxkIGNsZWFubHkgd2l0aCBHQ0MgOCBhbmQgSUNVIDYwCmRp ZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC9DTWFrZUxpc3RzLnR4dCBiL1NvdXJj ZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlzdHMudHh0CmluZGV4IDk5ZjdmYjA0NmY5YjA5YWQy MDAxZGNhOWFmY2E3ZjQ2MzA0ZjQ1MGUuLmRkMTAwNWZlNmU1N2M1MjBiZTk3ZjRmODA1MmI0MjZm MGZlMDU2OGYgMTAwNzU1Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlzdHMu dHh0CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L0NNYWtlTGlzdHMudHh0CkBAIC0zNSw2 ICszNSw3IEBAIGluY2x1ZGVfZGlyZWN0b3JpZXMoJHtHVEVTVF9JTkNMVURFX0RJUkVDVE9SSUVT fSkKIGFkZF9kZWZpbml0aW9ucygtREdURVNUX0hBU19SVFRJPTApCiAKIFdFQktJVF9BRERfVEFS R0VUX0NYWF9GTEFHUyhndGVzdCAtV25vLXVuZGVmCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgLVduby1zdHJpbmdvcC10cnVuY2F0aW9uCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgLVduby1zdWdnZXN0LWF0dHJpYnV0ZT1mb3JtYXQpCiAKICMgRklYTUU6IFRo aXMgd29ya3MgYXJvdW5kIGNvbXBhdGliaWxpdHkgcHJvYmxlbXMgaW4gdGhlIG9sZCB2ZXJzaW9u IG9mIHRoZSB0aGlyZC1wYXJ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9D aGFuZ2VMb2cKaW5kZXggNWU2MDJlZmZkNGNjMTExYWE2MzIwNDExNDVlOTg3M2I3YTY5OTZiOS4u YmFkYzZiNDc4OWMxZGUxZjkzNWI3NDZkOTI3OGQzNzY5NTc3ZDZlNSAxMDA2NDQKLS0tIGEvVG9v bHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4 LTA1LTA5ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAg ICAgICBGaXggc29tZSAtV3N0cmluZy1vcC10cnVuY2F0aW9uIHdhcm5pbmdzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU0OTYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBoYXZlIGFuIG9mZi1ieS1v bmUgaW4gdGhlIHVzZSBvZiBzdHJuY3B5LiBUaGUgc3RyaW5ncyB3b3VsZCBub3QgYmUgbnVsbC10 ZXJtaW5hdGVkIGlmCisgICAgICAgIHRoZSBpbnB1dCB3YXMgdG9vIGxvbmcuIEVuc3VyZSB0aGUg YnVmZmVycyBhcmUgemVyby1pbml0aWFsaXplZCBzbyB3ZSBkb24ndCBuZWVkIHRvIG1hbnVhbGx5 CisgICAgICAgIHNldCB0aGUgbGFzdCBidWNrZXQgdG8gTlVMLgorCisgICAgICAgICogVGVzdFdl YktpdEFQSS9UZXN0cy9XVEYvQXRvbWljU3RyaW5nLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRB UEk6OnRlc3RBdG9taWNTdHJpbmdOdW1iZXIpOgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVz dHMvV1RGL1dURlN0cmluZy5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjp0ZXN0U3RyaW5n TnVtYmVyRml4ZWRQcmVjaXNpb24pOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6dGVzdFN0cmlu Z051bWJlckZpeGVkV2lkdGgpOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6dGVzdFN0cmluZ051 bWJlcik6CisKIDIwMTgtMDUtMDkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkIFdpbmRvd3MgYnVpbGQgZml4IGFmdGVyIHIyMzE2MjIuCmRpZmYg LS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9BdG9taWNTdHJpbmcuY3BwIGIv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvQXRvbWljU3RyaW5nLmNwcAppbmRleCAxZDRh ZTRlYjE0OTU1YjgyM2U4NmNiY2NiNmZkZWExZTZlYjQ0YjNjLi4wOGIxZjgwNTIxNTM2MWIxYzNm MmFkZDkyYjQ3Y2FlMDY5ZDk3ODIyIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dURi9BdG9taWNTdHJpbmcuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V1RGL0F0b21pY1N0cmluZy5jcHAKQEAgLTYzLDggKzYzLDggQEAgVEVTVChXVEYsIEF0b21pY1N0 cmluZ0V4aXN0aW5nSGFzaCkKIAogc3RhdGljIGlubGluZSBjb25zdCBjaGFyKiB0ZXN0QXRvbWlj U3RyaW5nTnVtYmVyKGRvdWJsZSBudW1iZXIpCiB7Ci0gICAgc3RhdGljIGNoYXIgdGVzdEJ1ZmZl clsxMDBdOwotICAgIHN0ZDo6c3RybmNweSh0ZXN0QnVmZmVyLCBBdG9taWNTdHJpbmc6Om51bWJl cihudW1iZXIpLnN0cmluZygpLnV0ZjgoKS5kYXRhKCksIDEwMCk7CisgICAgc3RhdGljIGNoYXIg dGVzdEJ1ZmZlclsxMDBdID0geyB9OworICAgIHN0ZDo6c3RybmNweSh0ZXN0QnVmZmVyLCBBdG9t aWNTdHJpbmc6Om51bWJlcihudW1iZXIpLnN0cmluZygpLnV0ZjgoKS5kYXRhKCksIDk5KTsKICAg ICByZXR1cm4gdGVzdEJ1ZmZlcjsKIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XVEYvV1RGU3RyaW5nLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RG L1dURlN0cmluZy5jcHAKaW5kZXggNGVjZmUyZmZlNmNkMzFkOTU4MzQ4YTA2MTVhMGQwZTUxNTVj ZjZjZC4uN2Y2NmMxODFiOWRiZmVhMTQ0YTA5YmUxMzRkNzQ0ODZiNDIxZmQ2MCAxMDA2NDQKLS0t IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvV1RGU3RyaW5nLmNwcAorKysgYi9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9XVEZTdHJpbmcuY3BwCkBAIC02Nyw4ICs2Nyw4IEBA IFRFU1QoV1RGLCBTdHJpbmdBU0NJSSkKIAogc3RhdGljIGlubGluZSBjb25zdCBjaGFyKiB0ZXN0 U3RyaW5nTnVtYmVyRml4ZWRQcmVjaXNpb24oZG91YmxlIG51bWJlcikKIHsKLSAgICBzdGF0aWMg Y2hhciB0ZXN0QnVmZmVyWzEwMF07Ci0gICAgc3RkOjpzdHJuY3B5KHRlc3RCdWZmZXIsIFN0cmlu Zzo6bnVtYmVyKG51bWJlcikudXRmOCgpLmRhdGEoKSwgMTAwKTsKKyAgICBzdGF0aWMgY2hhciB0 ZXN0QnVmZmVyWzEwMF0gPSB7IH07CisgICAgc3RkOjpzdHJuY3B5KHRlc3RCdWZmZXIsIFN0cmlu Zzo6bnVtYmVyKG51bWJlcikudXRmOCgpLmRhdGEoKSwgOTkpOwogICAgIHJldHVybiB0ZXN0QnVm ZmVyOwogfQogCkBAIC0xMTYsOCArMTE2LDggQEAgVEVTVChXVEYsIFN0cmluZ051bWJlckZpeGVk UHJlY2lzaW9uKQogCiBzdGF0aWMgaW5saW5lIGNvbnN0IGNoYXIqIHRlc3RTdHJpbmdOdW1iZXJG aXhlZFdpZHRoKGRvdWJsZSBudW1iZXIpCiB7Ci0gICAgc3RhdGljIGNoYXIgdGVzdEJ1ZmZlclsx MDBdOwotICAgIHN0ZDo6c3RybmNweSh0ZXN0QnVmZmVyLCBTdHJpbmc6Om51bWJlclRvU3RyaW5n Rml4ZWRXaWR0aChudW1iZXIsIDYpLnV0ZjgoKS5kYXRhKCksIDEwMCk7CisgICAgc3RhdGljIGNo YXIgdGVzdEJ1ZmZlclsxMDBdID0geyB9OworICAgIHN0ZDo6c3RybmNweSh0ZXN0QnVmZmVyLCBT dHJpbmc6Om51bWJlclRvU3RyaW5nRml4ZWRXaWR0aChudW1iZXIsIDYpLnV0ZjgoKS5kYXRhKCks IDk5KTsKICAgICByZXR1cm4gdGVzdEJ1ZmZlcjsKIH0KIApAQCAtMTY1LDggKzE2NSw4IEBAIFRF U1QoV1RGLCBTdHJpbmdOdW1iZXJGaXhlZFdpZHRoKQogCiBzdGF0aWMgaW5saW5lIGNvbnN0IGNo YXIqIHRlc3RTdHJpbmdOdW1iZXIoZG91YmxlIG51bWJlcikKIHsKLSAgICBzdGF0aWMgY2hhciB0 ZXN0QnVmZmVyWzEwMF07Ci0gICAgc3RkOjpzdHJuY3B5KHRlc3RCdWZmZXIsIFN0cmluZzo6bnVt YmVyVG9TdHJpbmdFQ01BU2NyaXB0KG51bWJlcikudXRmOCgpLmRhdGEoKSwgMTAwKTsKKyAgICBz dGF0aWMgY2hhciB0ZXN0QnVmZmVyWzEwMF0gPSB7IH07CisgICAgc3RkOjpzdHJuY3B5KHRlc3RC dWZmZXIsIFN0cmluZzo6bnVtYmVyVG9TdHJpbmdFQ01BU2NyaXB0KG51bWJlcikudXRmOCgpLmRh dGEoKSwgOTkpOwogICAgIHJldHVybiB0ZXN0QnVmZmVyOwogfQogCg==