185492 2018-05-09 14:45:56 -0700 Support --verbose in run-javascriptcore-tests 2018-05-10 12:12:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned achristensen commit-queue dbates fpizlo keith_miller mark.lam ross.kirsling saam webkit-bug-importer oldest_to_newest 1422498 0 stephan.szabo 2018-05-09 14:45:56 -0700 Support --verbose in run-javascriptcore-tests 1422501 1 340033 stephan.szabo 2018-05-09 14:48:00 -0700 Created attachment 340033 Patch 1422672 2 340033 dbates 2018-05-10 00:20:53 -0700 Comment on attachment 340033 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340033&action=review > Tools/Scripts/run-javascriptcore-tests:235 > + --verbose: Print more things while running. (can be specified multiple times) Looking at the existing usage descriptions in this file and in test-webkitpy we seem to incorporate the parentheses into the first sentence instead of in another sentence, taking inspiration from test-webkitpy I would write this as: Verbose output (specify more than once to increase verbosity). > Tools/Scripts/run-javascriptcore-tests:524 > + push(@jscStressDriverCmd, ("--verbose") x $verbose) Missing ‘;’ at the end of this line. Not sure how this ran without an error/warning. We prefer to write single body if blocks using one line: push(@jscStressDriverCmd, ("--verbose") x $verbose) if ($verbose > 0); 1422753 3 340098 stephan.szabo 2018-05-10 10:18:46 -0700 Created attachment 340098 Updated patch with review comments Here's an updated version with changed help text and converting to ... if (...) form. 1422814 4 340098 commit-queue 2018-05-10 12:11:52 -0700 Comment on attachment 340098 Updated patch with review comments Clearing flags on attachment: 340098 Committed r231652: <https://trac.webkit.org/changeset/231652> 1422815 5 commit-queue 2018-05-10 12:11:54 -0700 All reviewed patches have been landed. Closing bug. 1422816 6 webkit-bug-importer 2018-05-10 12:12:22 -0700 <rdar://problem/40136619> 340033 2018-05-09 14:48:00 -0700 2018-05-10 10:18:46 -0700 Patch bug-185492-20180509144759.patch text/plain 2266 stephan.szabo U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzdiYjI3MTg4YjdmYzZkZWU3MDgyMTcyOGZjYjJjZWQy NDYwN2JkMC4uNDJkYjgyY2MwODhjMjg2ZjBkZDc3NTk3ODdiNTZiMDdlYTA1OTBmMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA1LTA5ICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4K KworICAgICAgICBTdXBwb3J0IC0tdmVyYm9zZSBpbiBydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTQ5Mgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHM6CisgICAgICAgIChydW5KU0NTdHJlc3NUZXN0cyk6 CisKIDIwMTgtMDUtMDQgIExlbyBCYWx0ZXIgIDxsZW9uYXJkby5iYWx0ZXJAZ21haWwuY29tPgog CiAgICAgICAgIFRlc3QyNjItUnVubmVyOiBBZGQgYmFzZSBtb2R1bGUgdG8gdGhlIGxvY2FsIGRl cHMgLSB1bmljb3JlL1BWQS5wbApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNj cmlwdGNvcmUtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwpp bmRleCA3NWYxNmE0NzU1NjZhMjY2NjQwNjM3NzZmYTYzMWQ5ZDY5YzU0Y2M3Li5lMzQxOWM1NmY0 NDk5M2JmOWZmYTQ4ZTYyYWYzYmI1MDY1NjZhMWFhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRz L3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2Ny aXB0Y29yZS10ZXN0cwpAQCAtOTMsNiArOTMsNyBAQCBteSAkZmFpbEZhc3QgPSAxOwogbXkgJWpz b25EYXRhID0gKCk7CiBteSAkcmVtb3RlQ29uZmlnRmlsZTsKIG15ICRqc29uRmlsZU5hbWU7Citt eSAkdmVyYm9zZSA9IDA7CiAKIGlmICgkRU5We1JVTl9KQVZBU0NSSVBUQ09SRV9URVNUU19URVNU TUFTTX0pIHsKICAgICBpZiAoJEVOVntSVU5fSkFWQVNDUklQVENPUkVfVEVTVFNfVEVTVE1BU019 IGVxICJ0cnVlIikgewpAQCAtMjMxLDYgKzIzMiw3IEBAIFVzYWdlOiAkcHJvZ3JhbU5hbWUgW29w dGlvbnNdIFtvcHRpb25zIHRvIHBhc3MgdG8gYnVpbGQgc3lzdGVtXQogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBFYWNoIGVudmlyb25tZW50IHZhcmlhYmxlIHNob3VsZCBiZSBzZXBh cmF0ZWQgYnkgYSBzcGFjZS4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZS5nLiBc ImZvbz1iYXIgeD15XCIgKG5vIHF1b3RlcykuCiAgIC0tZ21hbGxvYzogICAgICAgICAgICAgICAg ICAgIFJ1biB0ZXN0cyB3aXRoIEd1YXJkIE1hbGxvYyBlbmFibGVkIChpZiBubyBwYXRoIGlzIGdp dmVuOiAkZ21hbGxvY0RlZmF1bHRQYXRoIGlzIHVzZWQpCisgIC0tdmVyYm9zZTogICAgICAgICAg ICAgICAgICAgIFByaW50IG1vcmUgdGhpbmdzIHdoaWxlIHJ1bm5pbmcuIChjYW4gYmUgc3BlY2lm aWVkIG11bHRpcGxlIHRpbWVzKQogCiBFbnZpcm9ubWVudCBWYXJpYWJsZXM6CiAgIC0gc2V0IFJV Tl9KQVZBU0NSSVBUQ09SRV9URVNUU19URVNUTUFTTSB0byAidHJ1ZSIgb3IgImZhbHNlIiAobm8g cXVvdGVzKSB0byBkZXRlcm1pbmUgaWYgd2UgcnVuIHRlc3RtYXNtIGJ5IGRlZmF1bHQuCkBAIC0y NzcsNiArMjc5LDcgQEAgR2V0T3B0aW9ucygKICAgICAnaGVscCcgPT4gXCRzaG93SGVscCwKICAg ICAnZW52LXZhcnM9cycgPT4gXCRlbnZWYXJzLAogICAgICdnbWFsbG9jOnMnID0+IFwkZ21hbGxv Y1BhdGgsCisgICAgJ3ZlcmJvc2UrJyA9PiBcJHZlcmJvc2UKICk7CiAKIApAQCAtNTE3LDYgKzUy MCwxMCBAQCBzdWIgcnVuSlNDU3RyZXNzVGVzdHMKICAgICAgICAgcHVzaChAanNjU3RyZXNzRHJp dmVyQ21kLCAkZmlsdGVyKTsKICAgICB9CiAKKyAgICBpZiAoJHZlcmJvc2UgPiAwKSB7CisgICAg ICAgIHB1c2goQGpzY1N0cmVzc0RyaXZlckNtZCwgKCItLXZlcmJvc2UiKSB4ICR2ZXJib3NlKQor ICAgIH0KKwogICAgIHVuc2hpZnQgQGpzY1N0cmVzc0RyaXZlckNtZCwgd3JhcHBlclByZWZpeElm TmVlZGVkKCkgaWYgc2hvdWxkVXNlSmhidWlsZCgpOwogCiAgICAgIyBFbmQgb3B0aW9uIHByb2Nl c3NpbmcsIHRoZSByZXN0IG9mIHRoZSBhcmd1bWVudHMgYXJlIHRlc3RzCg== 340098 2018-05-10 10:18:46 -0700 2018-05-10 12:11:52 -0700 Updated patch with review comments 185492-2.diff text/plain 2098 stephan.szabo ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3N2Ji MjcxODhiNy4uNDJkYjgyY2MwODggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxOC0wNS0wOSAgU3RlcGhhbiBTemFi byAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CisKKyAgICAgICAgU3VwcG9ydCAtLXZlcmJvc2Ug aW4gcnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODU0OTIKKworICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwg QmF0ZXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czoKKyAg ICAgICAgKHJ1bkpTQ1N0cmVzc1Rlc3RzKToKKwogMjAxOC0wNS0wNCAgTGVvIEJhbHRlciAgPGxl b25hcmRvLmJhbHRlckBnbWFpbC5jb20+CiAKICAgICAgICAgVGVzdDI2Mi1SdW5uZXI6IEFkZCBi YXNlIG1vZHVsZSB0byB0aGUgbG9jYWwgZGVwcyAtIHVuaWNvcmUvUFZBLnBsCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMv cnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCmluZGV4IDc1ZjE2YTQ3NTU2Li43OGRmOTYzM2Y4YiAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMKKysrIGIv VG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMKQEAgLTkzLDYgKzkzLDcgQEAg bXkgJGZhaWxGYXN0ID0gMTsKIG15ICVqc29uRGF0YSA9ICgpOwogbXkgJHJlbW90ZUNvbmZpZ0Zp bGU7CiBteSAkanNvbkZpbGVOYW1lOworbXkgJHZlcmJvc2UgPSAwOwogCiBpZiAoJEVOVntSVU5f SkFWQVNDUklQVENPUkVfVEVTVFNfVEVTVE1BU019KSB7CiAgICAgaWYgKCRFTlZ7UlVOX0pBVkFT Q1JJUFRDT1JFX1RFU1RTX1RFU1RNQVNNfSBlcSAidHJ1ZSIpIHsKQEAgLTIzMSw2ICsyMzIsNyBA QCBVc2FnZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXSBbb3B0aW9ucyB0byBwYXNzIHRvIGJ1aWxk IHN5c3RlbV0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRWFjaCBlbnZpcm9ubWVu dCB2YXJpYWJsZSBzaG91bGQgYmUgc2VwYXJhdGVkIGJ5IGEgc3BhY2UuCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGUuZy4gXCJmb289YmFyIHg9eVwiIChubyBxdW90ZXMpLgogICAt LWdtYWxsb2M6ICAgICAgICAgICAgICAgICAgICBSdW4gdGVzdHMgd2l0aCBHdWFyZCBNYWxsb2Mg ZW5hYmxlZCAoaWYgbm8gcGF0aCBpcyBnaXZlbjogJGdtYWxsb2NEZWZhdWx0UGF0aCBpcyB1c2Vk KQorICAtLXZlcmJvc2U6ICAgICAgICAgICAgICAgICAgICBWZXJib3NlIG91dHB1dCAoc3BlY2lm eSBtb3JlIHRoYW4gb25jZSB0byBpbmNyZWFzZSB2ZXJib3NpdHkpLgogCiBFbnZpcm9ubWVudCBW YXJpYWJsZXM6CiAgIC0gc2V0IFJVTl9KQVZBU0NSSVBUQ09SRV9URVNUU19URVNUTUFTTSB0byAi dHJ1ZSIgb3IgImZhbHNlIiAobm8gcXVvdGVzKSB0byBkZXRlcm1pbmUgaWYgd2UgcnVuIHRlc3Rt YXNtIGJ5IGRlZmF1bHQuCkBAIC0yNzcsNiArMjc5LDcgQEAgR2V0T3B0aW9ucygKICAgICAnaGVs cCcgPT4gXCRzaG93SGVscCwKICAgICAnZW52LXZhcnM9cycgPT4gXCRlbnZWYXJzLAogICAgICdn bWFsbG9jOnMnID0+IFwkZ21hbGxvY1BhdGgsCisgICAgJ3ZlcmJvc2UrJyA9PiBcJHZlcmJvc2UK ICk7CiAKIApAQCAtNTE3LDYgKzUyMCw4IEBAIHN1YiBydW5KU0NTdHJlc3NUZXN0cwogICAgICAg ICBwdXNoKEBqc2NTdHJlc3NEcml2ZXJDbWQsICRmaWx0ZXIpOwogICAgIH0KIAorICAgIHB1c2go QGpzY1N0cmVzc0RyaXZlckNtZCwgKCItLXZlcmJvc2UiKSB4ICR2ZXJib3NlKSBpZiAoJHZlcmJv c2UgPiAwKTsKKwogICAgIHVuc2hpZnQgQGpzY1N0cmVzc0RyaXZlckNtZCwgd3JhcHBlclByZWZp eElmTmVlZGVkKCkgaWYgc2hvdWxkVXNlSmhidWlsZCgpOwogCiAgICAgIyBFbmQgb3B0aW9uIHBy b2Nlc3NpbmcsIHRoZSByZXN0IG9mIHRoZSBhcmd1bWVudHMgYXJlIHRlc3RzCg==