185486 2018-05-09 13:21:38 -0700 Update WebKit.WebsiteDataStoreCustomPaths after r231536 2018-05-10 07:01:23 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu cdumez commit-queue dbates ggaren lforschler sihui_liu webkit-bug-importer oldest_to_newest 1422441 0 sihui_liu 2018-05-09 13:21:38 -0700 _syncNetworkProcessCookies is completely async after r231536, so we need to update the test using this API. 1422442 1 sihui_liu 2018-05-09 13:23:06 -0700 <rdar://problem/37214391> 1422450 2 340015 sihui_liu 2018-05-09 13:31:58 -0700 Created attachment 340015 Patch 1422451 3 340015 cdumez 2018-05-09 13:35:07 -0700 Comment on attachment 340015 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340015&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:150 > + TestWebKitAPI::Util::spinRunLoop(1); I am worried this could still be flaky. How do we know that spinning the runloop 10 times will be sufficient for us: 1. Sending the async IPC to the network process 2. The network process receiving the IPC and asking CFNetwork do sync the cookies 3. Cookies are done sync'ing by the CFNetwork. 1422487 4 340028 sihui_liu 2018-05-09 14:35:01 -0700 Created attachment 340028 Patch 1422490 5 sihui_liu 2018-05-09 14:37:23 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 340015 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340015&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:150 > > + TestWebKitAPI::Util::spinRunLoop(1); > > I am worried this could still be flaky. How do we know that spinning the > runloop 10 times will be sufficient for us: > 1. Sending the async IPC to the network process > 2. The network process receiving the IPC and asking CFNetwork do sync the > cookies > 3. Cookies are done sync'ing by the CFNetwork. We don't know. I've changed it to use sleep since second seems to be a better unit for estimation. 1422494 6 340028 cdumez 2018-05-09 14:40:59 -0700 Comment on attachment 340028 Patch I would have been more generous than 3 seconds given our slow bots but let's try... 1422533 7 340028 commit-queue 2018-05-09 15:35:44 -0700 Comment on attachment 340028 Patch Clearing flags on attachment: 340028 Committed r231603: <https://trac.webkit.org/changeset/231603> 1422534 8 commit-queue 2018-05-09 15:35:45 -0700 All reviewed patches have been landed. Closing bug. 1422545 9 webkit-bug-importer 2018-05-09 16:09:00 -0700 <rdar://problem/40110684> 1422641 10 340028 ap 2018-05-09 23:22:00 -0700 Comment on attachment 340028 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=340028&action=review > Tools/ChangeLog:9 > + Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now. "_syncNetworkProcessCookies is async"... 1422705 11 cdumez 2018-05-10 07:01:23 -0700 (In reply to Alexey Proskuryakov from comment #10) > Comment on attachment 340028 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=340028&action=review > > > Tools/ChangeLog:9 > > + Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now. > > "_syncNetworkProcessCookies is async"... Sync means synchronize here, not synchronous :) 340015 2018-05-09 13:31:58 -0700 2018-05-09 14:35:00 -0700 Patch bug-185486-20180509133158.patch text/plain 1819 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNTIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODBmZjM0NGMwODcxNzAyNWVlY2E3NGZlN2QwM2NlNzM3 N2M3ZGFjZS4uZmRhMGVhN2IzZWE5ZTIwMTQwOGNjNDQwMDlkYzUwMmMzNzljNWZjYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE4LTA1LTA5ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAg ICAgIFVwZGF0ZSBXZWJLaXQuV2Vic2l0ZURhdGFTdG9yZUN1c3RvbVBhdGhzIGFmdGVyIHIyMzE1 MzYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTQ4 NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzcyMTQzOTE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIFdlYktpdC5XZWJzaXRlRGF0YVN0 b3JlQ3VzdG9tUGF0aHMgYXMgX3N5bmNOZXR3b3JrUHJvY2Vzc0Nvb2tpZXMgaXMgYXN5bmMgbm93 LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJzaXRlRGF0 YVN0b3JlQ3VzdG9tUGF0aHMubW06CisgICAgICAgIChURVNUKToKKwogMjAxOC0wNS0wOCAgTGVv IEJhbHRlciAgPGxlb25hcmRvLmJhbHRlckBnbWFpbC5jb20+CiAKICAgICAgICAgVGVzdDI2Mi1S dW5uZXI6IEFkZCBiYXNlIFBlcmwgVW5pY29kZURhdGEKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV2Vic2l0ZURhdGFTdG9yZUN1c3RvbVBhdGhzLm1t IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJzaXRlRGF0YVN0b3Jl Q3VzdG9tUGF0aHMubW0KaW5kZXggNWEwNjgwOGI4NTk5YWI4MjZlNTQwYWU5NjMyOGU3MmVlNzgy Zjg5My4uNjYyZDVmMmE4NDhhMWE2Y2FmMDg4ZDIzYWFkMzg2YTcyODg3NGIzNiAxMDA2NDQKLS0t IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJzaXRlRGF0YVN0b3Jl Q3VzdG9tUGF0aHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2Nv YS9XZWJzaXRlRGF0YVN0b3JlQ3VzdG9tUGF0aHMubW0KQEAgLTE0Myw2ICsxNDMsMTIgQEAgVEVT VChXZWJLaXQsIFdlYnNpdGVEYXRhU3RvcmVDdXN0b21QYXRocykKICAgICBFWFBFQ1RfVFJVRShb W05TRmlsZU1hbmFnZXIgZGVmYXVsdE1hbmFnZXJdIGZpbGVFeGlzdHNBdFBhdGg6bG9jYWxTdG9y YWdlUGF0aC5wYXRoXSk7CiAKICNpZiBQTEFURk9STShJT1MpIHx8IChfX01BQ19PU19YX1ZFUlNJ T05fTUlOX1JFUVVJUkVEIDwgMTAxMzAwKQorICAgIGludCByZXRyeUNvdW50ID0gMTA7CisgICAg d2hpbGUgKHJldHJ5Q291bnQtLSkgeworICAgICAgICBpZiAoW1tOU0ZpbGVNYW5hZ2VyIGRlZmF1 bHRNYW5hZ2VyXSBmaWxlRXhpc3RzQXRQYXRoOmNvb2tpZVN0b3JhZ2VGaWxlLnBhdGhdKQorICAg ICAgICAgICAgYnJlYWs7CisgICAgICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnNwaW5SdW5Mb29w KDEpOworICAgIH0KICAgICBFWFBFQ1RfVFJVRShbW05TRmlsZU1hbmFnZXIgZGVmYXVsdE1hbmFn ZXJdIGZpbGVFeGlzdHNBdFBhdGg6Y29va2llU3RvcmFnZUZpbGUucGF0aF0pOwogCiAgICAgLy8g Tm90ZTogVGhlIGZvcm1hdCBvZiB0aGUgY29va2llIGZpbGUgb24gZGlzayBpcyBwcm9wcmlldGFy eSBhbmQgb3BhcXVlLCBzbyB0aGlzIGlzIGZyYWdpbGUgdG8gZnV0dXJlIGNoYW5nZXMuCg== 340028 2018-05-09 14:35:01 -0700 2018-05-09 15:35:44 -0700 Patch bug-185486-20180509143500.patch text/plain 1815 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNTIzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODBmZjM0NGMwODcxNzAyNWVlY2E3NGZlN2QwM2NlNzM3 N2M3ZGFjZS4uZmRhMGVhN2IzZWE5ZTIwMTQwOGNjNDQwMDlkYzUwMmMzNzljNWZjYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE4LTA1LTA5ICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAg ICAgIFVwZGF0ZSBXZWJLaXQuV2Vic2l0ZURhdGFTdG9yZUN1c3RvbVBhdGhzIGFmdGVyIHIyMzE1 MzYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTQ4 NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzcyMTQzOTE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIFdlYktpdC5XZWJzaXRlRGF0YVN0 b3JlQ3VzdG9tUGF0aHMgYXMgX3N5bmNOZXR3b3JrUHJvY2Vzc0Nvb2tpZXMgaXMgYXN5bmMgbm93 LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJzaXRlRGF0 YVN0b3JlQ3VzdG9tUGF0aHMubW06CisgICAgICAgIChURVNUKToKKwogMjAxOC0wNS0wOCAgTGVv IEJhbHRlciAgPGxlb25hcmRvLmJhbHRlckBnbWFpbC5jb20+CiAKICAgICAgICAgVGVzdDI2Mi1S dW5uZXI6IEFkZCBiYXNlIFBlcmwgVW5pY29kZURhdGEKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV2Vic2l0ZURhdGFTdG9yZUN1c3RvbVBhdGhzLm1t IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJzaXRlRGF0YVN0b3Jl Q3VzdG9tUGF0aHMubW0KaW5kZXggNWEwNjgwOGI4NTk5YWI4MjZlNTQwYWU5NjMyOGU3MmVlNzgy Zjg5My4uMTQ3YTBhYWUzOGNmYzljYjg3NjkwY2E1MTY1ZWEwMzRmNDkxOTEzMiAxMDA2NDQKLS0t IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XZWJzaXRlRGF0YVN0b3Jl Q3VzdG9tUGF0aHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2Nv YS9XZWJzaXRlRGF0YVN0b3JlQ3VzdG9tUGF0aHMubW0KQEAgLTE0Myw2ICsxNDMsMTIgQEAgVEVT VChXZWJLaXQsIFdlYnNpdGVEYXRhU3RvcmVDdXN0b21QYXRocykKICAgICBFWFBFQ1RfVFJVRShb W05TRmlsZU1hbmFnZXIgZGVmYXVsdE1hbmFnZXJdIGZpbGVFeGlzdHNBdFBhdGg6bG9jYWxTdG9y YWdlUGF0aC5wYXRoXSk7CiAKICNpZiBQTEFURk9STShJT1MpIHx8IChfX01BQ19PU19YX1ZFUlNJ T05fTUlOX1JFUVVJUkVEIDwgMTAxMzAwKQorICAgIGludCByZXRyeUNvdW50ID0gMzA7CisgICAg d2hpbGUgKHJldHJ5Q291bnQtLSkgeworICAgICAgICBpZiAoW1tOU0ZpbGVNYW5hZ2VyIGRlZmF1 bHRNYW5hZ2VyXSBmaWxlRXhpc3RzQXRQYXRoOmNvb2tpZVN0b3JhZ2VGaWxlLnBhdGhdKQorICAg ICAgICAgICAgYnJlYWs7CisgICAgICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnNsZWVwKDAuMSk7 CisgICAgfQogICAgIEVYUEVDVF9UUlVFKFtbTlNGaWxlTWFuYWdlciBkZWZhdWx0TWFuYWdlcl0g ZmlsZUV4aXN0c0F0UGF0aDpjb29raWVTdG9yYWdlRmlsZS5wYXRoXSk7CiAKICAgICAvLyBOb3Rl OiBUaGUgZm9ybWF0IG9mIHRoZSBjb29raWUgZmlsZSBvbiBkaXNrIGlzIHByb3ByaWV0YXJ5IGFu ZCBvcGFxdWUsIHNvIHRoaXMgaXMgZnJhZ2lsZSB0byBmdXR1cmUgY2hhbmdlcy4K