185478 2018-05-09 09:45:59 -0700 AX: Hidden nodes which are not directly referenced should not participate name/description from content 2018-05-09 17:06:56 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 jdiggs jdiggs aboxhall apinheiro cfleizach commit-queue dmazzoni ews-watchlist jcraig samuel_white webkit-bug-importer oldest_to_newest 1422305 0 jdiggs 2018-05-09 09:45:59 -0700 The Accname specification states that if the current node is hidden (as defined by that spec), and not directly referenced by aria-labelledby or aria-describedby, and is not a host language text alternative, the empty string should be returned. We're seeing bugs where the text under the element is being included for certain "hidden" nodes. For instance in the test case found here, https://github.com/w3c/web-platform-tests/blob/master/accname/description_from_content_of_describedby_element-manual.html, the "in" from the table is being included. 1422307 1 webkit-bug-importer 2018-05-09 09:46:11 -0700 <rdar://problem/40094706> 1422309 2 339972 jdiggs 2018-05-09 09:50:01 -0700 Created attachment 339972 Patch 1422568 3 339972 commit-queue 2018-05-09 17:06:55 -0700 Comment on attachment 339972 Patch Clearing flags on attachment: 339972 Committed r231620: <https://trac.webkit.org/changeset/231620> 1422569 4 commit-queue 2018-05-09 17:06:56 -0700 All reviewed patches have been landed. Closing bug. 339972 2018-05-09 09:50:01 -0700 2018-05-09 17:06:55 -0700 Patch bug-185478-20180509125001.patch text/plain 7126 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTk3OGY5NjhhMDlhNmU5 NWYxMmJmYzgxMWM0NzExZjdkNTk1MWQ1Ny4uN2U4OTAwNWQ4NGJhYmJhNmE1OTkxMGVjMWM5YTFk MjRkZGMxNjFjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA1LTA5ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogSGlkZGVuIG5v ZGVzIHdoaWNoIGFyZSBub3QgZGlyZWN0bHkgcmVmZXJlbmNlZCBzaG91bGQgbm90IHBhcnRpY2lw YXRlIG5hbWUvZGVzY3JpcHRpb24gZnJvbSBjb250ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU0NzgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBjaGVjayB0byBBY2Nlc3NpYmlsaXR5Tm9k ZU9iamVjdDo6dGV4dFVuZGVyRWxlbWVudCgpIGFuZCByZXR1cm4gZWFybHkKKyAgICAgICAgaWYg dGhlIG5vZGUgaXMgaGlkZGVuLCBub3QgcmVmZXJlbmNlZCBieSBhcmlhLWxhYmVsbGVkYnkgb3Ig YXJpYS1kZXNjcmliZWRieSwKKyAgICAgICAgbm90IGFuIEhUTUxMYWJlbEVsZW1lbnQsIGFuZCBu b3QgZmFsbGJhY2sgY29udGVudCBmb3IgYW4gSFRNTENhbnZhc0VsZW1lbnQuCisKKyAgICAgICAg VGVzdDogYWNjZXNzaWJpbGl0eS90ZXh0LWFsdGVybmF0aXZlLWNhbGN1bGF0aW9uLWhpZGRlbi1u b2Rlcy5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2Jq ZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0Ojp0ZXh0 VW5kZXJFbGVtZW50IGNvbnN0KToKKwogMjAxOC0wNS0wNyAgWmFsYW4gQnVqdGFzICA8emFsYW5A YXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdIEFkZCBGb3JtYXR0aW5nQ29udGV4dDo6bGF5b3V0 T3V0T2ZGbG93RGVzY2VuZGFudHMgaW1wbGVtZW50YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwIGIvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAKaW5kZXgg ZGI4NTc1ZTEwMzNkZjdlOGFjZWQ5MjM5N2Q4YmMwNTRkNjY2YjVhYy4uNzA5ZWNjMzQ5ZWY2OWQ5 NzY1NzNiNTk5MWQyOGZkMTQ5ZDg5YTg5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAKQEAgLTE3MzMsNiAr MTczMywxOCBAQCBTdHJpbmcgQWNjZXNzaWJpbGl0eU5vZGVPYmplY3Q6OnRleHRVbmRlckVsZW1l bnQoQWNjZXNzaWJpbGl0eVRleHRVbmRlckVsZW1lbnRNbwogICAgIGlmIChpczxUZXh0Pihub2Rl KSkKICAgICAgICAgcmV0dXJuIGRvd25jYXN0PFRleHQ+KCpub2RlKS53aG9sZVRleHQoKTsKIAor ICAgIC8vIFRoZSBBY2NuYW1lIHNwZWNpZmljYXRpb24gc3RhdGVzIHRoYXQgaWYgdGhlIGN1cnJl bnQgbm9kZSBpcyBoaWRkZW4sIGFuZCBub3QgZGlyZWN0bHkKKyAgICAvLyByZWZlcmVuY2VkIGJ5 IGFyaWEtbGFiZWxsZWRieSBvciBhcmlhLWRlc2NyaWJlZGJ5LCBhbmQgaXMgbm90IGEgaG9zdCBs YW5ndWFnZSB0ZXh0CisgICAgLy8gYWx0ZXJuYXRpdmUsIHRoZSBlbXB0eSBzdHJpbmcgc2hvdWxk IGJlIHJldHVybmVkLgorICAgIGlmIChpc0hpZGRlbigpICYmICFpczxIVE1MTGFiZWxFbGVtZW50 Pihub2RlKSAmJiAhYW5jZXN0b3JzT2ZUeXBlPEhUTUxDYW52YXNFbGVtZW50Pigqbm9kZSkuZmly c3QoKSkgeworICAgICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0OjpBY2Nlc3NpYmlsaXR5Q2hpbGRy ZW5WZWN0b3IgbGFiZWxGb3I7CisgICAgICAgIEFjY2Vzc2liaWxpdHlPYmplY3Q6OkFjY2Vzc2li aWxpdHlDaGlsZHJlblZlY3RvciBkZXNjcmlwdGlvbkZvcjsKKyAgICAgICAgYXJpYUxhYmVsbGVk QnlSZWZlcmVuY2luZ0VsZW1lbnRzKGxhYmVsRm9yKTsKKyAgICAgICAgYXJpYURlc2NyaWJlZEJ5 UmVmZXJlbmNpbmdFbGVtZW50cyhkZXNjcmlwdGlvbkZvcik7CisgICAgICAgIGlmICghbGFiZWxG b3Iuc2l6ZSgpICYmICFkZXNjcmlwdGlvbkZvci5zaXplKCkpCisgICAgICAgICAgICByZXR1cm4g U3RyaW5nKCk7CisgICAgfQorCiAgICAgU3RyaW5nQnVpbGRlciBidWlsZGVyOwogICAgIGZvciAo QWNjZXNzaWJpbGl0eU9iamVjdCogY2hpbGQgPSBmaXJzdENoaWxkKCk7IGNoaWxkOyBjaGlsZCA9 IGNoaWxkLT5uZXh0U2libGluZygpKSB7CiAgICAgICAgIGlmIChtb2RlLmlnbm9yZWRDaGlsZE5v ZGUgJiYgY2hpbGQtPm5vZGUoKSA9PSBtb2RlLmlnbm9yZWRDaGlsZE5vZGUpCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZjVk NDAyYjExZDk4NWUxMGU3MzI0ZjQ0ZjUyMzAxOWFjNmIzZTc2Ny4uMzdmNzAzYjRmMjk3M2VkNzE1 OTFhNjY5NGIxYjEzM2MyNjVkMzZkYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA1LTA5 ICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogSGlk ZGVuIG5vZGVzIHdoaWNoIGFyZSBub3QgZGlyZWN0bHkgcmVmZXJlbmNlZCBzaG91bGQgbm90IHBh cnRpY2lwYXRlIG5hbWUvZGVzY3JpcHRpb24gZnJvbSBjb250ZW50CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU0NzgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvdGV4dC1hbHRl cm5hdGl2ZS1jYWxjdWxhdGlvbi1oaWRkZW4tbm9kZXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBhY2Nlc3NpYmlsaXR5L3RleHQtYWx0ZXJuYXRpdmUtY2FsY3VsYXRpb24taGlkZGVu LW5vZGVzLmh0bWw6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5 L3RleHQtYWx0ZXJuYXRpdmUtY2FsY3VsYXRpb24taGlkZGVuLW5vZGVzLWV4cGVjdGVkLnR4dDog QWRkZWQuCisKIDIwMTgtMDUtMDcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBVbnJldmlld2VkLCBhZGQgZnJhbWUgbmFtZSBpbiBmb3JtLWlmcmFtZS10YXJnZXQt YmVmb3JlLWxvYWQtY3Jhc2guaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS90ZXh0LWFsdGVybmF0aXZlLWNhbGN1bGF0aW9uLWhpZGRlbi1ub2Rlcy1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3RleHQtYWx0ZXJuYXRpdmUtY2FsY3VsYXRp b24taGlkZGVuLW5vZGVzLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wZGUwNDc1OWMzMjZlNTVh ZThhMDEyOWVkOTI4NTI1YWQ5OWU1NmNlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS90ZXh0LWFsdGVybmF0aXZlLWNhbGN1bGF0aW9uLWhpZGRlbi1ub2Rlcy1l eHBlY3RlZC50eHQKQEAgLTAsMCArMSwyNCBAQAorVGhpcyB0ZXN0cyB0ZXh0IGFsdGVybmF0aXZl IGNhbGN1bGF0aW9uIHdpdGggaGlkZGVuIG5vZGVzLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVU RSIuCisKKworVGVzdCAxCisJVzNDIE5hbWU6IGZvbworCVczQyBEZXNjcmlwdGlvbjogCitUZXN0 IDIKKwlXM0MgTmFtZTogCisJVzNDIERlc2NyaXB0aW9uOiBiYXIKK1Rlc3QgMworCVczQyBOYW1l OiAKKwlXM0MgRGVzY3JpcHRpb246IAorVGVzdCA0CisJVzNDIE5hbWU6IGNlbGwgMSBjZWxsIDQK KwlXM0MgRGVzY3JpcHRpb246IAorVGVzdCA1CisJVzNDIE5hbWU6IAorCVczQyBEZXNjcmlwdGlv bjogY2VsbCAxIGNlbGwgNAorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNU IENPTVBMRVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvdGV4dC1h bHRlcm5hdGl2ZS1jYWxjdWxhdGlvbi1oaWRkZW4tbm9kZXMuaHRtbCBiL0xheW91dFRlc3RzL2Fj Y2Vzc2liaWxpdHkvdGV4dC1hbHRlcm5hdGl2ZS1jYWxjdWxhdGlvbi1oaWRkZW4tbm9kZXMuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi5kZDk2OTEzZmZjN2U4MWY3MDkwNWM2Njg3NmVkOTVlZmFmYWE3ZGNlCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS90ZXh0LWFsdGVybmF0 aXZlLWNhbGN1bGF0aW9uLWhpZGRlbi1ub2Rlcy5odG1sCkBAIC0wLDAgKzEsNTAgQEAKKzwhRE9D VFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMt dGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNlcy9hY2Nlc3Np YmlsaXR5LWhlbHBlci5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXYgaWQ9ImNv bnRlbnQiPgorICA8ZGl2IGlkPSJoaWRkZW4xIiBzdHlsZT0idmlzaWJpbGl0eTpoaWRkZW47Ij5m b288L2Rpdj4KKyAgPGRpdiBpZD0iaGlkZGVuMiIgc3R5bGU9ImRpc3BsYXk6bm9uZTsiPmJhcjwv ZGl2PgorCisgIDxpbnB1dCBpZD0idGVzdDEiIGFyaWEtbGFiZWxsZWRieT0iaGlkZGVuMSI+Cisg IDxpbnB1dCBpZD0idGVzdDIiIGFyaWEtZGVzY3JpYmVkYnk9ImhpZGRlbjIiPgorCisgIDxsYWJl bCBmb3I9InRlc3QzIiBpZD0iaGlkZGVuMyIgc3R5bGU9ImRpc3BsYXk6bm9uZTsiPmJhejwvbGFi ZWw+CisgIDxpbnB1dCBpZD0idGVzdDMiPgorCisgIDx0YWJsZSBpZD0idGFibGUiPgorICAgIDx0 cj4KKyAgICAgIDx0ZD5jZWxsIDE8L3RkPgorICAgICAgPHRkIHN0eWxlPSJ2aXNpYmlsaXR5Omhp ZGRlbjsiPmNlbGwgMjwvdGQ+CisgICAgICA8dGQ+PGRpdiBzdHlsZT0iZGlzcGxheTpub25lOyI+ PGRpdj5jZWxsIDM8L2Rpdj48L3RkPgorICAgICAgPHRkPjxkaXY+Y2VsbCA0PC9kaXY+PC90ZD4K KyAgICA8L3RyPgorICA8L3RhYmxlPgorICA8aW5wdXQgaWQ9InRlc3Q0IiBhcmlhLWxhYmVsbGVk Ynk9InRhYmxlIj4KKyAgPGlucHV0IGlkPSJ0ZXN0NSIgYXJpYS1kZXNjcmliZWRieT0idGFibGUi PgorPC9kaXY+CisKKzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+ PC9kaXY+CisKKzxzY3JpcHQ+CisgICAgZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGV4dCBhbHRl cm5hdGl2ZSBjYWxjdWxhdGlvbiB3aXRoIGhpZGRlbiBub2Rlcy4iKTsKKworICAgIGlmICh3aW5k b3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICAgICAgZm9yICh2YXIgaSA9IDE7IGkg PD0gNTsgaSsrKSB7CisgICAgICAgICAgICB2YXIgYXhFbGVtZW50ID0gYWNjZXNzaWJpbGl0eUNv bnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCJ0ZXN0IiArIGkpOworICAgICAgICAgICAg ZGVidWcoIlRlc3QgIiArIGkpOworICAgICAgICAgICAgZGVidWcoIlx0VzNDIE5hbWU6ICIgKyBw bGF0Zm9ybVZhbHVlRm9yVzNDTmFtZShheEVsZW1lbnQpKTsKKyAgICAgICAgICAgIGRlYnVnKCJc dFczQyBEZXNjcmlwdGlvbjogIiArIHBsYXRmb3JtVmFsdWVGb3JXM0NEZXNjcmlwdGlvbihheEVs ZW1lbnQpKTsKKyAgICAgICAgIH0KKyAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29u dGVudCIpLnN0eWxlLnZpc2liaWxpdHkgPSAiaGlkZGVuIjsKKyAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgidGFibGUiKS5zdHlsZS52aXNpYmlsaXR5ID0gImhpZGRlbiI7CisgICAgfQor PC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48 L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3RleHQtYWx0ZXJuYXRpdmUtY2FsY3VsYXRpb24taGlkZGVu LW5vZGVzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmls aXR5L3RleHQtYWx0ZXJuYXRpdmUtY2FsY3VsYXRpb24taGlkZGVuLW5vZGVzLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi5mZDdhMDk4NTE0NjIyNDJlOWIxODMxMjQwMDMwODYxZGFjM2U1ZGJjCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkv dGV4dC1hbHRlcm5hdGl2ZS1jYWxjdWxhdGlvbi1oaWRkZW4tbm9kZXMtZXhwZWN0ZWQudHh0CkBA IC0wLDAgKzEsMjQgQEAKK1RoaXMgdGVzdHMgdGV4dCBhbHRlcm5hdGl2ZSBjYWxjdWxhdGlvbiB3 aXRoIGhpZGRlbiBub2Rlcy4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m ICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1Rlc3Qg MQorCVczQyBOYW1lOiBmb28KKwlXM0MgRGVzY3JpcHRpb246IAorVGVzdCAyCisJVzNDIE5hbWU6 IAorCVczQyBEZXNjcmlwdGlvbjogYmFyCitUZXN0IDMKKwlXM0MgTmFtZTogYmF6CisJVzNDIERl c2NyaXB0aW9uOiAKK1Rlc3QgNAorCVczQyBOYW1lOiBjZWxsIDEgY2VsbCA0CisJVzNDIERlc2Ny aXB0aW9uOiAKK1Rlc3QgNQorCVczQyBOYW1lOiAKKwlXM0MgRGVzY3JpcHRpb246IGNlbGwgMSBj ZWxsIDQKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQor Cg==