185476 2018-05-09 09:29:05 -0700 [JSC] Fix ArraySpeciesCreate to return a new Array when the given object is not an array 2018-05-09 16:11:19 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=185495 InRadar P2 Normal --- 1 leo webkit-unassigned commit-queue ews-watchlist keith_miller leo mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1422297 0 leo 2018-05-09 09:29:05 -0700 [JSC] Fix ArraySpeciesCreate to return a new Array when the given object is not an array 1422299 1 339969 leo 2018-05-09 09:31:11 -0700 Created attachment 339969 Patch 1422314 2 339969 ysuzuki 2018-05-09 09:55:54 -0700 Comment on attachment 339969 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339969&action=review > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:256 > + // If isArray is false, return ? ArrayCreate(length). > + JSGlobalObject* globalObject = thisObject->globalObject(); > + JSValue newValue = constructArrayWithSizeQuirk(exec, nullptr, globalObject, jsNumber(length), exec->newTarget()); > + JSObject* newObject = newValue.toObject(exec); > RETURN_IF_EXCEPTION(scope, exceptionResult()); > + return std::make_pair(SpeciesConstructResult::CreatedObject, newObject); Let's return `std::make_pair(SpeciesConstructResult::FastPath, nullptr)` since it creates an Array(length), it is fast path case. 1422323 3 339974 leo 2018-05-09 10:06:47 -0700 Created attachment 339974 Patch 1422329 4 339977 leo 2018-05-09 10:13:17 -0700 Created attachment 339977 Patch 1422330 5 339977 ysuzuki 2018-05-09 10:14:13 -0700 Comment on attachment 339977 Patch r=me 1422336 6 339977 commit-queue 2018-05-09 10:29:45 -0700 Comment on attachment 339977 Patch Clearing flags on attachment: 339977 Committed r231572: <https://trac.webkit.org/changeset/231572> 1422337 7 commit-queue 2018-05-09 10:29:46 -0700 All reviewed patches have been landed. Closing bug. 1422338 8 webkit-bug-importer 2018-05-09 10:30:28 -0700 <rdar://problem/40096808> 339969 2018-05-09 09:31:11 -0700 2018-05-09 10:06:39 -0700 Patch bug-185476-20180509133110.patch text/plain 2284 leo U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 OWFiMTliZTg2YmJjMDdmNTI1Mzg0NzQxZDNjOTczNzE4M2RkYzQ4Li5kZGEyZWQxZGVjNjQ4NDZk NmI3ZGEzNDkzNzFkNjZkMDc0ZjlmODMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0wNS0wOSAgTGVvIEJhbHRlciAgPGxlb25hcmRvLmJhbHRlckBnbWFp bC5jb20+CisKKyAgICAgICAgW0pTQ10gRml4IEFycmF5U3BlY2llc0NyZWF0ZSB0byByZXR1cm4g YSBuZXcgQXJyYXkgd2hlbiB0aGUgZ2l2ZW4gb2JqZWN0IGlzIG5vdCBhbiBhcnJheQorICAgICAg ICBFcnJvciBmb3VuZCBpbiB0aGUgZm9sbG93aW5nIFRlc3QyNjIgdGVzdHM6CisKKyAgICAgICAg LSB0ZXN0L2J1aWx0LWlucy9BcnJheS9wcm90b3R5cGUvc2xpY2UvY3JlYXRlLW5vbi1hcnJheS1p bnZhbGlkLWxlbi5qcworICAgICAgICAtIHRlc3QvYnVpbHQtaW5zL0FycmF5L3Byb3RvdHlwZS9z bGljZS9jcmVhdGUtcHJveGllZC1hcnJheS1pbnZhbGlkLWxlbi5qcworICAgICAgICAtIHRlc3Qv YnVpbHQtaW5zL0FycmF5L3Byb3RvdHlwZS9zcGxpY2UvY3JlYXRlLXNwZWNpZXMtdW5kZWYtaW52 YWxpZC1sZW4uanMKKworICAgICAgICBUaGUgQXJyYXlTcGVjaWVzQ3JlYXRlIHNob3VsZCB0aHJv dyBhIFJhbmdlRXJyb3Igd2l0aCBub24tQXJyYXkgY3VzdG9tIG9iamVjdHMKKyAgICAgICAgcHJl c2VudGluZyBhIGxlbmd0aCA+IDIqKjMyLTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4NTQ3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHA6CisKIDIwMTgt MDUtMDkgIFNyZGphbiBMYXphcmV2aWMgIDxzcmRqYW4ubGF6YXJldmljQHJ0LXJrLmNvbT4KIAog ICAgICAgICBbTUlQU10gT3B0aW1pemUgZ2VuZXJhdGVkIEpJVCBjb2RlIHVzaW5nIHIyCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAKaW5kZXgg M2UyODQzZmVhZTFlZDM0NDM4M2Y2OWE0OTU1NDBjZmJiNWE5Nzc1Ni4uZDUzMTI1ZjY3Y2Q4YmFm ZDgzMzJjMzRiOTFlNDU2M2Q2NDFmNGFlZCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcApAQCAtMjQ3LDggKzI0NywxNCBAQCBzdGF0aWMg QUxXQVlTX0lOTElORSBzdGQ6OnBhaXI8U3BlY2llc0NvbnN0cnVjdFJlc3VsdCwgSlNPYmplY3Qq PiBzcGVjaWVzQ29uc3RydQogICAgICAgICAgICAgaWYgKGNvbnN0cnVjdG9yLmlzTnVsbCgpKQog ICAgICAgICAgICAgICAgIHJldHVybiBzdGQ6Om1ha2VfcGFpcihTcGVjaWVzQ29uc3RydWN0UmVz dWx0OjpGYXN0UGF0aCwgbnVsbHB0cik7OwogICAgICAgICB9Ci0gICAgfSBlbHNlCisgICAgfSBl bHNlIHsKKyAgICAgICAgLy8gSWYgaXNBcnJheSBpcyBmYWxzZSwgcmV0dXJuID8gQXJyYXlDcmVh dGUobGVuZ3RoKS4KKyAgICAgICAgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCA9IHRoaXNP YmplY3QtPmdsb2JhbE9iamVjdCgpOworICAgICAgICBKU1ZhbHVlIG5ld1ZhbHVlID0gY29uc3Ry dWN0QXJyYXlXaXRoU2l6ZVF1aXJrKGV4ZWMsIG51bGxwdHIsIGdsb2JhbE9iamVjdCwganNOdW1i ZXIobGVuZ3RoKSwgZXhlYy0+bmV3VGFyZ2V0KCkpOworICAgICAgICBKU09iamVjdCogbmV3T2Jq ZWN0ID0gbmV3VmFsdWUudG9PYmplY3QoZXhlYyk7CiAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJ T04oc2NvcGUsIGV4Y2VwdGlvblJlc3VsdCgpKTsKKyAgICAgICAgcmV0dXJuIHN0ZDo6bWFrZV9w YWlyKFNwZWNpZXNDb25zdHJ1Y3RSZXN1bHQ6OkNyZWF0ZWRPYmplY3QsIG5ld09iamVjdCk7Cisg ICAgfQogCiAgICAgaWYgKGNvbnN0cnVjdG9yLmlzVW5kZWZpbmVkKCkpCiAgICAgICAgIHJldHVy biBzdGQ6Om1ha2VfcGFpcihTcGVjaWVzQ29uc3RydWN0UmVzdWx0OjpGYXN0UGF0aCwgbnVsbHB0 cik7Cg== 339974 2018-05-09 10:06:47 -0700 2018-05-09 10:13:11 -0700 Patch bug-185476-20180509140644.patch text/plain 2030 leo U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 OWFiMTliZTg2YmJjMDdmNTI1Mzg0NzQxZDNjOTczNzE4M2RkYzQ4Li5kZGEyZWQxZGVjNjQ4NDZk NmI3ZGEzNDkzNzFkNjZkMDc0ZjlmODMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0wNS0wOSAgTGVvIEJhbHRlciAgPGxlb25hcmRvLmJhbHRlckBnbWFp bC5jb20+CisKKyAgICAgICAgW0pTQ10gRml4IEFycmF5U3BlY2llc0NyZWF0ZSB0byByZXR1cm4g YSBuZXcgQXJyYXkgd2hlbiB0aGUgZ2l2ZW4gb2JqZWN0IGlzIG5vdCBhbiBhcnJheQorICAgICAg ICBFcnJvciBmb3VuZCBpbiB0aGUgZm9sbG93aW5nIFRlc3QyNjIgdGVzdHM6CisKKyAgICAgICAg LSB0ZXN0L2J1aWx0LWlucy9BcnJheS9wcm90b3R5cGUvc2xpY2UvY3JlYXRlLW5vbi1hcnJheS1p bnZhbGlkLWxlbi5qcworICAgICAgICAtIHRlc3QvYnVpbHQtaW5zL0FycmF5L3Byb3RvdHlwZS9z bGljZS9jcmVhdGUtcHJveGllZC1hcnJheS1pbnZhbGlkLWxlbi5qcworICAgICAgICAtIHRlc3Qv YnVpbHQtaW5zL0FycmF5L3Byb3RvdHlwZS9zcGxpY2UvY3JlYXRlLXNwZWNpZXMtdW5kZWYtaW52 YWxpZC1sZW4uanMKKworICAgICAgICBUaGUgQXJyYXlTcGVjaWVzQ3JlYXRlIHNob3VsZCB0aHJv dyBhIFJhbmdlRXJyb3Igd2l0aCBub24tQXJyYXkgY3VzdG9tIG9iamVjdHMKKyAgICAgICAgcHJl c2VudGluZyBhIGxlbmd0aCA+IDIqKjMyLTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4NTQ3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHA6CisKIDIwMTgt MDUtMDkgIFNyZGphbiBMYXphcmV2aWMgIDxzcmRqYW4ubGF6YXJldmljQHJ0LXJrLmNvbT4KIAog ICAgICAgICBbTUlQU10gT3B0aW1pemUgZ2VuZXJhdGVkIEpJVCBjb2RlIHVzaW5nIHIyCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAKaW5kZXgg M2UyODQzZmVhZTFlZDM0NDM4M2Y2OWE0OTU1NDBjZmJiNWE5Nzc1Ni4uMTI0YmQzNGJkNGE3NjVj YTFmMGYxMjBlNmY5N2JiOTM1YWFlYmJkNyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcApAQCAtMjQ3LDggKzI0NywxMSBAQCBzdGF0aWMg QUxXQVlTX0lOTElORSBzdGQ6OnBhaXI8U3BlY2llc0NvbnN0cnVjdFJlc3VsdCwgSlNPYmplY3Qq PiBzcGVjaWVzQ29uc3RydQogICAgICAgICAgICAgaWYgKGNvbnN0cnVjdG9yLmlzTnVsbCgpKQog ICAgICAgICAgICAgICAgIHJldHVybiBzdGQ6Om1ha2VfcGFpcihTcGVjaWVzQ29uc3RydWN0UmVz dWx0OjpGYXN0UGF0aCwgbnVsbHB0cik7OwogICAgICAgICB9Ci0gICAgfSBlbHNlCisgICAgfSBl bHNlIHsKKyAgICAgICAgLy8gSWYgaXNBcnJheSBpcyBmYWxzZSwgcmV0dXJuID8gQXJyYXlDcmVh dGUobGVuZ3RoKS4KICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgZXhjZXB0aW9u UmVzdWx0KCkpOworICAgICAgICByZXR1cm4gc3RkOjptYWtlX3BhaXIoU3BlY2llc0NvbnN0cnVj dFJlc3VsdDo6RmFzdFBhdGgsIG51bGxwdHIpOworICAgIH0KIAogICAgIGlmIChjb25zdHJ1Y3Rv ci5pc1VuZGVmaW5lZCgpKQogICAgICAgICByZXR1cm4gc3RkOjptYWtlX3BhaXIoU3BlY2llc0Nv bnN0cnVjdFJlc3VsdDo6RmFzdFBhdGgsIG51bGxwdHIpOwo= 339977 2018-05-09 10:13:17 -0700 2018-05-09 10:29:45 -0700 Patch bug-185476-20180509141315.patch text/plain 2030 leo U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNTU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 OWFiMTliZTg2YmJjMDdmNTI1Mzg0NzQxZDNjOTczNzE4M2RkYzQ4Li5kZGEyZWQxZGVjNjQ4NDZk NmI3ZGEzNDkzNzFkNjZkMDc0ZjlmODMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOC0wNS0wOSAgTGVvIEJhbHRlciAgPGxlb25hcmRvLmJhbHRlckBnbWFp bC5jb20+CisKKyAgICAgICAgW0pTQ10gRml4IEFycmF5U3BlY2llc0NyZWF0ZSB0byByZXR1cm4g YSBuZXcgQXJyYXkgd2hlbiB0aGUgZ2l2ZW4gb2JqZWN0IGlzIG5vdCBhbiBhcnJheQorICAgICAg ICBFcnJvciBmb3VuZCBpbiB0aGUgZm9sbG93aW5nIFRlc3QyNjIgdGVzdHM6CisKKyAgICAgICAg LSB0ZXN0L2J1aWx0LWlucy9BcnJheS9wcm90b3R5cGUvc2xpY2UvY3JlYXRlLW5vbi1hcnJheS1p bnZhbGlkLWxlbi5qcworICAgICAgICAtIHRlc3QvYnVpbHQtaW5zL0FycmF5L3Byb3RvdHlwZS9z bGljZS9jcmVhdGUtcHJveGllZC1hcnJheS1pbnZhbGlkLWxlbi5qcworICAgICAgICAtIHRlc3Qv YnVpbHQtaW5zL0FycmF5L3Byb3RvdHlwZS9zcGxpY2UvY3JlYXRlLXNwZWNpZXMtdW5kZWYtaW52 YWxpZC1sZW4uanMKKworICAgICAgICBUaGUgQXJyYXlTcGVjaWVzQ3JlYXRlIHNob3VsZCB0aHJv dyBhIFJhbmdlRXJyb3Igd2l0aCBub24tQXJyYXkgY3VzdG9tIG9iamVjdHMKKyAgICAgICAgcHJl c2VudGluZyBhIGxlbmd0aCA+IDIqKjMyLTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4NTQ3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHA6CisKIDIwMTgt MDUtMDkgIFNyZGphbiBMYXphcmV2aWMgIDxzcmRqYW4ubGF6YXJldmljQHJ0LXJrLmNvbT4KIAog ICAgICAgICBbTUlQU10gT3B0aW1pemUgZ2VuZXJhdGVkIEpJVCBjb2RlIHVzaW5nIHIyCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAKaW5kZXgg M2UyODQzZmVhZTFlZDM0NDM4M2Y2OWE0OTU1NDBjZmJiNWE5Nzc1Ni4uNTFiMGQ1YjNlNDZmNWM3 MzkzMTMwOTI0N2VmOThhZDQ0YWIwY2U2YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvQXJyYXlQcm90b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcApAQCAtMjQ3LDggKzI0NywxMCBAQCBzdGF0aWMg QUxXQVlTX0lOTElORSBzdGQ6OnBhaXI8U3BlY2llc0NvbnN0cnVjdFJlc3VsdCwgSlNPYmplY3Qq PiBzcGVjaWVzQ29uc3RydQogICAgICAgICAgICAgaWYgKGNvbnN0cnVjdG9yLmlzTnVsbCgpKQog ICAgICAgICAgICAgICAgIHJldHVybiBzdGQ6Om1ha2VfcGFpcihTcGVjaWVzQ29uc3RydWN0UmVz dWx0OjpGYXN0UGF0aCwgbnVsbHB0cik7OwogICAgICAgICB9Ci0gICAgfSBlbHNlCi0gICAgICAg IFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGV4Y2VwdGlvblJlc3VsdCgpKTsKKyAgICB9IGVs c2UgeworICAgICAgICAvLyBJZiBpc0FycmF5IGlzIGZhbHNlLCByZXR1cm4gPyBBcnJheUNyZWF0 ZShsZW5ndGgpLgorICAgICAgICByZXR1cm4gc3RkOjptYWtlX3BhaXIoU3BlY2llc0NvbnN0cnVj dFJlc3VsdDo6RmFzdFBhdGgsIG51bGxwdHIpOworICAgIH0KIAogICAgIGlmIChjb25zdHJ1Y3Rv ci5pc1VuZGVmaW5lZCgpKQogICAgICAgICByZXR1cm4gc3RkOjptYWtlX3BhaXIoU3BlY2llc0Nv bnN0cnVjdFJlc3VsdDo6RmFzdFBhdGgsIG51bGxwdHIpOwo=