185472 2018-05-09 08:00:20 -0700 [iOS] Consider the annotation bounds when positioning action sheets near long-pressed PDF links 2018-05-09 12:08:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes bdakin commit-queue dbates mitz thorton timothy webkit-bug-importer wenson_hsieh oldest_to_newest 1422249 0 aestes 2018-05-09 08:00:20 -0700 [iOS] Consider the annotation bounds when positioning action sheets near long-pressed PDF links 1422254 1 339964 aestes 2018-05-09 08:11:24 -0700 Created attachment 339964 Patch 1422255 2 aestes 2018-05-09 08:14:28 -0700 rdar://problem/39967092 1422373 3 339964 dbates 2018-05-09 11:40:03 -0700 Comment on attachment 339964 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339964&action=review r=me > Source/WebKit/ChangeLog:14 > + We also no longer need to convert the press location into host view coordinate > + space, as PDFKit now does that for us. Cool. 1422391 4 339964 commit-queue 2018-05-09 12:08:36 -0700 Comment on attachment 339964 Patch Clearing flags on attachment: 339964 Committed r231583: <https://trac.webkit.org/changeset/231583> 1422392 5 commit-queue 2018-05-09 12:08:37 -0700 All reviewed patches have been landed. Closing bug. 339964 2018-05-09 08:11:24 -0700 2018-05-09 12:08:36 -0700 Patch bug-185472-20180509081124.patch text/plain 4072 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDViMTRlMTBiMzkxYmFhZWUw MmEzZTJiYWIyZjc2Y2E4ZDlhMmJiMTAuLjI3NmE4ZmIxNWEyYmRiMzEzNzFhYTgyNWY0ZGQ4ZmQ0 N2UyNzE4NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTgtMDUtMDkgIEFuZHkgRXN0 ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIENvbnNpZGVyIHRoZSBhbm5v dGF0aW9uIGJvdW5kcyB3aGVuIHBvc2l0aW9uaW5nIGFjdGlvbiBzaGVldHMgbmVhciBsb25nLXBy ZXNzZWQgUERGIGxpbmtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xODU0NzIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM5OTY3MDkyPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkb3B0ZWQgbmV3IFBE Rkhvc3RWaWV3Q29udHJvbGxlckRlbGVnYXRlIG1ldGhvZHMgdGhhdCBpbmNsdWRlIGFubm90YXRp b24gcmVjdHMKKyAgICAgICAgd2hlbiBVUkxzIGFuZCBwYWdlIGluZGljZXMgYXJlIGxvbmctcHJl c3NlZC4gVGhpcyBhbGxvd3MgdXMgdG8gYXZvaWQgb2JzY3VyaW5nCisgICAgICAgIGFubm90YXRp b25zIHdoZW4gcG9zaXRpb25pbmcgYWN0aW9uIHNoZWV0IHBvcG92ZXJzLgorCisgICAgICAgIFdl IGFsc28gbm8gbG9uZ2VyIG5lZWQgdG8gY29udmVydCB0aGUgcHJlc3MgbG9jYXRpb24gaW50byBo b3N0IHZpZXcgY29vcmRpbmF0ZQorICAgICAgICBzcGFjZSwgYXMgUERGS2l0IG5vdyBkb2VzIHRo YXQgZm9yIHVzLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcubW06CisgICAg ICAgICgtW1dLUERGVmlldyBfc2hvd0FjdGlvblNoZWV0Rm9yVVJMOmF0TG9jYXRpb246d2l0aEFu bm90YXRpb25SZWN0Ol0pOgorICAgICAgICAoLVtXS1BERlZpZXcgcGRmSG9zdFZpZXdDb250cm9s bGVyOmRpZExvbmdQcmVzc1VSTDphdExvY2F0aW9uOndpdGhBbm5vdGF0aW9uUmVjdDpdKToKKyAg ICAgICAgKC1bV0tQREZWaWV3IHBkZkhvc3RWaWV3Q29udHJvbGxlcjpkaWRMb25nUHJlc3NQYWdl SW5kZXg6YXRMb2NhdGlvbjp3aXRoQW5ub3RhdGlvblJlY3Q6XSk6CisgICAgICAgICgtW1dLUERG VmlldyBfc2hvd0FjdGlvblNoZWV0Rm9yVVJMOmF0TG9jYXRpb246XSk6IERlbGV0ZWQuCisgICAg ICAgICgtW1dLUERGVmlldyBwZGZIb3N0Vmlld0NvbnRyb2xsZXI6ZGlkTG9uZ1ByZXNzVVJMOmF0 TG9jYXRpb246XSk6IERlbGV0ZWQuCisgICAgICAgICgtW1dLUERGVmlldyBwZGZIb3N0Vmlld0Nv bnRyb2xsZXI6ZGlkTG9uZ1ByZXNzUGFnZUluZGV4OmF0TG9jYXRpb246XSk6IERlbGV0ZWQuCisK IDIwMTgtMDUtMDggIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIFN5 c3RlbSBQcmV2aWV3IGxpbmtzIHNob3VsZCB0cmlnZ2VyIGEgZG93bmxvYWQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9pb3MvV0tQREZWaWV3Lm1tCmluZGV4IDVjYmU4Y2VhZjY2NGYyODdjNjM2ZTll Y2IxNGJkNGIyODY1M2UyN2EuLmJmNzMxMjlmMzU2OGZjMTBiYjhlOGJkNGFhYWUxNjlhZDc5MDQ1 YTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcubW0K KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLUERGVmlldy5tbQpAQCAtNDA0LDMx ICs0MDQsMjkgQEAgLSAodm9pZClwZGZIb3N0Vmlld0NvbnRyb2xsZXI6KFBERkhvc3RWaWV3Q29u dHJvbGxlciAqKWNvbnRyb2xsZXIgZ29Ub1BhZ2VJbmRleDoKICAgICBbc2VsZiBfZ29Ub1VSTDpb c2VsZiBfVVJMV2l0aFBhZ2VJbmRleDpwYWdlSW5kZXhdIGF0TG9jYXRpb246ZG9jdW1lbnRWaWV3 UmVjdC5vcmlnaW5dOwogfQogCi0tICh2b2lkKV9zaG93QWN0aW9uU2hlZXRGb3JVUkw6KE5TVVJM ICopdXJsIGF0TG9jYXRpb246KENHUG9pbnQpbG9jYXRpb24KKy0gKHZvaWQpX3Nob3dBY3Rpb25T aGVldEZvclVSTDooTlNVUkwgKil1cmwgYXRMb2NhdGlvbjooQ0dQb2ludClsb2NhdGlvbiB3aXRo QW5ub3RhdGlvblJlY3Q6KENHUmVjdClhbm5vdGF0aW9uUmVjdAogewogICAgIFdLV2ViVmlldyAq d2ViVmlldyA9IF93ZWJWaWV3LmdldEF1dG9yZWxlYXNlZCgpOwogICAgIGlmICghd2ViVmlldykK ICAgICAgICAgcmV0dXJuOwogCi0gICAgQ0dQb2ludCBsb2NhdGlvbkluSG9zdFZpZXcgPSBbd2Vi Vmlldy5zY3JvbGxWaWV3IGNvbnZlcnRQb2ludDpsb2NhdGlvbiB0b1ZpZXc6W19ob3N0Vmlld0Nv bnRyb2xsZXIgdmlld11dOwotCiAgICAgV2ViS2l0OjpJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQ b3NpdGlvbiBwb3NpdGlvbkluZm9ybWF0aW9uOwotICAgIHBvc2l0aW9uSW5mb3JtYXRpb24uYm91 bmRzID0gV2ViQ29yZTo6cm91bmRlZEludFJlY3QoQ0dSZWN0IHsgbG9jYXRpb25Jbkhvc3RWaWV3 LCBDR1NpemVNYWtlKDAsIDApIH0pOwotICAgIHBvc2l0aW9uSW5mb3JtYXRpb24ucmVxdWVzdC5w b2ludCA9IFdlYkNvcmU6OnJvdW5kZWRJbnRQb2ludChsb2NhdGlvbkluSG9zdFZpZXcpOworICAg IHBvc2l0aW9uSW5mb3JtYXRpb24uYm91bmRzID0gV2ViQ29yZTo6cm91bmRlZEludFJlY3QoYW5u b3RhdGlvblJlY3QpOworICAgIHBvc2l0aW9uSW5mb3JtYXRpb24ucmVxdWVzdC5wb2ludCA9IFdl YkNvcmU6OnJvdW5kZWRJbnRQb2ludChsb2NhdGlvbik7CiAgICAgcG9zaXRpb25JbmZvcm1hdGlv bi51cmwgPSB1cmw7CiAKICAgICBfcG9zaXRpb25JbmZvcm1hdGlvbiA9IFdURk1vdmUocG9zaXRp b25JbmZvcm1hdGlvbik7CiAgICAgW19hY3Rpb25TaGVldEFzc2lzdGFudCBzaG93TGlua1NoZWV0 XTsKIH0KIAotLSAodm9pZClwZGZIb3N0Vmlld0NvbnRyb2xsZXI6KFBERkhvc3RWaWV3Q29udHJv bGxlciAqKWNvbnRyb2xsZXIgZGlkTG9uZ1ByZXNzVVJMOihOU1VSTCAqKXVybCBhdExvY2F0aW9u OihDR1BvaW50KWxvY2F0aW9uCistICh2b2lkKXBkZkhvc3RWaWV3Q29udHJvbGxlcjooUERGSG9z dFZpZXdDb250cm9sbGVyICopY29udHJvbGxlciBkaWRMb25nUHJlc3NVUkw6KE5TVVJMICopdXJs IGF0TG9jYXRpb246KENHUG9pbnQpbG9jYXRpb24gd2l0aEFubm90YXRpb25SZWN0OihDR1JlY3Qp YW5ub3RhdGlvblJlY3QKIHsKLSAgICBbc2VsZiBfc2hvd0FjdGlvblNoZWV0Rm9yVVJMOnVybCBh dExvY2F0aW9uOmxvY2F0aW9uXTsKKyAgICBbc2VsZiBfc2hvd0FjdGlvblNoZWV0Rm9yVVJMOnVy bCBhdExvY2F0aW9uOmxvY2F0aW9uIHdpdGhBbm5vdGF0aW9uUmVjdDphbm5vdGF0aW9uUmVjdF07 CiB9CiAKLS0gKHZvaWQpcGRmSG9zdFZpZXdDb250cm9sbGVyOihQREZIb3N0Vmlld0NvbnRyb2xs ZXIgKiljb250cm9sbGVyIGRpZExvbmdQcmVzc1BhZ2VJbmRleDooTlNJbnRlZ2VyKXBhZ2VJbmRl eCBhdExvY2F0aW9uOihDR1BvaW50KWxvY2F0aW9uCistICh2b2lkKXBkZkhvc3RWaWV3Q29udHJv bGxlcjooUERGSG9zdFZpZXdDb250cm9sbGVyICopY29udHJvbGxlciBkaWRMb25nUHJlc3NQYWdl SW5kZXg6KE5TSW50ZWdlcilwYWdlSW5kZXggYXRMb2NhdGlvbjooQ0dQb2ludClsb2NhdGlvbiB3 aXRoQW5ub3RhdGlvblJlY3Q6KENHUmVjdClhbm5vdGF0aW9uUmVjdAogewotICAgIFtzZWxmIF9z aG93QWN0aW9uU2hlZXRGb3JVUkw6W3NlbGYgX1VSTFdpdGhQYWdlSW5kZXg6cGFnZUluZGV4XSBh dExvY2F0aW9uOmxvY2F0aW9uXTsKKyAgICBbc2VsZiBfc2hvd0FjdGlvblNoZWV0Rm9yVVJMOltz ZWxmIF9VUkxXaXRoUGFnZUluZGV4OnBhZ2VJbmRleF0gYXRMb2NhdGlvbjpsb2NhdGlvbiB3aXRo QW5ub3RhdGlvblJlY3Q6YW5ub3RhdGlvblJlY3RdOwogfQogCiAjcHJhZ21hIG1hcmsgV0tBY3Rp b25TaGVldEFzc2lzdGFudERlbGVnYXRlCg==