185451 2018-05-08 15:24:25 -0700 Switch some RELEASE_ASSERTS to plain debug ASSERTS in PlatformScreenMac.mm 2018-05-08 16:27:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham webkit-bug-importer zalan oldest_to_newest 1421975 0 bfulgham 2018-05-08 15:24:25 -0700 Switch a number of RELEASE_ASSERTS in PlatformScreenMac.mm to less costly Debug ASSERTS now that we've addressed the various platform issues we were tracking down using the RELEASE_ASSERTS. 1421976 1 339888 bfulgham 2018-05-08 15:26:59 -0700 Created attachment 339888 Patch 1422016 2 bfulgham 2018-05-08 16:26:45 -0700 Committed r231520: <https://trac.webkit.org/changeset/231520> 1422017 3 bfulgham 2018-05-08 16:27:31 -0700 <rdar://problem/39620348> 339888 2018-05-08 15:26:59 -0700 2018-05-08 16:06:42 -0700 Patch bug-185451-20180508152659.patch text/plain 4682 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDBmNWEyMTgxYzAzYmIy MjllODk3NTIwODMwMGJjNTM3MDgwY2NiMC4uMGU3MTlmZjYxNzhhZjk2NjQ0YTE4NTI5Mjg2OWIy NDk3Yzc1ZThkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE4LTA1LTA4ICBCcmVu dCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFN3aXRjaCBzb21lIFJF TEVBU0VfQVNTRVJUUyB0byBwbGFpbiBkZWJ1ZyBBU1NFUlRTIGluIFBsYXRmb3JtU2NyZWVuTWFj Lm1tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODU0 NTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM5NjIwMzQ4PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENoYW5nZSBhIHNldCBvZiBSRUxFQVNFX0FT U0VSVFMgdXNlZCB0byBwcmV2ZW50IGFjY2Vzc2luZyBOU1NjcmVlbiByZWxhdGVkIGZ1bmN0aW9u cyBpbiB0aGUKKyAgICAgICAgUGxhdGZvcm1TY3JlZW5NYWMgaW1wbGVtZW50YXRpb24gdG8gbGVz cyBleHBlbnNpdmUgRGVidWcgQVNTRVJUUy4KKworICAgICAgICBObyBjaGFuZ2UgaW4gYmVoYXZp b3IuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvUGxhdGZvcm1TY3JlZW5NYWMubW06CisgICAg ICAgIChXZWJDb3JlOjpzY3JlZW5IYXNJbnZlcnRlZENvbG9ycyk6CisgICAgICAgIChXZWJDb3Jl OjpzY3JlZW5EZXB0aCk6CisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5EZXB0aFBlckNvbXBvbmVu dCk6CisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5SZWN0Rm9yRGlzcGxheSk6CisgICAgICAgIChX ZWJDb3JlOjpzY3JlZW5SZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OnNjcmVlbkF2YWlsYWJsZVJl Y3QpOgorICAgICAgICAoV2ViQ29yZTo6c2NyZWVuQ29sb3JTcGFjZSk6CisgICAgICAgIChXZWJD b3JlOjpzY3JlZW5TdXBwb3J0c0V4dGVuZGVkQ29sb3IpOgorCiAyMDE4LTA1LTA3ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBleHBlcmltZW50YWwg ZmVhdHVyZSB0byBwcm9tcHQgZm9yIFN0b3JhZ2UgQWNjZXNzIEFQSSB1c2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbSBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbQppbmRleCA4MTVhYTY1 ZWIwYjg1MzhhODY2ZTQ2MGE3OTNhMGMxNmI4ZTkxNGEwLi42Mjk4MTIyMzFkYzUwZDk5OThhNDFj MTYwZTU5ZDI5Zjk0NDJhOGZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t YWMvUGxhdGZvcm1TY3JlZW5NYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1BsYXRmb3JtU2NyZWVuTWFjLm1tCkBAIC0xODEsNyArMTgxLDcgQEAgYm9vbCBzY3JlZW5IYXNJ bnZlcnRlZENvbG9ycygpCiAgICAgICAgIHJldHVybiBzY3JlZW5Qcm9wZXJ0aWVzKHByaW1hcnlT Y3JlZW5EaXNwbGF5SUQoKSkuc2NyZWVuSGFzSW52ZXJ0ZWRDb2xvcnM7CiAKICAgICAvLyBUaGlz IGlzIGEgc3lzdGVtLXdpZGUgYWNjZXNzaWJpbGl0eSBzZXR0aW5nLCBzYW1lIG9uIGFsbCBzY3Jl ZW5zLgotICAgIFJFTEVBU0VfQVNTRVJUKGhhc1Byb2Nlc3NQcml2aWxlZ2UoUHJvY2Vzc1ByaXZp bGVnZTo6Q2FuQ29tbXVuaWNhdGVXaXRoV2luZG93U2VydmVyKSk7CisgICAgQVNTRVJUKGhhc1By b2Nlc3NQcml2aWxlZ2UoUHJvY2Vzc1ByaXZpbGVnZTo6Q2FuQ29tbXVuaWNhdGVXaXRoV2luZG93 U2VydmVyKSk7CiAgICAgcmV0dXJuIENHRGlzcGxheVVzZXNJbnZlcnRlZFBvbGFyaXR5KCk7CiB9 CiAKQEAgLTE5Myw3ICsxOTMsNyBAQCBpbnQgc2NyZWVuRGVwdGgoV2lkZ2V0KiB3aWRnZXQpCiAg ICAgICAgIHJldHVybiBzY3JlZW5EZXB0aDsKICAgICB9CiAKLSAgICBSRUxFQVNFX0FTU0VSVCho YXNQcm9jZXNzUHJpdmlsZWdlKFByb2Nlc3NQcml2aWxlZ2U6OkNhbkNvbW11bmljYXRlV2l0aFdp bmRvd1NlcnZlcikpOworICAgIEFTU0VSVChoYXNQcm9jZXNzUHJpdmlsZWdlKFByb2Nlc3NQcml2 aWxlZ2U6OkNhbkNvbW11bmljYXRlV2l0aFdpbmRvd1NlcnZlcikpOwogICAgIHJldHVybiBOU0Jp dHNQZXJQaXhlbEZyb21EZXB0aChzY3JlZW4od2lkZ2V0KS5kZXB0aCk7CiB9CiAKQEAgLTIwNSw3 ICsyMDUsNyBAQCBpbnQgc2NyZWVuRGVwdGhQZXJDb21wb25lbnQoV2lkZ2V0KiB3aWRnZXQpCiAg ICAgICAgIHJldHVybiBkZXB0aFBlckNvbXBvbmVudDsKICAgICB9CiAKLSAgICBSRUxFQVNFX0FT U0VSVChoYXNQcm9jZXNzUHJpdmlsZWdlKFByb2Nlc3NQcml2aWxlZ2U6OkNhbkNvbW11bmljYXRl V2l0aFdpbmRvd1NlcnZlcikpOworICAgIEFTU0VSVChoYXNQcm9jZXNzUHJpdmlsZWdlKFByb2Nl c3NQcml2aWxlZ2U6OkNhbkNvbW11bmljYXRlV2l0aFdpbmRvd1NlcnZlcikpOwogICAgIHJldHVy biBOU0JpdHNQZXJTYW1wbGVGcm9tRGVwdGgoc2NyZWVuKHdpZGdldCkuZGVwdGgpOwogfQogCkBA IC0yMTcsNyArMjE3LDcgQEAgRmxvYXRSZWN0IHNjcmVlblJlY3RGb3JEaXNwbGF5KFBsYXRmb3Jt RGlzcGxheUlEIGRpc3BsYXlJRCkKICAgICAgICAgcmV0dXJuIHNjcmVlblJlY3Q7CiAgICAgfQog Ci0gICAgUkVMRUFTRV9BU1NFUlQoaGFzUHJvY2Vzc1ByaXZpbGVnZShQcm9jZXNzUHJpdmlsZWdl OjpDYW5Db21tdW5pY2F0ZVdpdGhXaW5kb3dTZXJ2ZXIpKTsKKyAgICBBU1NFUlQoaGFzUHJvY2Vz c1ByaXZpbGVnZShQcm9jZXNzUHJpdmlsZWdlOjpDYW5Db21tdW5pY2F0ZVdpdGhXaW5kb3dTZXJ2 ZXIpKTsKICAgICByZXR1cm4gc2NyZWVuKGRpc3BsYXlJRCkuZnJhbWU7CiB9CiAKQEAgLTIyNiw3 ICsyMjYsNyBAQCBGbG9hdFJlY3Qgc2NyZWVuUmVjdChXaWRnZXQqIHdpZGdldCkKICAgICBpZiAo IXNjcmVlblByb3BlcnRpZXMoKS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBnZXRTY3JlZW5Q cm9wZXJ0aWVzKHdpZGdldCkuc2NyZWVuUmVjdDsKIAotICAgIFJFTEVBU0VfQVNTRVJUKGhhc1By b2Nlc3NQcml2aWxlZ2UoUHJvY2Vzc1ByaXZpbGVnZTo6Q2FuQ29tbXVuaWNhdGVXaXRoV2luZG93 U2VydmVyKSk7CisgICAgQVNTRVJUKGhhc1Byb2Nlc3NQcml2aWxlZ2UoUHJvY2Vzc1ByaXZpbGVn ZTo6Q2FuQ29tbXVuaWNhdGVXaXRoV2luZG93U2VydmVyKSk7CiAgICAgcmV0dXJuIHRvVXNlclNw YWNlKFtzY3JlZW4od2lkZ2V0KSBmcmFtZV0sIHdpbmRvdyh3aWRnZXQpKTsKIH0KIApAQCAtMjM1 LDcgKzIzNSw3IEBAIEZsb2F0UmVjdCBzY3JlZW5BdmFpbGFibGVSZWN0KFdpZGdldCogd2lkZ2V0 KQogICAgIGlmICghc2NyZWVuUHJvcGVydGllcygpLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJu IGdldFNjcmVlblByb3BlcnRpZXMod2lkZ2V0KS5zY3JlZW5BdmFpbGFibGVSZWN0OwogCi0gICAg UkVMRUFTRV9BU1NFUlQoaGFzUHJvY2Vzc1ByaXZpbGVnZShQcm9jZXNzUHJpdmlsZWdlOjpDYW5D b21tdW5pY2F0ZVdpdGhXaW5kb3dTZXJ2ZXIpKTsKKyAgICBBU1NFUlQoaGFzUHJvY2Vzc1ByaXZp bGVnZShQcm9jZXNzUHJpdmlsZWdlOjpDYW5Db21tdW5pY2F0ZVdpdGhXaW5kb3dTZXJ2ZXIpKTsK ICAgICByZXR1cm4gdG9Vc2VyU3BhY2UoW3NjcmVlbih3aWRnZXQpIHZpc2libGVGcmFtZV0sIHdp bmRvdyh3aWRnZXQpKTsKIH0KIApAQCAtMjYwLDcgKzI2MCw3IEBAIENHQ29sb3JTcGFjZVJlZiBz Y3JlZW5Db2xvclNwYWNlKFdpZGdldCogd2lkZ2V0KQogICAgIGlmICghc2NyZWVuUHJvcGVydGll cygpLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIGdldFNjcmVlblByb3BlcnRpZXMod2lkZ2V0 KS5jb2xvclNwYWNlLmdldCgpOwogCi0gICAgUkVMRUFTRV9BU1NFUlQoaGFzUHJvY2Vzc1ByaXZp bGVnZShQcm9jZXNzUHJpdmlsZWdlOjpDYW5Db21tdW5pY2F0ZVdpdGhXaW5kb3dTZXJ2ZXIpKTsK KyAgICBBU1NFUlQoaGFzUHJvY2Vzc1ByaXZpbGVnZShQcm9jZXNzUHJpdmlsZWdlOjpDYW5Db21t dW5pY2F0ZVdpdGhXaW5kb3dTZXJ2ZXIpKTsKICAgICByZXR1cm4gc2NyZWVuKHdpZGdldCkuY29s b3JTcGFjZS5DR0NvbG9yU3BhY2U7CiB9CiAKQEAgLTI2OSw3ICsyNjksNyBAQCBib29sIHNjcmVl blN1cHBvcnRzRXh0ZW5kZWRDb2xvcihXaWRnZXQqIHdpZGdldCkKICAgICBpZiAoIXNjcmVlblBy b3BlcnRpZXMoKS5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBnZXRTY3JlZW5Qcm9wZXJ0aWVz KHdpZGdldCkuc2NyZWVuU3VwcG9ydHNFeHRlbmRlZENvbG9yOwogCi0gICAgUkVMRUFTRV9BU1NF UlQoaGFzUHJvY2Vzc1ByaXZpbGVnZShQcm9jZXNzUHJpdmlsZWdlOjpDYW5Db21tdW5pY2F0ZVdp dGhXaW5kb3dTZXJ2ZXIpKTsKKyAgICBBU1NFUlQoaGFzUHJvY2Vzc1ByaXZpbGVnZShQcm9jZXNz UHJpdmlsZWdlOjpDYW5Db21tdW5pY2F0ZVdpdGhXaW5kb3dTZXJ2ZXIpKTsKICAgICByZXR1cm4g W3NjcmVlbih3aWRnZXQpIGNhblJlcHJlc2VudERpc3BsYXlHYW11dDpOU0Rpc3BsYXlHYW11dFAz XTsKIH0KIAo=