185440 2018-05-08 12:01:03 -0700 Add tests to ensure that the Strong Password appearance is removed on form reset 2018-05-08 16:23:19 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 185433 1 dbates dbates aestes lforschler rniwa simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1421871 0 dbates 2018-05-08 12:01:03 -0700 Add a unit test to ensure that the embedding client is notified when the Strong Password appearance is removed on form reset. 1421873 1 dbates 2018-05-08 12:02:49 -0700 (In reply to Daniel Bates from comment #0) > Add a unit test to ensure that the embedding client is notified when the > Strong Password appearance is removed on form reset. Actually we should add both a unit test and a layout test. 1421874 2 339854 dbates 2018-05-08 12:04:12 -0700 Created attachment 339854 Tests This patch depends on the refactoring done in the patch for bug #185433. 1421948 3 339854 rniwa 2018-05-08 14:39:58 -0700 Comment on attachment 339854 Tests View in context: https://bugs.webkit.org/attachment.cgi?id=339854&action=review > LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:14 > + let form = document.querySelector("form"); > + form.reset(); It seems like we don't need this local variable. Just do: document.querySelector("form").reset(). Or simply document.forms[0].reset()? 1422004 4 dbates 2018-05-08 16:18:09 -0700 (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 339854 [details] > Tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339854&action=review > > > LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:14 > > + let form = document.querySelector("form"); > > + form.reset(); > > It seems like we don't need this local variable. > Just do: document.querySelector("form").reset(). Or simply > document.forms[0].reset()? Will fix before landing. 1422005 5 dbates 2018-05-08 16:19:43 -0700 (In reply to Daniel Bates from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > Comment on attachment 339854 [details] > > Tests > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=339854&action=review > > > > > LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-when-form-is-reset.html:14 > > > + let form = document.querySelector("form"); > > > + form.reset(); > > > > It seems like we don't need this local variable. > > Just do: document.querySelector("form").reset(). Or simply > > document.forms[0].reset()? > > Will fix before landing. Will use document.forms[0].reset(). 1422008 6 dbates 2018-05-08 16:22:19 -0700 Committed r231519: <https://trac.webkit.org/changeset/231519> 1422013 7 webkit-bug-importer 2018-05-08 16:23:19 -0700 <rdar://problem/40075899> 339854 2018-05-08 12:04:12 -0700 2018-05-08 14:39:58 -0700 Tests bug-185440-20180508120300.patch text/plain 6154 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNDg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTFkYzAzYTE0Mzg3MmZhMWMzMWUzYjUyOGNlNTg2ZmFh MWZlNGFiYy4uMjUwMzI5NTQ2NGUxYmY2MjkwNTZlZTQ0ZGIzZWFhYjU0NWM2OTg5NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE4LTA1LTA4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBBZGQgdGVzdHMgdG8gZW5zdXJlIHRoYXQgdGhlIFN0cm9uZyBQYXNzd29yZCBhcHBlYXJh bmNlIGlzIHJlbW92ZWQgb24gZm9ybSByZXNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1NDQwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0Rp ZFJlc2lnbklucHV0RWxlbWVudFN0cm9uZ1Bhc3N3b3JkQXBwZWFyYW5jZS5tbToKKyAgICAgICAg KC1bRGlkUmVzaWduSW5wdXRFbGVtZW50U3Ryb25nUGFzc3dvcmRBcHBlYXJhbmNlIHdlYlByb2Nl c3NQbHVnSW46ZGlkQ3JlYXRlQnJvd3NlckNvbnRleHRDb250cm9sbGVyOl0pOgorICAgICAgICAq IFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvVUlEZWxlZ2F0ZS5tbToKKyAgICAgICAg KFRFU1QpOgorCiAyMDE4LTA1LTA4ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXNpZ24gU3Ryb25nIFBhc3N3b3JkIGFwcGVhcmFuY2Ugd2hlbiB0ZXh0IGZp ZWxkIHZhbHVlIGNoYW5nZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V2ViS2l0Q29jb2EvRGlkUmVzaWduSW5wdXRFbGVtZW50U3Ryb25nUGFzc3dvcmRBcHBlYXJhbmNl Lm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9EaWRSZXNpZ25JbnB1 dEVsZW1lbnRTdHJvbmdQYXNzd29yZEFwcGVhcmFuY2UubW0KaW5kZXggNjdhMDI1YzI2NjFlZjQy NGZhZmY2MGEzNGJiNzk1Mjg5NDJkODdkMC4uYThmNjhlOWIxN2MxNzM4OWI0NGUwMGE3YmNlNWI4 ZGY0MzFmN2QyZSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9EaWRSZXNpZ25JbnB1dEVsZW1lbnRTdHJvbmdQYXNzd29yZEFwcGVhcmFuY2UubW0KKysr IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9EaWRSZXNpZ25JbnB1dEVs ZW1lbnRTdHJvbmdQYXNzd29yZEFwcGVhcmFuY2UubW0KQEAgLTYwLDkgKzYwLDExIEBAIC0gKHZv aWQpd2ViUHJvY2Vzc1BsdWdJbjooV0tXZWJQcm9jZXNzUGx1Z0luQ29udHJvbGxlciAqKXBsdWdJ bkNvbnRyb2xsZXIgZGlkQ3JlCiAgICAgV0tCdW5kbGVQYWdlU2V0VUlDbGllbnQoW2Jyb3dzZXJD b250ZXh0Q29udHJvbGxlciBfYnVuZGxlUGFnZVJlZl0sICZjbGllbnQuYmFzZSk7CiAKICAgICBX S0RPTURvY3VtZW50ICpkb2N1bWVudCA9IFticm93c2VyQ29udGV4dENvbnRyb2xsZXIgbWFpbkZy YW1lRG9jdW1lbnRdOworICAgIFdLRE9NRWxlbWVudCAqZm9ybUVsZW1lbnQgPSBbZG9jdW1lbnQg Y3JlYXRlRWxlbWVudDpAImZvcm0iXTsKICAgICBXS0RPTUVsZW1lbnQgKmlucHV0RWxlbWVudCA9 IFtkb2N1bWVudCBjcmVhdGVFbGVtZW50OkAiaW5wdXQiXTsKICAgICBbaW5wdXRFbGVtZW50IHNl dEF0dHJpYnV0ZTpAInR5cGUiIHZhbHVlOkAicGFzc3dvcmQiXTsKLSAgICBbW2RvY3VtZW50IGJv ZHldIGFwcGVuZENoaWxkOmlucHV0RWxlbWVudF07CisgICAgW2Zvcm1FbGVtZW50IGFwcGVuZENo aWxkOmlucHV0RWxlbWVudF07CisgICAgW1tkb2N1bWVudCBib2R5XSBhcHBlbmRDaGlsZDpmb3Jt RWxlbWVudF07CiAKICAgICBhdXRvICpqc0NvbnRleHQgPSBbW2Jyb3dzZXJDb250ZXh0Q29udHJv bGxlciBtYWluRnJhbWVdIGpzQ29udGV4dEZvcldvcmxkOltXS1dlYlByb2Nlc3NQbHVnSW5TY3Jp cHRXb3JsZCBub3JtYWxXb3JsZF1dOwogICAgIGF1dG8gKmpzVmFsdWUgPSBbanNDb250ZXh0IGV2 YWx1YXRlU2NyaXB0OkAiZG9jdW1lbnQucXVlcnlTZWxlY3RvcignaW5wdXQnKSJdOwpkaWZmIC0t Z2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9VSURlbGVnYXRlLm1t IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9VSURlbGVnYXRlLm1tCmlu ZGV4IGY4YzM5MTUxZjMyZDhlZGMyNGE3MTAzYjUzMzNkMTkxNjcyNTA3YWYuLmJmODJkNWZhM2Jj ZTMzZGM1NGY1MjIyYzE1MDU5MjBiMmQzNDkwNTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvVUlEZWxlZ2F0ZS5tbQorKysgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1VJRGVsZWdhdGUubW0KQEAgLTU5OCw2ICs1OTgsMTEg QEAgVEVTVChXZWJLaXQsIERpZFJlc2lnbklucHV0RWxlbWVudFN0cm9uZ1Bhc3N3b3JkQXBwZWFy YW5jZVdoZW5WYWx1ZURpZENoYW5nZSkKICAgICB0ZXN0RGlkUmVzaWduSW5wdXRFbGVtZW50U3Ry b25nUGFzc3dvcmRBcHBlYXJhbmNlQWZ0ZXJFdmFsdWF0aW5nSmF2YVNjcmlwdChAImRvY3VtZW50 LnF1ZXJ5U2VsZWN0b3IoJ2lucHV0JykudmFsdWUgPSAnJyIpOwogfQogCitURVNUKFdlYktpdCwg RGlkUmVzaWduSW5wdXRFbGVtZW50U3Ryb25nUGFzc3dvcmRBcHBlYXJhbmNlV2hlbkZvcm1Jc1Jl c2V0KQoreworICAgIHRlc3REaWRSZXNpZ25JbnB1dEVsZW1lbnRTdHJvbmdQYXNzd29yZEFwcGVh cmFuY2VBZnRlckV2YWx1YXRpbmdKYXZhU2NyaXB0KEAiZG9jdW1lbnQucXVlcnlTZWxlY3Rvcign Zm9ybScpLnJlc2V0KCkiKTsKK30KKwogQGludGVyZmFjZSBBdXRvRmlsbEF2YWlsYWJsZURlbGVn YXRlIDogTlNPYmplY3QgPFdLVUlEZWxlZ2F0ZVByaXZhdGU+CiBAZW5kCiAKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4YmMz NDVhYzhlNWEzNzg0MzUyOTViNjUwZWMyZTFmMmI2ZDNkYWMyLi5mNTBmODk4ZGM4NDFlMmNlODM5 MmY5MTEzYzM0ODUxNGQ5OTk5ZmMzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDUtMDgg IERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCB0ZXN0cyB0 byBlbnN1cmUgdGhhdCB0aGUgU3Ryb25nIFBhc3N3b3JkIGFwcGVhcmFuY2UgaXMgcmVtb3ZlZCBv biBmb3JtIHJlc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xODU0NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGZhc3QvZm9ybXMvYXV0by1maWxsLWJ1dHRvbi9oaWRlLWF1dG8tZmlsbC1zdHJvbmct cGFzc3dvcmQtYnV0dG9uLXdoZW4tZm9ybS1pcy1yZXNldC1leHBlY3RlZC5odG1sOiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L2Zvcm1zL2F1dG8tZmlsbC1idXR0b24vaGlkZS1hdXRvLWZpbGwtc3Ry b25nLXBhc3N3b3JkLWJ1dHRvbi13aGVuLWZvcm0taXMtcmVzZXQuaHRtbDogQWRkZWQuCisKIDIw MTgtMDUtMDggIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFJl c2lnbiBTdHJvbmcgUGFzc3dvcmQgYXBwZWFyYW5jZSB3aGVuIHRleHQgZmllbGQgdmFsdWUgY2hh bmdlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRvLWZpbGwtYnV0dG9u L2hpZGUtYXV0by1maWxsLXN0cm9uZy1wYXNzd29yZC1idXR0b24td2hlbi1mb3JtLWlzLXJlc2V0 LWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG8tZmlsbC1idXR0b24v aGlkZS1hdXRvLWZpbGwtc3Ryb25nLXBhc3N3b3JkLWJ1dHRvbi13aGVuLWZvcm0taXMtcmVzZXQt ZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wNzhiY2RjYTk3NjExOGFkZTNlYWE4YjkwMWEwOGM0 ZTUwZThkZWJkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9hdXRv LWZpbGwtYnV0dG9uL2hpZGUtYXV0by1maWxsLXN0cm9uZy1wYXNzd29yZC1idXR0b24td2hlbi1m b3JtLWlzLXJlc2V0LWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSwxMCBAQAorPCFET0NUWVBFIGh0 bWw+Cis8aHRtbD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0cyB0aGF0IHRoYXQgYW4gYXV0b2ZpbGxl ZCBTdHJvbmcgUGFzc3dvcmQgb3IgU3Ryb25nIENvbmZpcm1hdGlvbiBQYXNzd29yZCBkZWNvcmF0 ZWQgdGV4dCBmaWVsZCByZXZlcnRzIHRvIGl0cyBvcmlnaW5hbCBhcHBlYXJhbmNlIHdoZW4gdGhl IGZvcm0gaXMgcmVzZXQuIEl0IGNhbiBvbmx5IGJlIHRlc3RlZCBpbiB0aGUgdGVzdCB0b29sLjwv cD4KKzxmb3JtPgorPGlucHV0IHR5cGU9InBhc3N3b3JkIiB2YWx1ZT0iQ3VwZXJ0aW5vIj4KKzxp bnB1dCB0eXBlPSJwYXNzd29yZCIgdmFsdWU9IkN1cGVydGlubyI+Cis8L2Zvcm0+Cis8L2JvZHk+ Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG8tZmlsbC1i dXR0b24vaGlkZS1hdXRvLWZpbGwtc3Ryb25nLXBhc3N3b3JkLWJ1dHRvbi13aGVuLWZvcm0taXMt cmVzZXQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvYXV0by1maWxsLWJ1dHRvbi9oaWRl LWF1dG8tZmlsbC1zdHJvbmctcGFzc3dvcmQtYnV0dG9uLXdoZW4tZm9ybS1pcy1yZXNldC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjAxMjhlMGRkMTgzOGMzZjQxNGI0NjNhMzkyMjAzZTNmMjVkNmI3M2YKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2F1dG8tZmlsbC1idXR0b24v aGlkZS1hdXRvLWZpbGwtc3Ryb25nLXBhc3N3b3JkLWJ1dHRvbi13aGVuLWZvcm0taXMtcmVzZXQu aHRtbApAQCAtMCwwICsxLDI5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8 c2NyaXB0IHNyYz0icmVzb3VyY2VzL3Byb2Nlc3MtYXV0by1maWxsLWJ1dHRvbi10eXBlLWFuZC1p bnZva2UtcnVuVGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0Pgord2luZG93Lm1hcmtGaWVsZHNB c0F1dG9GaWxsZWQgPSB0cnVlOworICAgIAoraWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRl c3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworCitmdW5jdGlvbiBydW5UZXN0KCkKK3sKKyAgICBs ZXQgZm9ybSA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoImZvcm0iKTsKKyAgICBmb3JtLnJlc2V0 KCk7CisgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpCisgICAgICAgIGludGVybmFscy51cGRhdGVM YXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHNBbmRSdW5Qb3N0TGF5b3V0VGFza3MoKTsKKyAg ICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgp OworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPlRoaXMgdGVzdHMgdGhhdCB0aGF0 IGFuIGF1dG9maWxsZWQgU3Ryb25nIFBhc3N3b3JkIG9yIFN0cm9uZyBDb25maXJtYXRpb24gUGFz c3dvcmQgZGVjb3JhdGVkIHRleHQgZmllbGQgcmV2ZXJ0cyB0byBpdHMgb3JpZ2luYWwgYXBwZWFy YW5jZSB3aGVuIHRoZSBmb3JtIGlzIHJlc2V0LiBJdCBjYW4gb25seSBiZSB0ZXN0ZWQgaW4gdGhl IHRlc3QgdG9vbC48L3A+Cis8Zm9ybT4KKzxpbnB1dCB0eXBlPSJwYXNzd29yZCIgdmFsdWU9IkN1 cGVydGlubyIgZGF0YS1hdXRvLWZpbGwtYnV0dG9uLXR5cGU9IlN0cm9uZ1Bhc3N3b3JkIiBkYXRh LWF1dG9maWxsZWQ9InRydWUiPgorPGlucHV0IHR5cGU9InBhc3N3b3JkIiB2YWx1ZT0iQ3VwZXJ0 aW5vIiBkYXRhLWF1dG8tZmlsbC1idXR0b24tdHlwZT0iU3Ryb25nQ29uZmlybWF0aW9uUGFzc3dv cmQiIGRhdGEtYXV0b2ZpbGxlZD0idHJ1ZSI+Cis8L2Zvcm0+Cis8L2JvZHk+Cis8L2h0bWw+Cg==