185425 2018-05-08 09:00:01 -0700 REGRESSION(r230743): Mousemove events are not coalesced properly, mousemove/drag is very laggy 2019-02-06 09:18:49 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bl.ocks.org/mbostock/4343214 InRadar P2 Normal --- 1 bburg bburg bburg cgarcia simon.fraser thorton webkit-bug-importer oldest_to_newest 1421730 0 bburg 2018-05-08 09:00:01 -0700 Oops. 1421732 1 bburg 2018-05-08 09:04:53 -0700 <rdar://problem/39323336> 1421739 2 339824 bburg 2018-05-08 09:16:39 -0700 Created attachment 339824 Patch 1421789 3 339824 simon.fraser 2018-05-08 10:43:58 -0700 Comment on attachment 339824 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339824&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:1929 > + bool lastQueuedEventWasAMouseMove = m_mouseEventQueue.size() > 1 && m_mouseEventQueue.last().type() == WebEvent::MouseMove; Why not size() > 0 ? I would call it lastQueuedEventWasMouseMove or do away with the variable entirely. 1421878 4 bburg 2018-05-08 12:22:29 -0700 (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 339824 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=339824&action=review > > > Source/WebKit/UIProcess/WebPageProxy.cpp:1929 > > + bool lastQueuedEventWasAMouseMove = m_mouseEventQueue.size() > 1 && m_mouseEventQueue.last().type() == WebEvent::MouseMove; > > Why not size() > 0 ? Events are dequeued when WebProcess is done handling them. If size 0, then nothing is being processed in WebProcess. If size 1, we sent the event and are waiting on the reply. If size 2, then the first event is being processed and the second event is queued and will be sent to WebProcess when the previous event is retired. So if there is only one event and it's a mousemove, we can't update it because it's already been sent. > I would call it lastQueuedEventWasMouseMove or do away with the variable > entirely. 1421906 5 339863 bburg 2018-05-08 13:26:55 -0700 Created attachment 339863 For EWS 1421926 6 339874 bburg 2018-05-08 14:06:54 -0700 Created attachment 339874 For EWS 1421933 7 bburg 2018-05-08 14:19:40 -0700 Committed r231511: <https://trac.webkit.org/changeset/231511> 1503256 8 lforschler 2019-02-06 09:18:49 -0800 Mass move bugs into the DOM component. 339824 2018-05-08 09:16:39 -0700 2018-05-08 13:26:53 -0700 Patch bug-185425-20180508091638.patch text/plain 2795 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGMxNWMyYzc4MjgyYWI1Mzgz Y2ZjOWMxZDBjYmFhMWQwYjY3YWYxMGIuLjEwYzg2N2VlMTQ5OGU3MjcwZDkyMjZhNGRjZGQ3MThl YTJiOTU2YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDUtMDggIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjMwNzQzKTogTW91 c2Vtb3ZlIGV2ZW50cyBhcmUgbm90IGNvYWxlc2NlZCBwcm9wZXJseSwgbW91c2Vtb3ZlL2RyYWcg aXMgdmVyeSBsYWdneQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg1NDI1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTMyMzMzNj4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIG1vdXNlbW92ZSBl dmVudHMgY29tZSBpbiBmYXN0ZXIgdGhhbiB0aGV5IGNhbiBiZSBwcm9jZXNzZWQsIHdlIHNob3Vs ZCBjb2FsZXNjZQorICAgICAgICBwZW5kaW5nIG1vdXNlbW92ZXMgdGhhdCBoYXZlIG5vdCB5ZXQg YmVlbiBzZW50IHRvIFdlYlByb2Nlc3MuIFRoaXMgaGFzIHRoZSBlZmZlY3Qgb2YKKyAgICAgICAg cHJvY2Vzc2luZyB0aGUgbW9zdCByZWNlbnQgbW91c2Vtb3ZlIGxvY2F0aW9uLCB3aGljaCBpcyB0 aGUgb2xkIGJlaGF2aW9yIHRoYXQgcmVncmVzc2VkLgorCisgICAgICAgICogVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6aGFuZGxlTW91 c2VFdmVudCk6CisgICAgICAgIElmIHRoZXJlIGlzID4xIGV2ZW50IGluIHRoZSBtb3VzZSBxdWV1 ZSwgdGhlbiB0aGUgZmlyc3Qgb25lIGlzIGJlaW5nIHByb2Nlc3NlZCBieSBXZWJQcm9jZXNzCisg ICAgICAgIGFuZCB0aGUgc2Vjb25kIG9uZSBpcyBlbGlnaWJsZSBmb3IgY29hbGVzY2luZy4gUmVw bGFjZSBpdCBpZiB0aGUgbGFzdCBldmVudCBhbmQgbmV3IGV2ZW50CisgICAgICAgIGFyZSBib3Ro IG1vdXNlbW92ZXMuCisKIDIwMTgtMDUtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEFkZCBtaXNzaW5nIGV4aXQgbm90 IGluY2x1ZGVkIGluIHIyMzEyOTguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmNwcAppbmRleCA0YmNhNTc1ZDNjMDdiYWEyYWFjMWVmNTI1OWMwYjcyOWU1ZDQ0NjE0Li5jN2Iz MWYyYmZjNTBjYWMxMmRmYTk0ZThlNDBjZTZhNjJjYzg1ZDNlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTE5MjQsOCArMTkyNCwxNiBAQCB2b2lkIFdlYlBh Z2VQcm94eTo6aGFuZGxlTW91c2VFdmVudChjb25zdCBOYXRpdmVXZWJNb3VzZUV2ZW50JiBldmVu dCkKICAgICBpZiAoIWlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgTE9HKE1vdXNl SGFuZGxpbmcsICJVSVByb2Nlc3M6IGVucXVldWVkIG1vdXNlIGV2ZW50ICVzIChxdWV1ZSBzaXpl ICV6dSkiLCB3ZWJNb3VzZUV2ZW50VHlwZVN0cmluZyhldmVudC50eXBlKCkpLCBtX21vdXNlRXZl bnRRdWV1ZS5zaXplKCkpOwotICAgIG1fbW91c2VFdmVudFF1ZXVlLmFwcGVuZChldmVudCk7Cisg ICAgLy8gSWYgd2UgcmVjZWl2ZSBtdWx0aXBsZSBtb3VzZW1vdmUgZXZlbnRzIGFuZCB0aGUgbW9z dCByZWNlbnQgbW91c2Vtb3ZlIGV2ZW50IGhhcyBub3QgYmVlbgorICAgIC8vIHNlbnQgdG8gV2Vi UHJvY2VzcyBmb3IgcHJvY2Vzc2luZywgcmVwbGFjZSB0aGUgcGVuZGluZyBtb3VzZW1vdmUgZXZl bnQgd2l0aCBhIG5ldyBvbmUuCisgICAgYm9vbCBsYXN0UXVldWVkRXZlbnRXYXNBTW91c2VNb3Zl ID0gbV9tb3VzZUV2ZW50UXVldWUuc2l6ZSgpID4gMSAmJiBtX21vdXNlRXZlbnRRdWV1ZS5sYXN0 KCkudHlwZSgpID09IFdlYkV2ZW50OjpNb3VzZU1vdmU7CisgICAgaWYgKGV2ZW50LnR5cGUoKSA9 PSBXZWJFdmVudDo6TW91c2VNb3ZlICYmIGxhc3RRdWV1ZWRFdmVudFdhc0FNb3VzZU1vdmUpIHsK KyAgICAgICAgTE9HKE1vdXNlSGFuZGxpbmcsICJVSVByb2Nlc3M6IHVwZGF0ZWQgcGVuZGluZyBt b3VzZW1vdmUgZXZlbnQgKHF1ZXVlIHNpemUgJXp1KSIsIG1fbW91c2VFdmVudFF1ZXVlLnNpemUo KSk7CisgICAgICAgIG1fbW91c2VFdmVudFF1ZXVlLmxhc3QoKSA9IGV2ZW50OworICAgIH0gZWxz ZSB7CisgICAgICAgIExPRyhNb3VzZUhhbmRsaW5nLCAiVUlQcm9jZXNzOiBlbnF1ZXVlZCBtb3Vz ZSBldmVudCAlcyAocXVldWUgc2l6ZSAlenUpIiwgd2ViTW91c2VFdmVudFR5cGVTdHJpbmcoZXZl bnQudHlwZSgpKSwgbV9tb3VzZUV2ZW50UXVldWUuc2l6ZSgpKTsKKyAgICAgICAgbV9tb3VzZUV2 ZW50UXVldWUuYXBwZW5kKGV2ZW50KTsKKyAgICB9CiAgICAgaWYgKG1fbW91c2VFdmVudFF1ZXVl LnNpemUoKSA9PSAxKSAvLyBPdGhlcndpc2UsIGNhbGxlZCBmcm9tIERpZFJlY2VpdmVFdmVudCBt ZXNzYWdlIGhhbmRsZXIuCiAgICAgICAgIHByb2Nlc3NOZXh0UXVldWVkTW91c2VFdmVudCgpOwog fQo= 339863 2018-05-08 13:26:55 -0700 2018-05-08 14:06:53 -0700 For EWS bug-185425-20180508132654.patch text/plain 2807 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDViMTRlMTBiMzkxYmFhZWUw MmEzZTJiYWIyZjc2Y2E4ZDlhMmJiMTAuLmVlMjU4ZDBkNWE2MWMwOWU3N2JlMmU0MzZmZWFmZmQy OTJhMjc2ZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDUtMDggIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjMwNzQzKTogTW91 c2Vtb3ZlIGV2ZW50cyBhcmUgbm90IGNvYWxlc2NlZCBwcm9wZXJseSwgbW91c2Vtb3ZlL2RyYWcg aXMgdmVyeSBsYWdneQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg1NDI1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTMyMzMzNj4KKworICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgV2hlbiBtb3VzZW1vdmUgZXZl bnRzIGNvbWUgaW4gZmFzdGVyIHRoYW4gdGhleSBjYW4gYmUgcHJvY2Vzc2VkLCB3ZSBzaG91bGQg Y29hbGVzY2UKKyAgICAgICAgcGVuZGluZyBtb3VzZW1vdmVzIHRoYXQgaGF2ZSBub3QgeWV0IGJl ZW4gc2VudCB0byBXZWJQcm9jZXNzLiBUaGlzIGhhcyB0aGUgZWZmZWN0IG9mCisgICAgICAgIHBy b2Nlc3NpbmcgdGhlIG1vc3QgcmVjZW50IG1vdXNlbW92ZSBsb2NhdGlvbiwgd2hpY2ggaXMgdGhl IG9sZCBiZWhhdmlvciB0aGF0IHJlZ3Jlc3NlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmhhbmRsZU1vdXNl RXZlbnQpOgorICAgICAgICBJZiB0aGVyZSBpcyA+MSBldmVudCBpbiB0aGUgbW91c2UgcXVldWUs IHRoZW4gdGhlIGZpcnN0IG9uZSBpcyBiZWluZyBwcm9jZXNzZWQgYnkgV2ViUHJvY2VzcworICAg ICAgICBhbmQgdGhlIHNlY29uZCBvbmUgaXMgZWxpZ2libGUgZm9yIGNvYWxlc2NpbmcuIFJlcGxh Y2UgaXQgaWYgdGhlIGxhc3QgZXZlbnQgYW5kIG5ldyBldmVudAorICAgICAgICBhcmUgYm90aCBt b3VzZW1vdmVzLgorCiAyMDE4LTA1LTA4ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4K IAogICAgICAgICBTeXN0ZW0gUHJldmlldyBsaW5rcyBzaG91bGQgdHJpZ2dlciBhIGRvd25sb2Fk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCAzMGQ1ODYwNWRk NGQ3YTVjZTU1MzJiMGVmYzY2NmMzMDJmMDllMTJlLi40N2Q0OTAyZTNmMTNjZDJlMjBlOGQ2OTdi YWVjMWYwMTNiOGUyNzZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHAKQEAgLTE5MjgsOCArMTkyOCwxNyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6aGFuZGxlTW91c2VF dmVudChjb25zdCBOYXRpdmVXZWJNb3VzZUV2ZW50JiBldmVudCkKICAgICBpZiAoIWlzVmFsaWQo KSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgTE9HKE1vdXNlSGFuZGxpbmcsICJVSVByb2Nlc3M6 IGVucXVldWVkIG1vdXNlIGV2ZW50ICVzIChxdWV1ZSBzaXplICV6dSkiLCB3ZWJNb3VzZUV2ZW50 VHlwZVN0cmluZyhldmVudC50eXBlKCkpLCBtX21vdXNlRXZlbnRRdWV1ZS5zaXplKCkpOwotICAg IG1fbW91c2VFdmVudFF1ZXVlLmFwcGVuZChldmVudCk7CisgICAgLy8gSWYgd2UgcmVjZWl2ZSBt dWx0aXBsZSBtb3VzZW1vdmUgZXZlbnRzIGFuZCB0aGUgbW9zdCByZWNlbnQgbW91c2Vtb3ZlIGV2 ZW50IGhhcyBub3QgYmVlbgorICAgIC8vIHNlbnQgdG8gV2ViUHJvY2VzcyBmb3IgcHJvY2Vzc2lu ZywgcmVwbGFjZSB0aGUgcGVuZGluZyBtb3VzZW1vdmUgZXZlbnQgd2l0aCBhIG5ldyBvbmUuCisg ICAgYm9vbCBsYXN0UXVldWVkRXZlbnRXYXNBTW91c2VNb3ZlID0gbV9tb3VzZUV2ZW50UXVldWUu c2l6ZSgpID4gMSAmJiBtX21vdXNlRXZlbnRRdWV1ZS5sYXN0KCkudHlwZSgpID09IFdlYkV2ZW50 OjpNb3VzZU1vdmU7CisgICAgaWYgKGV2ZW50LnR5cGUoKSA9PSBXZWJFdmVudDo6TW91c2VNb3Zl ICYmIGxhc3RRdWV1ZWRFdmVudFdhc0FNb3VzZU1vdmUpIHsKKyAgICAgICAgTE9HKE1vdXNlSGFu ZGxpbmcsICJVSVByb2Nlc3M6IHVwZGF0ZWQgcGVuZGluZyBtb3VzZW1vdmUgZXZlbnQgKHF1ZXVl IHNpemUgJXp1KSIsIG1fbW91c2VFdmVudFF1ZXVlLnNpemUoKSk7CisgICAgICAgIG1fbW91c2VF dmVudFF1ZXVlLnBvcCgpOworICAgICAgICBtX21vdXNlRXZlbnRRdWV1ZS5hcHBlbmQoZXZlbnQp OworICAgIH0gZWxzZSB7CisgICAgICAgIExPRyhNb3VzZUhhbmRsaW5nLCAiVUlQcm9jZXNzOiBl bnF1ZXVlZCBtb3VzZSBldmVudCAlcyAocXVldWUgc2l6ZSAlenUpIiwgd2ViTW91c2VFdmVudFR5 cGVTdHJpbmcoZXZlbnQudHlwZSgpKSwgbV9tb3VzZUV2ZW50UXVldWUuc2l6ZSgpKTsKKyAgICAg ICAgbV9tb3VzZUV2ZW50UXVldWUuYXBwZW5kKGV2ZW50KTsKKyAgICB9CiAgICAgaWYgKG1fbW91 c2VFdmVudFF1ZXVlLnNpemUoKSA9PSAxKSAvLyBPdGhlcndpc2UsIGNhbGxlZCBmcm9tIERpZFJl Y2VpdmVFdmVudCBtZXNzYWdlIGhhbmRsZXIuCiAgICAgICAgIHByb2Nlc3NOZXh0UXVldWVkTW91 c2VFdmVudCgpOwogfQo= 339874 2018-05-08 14:06:54 -0700 2018-05-08 15:07:50 -0700 For EWS bug-185425-20180508140653.patch text/plain 2743 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDViMTRlMTBiMzkxYmFhZWUw MmEzZTJiYWIyZjc2Y2E4ZDlhMmJiMTAuLmVlMjU4ZDBkNWE2MWMwOWU3N2JlMmU0MzZmZWFmZmQy OTJhMjc2ZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDUtMDggIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjMwNzQzKTogTW91 c2Vtb3ZlIGV2ZW50cyBhcmUgbm90IGNvYWxlc2NlZCBwcm9wZXJseSwgbW91c2Vtb3ZlL2RyYWcg aXMgdmVyeSBsYWdneQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg1NDI1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zOTMyMzMzNj4KKworICAgICAg ICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgV2hlbiBtb3VzZW1vdmUgZXZl bnRzIGNvbWUgaW4gZmFzdGVyIHRoYW4gdGhleSBjYW4gYmUgcHJvY2Vzc2VkLCB3ZSBzaG91bGQg Y29hbGVzY2UKKyAgICAgICAgcGVuZGluZyBtb3VzZW1vdmVzIHRoYXQgaGF2ZSBub3QgeWV0IGJl ZW4gc2VudCB0byBXZWJQcm9jZXNzLiBUaGlzIGhhcyB0aGUgZWZmZWN0IG9mCisgICAgICAgIHBy b2Nlc3NpbmcgdGhlIG1vc3QgcmVjZW50IG1vdXNlbW92ZSBsb2NhdGlvbiwgd2hpY2ggaXMgdGhl IG9sZCBiZWhhdmlvciB0aGF0IHJlZ3Jlc3NlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmhhbmRsZU1vdXNl RXZlbnQpOgorICAgICAgICBJZiB0aGVyZSBpcyA+MSBldmVudCBpbiB0aGUgbW91c2UgcXVldWUs IHRoZW4gdGhlIGZpcnN0IG9uZSBpcyBiZWluZyBwcm9jZXNzZWQgYnkgV2ViUHJvY2VzcworICAg ICAgICBhbmQgdGhlIHNlY29uZCBvbmUgaXMgZWxpZ2libGUgZm9yIGNvYWxlc2NpbmcuIFJlcGxh Y2UgaXQgaWYgdGhlIGxhc3QgZXZlbnQgYW5kIG5ldyBldmVudAorICAgICAgICBhcmUgYm90aCBt b3VzZW1vdmVzLgorCiAyMDE4LTA1LTA4ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4K IAogICAgICAgICBTeXN0ZW0gUHJldmlldyBsaW5rcyBzaG91bGQgdHJpZ2dlciBhIGRvd25sb2Fk CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCAzMGQ1ODYwNWRk NGQ3YTVjZTU1MzJiMGVmYzY2NmMzMDJmMDllMTJlLi5kN2RmNGNmODE2NjlkMjNlYzcwZjg5ZjFh NGU4N2Q0ZmE0MDkyYWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5j cHAKQEAgLTE5MjgsOCArMTkyOCwxNiBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6aGFuZGxlTW91c2VF dmVudChjb25zdCBOYXRpdmVXZWJNb3VzZUV2ZW50JiBldmVudCkKICAgICBpZiAoIWlzVmFsaWQo KSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgTE9HKE1vdXNlSGFuZGxpbmcsICJVSVByb2Nlc3M6 IGVucXVldWVkIG1vdXNlIGV2ZW50ICVzIChxdWV1ZSBzaXplICV6dSkiLCB3ZWJNb3VzZUV2ZW50 VHlwZVN0cmluZyhldmVudC50eXBlKCkpLCBtX21vdXNlRXZlbnRRdWV1ZS5zaXplKCkpOwotICAg IG1fbW91c2VFdmVudFF1ZXVlLmFwcGVuZChldmVudCk7CisgICAgLy8gSWYgd2UgcmVjZWl2ZSBt dWx0aXBsZSBtb3VzZW1vdmUgZXZlbnRzIGFuZCB0aGUgbW9zdCByZWNlbnQgbW91c2Vtb3ZlIGV2 ZW50IGhhcyBub3QgYmVlbgorICAgIC8vIHNlbnQgdG8gV2ViUHJvY2VzcyBmb3IgcHJvY2Vzc2lu ZywgcmVwbGFjZSB0aGUgcGVuZGluZyBtb3VzZW1vdmUgZXZlbnQgd2l0aCBhIG5ldyBvbmUuCisg ICAgaWYgKGV2ZW50LnR5cGUoKSA9PSBXZWJFdmVudDo6TW91c2VNb3ZlICYmIG1fbW91c2VFdmVu dFF1ZXVlLnNpemUoKSA+IDEgJiYgbV9tb3VzZUV2ZW50UXVldWUubGFzdCgpLnR5cGUoKSA9PSBX ZWJFdmVudDo6TW91c2VNb3ZlKSB7CisgICAgICAgIExPRyhNb3VzZUhhbmRsaW5nLCAiVUlQcm9j ZXNzOiB1cGRhdGVkIHBlbmRpbmcgbW91c2Vtb3ZlIGV2ZW50IChxdWV1ZSBzaXplICV6dSkiLCBt X21vdXNlRXZlbnRRdWV1ZS5zaXplKCkpOworICAgICAgICBtX21vdXNlRXZlbnRRdWV1ZS5yZW1v dmVMYXN0KCk7CisgICAgICAgIG1fbW91c2VFdmVudFF1ZXVlLmFwcGVuZChldmVudCk7CisgICAg fSBlbHNlIHsKKyAgICAgICAgTE9HKE1vdXNlSGFuZGxpbmcsICJVSVByb2Nlc3M6IGVucXVldWVk IG1vdXNlIGV2ZW50ICVzIChxdWV1ZSBzaXplICV6dSkiLCB3ZWJNb3VzZUV2ZW50VHlwZVN0cmlu ZyhldmVudC50eXBlKCkpLCBtX21vdXNlRXZlbnRRdWV1ZS5zaXplKCkpOworICAgICAgICBtX21v dXNlRXZlbnRRdWV1ZS5hcHBlbmQoZXZlbnQpOworICAgIH0KICAgICBpZiAobV9tb3VzZUV2ZW50 UXVldWUuc2l6ZSgpID09IDEpIC8vIE90aGVyd2lzZSwgY2FsbGVkIGZyb20gRGlkUmVjZWl2ZUV2 ZW50IG1lc3NhZ2UgaGFuZGxlci4KICAgICAgICAgcHJvY2Vzc05leHRRdWV1ZWRNb3VzZUV2ZW50 KCk7CiB9Cg==