18540 2008-04-16 13:20:53 -0700 console.log('multiple', 'strings') quotes all strings after the first 2008-07-26 22:14:27 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED http://svn.webkit.org/repository/webkit/trunk/WebCore/manual-tests/inspector/console-log-formatting.html P2 Normal --- 1 aroben webkit-unassigned oldest_to_newest 77853 0 aroben 2008-04-16 13:20:53 -0700 console.log('multiple', 'strings') quotes all strings after the first one. For example: console.log('here', 'are', 'some', 'strings') Inspector's output: here "are" "some" "strings" Firebug's output: here are some strings We should match Firebug here. 85601 1 22197 keishi 2008-07-10 01:07:05 -0700 Created attachment 22197 fix Should I have written Object.type(parameters[i], InspectorController.inspectedWindow()) === "string" instead of typeof parameters[i] === "string" like on line 49 of Console.js? I kind of feel using Object.type is an overkill for detecting string. 85608 2 22197 aroben 2008-07-10 08:07:01 -0700 Comment on attachment 22197 fix It would be great to add a testcase just for this particular problem (though the issue can already be seen in existing testcases) r=me even without a testcase 87032 3 mrowe 2008-07-26 22:14:27 -0700 Landed in r35383. 22197 2008-07-10 01:07:05 -0700 2008-07-10 08:07:01 -0700 fix MySixthPatch.txt text/plain 1476 keishi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNTA5NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMDctMTAgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9y aUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg ICAgIAorICAgICAgICBGaXhlZCBidWcgMTg1NDA6IGNvbnNvbGUubG9nKCdtdWx0aXBsZScsICdz dHJpbmdzJykgcXVvdGVzIGFsbCBzdHJpbmdzIGFmdGVyIHRoZSBmaXJzdAorICAgICAgICA8aHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTQwPgorCisgICAgICAgICog cGFnZS9pbnNwZWN0b3IvQ29uc29sZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db25zb2xl TWVzc2FnZS5wcm90b3R5cGUuX2Zvcm1hdCk6IFN0cmluZyBhcmd1bWVudHMgYXJlIGFwcGVuZGVk IHdpdGhvdXQgZm9ybWF0dGluZy4KKwogMjAwOC0wNy0wOSAgQWxleCBNYXRoZXdzICA8cG9zc2Vz c2VkcGVuZ3VpbmJvYkBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1 bnQuCkluZGV4OiBXZWJDb3JlL3BhZ2UvaW5zcGVjdG9yL0NvbnNvbGUuanMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9Db25zb2xlLmpzCShyZXZpc2lvbiAzNTA4NCkKKysr IFdlYkNvcmUvcGFnZS9pbnNwZWN0b3IvQ29uc29sZS5qcwkod29ya2luZyBjb3B5KQpAQCAtNDk3 LDcgKzUyMiwxMCBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2UucHJvdG90eXBlID0gCiAg ICAgICAgIH0KIAogICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHBhcmFtZXRlcnMubGVuZ3Ro OyArK2kpIHsKLSAgICAgICAgICAgIGZvcm1hdHRlZFJlc3VsdC5hcHBlbmRDaGlsZChmb3JtYXRG b3JDb25zb2xlKHBhcmFtZXRlcnNbaV0pKTsKKyAgICAgICAgICAgIGlmICh0eXBlb2YgcGFyYW1l dGVyc1tpXSA9PT0gInN0cmluZyIpCisgICAgICAgICAgICAgICAgZm9ybWF0dGVkUmVzdWx0LmFw cGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKHBhcmFtZXRlcnNbaV0pKTsKKyAgICAg ICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICBmb3JtYXR0ZWRSZXN1bHQuYXBwZW5kQ2hpbGQo Zm9ybWF0Rm9yQ29uc29sZShwYXJhbWV0ZXJzW2ldKSk7CiAgICAgICAgICAgICBpZiAoaSA8IHBh cmFtZXRlcnMubGVuZ3RoIC0gMSkKICAgICAgICAgICAgICAgICBmb3JtYXR0ZWRSZXN1bHQuYXBw ZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoIiAiKSk7CiAgICAgICAgIH0K