185394 2018-05-07 14:32:50 -0700 Avoid traversing the FrameTree up in FrameTree::top() 2024-01-19 11:14:14 -0800 1 1 1 Unclassified WebKit Frames WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez ahmad.saleem792 ggaren koivisto rniwa sam webkit-bug-importer oldest_to_newest 1421441 0 cdumez 2018-05-07 14:32:50 -0700 Avoid traversing the FrameTree up in FrameTree::top() and rely on Frame::mainFrame() instead to get the answer right away. 1421443 1 339754 cdumez 2018-05-07 14:36:26 -0700 Created attachment 339754 Patch 1421584 2 339754 sam 2018-05-07 18:58:52 -0700 Comment on attachment 339754 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339754&action=review > Source/WebCore/ChangeLog:12 > + of returning the frame itself). However, it should not matter in practice as we should > + not be dealing with the FrameTree of a detached frame. Do we want to / can we assert this? 1421589 3 339754 cdumez 2018-05-07 19:11:12 -0700 Comment on attachment 339754 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339754&action=review >> Source/WebCore/ChangeLog:12 >> + not be dealing with the FrameTree of a detached frame. > > Do we want to / can we assert this? Like an ASSERT(m_thisFrame.isMainFrame() || tree().parent()); inside FrameTree::top() ? This would make sure no one calls FrameTree::top() on a detached Frame. I am not sure if such assertion would be hit or not. I could try. 1904635 4 ahmad.saleem792 2022-10-10 15:03:50 -0700 Checking via BugID, it seems this r+ patch didn't landed and old code is still present: https://github.com/WebKit/WebKit/blob/8f0e98e67893ed3be45684a65a42de9bf244ed81/Source/WebCore/page/FrameTree.cpp#L454 Do we need this? Thanks! 2004193 5 ahmad.saleem792 2024-01-10 13:23:01 -0800 Frame& FrameTree::top() const { ASSERT(m_thisFrame.isMainFrame() || tree().parent()); return m_thisFrame.mainFrame(); } This compiles with --release but didn't check with --debug. 2006180 6 ews-feeder 2024-01-19 11:13:24 -0800 Committed 273230@main (80993fda030b): <https://commits.webkit.org/273230@main> Reviewed commits have been landed. Closing PR #22760 and removing active labels. 2006181 7 webkit-bug-importer 2024-01-19 11:14:14 -0800 <rdar://problem/121272959> 339754 2018-05-07 14:36:26 -0700 2022-02-27 23:21:14 -0800 Patch bug-185394-20180507143625.patch text/plain 1705 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxNDUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjZmZjZlMWIxMmVhMzg0 ODYwZjgwOWU3ZWIzYWNlMGJiNGQxMDdmNi4uN2FhNGIzODFiY2E2Y2I1MTYzOGU0OGI1ZDcxZjM1 MmQ0ODMwNTYzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA1LTA3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQXZvaWQgdHJhdmVyc2luZyB0 aGUgRnJhbWVUcmVlIHVwIGluIEZyYW1lVHJlZTo6dG9wKCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4NTM5NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkIHRyYXZlcnNpbmcgdGhlIEZyYW1lVHJl ZSB1cCBpbiBGcmFtZVRyZWU6OnRvcCgpIGFuZCByZWx5IG9uIEZyYW1lOjptYWluRnJhbWUoKQor ICAgICAgICBpbnN0ZWFkIHRvIGdldCB0aGUgYW5zd2VyIHJpZ2h0IGF3YXkuIFRoZXJlIGlzIGEg cG90ZW50aWFsIGJlaGF2aW9yIGNoYW5nZSBpZiBjYWxsaW5nCisgICAgICAgIEZyYW1lVHJlZTo6 dG9wKCkgb24gYSBkZXRhY2hlZCBmcmFtZSAoaXQgd2lsbCBrZWVwIHJldHVybiB0aGUgbWFpbiBm cmFtZSBub3cgaW5zdGVhZAorICAgICAgICBvZiByZXR1cm5pbmcgdGhlIGZyYW1lIGl0c2VsZiku IEhvd2V2ZXIsIGl0IHNob3VsZCBub3QgbWF0dGVyIGluIHByYWN0aWNlIGFzIHdlIHNob3VsZAor ICAgICAgICBub3QgYmUgZGVhbGluZyB3aXRoIHRoZSBGcmFtZVRyZWUgb2YgYSBkZXRhY2hlZCBm cmFtZS4KKworICAgICAgICAqIHBhZ2UvRnJhbWVUcmVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkZyYW1lVHJlZTo6dG9wIGNvbnN0KToKKwogMjAxOC0wNS0wMyAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFN0b3AgdXNpbmcgYW4gaWZyYW1lJ3MgaWQgYXMgZmFs bGJhY2sgaWYgaXRzIG5hbWUgYXR0cmlidXRlIGlzIG5vdCBzZXQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVUcmVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVU cmVlLmNwcAppbmRleCA0MmNiMzMzYTBjMDlkNTE0ZGIwZjE3YzdjZjBkYjZmODc2NmJmZDMwLi45 N2JhYzVmYzc3MmEzYTE2MzU5MzI2ODlkNDMyNWU1OGUyNmYwZWRhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVHJlZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9G cmFtZVRyZWUuY3BwCkBAIC00MjcsMTAgKzQyNyw3IEBAIEZyYW1lKiBGcmFtZVRyZWU6OmRlZXBM YXN0Q2hpbGQoKSBjb25zdAogCiBGcmFtZSYgRnJhbWVUcmVlOjp0b3AoKSBjb25zdAogewotICAg IEZyYW1lKiBmcmFtZSA9ICZtX3RoaXNGcmFtZTsKLSAgICBmb3IgKEZyYW1lKiBwYXJlbnQgPSAm bV90aGlzRnJhbWU7IHBhcmVudDsgcGFyZW50ID0gcGFyZW50LT50cmVlKCkucGFyZW50KCkpCi0g ICAgICAgIGZyYW1lID0gcGFyZW50OwotICAgIHJldHVybiAqZnJhbWU7CisgICAgcmV0dXJuIG1f dGhpc0ZyYW1lLm1haW5GcmFtZSgpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==