185391 2018-05-07 13:46:16 -0700 Use a dark gray for system preview background 2018-05-07 14:00:30 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino eric.carlson jonlee webkit-bug-importer oldest_to_newest 1421410 0 dino 2018-05-07 13:46:16 -0700 Use a dark gray for system preview bbackground 1421412 1 webkit-bug-importer 2018-05-07 13:48:06 -0700 <rdar://problem/40035120> 1421417 2 339748 dino 2018-05-07 13:50:51 -0700 Created attachment 339748 Patch 1421421 3 339748 jonlee 2018-05-07 13:53:25 -0700 Comment on attachment 339748 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review > Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64 > + UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1] not being used? 1421422 4 339748 eric.carlson 2018-05-07 13:55:10 -0700 Comment on attachment 339748 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review >> Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64 >> + UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1] > > not being used? Ditto. 1421423 5 339748 dino 2018-05-07 13:56:02 -0700 Comment on attachment 339748 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339748&action=review >>> Source/WebKit/UIProcess/ios/WKSystemPreviewView.mm:64 >>> + UIColor *backgroundColor = [UIColor colorWithRed:(38. / 255) green:(38. / 255) blue:(38. / 255) alpha:1] >> >> not being used? > > Ditto. Oh gosh. This patch is very wrong. It will make sense when I fix it. 1421428 6 dino 2018-05-07 14:00:30 -0700 Committed r231454: <https://trac.webkit.org/changeset/231454> 339748 2018-05-07 13:50:51 -0700 2018-05-07 13:55:10 -0700 Patch bug-185391-20180507135051.patch text/plain 1776 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZiYzYxYjYxYjRmYTAyNDY3 MzhkYzFmYTJlYWU5ZjhlMjNkNmY1MzMuLmJkN2NiNzE2OGQ5OWMwZGYyY2YzZWEzZTA1ZjAxZGE1 NWQyNzQzZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDUtMDcgIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBhIGRhcmsgZ3JheSBmb3Igc3lz dGVtIHByZXZpZXcgYmJhY2tncm91bmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4NTM5MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDAwMzUxMjA+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhyb3cg c29tZSBkYXJrZXIgc2hhZGUgYXQgdGhpcyB2aWV3LgorCisgICAgICAgICogVUlQcm9jZXNzL2lv cy9XS1N5c3RlbVByZXZpZXdWaWV3Lm1tOgorICAgICAgICAoLVtXS1N5c3RlbVByZXZpZXdWaWV3 IHdlYl9pbml0V2l0aEZyYW1lOndlYlZpZXc6XSk6CisKIDIwMTgtMDUtMDQgIFRpbSBIb3J0b24g IDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgU2hpZnQgdG8gYSBsb3dlci1s ZXZlbCBmcmFtZXdvcmsgZm9yIHNpbXBsaWZ5aW5nIFVSTHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9XS1N5c3RlbVByZXZpZXdWaWV3Lm1tIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLU3lzdGVtUHJldmlld1ZpZXcubW0KaW5kZXggODUyNzUwNzY5NWNk ZjdmYjc3NmIxMGViZjY4NzFjY2ZiZjQzYzE1NS4uODQzZjFjZGRkNWY5MjZlY2MyMDFjOTA3NmQ0 YjVmZDEwNzgzZTU3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dL U3lzdGVtUHJldmlld1ZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dL U3lzdGVtUHJldmlld1ZpZXcubW0KQEAgLTYxLDE0ICs2MSwxNSBAQCBTT0ZUX0xJTktfQ0xBU1Mo UXVpY2tMb29rLCBRTFByZXZpZXdDb250cm9sbGVyKTsKICAgICBpZiAoIShzZWxmID0gW3N1cGVy IGluaXRXaXRoRnJhbWU6ZnJhbWVdKSkKICAgICAgICAgcmV0dXJuIG5pbDsKIAotICAgIHNlbGYu YmFja2dyb3VuZENvbG9yID0gW1VJQ29sb3IgbGlnaHRHcmF5Q29sb3JdOworICAgIFVJQ29sb3Ig KmJhY2tncm91bmRDb2xvciA9IFtVSUNvbG9yIGNvbG9yV2l0aFJlZDooMzguIC8gMjU1KSBncmVl bjooMzguIC8gMjU1KSBibHVlOigzOC4gLyAyNTUpIGFscGhhOjFdCisgICAgc2VsZi5iYWNrZ3Jv dW5kQ29sb3IgPSBbVUlDb2xvciBiYWNrZ3JvdW5kQ29sb3JdOwogCiAgICAgX3dlYlZpZXcgPSB3 ZWJWaWV3OwogCiAgICAgVUlTY3JvbGxWaWV3ICpzY3JvbGxWaWV3ID0gd2ViVmlldy5zY3JvbGxW aWV3OwogICAgIFtzY3JvbGxWaWV3IHNldE1pbmltdW1ab29tU2NhbGU6MV07CiAgICAgW3Njcm9s bFZpZXcgc2V0TWF4aW11bVpvb21TY2FsZToxXTsKLSAgICBbc2Nyb2xsVmlldyBzZXRCYWNrZ3Jv dW5kQ29sb3I6W1VJQ29sb3IgbGlnaHRHcmF5Q29sb3JdXTsKKyAgICBbc2Nyb2xsVmlldyBzZXRC YWNrZ3JvdW5kQ29sb3I6W1VJQ29sb3IgYmFja2dyb3VuZENvbG9yXV07CiAKICAgICByZXR1cm4g c2VsZjsKIH0K