185388 2018-05-07 12:04:13 -0700 REGRESSION(r211075): Web Inspector throws an exception when inspecting WebViews on iOS 8.4 simulator 2022-03-01 02:28:26 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 bburg bburg bburg hi inspector-bugzilla-changes joepeck oldest_to_newest 1421368 0 bburg 2018-05-07 12:04:13 -0700 Missing a HeapAgent check. 1421369 1 339737 bburg 2018-05-07 12:06:22 -0700 Created attachment 339737 Patch 1421370 2 339737 joepeck 2018-05-07 12:08:22 -0700 Comment on attachment 339737 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=339737&action=review > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:132 > - if (HeapAgent.gc) > + // COMPATIBILITY (iOS 9): HeapAgent did not exist. > + if (WI.mainTarget.HeapAgent) Normally this is just `if (window.HeapAgent)` I think its a little weird to use `WI.mainTarget`. 339737 2018-05-07 12:06:22 -0700 2022-03-01 02:28:26 -0800 Patch bug-185388-20180507120621.patch text/plain 1709 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjMxMzkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA4 MmEwMzI4M2E0ZWRkOGRlYjBiNjc0YWFlMGU0YzRjNDgzMDAyZDgxLi5kOGI5YTQ5NzBmYzc1YzNh MzY4ZTM4Y2UxYjdmNWUxZWZlODQ4MDRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxOC0wNS0wNyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBSRUdSRVNTSU9OKHIyMTEwNzUpOiBXZWIgSW5zcGVjdG9yIHRocm93cyBhbiBleGNl cHRpb24gd2hlbiBpbnNwZWN0aW5nIFdlYlZpZXdzIG9uIGlPUyA4LjQgc2ltdWxhdG9yCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODUzODgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvVmlld3MvTG9nQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5Mb2dDb250ZW50Vmlldy5w cm90b3R5cGUuZ2V0IG5hdmlnYXRpb25JdGVtcyk6CisgICAgICAgIEFkZCBndWFyZCBmb3IgSGVh cEFnZW50LCB3aGljaCB3YXMgYWRkZWQgaW4gaU9TIDkuCisKIDIwMTgtMDUtMDQgIERldmluIFJv dXNzbyAgPHdlYmtpdEBkZXZpbnJvdXNzby5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog c2ltcGxpZnkgdGhlIFdJLkNvbGxlY3Rpb24gaW50ZXJmYWNlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3Lmpz CmluZGV4IDNjODZmOWVlMzUzODhiZjcwMjMxNzZlYjlhNTliODE4OGFmOGUyNzcuLmIxOTU1NDc3 YmE2MDMwN2U1NDc5YzE5MzQzOTRhYzBkMTNlOTJlYWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3Lmpz CkBAIC0xMjgsNyArMTI4LDggQEAgV0kuTG9nQ29udGVudFZpZXcgPSBjbGFzcyBMb2dDb250ZW50 VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWV3CiAgICAgICAgIGlmICh0aGlzLl9oYXNOb25EZWZh dWx0TG9nQ2hhbm5lbE1lc3NhZ2UgJiYgdGhpcy5fbWVzc2FnZVNvdXJjZUJhcikKICAgICAgICAg ICAgIG5hdmlnYXRpb25JdGVtcy5wdXNoKHRoaXMuX21lc3NhZ2VTb3VyY2VCYXIsIG5ldyBXSS5E aXZpZGVyTmF2aWdhdGlvbkl0ZW0pOwogCi0gICAgICAgIGlmIChIZWFwQWdlbnQuZ2MpCisgICAg ICAgIC8vIENPTVBBVElCSUxJVFkgKGlPUyA5KTogSGVhcEFnZW50IGRpZCBub3QgZXhpc3QuCisg ICAgICAgIGlmIChXSS5tYWluVGFyZ2V0LkhlYXBBZ2VudCkKICAgICAgICAgICAgIG5hdmlnYXRp b25JdGVtcy5wdXNoKHRoaXMuX2dhcmJhZ2VDb2xsZWN0TmF2aWdhdGlvbkl0ZW0pOwogCiAgICAg ICAgIG5hdmlnYXRpb25JdGVtcy5wdXNoKHRoaXMuX2NsZWFyTG9nTmF2aWdhdGlvbkl0ZW0pOwo=